@oneuptime/common 13.0.6 → 13.0.7

package/Tests/Server/Utils/AI/AIIncidentGating.test.ts

@@ -1,3 +1,4 @@
+import InvestigationEligibility from "../../../../Server/Utils/AI/SRE/InvestigationEligibility";
 import AIIncidentInvestigationRunner, {
   DEFAULT_INCIDENT_DEDUPE_WINDOW_MINUTES,
   IncidentGateDecision,
@@ -15,7 +16,7 @@ import Project from "../../../../Models/DatabaseModels/Project";
 import AIRunType from "../../../../Types/AI/AIRunType";
 import ObjectID from "../../../../Types/ObjectID";
 import PositiveNumber from "../../../../Types/PositiveNumber";
-import { afterEach, describe, expect, test } from "@jest/globals";
+import { afterEach, beforeEach, describe, expect, test } from "@jest/globals";
 
 /*
  * Cost gates for autonomous INCIDENT investigations.
@@ -401,8 +402,8 @@ describe("AIIncidentInvestigationRunner.investigateNewIncident — gate wiring",
 
   test("a gated-out incident is never enqueued", async () => {
     jest
-      .spyOn(AIInvestigationEngine, "isEnabledForProject")
-      .mockResolvedValue(true);
+      .spyOn(AIInvestigationEngine, "getDisabledReason")
+      .mockResolvedValue(null);
     jest
       .spyOn(AIIncidentInvestigationRunner, "shouldInvestigateIncident")
       .mockResolvedValue({ investigate: false, reason: "below floor" });
@@ -420,8 +421,8 @@ describe("AIIncidentInvestigationRunner.investigateNewIncident — gate wiring",
 
   test("a passing incident is enqueued carrying its monitor as the dedupe key", async () => {
     jest
-      .spyOn(AIInvestigationEngine, "isEnabledForProject")
-      .mockResolvedValue(true);
+      .spyOn(AIInvestigationEngine, "getDisabledReason")
+      .mockResolvedValue(null);
     jest
       .spyOn(AIIncidentInvestigationRunner, "shouldInvestigateIncident")
       .mockResolvedValue({
@@ -449,8 +450,8 @@ describe("AIIncidentInvestigationRunner.investigateNewIncident — gate wiring",
   // The project opt-in is still checked before anything else costs a query.
   test("a project with investigations disabled never reaches the gate", async () => {
     jest
-      .spyOn(AIInvestigationEngine, "isEnabledForProject")
-      .mockResolvedValue(false);
+      .spyOn(AIInvestigationEngine, "getDisabledReason")
+      .mockResolvedValue("automatic_investigation_disabled");
     const gateSpy: jest.SpyInstance = jest.spyOn(
       AIIncidentInvestigationRunner,
       "shouldInvestigateIncident",
@@ -478,8 +479,8 @@ describe("AIIncidentInvestigationRunner.investigateNewIncident — gate wiring",
    */
   test("a throwing gate is swallowed, enqueues nothing, and reports not-enqueued", async () => {
     jest
-      .spyOn(AIInvestigationEngine, "isEnabledForProject")
-      .mockResolvedValue(true);
+      .spyOn(AIInvestigationEngine, "getDisabledReason")
+      .mockResolvedValue(null);
     jest
       .spyOn(AIIncidentInvestigationRunner, "shouldInvestigateIncident")
       .mockRejectedValue(new Error("database unavailable"));
@@ -498,3 +499,9 @@ describe("AIIncidentInvestigationRunner.investigateNewIncident — gate wiring",
     expect(enqueue).not.toHaveBeenCalled();
   });
 });
+
+beforeEach(() => {
+  jest
+    .spyOn(InvestigationEligibility, "recordSkipped")
+    .mockResolvedValue(undefined);
+});

package/Tests/Server/Utils/AI/ChatAgentRunner.test.ts

@@ -25,6 +25,10 @@ import AIChatPageContextType, {
   AIChatPageContext,
 } from "../../../../Types/AI/AIChatPageContext";
 import AIChatPermissionMode from "../../../../Types/AI/AIChatPermissionMode";
+import {
+  AIResourceSubresourceKind,
+  AIResourceType,
+} from "../../../../Types/AI/AIResourceContext";
 import AIRunStatus from "../../../../Types/AI/AIRunStatus";
 import {
   AIChatCitation,
@@ -357,7 +361,7 @@ describe("buildReplayedHistoryMessage", () => {
 const INCIDENT_ID: string = "0b6ff65a-71a1-40b0-8b9c-6c11f5f6a123";
 
 function buildRequest(data?: {
-  pageContext?: AIChatPageContext | undefined;
+  pageContext?: AIChatPageContext | null | undefined;
 }): ChatTurnRequest {
   return {
     projectId: ObjectID.generate(),
@@ -510,6 +514,138 @@ describe("ChatAgentRunner.runTurn — cooperative cancellation", () => {
 });
 
 describe("ChatAgentRunner.runTurn — page context persistence", () => {
+  test("persists a newly selected pod and reuses its full identity on the next turn", async () => {
+    const conversation: AIConversation = new AIConversation();
+    conversation.pageContext = {
+      type: AIChatPageContextType.Resource,
+      resourceType: AIResourceType.KubernetesCluster,
+      entityId: INCIDENT_ID,
+      subresource: {
+        kind: AIResourceSubresourceKind.Pod,
+        key: "checkout-old",
+        namespace: "payments",
+      },
+    };
+    const pageContext: AIChatPageContext = {
+      type: AIChatPageContextType.Resource,
+      resourceType: AIResourceType.KubernetesCluster,
+      entityId: INCIDENT_ID,
+      entityTitle: "Production / pod: checkout-current",
+      subresource: {
+        kind: AIResourceSubresourceKind.Pod,
+        key: "checkout-current",
+        namespace: "payments",
+      },
+    };
+    const spies: RunnerSpies = installRunnerSpies({
+      conversation,
+      titleCount: 5,
+    });
+    /*
+     * Keep the mocked database read consistent with writes the real runner
+     * actually makes. Without a persistence write the next turn sees the old pod.
+     */
+    spies.conversationUpdateOneById.mockImplementation(
+      async (update: { data?: JSONObject }): Promise<number> => {
+        if (update.data?.["pageContext"] !== undefined) {
+          conversation.pageContext = update.data[
+            "pageContext"
+          ] as unknown as AIChatPageContext;
+        }
+        return 1;
+      },
+    );
+
+    const request: ChatTurnRequest = buildRequest({ pageContext });
+    await ChatAgentRunner.runTurn(request);
+    await flushAsync();
+
+    expect(
+      findCallWithDataKey(spies.conversationUpdateOneById, "pageContext"),
+    ).toEqual({ pageContext });
+    const firstPrompt: string = (
+      spies.executeWithLogging.mock.calls[0]?.[0] as AILogRequest
+    ).messages[0]!.content;
+    expect(firstPrompt).toContain(JSON.stringify(pageContext.subresource));
+
+    spies.executeWithLogging.mockClear();
+    spies.conversationUpdateOneById.mockClear();
+    await ChatAgentRunner.runTurn({
+      ...request,
+      assistantMessageId: ObjectID.generate(),
+      aiRunId: ObjectID.generate(),
+      pageContext: undefined,
+    });
+    await flushAsync();
+
+    const nextPrompt: string = (
+      spies.executeWithLogging.mock.calls[0]?.[0] as AILogRequest
+    ).messages[0]!.content;
+    expect(nextPrompt).toContain('"resourceType":"KubernetesCluster"');
+    expect(nextPrompt).toContain(`"resourceId":"${INCIDENT_ID}"`);
+    expect(nextPrompt).toContain(JSON.stringify(pageContext.subresource));
+    expect(nextPrompt).not.toContain("checkout-old");
+    expect(
+      findCallWithDataKey(spies.conversationUpdateOneById, "pageContext"),
+    ).toBeUndefined();
+  });
+
+  test("explicitly detaching clears the saved subject and omits it from the prompt", async () => {
+    const conversation: AIConversation = new AIConversation();
+    conversation.pageContext = {
+      type: AIChatPageContextType.RumApplication,
+      entityId: INCIDENT_ID,
+      entityTitle: "Checkout browser",
+    };
+    const spies: RunnerSpies = installRunnerSpies({
+      conversation,
+      titleCount: 5,
+    });
+
+    await ChatAgentRunner.runTurn(buildRequest({ pageContext: null }));
+    await flushAsync();
+
+    expect(
+      findCallWithDataKey(spies.conversationUpdateOneById, "pageContext"),
+    ).toEqual({ pageContext: null });
+    const llmRequest: AILogRequest = spies.executeWithLogging.mock
+      .calls[0]?.[0] as AILogRequest;
+    expect(llmRequest.messages[0]?.content).not.toContain(
+      "## Current page context",
+    );
+    expect(llmRequest.messages[0]?.content).not.toContain(INCIDENT_ID);
+  });
+
+  test("a RUM application replaces the previous module as the conversation subject", async () => {
+    const conversation: AIConversation = new AIConversation();
+    conversation.pageContext = { type: AIChatPageContextType.MonitorsList };
+    const spies: RunnerSpies = installRunnerSpies({
+      conversation,
+      titleCount: 5,
+    });
+    const pageContext: AIChatPageContext = {
+      type: AIChatPageContextType.RumApplication,
+      entityId: INCIDENT_ID,
+      entityTitle: "Checkout browser",
+    };
+
+    await ChatAgentRunner.runTurn(buildRequest({ pageContext }));
+    await flushAsync();
+
+    expect(
+      findCallWithDataKey(spies.conversationUpdateOneById, "pageContext"),
+    ).toEqual({ pageContext });
+    const llmRequest: AILogRequest = spies.executeWithLogging.mock
+      .calls[0]?.[0] as AILogRequest;
+    expect(llmRequest.messages[0]?.content).toContain(
+      `rumApplicationId="${INCIDENT_ID}"`,
+    );
+    expect(llmRequest.messages[0]?.content).toContain("query_rum_web_vitals");
+    expect(llmRequest.messages[0]?.content).not.toContain(
+      "browsing the monitors list",
+    );
+  });
+
   test("persists a fresh page context on the conversation and folds it into the prompt", async () => {
     const pageContext: AIChatPageContext = {
       type: AIChatPageContextType.Incident,