@oneuptime/common 13.0.4 → 13.0.5

package/Tests/App/Dashboard/EventOverviewSkeleton.test.tsx

@@ -0,0 +1,210 @@
+import EventOverviewSkeleton from "../../../../App/FeatureSet/Dashboard/src/Components/EventView/EventOverviewSkeleton";
+import "@testing-library/jest-dom";
+import { cleanup, render, screen, within } from "@testing-library/react";
+import React from "react";
+import { afterEach, describe, expect, test } from "@jest/globals";
+
+/*
+ * Overview pages show this on first load instead of a full-page loader, so
+ * the header, stat bar and card grid appear in place and the page does not
+ * jump when data lands. It must announce itself once, politely, and hide
+ * the decorative blocks from assistive technology.
+ */
+
+afterEach(() => {
+  cleanup();
+});
+
+type GetStatCellsFunction = () => Array<Element>;
+
+const getStatCells: GetStatCellsFunction = (): Array<Element> => {
+  const statWrapper: HTMLElement = screen.getByTestId(
+    "event-overview-skeleton-stats",
+  );
+  const bar: Element = statWrapper.firstElementChild as Element;
+  return Array.from(bar.children);
+};
+
+describe("EventOverviewSkeleton accessibility", () => {
+  test("is one polite status region with a screen-reader-only label", () => {
+    render(<EventOverviewSkeleton />);
+
+    const status: HTMLElement = screen.getByRole("status");
+
+    expect(status).toHaveAttribute("aria-live", "polite");
+    expect(within(status).getByText("Loading")).toHaveClass("sr-only");
+    expect(screen.getAllByRole("status")).toHaveLength(1);
+  });
+
+  test("announces a caller-specific loading label", () => {
+    render(<EventOverviewSkeleton loadingText="Loading incident" />);
+
+    expect(screen.getByRole("status")).toHaveTextContent("Loading incident");
+    expect(screen.queryByText("Loading")).not.toBeInTheDocument();
+  });
+
+  test("hides every placeholder block from assistive technology", () => {
+    render(<EventOverviewSkeleton />);
+
+    const status: HTMLElement = screen.getByRole("status");
+    const decorative: Element | null = status.querySelector(
+      '[aria-hidden="true"]',
+    );
+
+    expect(decorative).not.toBeNull();
+    expect(decorative).toContainElement(
+      screen.getByTestId("event-overview-skeleton-hero"),
+    );
+    expect(decorative).toContainElement(
+      screen.getByTestId("event-overview-skeleton-stats"),
+    );
+    // The only accessible text is the sr-only label.
+    expect(status.textContent).toBe("Loading");
+  });
+
+  test("only pulses when the user has not asked for reduced motion", () => {
+    const { container } = render(<EventOverviewSkeleton />);
+
+    expect(
+      container.querySelector('[class~="motion-safe:animate-pulse"]'),
+    ).not.toBeNull();
+    expect(container.querySelector('[class~="animate-pulse"]')).toBeNull();
+  });
+
+  test("renders no interactive controls", () => {
+    render(<EventOverviewSkeleton />);
+
+    expect(screen.queryAllByRole("button")).toHaveLength(0);
+    expect(screen.queryAllByRole("link")).toHaveLength(0);
+  });
+});
+
+describe("EventOverviewSkeleton layout", () => {
+  test("mirrors the header card of the loaded page", () => {
+    render(<EventOverviewSkeleton />);
+
+    expect(screen.getByTestId("event-overview-skeleton-hero")).toHaveClass(
+      "rounded-xl",
+      "border",
+      "border-gray-200",
+      "bg-white",
+      "shadow-sm",
+    );
+  });
+
+  test("places the hero, then the stat bar, then the card grid", () => {
+    render(<EventOverviewSkeleton />);
+
+    const hero: HTMLElement = screen.getByTestId(
+      "event-overview-skeleton-hero",
+    );
+    const stats: HTMLElement = screen.getByTestId(
+      "event-overview-skeleton-stats",
+    );
+    const mainCard: HTMLElement = screen.getAllByTestId(
+      "event-overview-skeleton-main-card",
+    )[0] as HTMLElement;
+
+    expect(
+      hero.compareDocumentPosition(stats) & Node.DOCUMENT_POSITION_FOLLOWING,
+    ).toBeTruthy();
+    expect(
+      stats.compareDocumentPosition(mainCard) &
+        Node.DOCUMENT_POSITION_FOLLOWING,
+    ).toBeTruthy();
+  });
+
+  test("defaults to three stat cells", () => {
+    render(<EventOverviewSkeleton />);
+
+    expect(getStatCells()).toHaveLength(3);
+  });
+
+  test("matches the stat bar's cell count when asked", () => {
+    render(<EventOverviewSkeleton statCount={4} />);
+
+    expect(getStatCells()).toHaveLength(4);
+
+    const bar: Element = screen.getByTestId("event-overview-skeleton-stats")
+      .firstElementChild as Element;
+    expect(bar).toHaveClass("sm:grid-cols-2", "lg:grid-cols-4");
+  });
+
+  test("uses the stat bar card so the placeholder has the same frame", () => {
+    render(<EventOverviewSkeleton statCount={2} />);
+
+    const bar: Element = screen.getByTestId("event-overview-skeleton-stats")
+      .firstElementChild as Element;
+
+    expect(bar).toHaveClass(
+      "grid",
+      "grid-cols-1",
+      "rounded-xl",
+      "border",
+      "sm:grid-cols-2",
+    );
+    for (const cell of getStatCells()) {
+      expect(cell).toHaveClass("bg-white", "px-5", "py-4");
+    }
+  });
+
+  test("lays cards out two-thirds and one-third from xl, stacked below it", () => {
+    render(<EventOverviewSkeleton />);
+
+    const mainCards: Array<HTMLElement> = screen.getAllByTestId(
+      "event-overview-skeleton-main-card",
+    );
+    const sideCards: Array<HTMLElement> = screen.getAllByTestId(
+      "event-overview-skeleton-side-card",
+    );
+
+    expect(mainCards.length).toBeGreaterThan(0);
+    expect(sideCards.length).toBeGreaterThan(0);
+
+    const mainColumn: HTMLElement = mainCards[0]!.parentElement as HTMLElement;
+    const sideColumn: HTMLElement = sideCards[0]!.parentElement as HTMLElement;
+    const grid: HTMLElement = mainColumn.parentElement as HTMLElement;
+
+    expect(grid).toHaveClass("grid", "grid-cols-1", "xl:grid-cols-3");
+    expect(grid).toContainElement(sideColumn);
+    expect(mainColumn).toHaveClass("xl:col-span-2", "min-w-0");
+    expect(sideColumn).toHaveClass("min-w-0");
+    expect(sideColumn).not.toHaveClass("xl:col-span-2");
+  });
+
+  test("keeps every width responsive so it fits a phone screen", () => {
+    const { container } = render(<EventOverviewSkeleton />);
+
+    const fixedWideWidths: Array<Element> = Array.from(
+      container.querySelectorAll("*"),
+    ).filter((element: Element) => {
+      return Array.from(element.classList).some((className: string) => {
+        // Anything wider than w-40 (10rem) must be fractional or capped.
+        const match: RegExpMatchArray | null = className.match(/^w-(\d+)$/);
+        return (
+          match !== null &&
+          Number(match[1]) > 40 &&
+          !element.classList.contains("max-w-full")
+        );
+      });
+    });
+
+    expect(fixedWideWidths).toEqual([]);
+    expect(container.innerHTML).not.toContain("min-w-[");
+  });
+
+  test("renders the same markup on every render (no random widths)", () => {
+    const { container, rerender } = render(<EventOverviewSkeleton />);
+    const firstHtml: string = container.innerHTML;
+
+    rerender(<EventOverviewSkeleton />);
+
+    expect(container.innerHTML).toBe(firstHtml);
+  });
+
+  test("appends a caller class name to the status wrapper", () => {
+    render(<EventOverviewSkeleton className="mb-5" />);
+
+    expect(screen.getByRole("status")).toHaveClass("mb-5", "w-full");
+  });
+});

package/Tests/App/Dashboard/EventStatBar.test.tsx

@@ -0,0 +1,392 @@
+import EventStatBar, {
+  EventStatBarColumns,
+  getEventStatBarColumnClassName,
+} from "../../../../App/FeatureSet/Dashboard/src/Components/EventView/EventStatBar";
+import EventStatTile from "../../../../App/FeatureSet/Dashboard/src/Components/EventView/EventStatTile";
+import "@testing-library/jest-dom";
+import { cleanup, render, screen } from "@testing-library/react";
+import React from "react";
+import { afterEach, describe, expect, test } from "@jest/globals";
+import IconProp from "../../../Types/Icon/IconProp";
+
+/*
+ * The incident, alert, scheduled maintenance and episode overview pages show
+ * their headline timings as one EventStatBar of EventStatTile
+ * variant="segment" cells. The tile's original "card" look is still used
+ * elsewhere, so it must not move, and the segment cell must never truncate:
+ * a narrow bar has no hover to reveal a clipped duration.
+ */
+
+const LONG_VALUE: string =
+  "Not yet acknowledged after a very long escalation chain across three teams";
+
+afterEach(() => {
+  cleanup();
+});
+
+type GetTileFunction = (label: string) => HTMLElement;
+
+// The tile root is the parent of the label row (label span -> row -> tile).
+const getTile: GetTileFunction = (label: string): HTMLElement => {
+  const labelElement: HTMLElement = screen.getByText(label);
+  return labelElement.parentElement!.parentElement as HTMLElement;
+};
+
+describe("EventStatTile card variant (default)", () => {
+  test("renders exactly the standalone bordered tile it always has", () => {
+    render(
+      <EventStatTile
+        id="duration-tile"
+        label="Duration"
+        icon={IconProp.Clock}
+        value="2h 13m"
+        description="Since declared"
+        className="extra-class"
+      />,
+    );
+
+    const tile: HTMLElement = getTile("Duration");
+
+    expect(tile).toHaveAttribute("id", "duration-tile");
+    expect(tile.className).toBe(
+      "rounded-xl border border-gray-200 bg-white px-4 py-3.5 shadow-sm extra-class",
+    );
+
+    const value: HTMLElement = screen.getByText("2h 13m");
+    expect(value.className).toBe(
+      "mt-1.5 truncate text-lg font-semibold text-gray-900",
+    );
+
+    const description: HTMLElement = screen.getByText("Since declared");
+    expect(description.className).toBe("mt-0.5 text-xs text-gray-500");
+
+    expect(tile.querySelector("svg")).toHaveClass(
+      "h-3.5",
+      "w-3.5",
+      "text-gray-400",
+    );
+  });
+
+  test("an explicit card variant is identical to the default", () => {
+    const { container: defaultContainer } = render(
+      <EventStatTile label="Duration" value="5m" icon={IconProp.Clock} />,
+    );
+    const defaultHtml: string = defaultContainer.innerHTML;
+    cleanup();
+
+    const { container: cardContainer } = render(
+      <EventStatTile
+        label="Duration"
+        value="5m"
+        icon={IconProp.Clock}
+        variant="card"
+      />,
+    );
+
+    expect(cardContainer.innerHTML).toBe(defaultHtml);
+  });
+
+  test("omits the icon and description when they are not given", () => {
+    render(<EventStatTile label="Acknowledged in" value="-" />);
+
+    const tile: HTMLElement = getTile("Acknowledged in");
+
+    expect(tile.querySelector("svg")).toBeNull();
+    expect(tile.children).toHaveLength(2);
+  });
+});
+
+describe("EventStatTile segment variant", () => {
+  test("drops its own border, shadow and rounding and uses the cell padding", () => {
+    render(
+      <EventStatTile
+        id="ack-cell"
+        variant="segment"
+        label="Acknowledged in"
+        icon={IconProp.Check}
+        value="4m 10s"
+      />,
+    );
+
+    const cell: HTMLElement = getTile("Acknowledged in");
+
+    expect(cell).toHaveAttribute("id", "ack-cell");
+    expect(cell).toHaveClass("bg-white", "px-5", "py-4", "min-w-0");
+    expect(cell).not.toHaveClass("border");
+    expect(cell).not.toHaveClass("rounded-xl");
+    expect(cell).not.toHaveClass("shadow-sm");
+  });
+
+  test("uses the stat bar label, icon and value tokens", () => {
+    render(
+      <EventStatTile
+        variant="segment"
+        label="Resolved in"
+        icon={IconProp.CheckCircle}
+        value="1h 2m"
+        description="From first report"
+      />,
+    );
+
+    const cell: HTMLElement = getTile("Resolved in");
+    const labelRow: HTMLElement = screen.getByText("Resolved in")
+      .parentElement as HTMLElement;
+
+    expect(labelRow).toHaveClass(
+      "text-xs",
+      "font-medium",
+      "uppercase",
+      "tracking-wide",
+      "text-gray-500",
+    );
+    expect(cell.querySelector("svg")).toHaveClass("h-3.5", "w-3.5");
+
+    const value: HTMLElement = screen.getByText("1h 2m");
+    expect(value).toHaveClass(
+      "mt-1",
+      "text-lg",
+      "font-semibold",
+      "text-gray-900",
+    );
+
+    expect(screen.getByText("From first report")).toHaveClass(
+      "mt-0.5",
+      "text-xs",
+      "text-gray-500",
+    );
+  });
+
+  test("wraps a long value instead of truncating it", () => {
+    render(
+      <EventStatTile variant="segment" label="Status" value={LONG_VALUE} />,
+    );
+
+    const value: HTMLElement = screen.getByText(LONG_VALUE);
+
+    expect(value).toHaveClass("break-words");
+    expect(value).not.toHaveClass("truncate");
+    expect(value.className).not.toContain("whitespace-nowrap");
+  });
+
+  test("renders an element value such as a live duration", () => {
+    render(
+      <EventStatTile
+        variant="segment"
+        label="Duration"
+        value={<span data-testid="live-duration">12m</span>}
+      />,
+    );
+
+    expect(screen.getByTestId("live-duration")).toHaveTextContent("12m");
+  });
+
+  test("appends a caller class name", () => {
+    render(
+      <EventStatTile
+        variant="segment"
+        label="Duration"
+        value="1m"
+        className="sm:col-span-2"
+      />,
+    );
+
+    expect(getTile("Duration")).toHaveClass("sm:col-span-2", "px-5");
+  });
+});
+
+describe("EventStatBar", () => {
+  test("renders one card with the stat bar tokens and every cell inside it", () => {
+    const { container } = render(
+      <EventStatBar columns={3}>
+        <EventStatTile variant="segment" label="Acknowledged in" value="4m" />
+        <EventStatTile variant="segment" label="Resolved in" value="1h" />
+        <EventStatTile variant="segment" label="Duration" value="2h" />
+      </EventStatBar>,
+    );
+
+    const bar: HTMLElement = container.firstElementChild as HTMLElement;
+
+    expect(bar).toHaveClass(
+      "grid",
+      "grid-cols-1",
+      "overflow-hidden",
+      "rounded-xl",
+      "border",
+      "border-gray-200",
+      "shadow-sm",
+      "sm:grid-cols-3",
+    );
+    expect(bar.children).toHaveLength(3);
+    expect(bar).toContainElement(screen.getByText("Acknowledged in"));
+    expect(bar).toContainElement(screen.getByText("Resolved in"));
+    expect(bar).toContainElement(screen.getByText("Duration"));
+  });
+
+  test("draws hairline dividers between cells through a 1px gap", () => {
+    const { container } = render(
+      <EventStatBar columns={2}>
+        <EventStatTile variant="segment" label="Starts" value="Today" />
+        <EventStatTile variant="segment" label="Ends" value="Tomorrow" />
+      </EventStatBar>,
+    );
+
+    const bar: HTMLElement = container.firstElementChild as HTMLElement;
+
+    expect(bar).toHaveClass("gap-px", "bg-gray-100");
+    // Cells paint white over the divider colour.
+    for (const cell of Array.from(bar.children)) {
+      expect(cell).toHaveClass("bg-white");
+    }
+  });
+
+  test("is a single column on mobile for every column count", () => {
+    const columnCounts: Array<EventStatBarColumns> = [1, 2, 3, 4];
+
+    for (const columns of columnCounts) {
+      const { container } = render(
+        <EventStatBar columns={columns}>
+          {[1, 2, 3, 4].slice(0, columns).map((cell: number) => {
+            return (
+              <EventStatTile
+                key={cell}
+                variant="segment"
+                label={`Cell ${cell}`}
+                value="1"
+              />
+            );
+          })}
+        </EventStatBar>,
+      );
+
+      const bar: HTMLElement = container.firstElementChild as HTMLElement;
+      const unprefixedColumnClasses: Array<string> = Array.from(
+        bar.classList,
+      ).filter((className: string) => {
+        return className.startsWith("grid-cols-");
+      });
+
+      expect(unprefixedColumnClasses).toEqual(["grid-cols-1"]);
+      cleanup();
+    }
+  });
+
+  test("maps each column count to literal responsive classes", () => {
+    const expectations: Array<{
+      columns: EventStatBarColumns;
+      className: string;
+    }> = [
+      { columns: 1, className: "" },
+      { columns: 2, className: "sm:grid-cols-2" },
+      { columns: 3, className: "sm:grid-cols-3" },
+      { columns: 4, className: "sm:grid-cols-2 lg:grid-cols-4" },
+    ];
+
+    for (const expectation of expectations) {
+      expect(
+        getEventStatBarColumnClassName(
+          expectation.columns,
+          expectation.columns,
+        ),
+      ).toBe(expectation.className);
+    }
+  });
+
+  test("goes through a 2 x 2 grid before spreading four cells into one row", () => {
+    const { container } = render(
+      <EventStatBar columns={4}>
+        <EventStatTile variant="segment" label="Acknowledged in" value="1m" />
+        <EventStatTile variant="segment" label="Resolved in" value="2m" />
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+        <EventStatTile variant="segment" label="Incidents" value="7" />
+      </EventStatBar>,
+    );
+
+    const bar: HTMLElement = container.firstElementChild as HTMLElement;
+
+    expect(bar).toHaveClass("sm:grid-cols-2", "lg:grid-cols-4");
+    expect(bar).not.toHaveClass("sm:grid-cols-4");
+  });
+
+  test("never lays out more columns than it has cells", () => {
+    expect(getEventStatBarColumnClassName(4, 3)).toBe("sm:grid-cols-3");
+    expect(getEventStatBarColumnClassName(3, 2)).toBe("sm:grid-cols-2");
+    expect(getEventStatBarColumnClassName(3, 1)).toBe("");
+    expect(getEventStatBarColumnClassName(2, 0)).toBe("");
+  });
+
+  test("skips cells a caller left out conditionally", () => {
+    const showEpisodeCount: boolean = false;
+
+    const { container } = render(
+      <EventStatBar columns={3}>
+        <EventStatTile variant="segment" label="Acknowledged in" value="1m" />
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+        {showEpisodeCount && (
+          <EventStatTile variant="segment" label="Alerts" value="2" />
+        )}
+        {null}
+      </EventStatBar>,
+    );
+
+    const bar: HTMLElement = container.firstElementChild as HTMLElement;
+
+    expect(bar.children).toHaveLength(2);
+    expect(bar).toHaveClass("sm:grid-cols-2");
+    expect(bar).not.toHaveClass("sm:grid-cols-3");
+  });
+
+  test("renders nothing, not an empty bordered box, without cells", () => {
+    const { container } = render(
+      <EventStatBar columns={3}>
+        {null}
+        {false}
+      </EventStatBar>,
+    );
+
+    expect(container).toBeEmptyDOMElement();
+  });
+
+  test("appends a caller class name", () => {
+    const { container } = render(
+      <EventStatBar columns={1} className="mb-5">
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+      </EventStatBar>,
+    );
+
+    expect(container.firstElementChild).toHaveClass("mb-5", "grid");
+  });
+
+  test("is an unnamed layout wrapper by default and a named group on request", () => {
+    const { container, rerender } = render(
+      <EventStatBar columns={1}>
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+      </EventStatBar>,
+    );
+
+    const bar: HTMLElement = container.firstElementChild as HTMLElement;
+    expect(bar).not.toHaveAttribute("role");
+    expect(bar).not.toHaveAttribute("aria-label");
+
+    rerender(
+      <EventStatBar columns={1} ariaLabel="Incident timing">
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+      </EventStatBar>,
+    );
+
+    expect(
+      screen.getByRole("group", { name: "Incident timing" }),
+    ).toContainElement(screen.getByText("Duration"));
+  });
+
+  test("keeps long cell values whole inside the bar", () => {
+    render(
+      <EventStatBar columns={2}>
+        <EventStatTile variant="segment" label="Status" value={LONG_VALUE} />
+        <EventStatTile variant="segment" label="Duration" value="3m" />
+      </EventStatBar>,
+    );
+
+    expect(screen.getByText(LONG_VALUE)).toHaveTextContent(LONG_VALUE);
+    expect(screen.getByText(LONG_VALUE)).not.toHaveClass("truncate");
+  });
+});