@oneuptime/common 12.0.5 → 12.0.6

package/Tests/App/Dashboard/AlertsSideMenu.test.tsx

@@ -0,0 +1,387 @@
+import {
+  afterEach,
+  beforeEach,
+  describe,
+  expect,
+  jest,
+  test,
+} from "@jest/globals";
+import "@testing-library/jest-dom";
+import { cleanup, fireEvent } from "@testing-library/react";
+import * as React from "react";
+
+/*
+ * The alerts side menu is the only map users have of the alerts product, and
+ * the reorganisation that split AI and Rules out of Settings is exactly the
+ * kind of change that silently drops a page: an entry moved into a new section
+ * but never added, or added twice, or pointed at the wrong route. Nothing about
+ * any of those looks wrong in a diff.
+ *
+ * So these render the real component against the real RouteMap rather than
+ * asserting on its source, and every href is compared to the route the page is
+ * actually registered under. The last test in "coverage" is the important one:
+ * it pins the full set of settings pages that were reachable before the move,
+ * so a page can be re-sectioned freely but never lost.
+ */
+/*
+ * ModelAPI.count backs the badge entries. Stubbed inline rather than through
+ * the shared harness because jest.mock is hoisted above the imports — a helper
+ * imported from another module is not initialised yet when it runs.
+ */
+jest.mock("../../../UI/Utils/ModelAPI/ModelAPI", () => {
+  return {
+    __esModule: true,
+    default: {
+      count: () => {
+        return Promise.resolve(0);
+      },
+    },
+  };
+});
+
+import AlertsSideMenu from "../../../../App/FeatureSet/Dashboard/src/Pages/Alerts/SideMenu";
+import PageMap from "../../../../App/FeatureSet/Dashboard/src/Utils/PageMap";
+import {
+  DESKTOP_WIDTH,
+  MOBILE_WIDTH,
+  MenuLink,
+  PROJECT_ID,
+  goTo,
+  hrefsInMenu,
+  iconCountIn,
+  isExpanded,
+  linksIn,
+  mobileSummaryText,
+  renderMenu,
+  routeFor,
+  sectionBody,
+  sectionTitlesInOrder,
+  sectionToggle,
+  setViewportWidth,
+  titlesInMenu,
+} from "./SideMenuHarness";
+
+async function renderAlertsMenu(): Promise<void> {
+  await renderMenu(<AlertsSideMenu />);
+}
+
+describe("Alerts side menu", () => {
+  beforeEach(() => {
+    setViewportWidth(DESKTOP_WIDTH);
+    goTo(`/dashboard/${PROJECT_ID}/alerts`);
+  });
+
+  afterEach(() => {
+    cleanup();
+  });
+
+  describe("sections", () => {
+    test("renders the six product sections in order", async () => {
+      await renderAlertsMenu();
+
+      expect(sectionTitlesInOrder()).toEqual([
+        "Alerts",
+        "Episodes",
+        "AI",
+        "Workspace",
+        "Rules",
+        "Settings",
+      ]);
+    });
+
+    test("the day-to-day sections are expanded and the configuration sections are collapsed", async () => {
+      await renderAlertsMenu();
+
+      expect(isExpanded("Alerts")).toBe(true);
+      expect(isExpanded("Episodes")).toBe(true);
+      expect(isExpanded("AI")).toBe(true);
+      expect(isExpanded("Workspace")).toBe(true);
+      expect(isExpanded("Rules")).toBe(false);
+      expect(isExpanded("Settings")).toBe(false);
+    });
+
+    test("the alert, episode and workspace sections are unchanged by the move", async () => {
+      await renderAlertsMenu();
+
+      expect(linksIn("Alerts")).toEqual([
+        { title: "All Alerts", href: routeFor(PageMap.ALERTS) },
+        { title: "Active Alerts", href: routeFor(PageMap.UNRESOLVED_ALERTS) },
+      ]);
+
+      expect(linksIn("Episodes")).toEqual([
+        { title: "All Episodes", href: routeFor(PageMap.ALERT_EPISODES) },
+        {
+          title: "Active Episodes",
+          href: routeFor(PageMap.UNRESOLVED_ALERT_EPISODES),
+        },
+        { title: "Documentation", href: routeFor(PageMap.ALERT_EPISODE_DOCS) },
+      ]);
+
+      expect(linksIn("Workspace")).toEqual([
+        {
+          title: "Slack",
+          href: routeFor(PageMap.ALERTS_WORKSPACE_CONNECTION_SLACK),
+        },
+        {
+          title: "Microsoft Teams",
+          href: routeFor(PageMap.ALERTS_WORKSPACE_CONNECTION_MICROSOFT_TEAMS),
+        },
+      ]);
+    });
+  });
+
+  describe("AI section", () => {
+    test("holds exactly Investigation and Remediation, pointing at the AI and auto-remediation pages", async () => {
+      await renderAlertsMenu();
+
+      expect(linksIn("AI")).toEqual([
+        { title: "Investigation", href: routeFor(PageMap.ALERTS_SETTINGS_AI) },
+        {
+          title: "Remediation",
+          href: routeFor(PageMap.ALERTS_SETTINGS_AUTO_REMEDIATION_RULES),
+        },
+      ]);
+    });
+
+    test("is visible without expanding anything", async () => {
+      await renderAlertsMenu();
+
+      expect(isExpanded("AI")).toBe(true);
+      expect(sectionBody("AI").className).toContain("opacity-100");
+      expect(sectionBody("AI").className).not.toContain("max-h-0");
+    });
+
+    test("both entries carry an icon", async () => {
+      await renderAlertsMenu();
+
+      expect(iconCountIn("AI")).toBe(2);
+    });
+  });
+
+  describe("Rules section", () => {
+    test("holds every alert rule page", async () => {
+      await renderAlertsMenu();
+
+      expect(linksIn("Rules")).toEqual([
+        {
+          title: "Grouping Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_GROUPING_RULES),
+        },
+        {
+          title: "On-Call Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_ON_CALL_RULES),
+        },
+        {
+          title: "Owner Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_OWNER_RULES),
+        },
+        {
+          title: "Runbook Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_RUNBOOK_RULES),
+        },
+        {
+          title: "Privacy Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_PRIVACY_RULES),
+        },
+        {
+          title: "Label Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_LABEL_RULES),
+        },
+        {
+          title: "Reminder Rules",
+          href: routeFor(PageMap.ALERTS_SETTINGS_REMINDER_RULES),
+        },
+      ]);
+    });
+
+    test("starts collapsed", async () => {
+      await renderAlertsMenu();
+
+      expect(isExpanded("Rules")).toBe(false);
+      expect(sectionBody("Rules").className).toContain("max-h-0");
+      expect(sectionBody("Rules").className).toContain("opacity-0");
+    });
+
+    test("expands on click and collapses again", async () => {
+      await renderAlertsMenu();
+
+      fireEvent.click(sectionToggle("Rules"));
+
+      expect(isExpanded("Rules")).toBe(true);
+      expect(sectionBody("Rules").className).not.toContain("max-h-0");
+      expect(sectionBody("Rules").className).toContain("opacity-100");
+
+      fireEvent.click(sectionToggle("Rules"));
+
+      expect(isExpanded("Rules")).toBe(false);
+      expect(sectionBody("Rules").className).toContain("max-h-0");
+    });
+
+    /*
+     * Collapsed is a style, not an unmount — the links stay in the DOM and
+     * stay clickable through keyboard navigation. Worth pinning: a future
+     * change to conditional rendering would make the collapsed section
+     * unreachable for anything that is not a mouse.
+     */
+    test("its links stay reachable while collapsed", async () => {
+      await renderAlertsMenu();
+
+      expect(isExpanded("Rules")).toBe(false);
+      expect(linksIn("Rules")).toHaveLength(7);
+    });
+  });
+
+  describe("Settings section", () => {
+    test("keeps only the settings pages that are neither AI nor rules", async () => {
+      await renderAlertsMenu();
+
+      expect(linksIn("Settings")).toEqual([
+        {
+          title: "Alert State",
+          href: routeFor(PageMap.ALERTS_SETTINGS_STATE),
+        },
+        {
+          title: "Alert Severity",
+          href: routeFor(PageMap.ALERTS_SETTINGS_SEVERITY),
+        },
+        {
+          title: "Note Templates",
+          href: routeFor(PageMap.ALERTS_SETTINGS_NOTE_TEMPLATES),
+        },
+        {
+          title: "Custom Fields",
+          href: routeFor(PageMap.ALERTS_SETTINGS_CUSTOM_FIELDS),
+        },
+        {
+          title: "More Settings",
+          href: routeFor(PageMap.ALERTS_SETTINGS_MORE),
+        },
+      ]);
+    });
+
+    test("no longer links to the AI or auto-remediation pages", async () => {
+      await renderAlertsMenu();
+
+      const settingsHrefs: Array<string> = linksIn("Settings").map(
+        (link: MenuLink): string => {
+          return link.href;
+        },
+      );
+
+      expect(settingsHrefs).not.toContain(routeFor(PageMap.ALERTS_SETTINGS_AI));
+      expect(settingsHrefs).not.toContain(
+        routeFor(PageMap.ALERTS_SETTINGS_AUTO_REMEDIATION_RULES),
+      );
+    });
+
+    test("no longer holds any rule page", async () => {
+      await renderAlertsMenu();
+
+      expect(
+        linksIn("Settings").filter((link: MenuLink): boolean => {
+          return link.title.endsWith("Rules");
+        }),
+      ).toEqual([]);
+    });
+  });
+
+  describe("coverage", () => {
+    /*
+     * The set of settings pages the menu reached before AI and Rules were
+     * split out. Re-sectioning is fine; dropping one is not.
+     */
+    const SETTINGS_PAGES_BEFORE_THE_MOVE: Array<string> = [
+      PageMap.ALERTS_SETTINGS_AI,
+      PageMap.ALERTS_SETTINGS_STATE,
+      PageMap.ALERTS_SETTINGS_SEVERITY,
+      PageMap.ALERTS_SETTINGS_NOTE_TEMPLATES,
+      PageMap.ALERTS_SETTINGS_CUSTOM_FIELDS,
+      PageMap.ALERTS_SETTINGS_GROUPING_RULES,
+      PageMap.ALERTS_SETTINGS_ON_CALL_RULES,
+      PageMap.ALERTS_SETTINGS_OWNER_RULES,
+      PageMap.ALERTS_SETTINGS_RUNBOOK_RULES,
+      PageMap.ALERTS_SETTINGS_AUTO_REMEDIATION_RULES,
+      PageMap.ALERTS_SETTINGS_PRIVACY_RULES,
+      PageMap.ALERTS_SETTINGS_LABEL_RULES,
+      PageMap.ALERTS_SETTINGS_REMINDER_RULES,
+      PageMap.ALERTS_SETTINGS_MORE,
+    ];
+
+    test("every settings page reachable before the move is still reachable", async () => {
+      await renderAlertsMenu();
+
+      const hrefs: Array<string> = hrefsInMenu();
+
+      SETTINGS_PAGES_BEFORE_THE_MOVE.forEach((pageMapKey: string) => {
+        expect(hrefs).toContain(routeFor(pageMapKey));
+      });
+    });
+
+    test("no page is listed in two places", async () => {
+      await renderAlertsMenu();
+
+      const hrefs: Array<string> = hrefsInMenu();
+
+      expect(hrefs).toEqual(Array.from(new Set(hrefs)));
+    });
+
+    test("no title is used twice", async () => {
+      await renderAlertsMenu();
+
+      const titles: Array<string> = titlesInMenu();
+
+      expect(titles).toEqual(Array.from(new Set(titles)));
+    });
+
+    test("every link resolves to a fully populated route", async () => {
+      await renderAlertsMenu();
+
+      linksIn("Rules")
+        .concat(linksIn("AI"), linksIn("Settings"), linksIn("Alerts"))
+        .forEach((link: MenuLink) => {
+          expect(link.href).toContain(`/dashboard/${PROJECT_ID}/alerts`);
+          expect(link.href).not.toContain(":");
+          expect(link.title).not.toBe("");
+        });
+    });
+  });
+
+  /*
+   * On a phone the menu collapses to a single button that names where you
+   * are as "<section> / <page>". That string is the one place the section
+   * rename is spelled out to the user, so it is worth pinning directly.
+   */
+  describe("mobile summary", () => {
+    beforeEach(() => {
+      setViewportWidth(MOBILE_WIDTH);
+    });
+
+    test("names the AI section on the investigation page", async () => {
+      goTo(`/dashboard/${PROJECT_ID}/alerts/settings/ai`);
+      await renderAlertsMenu();
+
+      expect(mobileSummaryText()).toContain("AI / Investigation");
+    });
+
+    test("names the AI section on the remediation page", async () => {
+      goTo(`/dashboard/${PROJECT_ID}/alerts/settings/auto-remediation-rules`);
+      await renderAlertsMenu();
+
+      expect(mobileSummaryText()).toContain("AI / Remediation");
+    });
+
+    test("names the Rules section on a rule page", async () => {
+      goTo(`/dashboard/${PROJECT_ID}/alerts/settings/grouping-rules`);
+      await renderAlertsMenu();
+
+      expect(mobileSummaryText()).toContain("Rules / Grouping Rules");
+    });
+
+    test("still names the Settings section on a settings page", async () => {
+      goTo(`/dashboard/${PROJECT_ID}/alerts/settings/state`);
+      await renderAlertsMenu();
+
+      expect(mobileSummaryText()).toContain("Settings / Alert State");
+    });
+  });
+});

package/Tests/App/Dashboard/ChatActivityFeed.test.tsx

@@ -0,0 +1,199 @@
+import { afterEach, describe, expect, test } from "@jest/globals";
+import "@testing-library/jest-dom";
+import { cleanup, render, screen } from "@testing-library/react";
+import * as React from "react";
+import ChatActivityFeed, {
+  hasRenderableActivity,
+} from "../../../../App/FeatureSet/Dashboard/src/Components/AIChat/ChatActivityFeed";
+import AIRunEvent from "../../../Models/DatabaseModels/AIRunEvent";
+import AIRunEventType from "../../../Types/AI/AIRunEventType";
+import ObjectID from "../../../Types/ObjectID";
+
+/*
+ * ChatActivityFeed is shared: the AI chat panel and copilot render it with its
+ * own assistant bubble, while the investigation panel frames it itself and
+ * asks for the steps alone (hideChrome). Both shapes need pinning here —
+ * without the default-props test, inverting the hideChrome guard would strip
+ * the chat panel's chrome with every other suite still green.
+ */
+
+interface StepEvent {
+  eventType: AIRunEventType;
+  toolName?: string | undefined;
+  resultSummary?:
+    | { rowCount?: number | undefined; durationInMs?: number | undefined }
+    | undefined;
+}
+
+function events(steps: Array<StepEvent>): Array<AIRunEvent> {
+  return steps.map((step: StepEvent): AIRunEvent => {
+    const event: AIRunEvent = new AIRunEvent(ObjectID.generate());
+    event.eventType = step.eventType;
+
+    if (step.toolName) {
+      event.toolName = step.toolName;
+    }
+
+    if (step.resultSummary) {
+      event.resultSummary = step.resultSummary;
+    }
+
+    return event;
+  });
+}
+
+const SEARCH_LOGS_RUN: Array<AIRunEvent> = events([
+  { eventType: AIRunEventType.RunStarted },
+  { eventType: AIRunEventType.ToolCallStarted, toolName: "search_logs" },
+  {
+    eventType: AIRunEventType.ToolCallCompleted,
+    toolName: "search_logs",
+    resultSummary: { rowCount: 3, durationInMs: 1500 },
+  },
+]);
+
+function bubble(container: HTMLElement): Element | null {
+  return container.querySelector(".rounded-xl.border.border-gray-200");
+}
+
+afterEach(() => {
+  cleanup();
+});
+
+describe("hasRenderableActivity", () => {
+  test("no events draw nothing", () => {
+    expect(hasRenderableActivity([])).toBe(false);
+  });
+
+  /*
+   * The case the investigation panel used to get wrong: emitEvent swallows
+   * its own persistence failures, so a run can lose RunStarted and still
+   * record a terminal RunFailed — one event, zero steps.
+   */
+  test("a terminal-only trail draws nothing despite carrying events", () => {
+    expect(
+      hasRenderableActivity(events([{ eventType: AIRunEventType.RunFailed }])),
+    ).toBe(false);
+    expect(
+      hasRenderableActivity(
+        events([{ eventType: AIRunEventType.RunCompleted }]),
+      ),
+    ).toBe(false);
+  });
+
+  test("a completion without its opening event still draws nothing", () => {
+    expect(
+      hasRenderableActivity(
+        events([
+          {
+            eventType: AIRunEventType.ToolCallCompleted,
+            toolName: "search_logs",
+          },
+        ]),
+      ),
+    ).toBe(false);
+  });
+
+  test("a real trail draws steps", () => {
+    expect(hasRenderableActivity(SEARCH_LOGS_RUN)).toBe(true);
+  });
+});
+
+describe("ChatActivityFeed default chrome (chat panel and copilot)", () => {
+  test("keeps its avatar, bubble, title and live indicator", () => {
+    const { container } = render(<ChatActivityFeed events={SEARCH_LOGS_RUN} />);
+
+    expect(screen.getByText("Investigating…")).toBeVisible();
+    expect(bubble(container)).not.toBeNull();
+    // The assistant avatar is the dark rounded square holding the icon.
+    expect(container.querySelector(".bg-gray-900")).not.toBeNull();
+    expect(container.querySelector('[class~="animate-ping"]')).not.toBeNull();
+  });
+
+  test("an explicit title replaces the live wording and the dot can be hidden", () => {
+    const { container } = render(
+      <ChatActivityFeed
+        events={SEARCH_LOGS_RUN}
+        title="Completed activity"
+        showLiveIndicator={false}
+      />,
+    );
+
+    expect(screen.getByText("Completed activity")).toBeVisible();
+    expect(screen.queryByText("Investigating…")).toBeNull();
+    expect(container.querySelector('[class~="animate-ping"]')).toBeNull();
+  });
+});
+
+describe("ChatActivityFeed hideChrome (investigation panel)", () => {
+  test("renders the steps and none of the bubble chrome", () => {
+    const { container } = render(
+      <ChatActivityFeed events={SEARCH_LOGS_RUN} hideChrome={true} />,
+    );
+
+    expect(screen.getByText("Searching logs")).toBeVisible();
+    expect(screen.getByText("· 3 rows · 1.5s")).toBeVisible();
+
+    expect(screen.queryByText("Investigating…")).toBeNull();
+    expect(bubble(container)).toBeNull();
+    expect(container.querySelector(".bg-gray-900")).toBeNull();
+    expect(container.querySelector('[class~="animate-ping"]')).toBeNull();
+  });
+
+  test("a trail that yields no steps renders nothing at all", () => {
+    const { container } = render(
+      <ChatActivityFeed
+        events={events([{ eventType: AIRunEventType.RunFailed }])}
+        hideChrome={true}
+      />,
+    );
+
+    expect(container).toBeEmptyDOMElement();
+  });
+
+  test("marks a failed tool call rather than reporting it as done", () => {
+    render(
+      <ChatActivityFeed
+        events={events([
+          { eventType: AIRunEventType.RunStarted },
+          {
+            eventType: AIRunEventType.ToolCallStarted,
+            toolName: "query_traces",
+          },
+          {
+            eventType: AIRunEventType.ToolCallFailed,
+            toolName: "query_traces",
+          },
+        ])}
+        hideChrome={true}
+      />,
+    );
+
+    expect(screen.getByText("Analyzing traces")).toBeVisible();
+    expect(
+      screen.getByText("· did not succeed — retrying differently"),
+    ).toBeVisible();
+  });
+
+  test("caps the visible steps and says how many were hidden", () => {
+    const manySteps: Array<AIRunEvent> = events(
+      Array.from({ length: 12 }, () => {
+        return {
+          eventType: AIRunEventType.ToolCallStarted,
+          toolName: "search_logs",
+        };
+      }),
+    );
+
+    render(
+      <ChatActivityFeed
+        events={manySteps}
+        hideChrome={true}
+        maxVisibleSteps={4}
+      />,
+    );
+
+    expect(screen.getByText("+ 8 earlier steps")).toBeVisible();
+    expect(screen.getAllByText("Searching logs…")).toHaveLength(4);
+  });
+});