@oneuptime/common 12.0.3 → 12.0.5

package/Tests/Server/Utils/AI/FixFromIncidentAutoTrigger.test.ts

@@ -4,20 +4,28 @@ import FixFromIncidentTaskTrigger, {
 import SubjectCodeFixRun from "../../../../Server/Utils/AI/SRE/SubjectCodeFixRun";
 import FixRunBudget from "../../../../Server/Utils/AI/CodeFix/FixRunBudget";
 import ProjectService from "../../../../Server/Services/ProjectService";
+import AIRunService from "../../../../Server/Services/AIRunService";
+import Semaphore from "../../../../Server/Infrastructure/Semaphore";
+import {
+  getInvestigationSubjectLockKey,
+  INVESTIGATION_SUBJECT_LOCK_NAMESPACE,
+} from "../../../../Server/Utils/AI/SRE/InvestigationSubjectLock";
 import Project from "../../../../Models/DatabaseModels/Project";
 import AIRun from "../../../../Models/DatabaseModels/AIRun";
 import CodeFixTaskType from "../../../../Types/AI/CodeFixTaskType";
+import AIRunStatus from "../../../../Types/AI/AIRunStatus";
+import AIRunCodeFixRecommendation from "../../../../Types/AI/AIRunCodeFixRecommendation";
 import ObjectID from "../../../../Types/ObjectID";
 import { describe, expect, test, afterEach, beforeEach } from "@jest/globals";
 
 /*
- * The AUTOMATIC form of the FixFromIncident trigger: a CONFIDENT
+ * The AUTOMATIC form of the FixFromIncident trigger: a durably Recommended
  * investigation (per the structured G6 signal) enqueues a fix-PR CodeFix
  * run with no human click — but ONLY for projects that explicitly opted in
- * (Project.enableAutomaticCodeFixes, default FALSE — G11 posture), only
+ * for the investigation's incident or alert lane (both default FALSE — G11 posture), only
  * when a GitHub-App repo exists to open the PR against, at most one
  * non-terminal run per subject, and inside the daily fix-run budget. It
- * runs inside the investigation's postAnalysis, so it must NEVER throw,
+ * runs as a post-recommendation follow-up, so it must NEVER throw,
  * and the run stays system-authored (no userId). Unlike its
  * human-triggered sibling (createFixTaskFromInvestigation, tested in
  * Tests/Server/Services/FixFromIncidentTaskTrigger.test.ts), every failed
@@ -27,15 +35,22 @@ import { describe, expect, test, afterEach, beforeEach } from "@jest/globals";
 const projectId: ObjectID = ObjectID.generate();
 const incidentId: ObjectID = ObjectID.generate();
 const alertId: ObjectID = ObjectID.generate();
+const investigationRunId: ObjectID = ObjectID.generate();
+const analysisMarkdown: string = "## Frozen automatic investigation report";
+const enqueueSubjectCodeFixRun: typeof SubjectCodeFixRun.enqueueSubjectCodeFixRun =
+  SubjectCodeFixRun.enqueueSubjectCodeFixRun.bind(SubjectCodeFixRun);
 
 function fakeProject(data?: {
   enableAi?: boolean;
-  enableAutomaticCodeFixes?: boolean;
+  enableAutomaticIncidentCodeFixes?: boolean;
+  enableAutomaticAlertCodeFixes?: boolean;
 }): Project {
   return {
     id: projectId,
     enableAi: data?.enableAi ?? true,
-    enableAutomaticCodeFixes: data?.enableAutomaticCodeFixes ?? true,
+    enableAutomaticIncidentCodeFixes:
+      data?.enableAutomaticIncidentCodeFixes ?? true,
+    enableAutomaticAlertCodeFixes: data?.enableAutomaticAlertCodeFixes ?? true,
   } as unknown as Project;
 }
 
@@ -43,11 +58,27 @@ function fakeRun(): AIRun {
   return { id: ObjectID.generate() } as unknown as AIRun;
 }
 
+function persistedRecommendedInvestigation(
+  overrides: Partial<AIRun> = {},
+): AIRun {
+  return {
+    id: investigationRunId,
+    status: AIRunStatus.Completed,
+    codeFixRecommendation: AIRunCodeFixRecommendation.Recommended,
+    taskContext: {
+      sourceInvestigationRunId: investigationRunId.toString(),
+      sourceInvestigationAnalysisMarkdown: analysisMarkdown,
+    },
+    ...overrides,
+  } as unknown as AIRun;
+}
+
 describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
   test("does not enqueue when the project is missing", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project: null,
+        incidentId,
         hasConnectedRepository: true,
         existingRun: null,
       });
@@ -60,6 +91,7 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project: fakeProject({ enableAi: false }),
+        incidentId,
         hasConnectedRepository: true,
         existingRun: null,
       });
@@ -72,12 +104,13 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
     const project: Project = {
       id: projectId,
       enableAi: true,
-      // enableAutomaticCodeFixes deliberately absent.
+      // enableAutomaticIncidentCodeFixes deliberately absent.
     } as unknown as Project;
 
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project,
+        incidentId,
         hasConnectedRepository: true,
         existingRun: null,
       });
@@ -89,7 +122,8 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
   test("an explicit false flag never enqueues", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
-        project: fakeProject({ enableAutomaticCodeFixes: false }),
+        project: fakeProject({ enableAutomaticIncidentCodeFixes: false }),
+        incidentId,
         hasConnectedRepository: true,
         existingRun: null,
       });
@@ -98,10 +132,85 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
     expect(decision.reason).toMatch(/not opted in/);
   });
 
+  test("incident and alert opt-ins are independent: incident enabled does not enable alerts", () => {
+    const project: Project = fakeProject({
+      enableAutomaticIncidentCodeFixes: true,
+      enableAutomaticAlertCodeFixes: false,
+    });
+
+    expect(
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project,
+        incidentId,
+        hasConnectedRepository: true,
+        existingRun: null,
+      }).enqueue,
+    ).toBe(true);
+    expect(
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project,
+        alertId,
+        hasConnectedRepository: true,
+        existingRun: null,
+      }).enqueue,
+    ).toBe(false);
+  });
+
+  test("incident and alert opt-ins are independent: alert enabled does not enable incidents", () => {
+    const project: Project = fakeProject({
+      enableAutomaticIncidentCodeFixes: false,
+      enableAutomaticAlertCodeFixes: true,
+    });
+
+    expect(
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project,
+        incidentId,
+        hasConnectedRepository: true,
+        existingRun: null,
+      }).enqueue,
+    ).toBe(false);
+    expect(
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project,
+        alertId,
+        hasConnectedRepository: true,
+        existingRun: null,
+      }).enqueue,
+    ).toBe(true);
+  });
+
+  test("a subjectless gate decision is rejected instead of borrowing either opt-in", () => {
+    const decision: AutoFixTaskGateDecision =
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project: fakeProject(),
+        hasConnectedRepository: true,
+        existingRun: null,
+      });
+
+    expect(decision.enqueue).toBe(false);
+    expect(decision.reason).toMatch(/subject/);
+  });
+
+  test("a gate carrying both subject types is rejected instead of borrowing the incident opt-in", () => {
+    const decision: AutoFixTaskGateDecision =
+      FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
+        project: fakeProject(),
+        incidentId,
+        alertId,
+        hasConnectedRepository: true,
+        existingRun: null,
+      });
+
+    expect(decision.enqueue).toBe(false);
+    expect(decision.reason).toMatch(/exactly one/);
+  });
+
   test("does not enqueue without a GitHub-App-connected repository", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project: fakeProject(),
+        incidentId,
         hasConnectedRepository: false,
         existingRun: null,
       });
@@ -114,6 +223,7 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project: fakeProject(),
+        incidentId,
         hasConnectedRepository: true,
         existingRun: fakeRun(),
       });
@@ -126,6 +236,7 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
     const decision: AutoFixTaskGateDecision =
       FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask({
         project: fakeProject(),
+        incidentId,
         hasConnectedRepository: true,
         existingRun: null,
       });
@@ -135,7 +246,7 @@ describe("FixFromIncidentTaskTrigger.shouldAutoEnqueueFixTask", () => {
   });
 });
 
-describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", () => {
+describe("FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation", () => {
   let getBudgetStatus: jest.SpyInstance;
   let hasRepository: jest.SpyInstance;
   let findNonTerminalRun: jest.SpyInstance;
@@ -163,6 +274,12 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
     enqueue = jest
       .spyOn(SubjectCodeFixRun, "enqueueSubjectCodeFixRun")
       .mockResolvedValue(fakeRun());
+    jest.spyOn(FixRunBudget, "assertWithinBudget").mockResolvedValue();
+    jest.spyOn(Semaphore, "lock").mockResolvedValue({} as never);
+    jest.spyOn(Semaphore, "release").mockResolvedValue();
+    jest
+      .spyOn(AIRunService, "findOneBy")
+      .mockResolvedValue(persistedRecommendedInvestigation());
   });
 
   afterEach(() => {
@@ -175,8 +292,10 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
       "findOneById",
     );
 
-    await FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
       projectId,
+      investigationRunId,
+      analysisMarkdown,
     });
 
     expect(findProject).not.toHaveBeenCalled();
@@ -186,13 +305,68 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
     expect(enqueue).not.toHaveBeenCalled();
   });
 
+  test("a call carrying both subject types is an immediate no-op", async () => {
+    const findProject: jest.SpyInstance = jest.spyOn(
+      ProjectService,
+      "findOneById",
+    );
+
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
+      projectId,
+      investigationRunId,
+      analysisMarkdown,
+      incidentId,
+      alertId,
+    });
+
+    expect(findProject).not.toHaveBeenCalled();
+    expect(getBudgetStatus).not.toHaveBeenCalled();
+    expect(hasRepository).not.toHaveBeenCalled();
+    expect(findNonTerminalRun).not.toHaveBeenCalled();
+    expect(enqueue).not.toHaveBeenCalled();
+  });
+
+  test.each([
+    ["missing source run id", undefined, analysisMarkdown],
+    ["blank analysis", investigationRunId, "   "],
+  ] as Array<[string, ObjectID | undefined, string]>)(
+    "%s fails closed before project or gate IO",
+    async (
+      _label: string,
+      sourceRunId: ObjectID | undefined,
+      sourceAnalysis: string,
+    ) => {
+      const findProject: jest.SpyInstance = jest.spyOn(
+        ProjectService,
+        "findOneById",
+      );
+
+      await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
+        projectId,
+        investigationRunId: sourceRunId as ObjectID,
+        analysisMarkdown: sourceAnalysis,
+        incidentId,
+      });
+
+      expect(findProject).not.toHaveBeenCalled();
+      expect(getBudgetStatus).not.toHaveBeenCalled();
+      expect(hasRepository).not.toHaveBeenCalled();
+      expect(findNonTerminalRun).not.toHaveBeenCalled();
+      expect(enqueue).not.toHaveBeenCalled();
+    },
+  );
+
   test("a not-opted-in project (default) skips cheaply: BEFORE the budget, repo and dedupe queries", async () => {
     jest
       .spyOn(ProjectService, "findOneById")
-      .mockResolvedValue(fakeProject({ enableAutomaticCodeFixes: false }));
+      .mockResolvedValue(
+        fakeProject({ enableAutomaticIncidentCodeFixes: false }),
+      );
 
-    await FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
       projectId,
+      investigationRunId,
+      analysisMarkdown,
       incidentId,
     });
 
@@ -202,6 +376,26 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
     expect(enqueue).not.toHaveBeenCalled();
   });
 
+  test("the alert opt-in cannot enable an automatic incident code fix", async () => {
+    jest.spyOn(ProjectService, "findOneById").mockResolvedValue(
+      fakeProject({
+        enableAutomaticIncidentCodeFixes: false,
+        enableAutomaticAlertCodeFixes: true,
+      }),
+    );
+
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
+      projectId,
+      investigationRunId,
+      analysisMarkdown,
+      incidentId,
+    });
+
+    expect(getBudgetStatus).not.toHaveBeenCalled();
+    expect(hasRepository).not.toHaveBeenCalled();
+    expect(enqueue).not.toHaveBeenCalled();
+  });
+
   test("over the daily fix-run budget: a quiet SKIP — nothing enqueued, nothing thrown into the investigation", async () => {
     jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
     getBudgetStatus.mockResolvedValue({
@@ -212,8 +406,10 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
     });
 
     await expect(
-      FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+      FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
         projectId,
+        investigationRunId,
+        analysisMarkdown,
         incidentId,
       }),
     ).resolves.toBeUndefined();
@@ -221,14 +417,59 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
     // Skipped before the repo/dedupe queries, and no run was enqueued.
     expect(hasRepository).not.toHaveBeenCalled();
     expect(enqueue).not.toHaveBeenCalled();
+    expect(getBudgetStatus).toHaveBeenCalledWith(projectId, {
+      incidentId,
+      alertId: undefined,
+    });
   });
 
+  test.each([
+    ["a newer investigation", { id: ObjectID.generate() }],
+    [
+      "a still-Pending source",
+      { codeFixRecommendation: AIRunCodeFixRecommendation.Pending },
+    ],
+    [
+      "a mismatched durable snapshot",
+      {
+        taskContext: {
+          sourceInvestigationRunId: investigationRunId.toString(),
+          sourceInvestigationAnalysisMarkdown: "different analysis",
+        },
+      },
+    ],
+  ] as Array<[string, Partial<AIRun>]>)(
+    "%s fails closed before budget, repository, dedupe, and enqueue IO",
+    async (_label: string, overrides: Partial<AIRun>) => {
+      jest
+        .spyOn(ProjectService, "findOneById")
+        .mockResolvedValue(fakeProject());
+      (AIRunService.findOneBy as unknown as jest.Mock).mockResolvedValue(
+        persistedRecommendedInvestigation(overrides),
+      );
+
+      await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
+        projectId,
+        investigationRunId,
+        analysisMarkdown,
+        incidentId,
+      });
+
+      expect(getBudgetStatus).not.toHaveBeenCalled();
+      expect(hasRepository).not.toHaveBeenCalled();
+      expect(findNonTerminalRun).not.toHaveBeenCalled();
+      expect(enqueue).not.toHaveBeenCalled();
+    },
+  );
+
   test("dedupe: a live FixFromIncident run for the same subject blocks the automatic enqueue", async () => {
     jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
     findNonTerminalRun.mockResolvedValue(fakeRun());
 
-    await FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
       projectId,
+      investigationRunId,
+      analysisMarkdown,
       incidentId,
     });
 
@@ -243,11 +484,28 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
   });
 
   test("happy path (incident): enqueues a FixFromIncident run for the incident with NO user attribution", async () => {
-    jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
+    const findProject: jest.SpyInstance = jest
+      .spyOn(ProjectService, "findOneById")
+      .mockResolvedValue(fakeProject());
 
-    await FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
       projectId,
+      investigationRunId,
+      analysisMarkdown,
+      incidentId,
+    });
+
+    expect(findProject).toHaveBeenCalledWith(
+      expect.objectContaining({
+        select: {
+          enableAi: true,
+          enableAutomaticIncidentCodeFixes: true,
+        },
+      }),
+    );
+    expect(getBudgetStatus).toHaveBeenCalledWith(projectId, {
       incidentId,
+      alertId: undefined,
     });
 
     expect(enqueue).toHaveBeenCalledTimes(1);
@@ -256,6 +514,10 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
         projectId,
         taskType: CodeFixTaskType.FixFromIncident,
         incidentId,
+        taskContext: {
+          sourceInvestigationRunId: investigationRunId.toString(),
+          sourceInvestigationAnalysisMarkdown: analysisMarkdown,
+        },
       }),
     );
 
@@ -264,10 +526,27 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
   });
 
   test("happy path (alert): the enqueue carries the alert subject", async () => {
-    jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
+    const findProject: jest.SpyInstance = jest
+      .spyOn(ProjectService, "findOneById")
+      .mockResolvedValue(fakeProject());
 
-    await FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+    await FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
       projectId,
+      investigationRunId,
+      analysisMarkdown,
+      alertId,
+    });
+
+    expect(findProject).toHaveBeenCalledWith(
+      expect.objectContaining({
+        select: {
+          enableAi: true,
+          enableAutomaticAlertCodeFixes: true,
+        },
+      }),
+    );
+    expect(getBudgetStatus).toHaveBeenCalledWith(projectId, {
+      incidentId: undefined,
       alertId,
     });
 
@@ -275,18 +554,62 @@ describe("FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation", ()
       expect.objectContaining({
         taskType: CodeFixTaskType.FixFromIncident,
         alertId,
+        taskContext: {
+          sourceInvestigationRunId: investigationRunId.toString(),
+          sourceInvestigationAnalysisMarkdown: analysisMarkdown,
+        },
       }),
     );
     expect(enqueue.mock.calls[0]![0]).not.toHaveProperty("userId");
   });
 
-  test("never throws — a failed enqueue must not fail the investigation's postAnalysis", async () => {
+  test("a newer Investigation appearing before the locked automatic insert is revalidated and blocks creation", async () => {
+    jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
+    const newerRunId: ObjectID = ObjectID.generate();
+    (AIRunService.findOneBy as unknown as jest.Mock)
+      .mockReset()
+      .mockResolvedValueOnce(persistedRecommendedInvestigation())
+      .mockResolvedValueOnce(
+        persistedRecommendedInvestigation({
+          id: newerRunId,
+          codeFixRecommendation: AIRunCodeFixRecommendation.NotRecommended,
+          taskContext: {
+            sourceInvestigationRunId: newerRunId.toString(),
+            sourceInvestigationAnalysisMarkdown: "newer operational analysis",
+          },
+        }),
+      );
+    enqueue.mockImplementation(enqueueSubjectCodeFixRun);
+    const create: jest.SpyInstance = jest.spyOn(AIRunService, "create");
+
+    await expect(
+      FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
+        projectId,
+        investigationRunId,
+        analysisMarkdown,
+        incidentId,
+      }),
+    ).resolves.toBeUndefined();
+
+    expect(Semaphore.lock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        key: getInvestigationSubjectLockKey({ projectId, incidentId }),
+        namespace: INVESTIGATION_SUBJECT_LOCK_NAMESPACE,
+      }),
+    );
+    expect(Semaphore.release).toHaveBeenCalledTimes(1);
+    expect(create).not.toHaveBeenCalled();
+  });
+
+  test("never throws — a failed enqueue must not fail the completed investigation", async () => {
     jest.spyOn(ProjectService, "findOneById").mockResolvedValue(fakeProject());
     enqueue.mockRejectedValue(new Error("database is down"));
 
     await expect(
-      FixFromIncidentTaskTrigger.autoEnqueueFromConfidentInvestigation({
+      FixFromIncidentTaskTrigger.autoEnqueueFromRecommendedInvestigation({
         projectId,
+        investigationRunId,
+        analysisMarkdown,
         incidentId,
       }),
     ).resolves.toBeUndefined();