@oneuptime/common 10.4.14 → 10.4.15

package/Models/AnalyticsModels/AnalyticsBaseModel/AnalyticsBaseModel.ts

@@ -52,6 +52,16 @@ export default class AnalyticsBaseModel extends CommonModel {
     materializedViews?: Array<MaterializedView> | undefined;
     enableMCP?: boolean | undefined;
     ttlExpression?: string | undefined; // e.g. "retentionDate DELETE"
+    /*
+     * Column that `findBy` falls back to when the caller doesn't
+     * specify a `sort`. Defaults to `createdAt` (matching the legacy
+     * behavior), but heavy analytics tables should override this to
+     * a column that participates in their ClickHouse sort key so the
+     * default list query streams from the index instead of doing a
+     * full sort. Examples: Log/MonitorLog/ExceptionInstance => "time",
+     * Span/Profile => "startTime", AuditLog => "createdAt".
+     */
+    defaultSortColumn?: string | undefined;
   }) {
     super({
       tableColumns: data.tableColumns,
@@ -156,6 +166,29 @@ export default class AnalyticsBaseModel extends CommonModel {
     this.materializedViews = data.materializedViews || [];
     this.enableMCP = data.enableMCP || false;
     this.ttlExpression = data.ttlExpression || "";
+
+    /*
+     * Validate the override matches the schema. We deliberately do
+     * NOT require the column to be in `sortKeys` — it must just
+     * exist on the table; the caller picks a column they know is
+     * indexed (typically the timestamp column at position 2 of the
+     * sort key, after `projectId`).
+     */
+    if (data.defaultSortColumn) {
+      const column: AnalyticsTableColumn | undefined = columns.find(
+        (column: AnalyticsTableColumn) => {
+          return column.key === data.defaultSortColumn;
+        },
+      );
+      if (!column) {
+        throw new BadDataException(
+          "defaultSortColumn " +
+            data.defaultSortColumn +
+            " is not part of tableColumns",
+        );
+      }
+      this.defaultSortColumn = data.defaultSortColumn;
+    }
   }
 
   private _enableWorkflowOn: EnableWorkflowOn | undefined;
@@ -214,6 +247,22 @@ export default class AnalyticsBaseModel extends CommonModel {
     this._sortKeys = v;
   }
 
+  /*
+   * Column that `AnalyticsDatabaseService._findBy` falls back to
+   * when the caller didn't pass a `sort`. `createdAt` (the historical
+   * default) is not part of the ClickHouse sort key on heavy
+   * analytics tables (Log/Span/Metric/...), so a default list query
+   * over those tables triggers a full sort. Per-model overrides
+   * point at a column that participates in the sort key.
+   */
+  private _defaultSortColumn: string = "createdAt";
+  public get defaultSortColumn(): string {
+    return this._defaultSortColumn;
+  }
+  public set defaultSortColumn(v: string) {
+    this._defaultSortColumn = v;
+  }
+
   private _singularName: string = "";
   public get singularName(): string {
     return this._singularName;

package/Models/AnalyticsModels/AuditLog.ts

@@ -287,6 +287,14 @@ export default class AuditLog extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "createdAt"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      /*
+       * `createdAt` already participates in the AuditLog sort key
+       * (position 2 after `projectId`), so the legacy `createdAt
+       * DESC` default was already efficient here. Set it explicitly
+       * so the choice is intentional rather than inherited from the
+       * base class.
+       */
+      defaultSortColumn: "createdAt",
     });
   }
 

package/Models/AnalyticsModels/ExceptionInstance.ts

@@ -667,6 +667,7 @@ export default class ExceptionInstance extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "time", "serviceId", "fingerprint"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "time",
     });
   }
 

package/Models/AnalyticsModels/Log.ts

@@ -569,6 +569,7 @@ export default class Log extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "time", "serviceId"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "time",
     });
   }
 

package/Models/AnalyticsModels/Metric.ts

@@ -1046,6 +1046,16 @@ export default class Metric extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "name", "serviceId", "time"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      /*
+       * `time` is the 4th column of the Metric sort key (after
+       * projectId + name + serviceId). A list query that filters
+       * by name (the typical "metric detail" drilldown) can still
+       * stream from the index when sorting by `time DESC`. With
+       * no name filter the sort is less efficient but still far
+       * better than the legacy `createdAt DESC` fallback, which
+       * isn't in the sort key at all.
+       */
+      defaultSortColumn: "time",
     });
   }
 

package/Models/AnalyticsModels/MonitorLog.ts

@@ -188,6 +188,7 @@ export default class MonitorLog extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "time", "monitorId"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "time",
     });
   }
 

package/Models/AnalyticsModels/Profile.ts

@@ -673,6 +673,7 @@ export default class Profile extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "startTime", "serviceId", "profileType"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "startTime",
     });
   }
 

package/Models/AnalyticsModels/ProfileSample.ts

@@ -542,6 +542,7 @@ export default class ProfileSample extends AnalyticsBaseModel {
       ],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "time",
     });
   }
 

package/Models/AnalyticsModels/Span.ts

@@ -846,6 +846,7 @@ export default class Span extends AnalyticsBaseModel {
       primaryKeys: ["projectId", "startTime", "serviceId", "traceId"],
       partitionKey: "sipHash64(projectId) % 16",
       ttlExpression: "retentionDate DELETE",
+      defaultSortColumn: "startTime",
     });
   }
 

package/Models/DatabaseModels/AlertCustomField.ts

@@ -249,6 +249,43 @@ export default class AlertCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateAlertCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.AlertAdmin,
+      Permission.AlertMember,
+      Permission.AlertViewer,
+      Permission.ReadAlertCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditAlertCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/IncidentCustomField.ts

@@ -249,6 +249,43 @@ export default class IncidentCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateIncidentCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.IncidentAdmin,
+      Permission.IncidentMember,
+      Permission.IncidentViewer,
+      Permission.ReadIncidentCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditIncidentCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/IncidentMember.ts

@@ -605,6 +605,15 @@ export default class IncidentMember extends BaseModel {
     read: [],
     update: [],
   })
+  /*
+   * Indexed because `IncidentMembers/SendMemberAddedNotification`
+   * cron polls `WHERE isMemberNotified = false` every minute. Without
+   * the index the cron does a full table scan that grows with every
+   * incident-member assignment ever made. Matches the indexing
+   * pattern used by the sibling `isOwnerNotified` flag on state
+   * timeline tables.
+   */
+  @Index()
   @TableColumn({
     isDefaultValueColumn: true,
     type: TableColumnType.Boolean,

package/Models/DatabaseModels/MonitorCustomField.ts

@@ -249,6 +249,43 @@ export default class MonitorCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateMonitorCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.MonitorAdmin,
+      Permission.MonitorMember,
+      Permission.MonitorViewer,
+      Permission.ReadMonitorCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditMonitorCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/OnCallDutyPolicyCustomField.ts

@@ -244,6 +244,43 @@ export default class OnCallDutyPolicyCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateOnCallDutyPolicyCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.OnCallAdmin,
+      Permission.OnCallMember,
+      Permission.OnCallViewer,
+      Permission.ReadOnCallDutyPolicyCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditOnCallDutyPolicyCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/ScheduledMaintenanceCustomField.ts

@@ -249,6 +249,43 @@ export default class ScheduledMaintenanceCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateScheduledMaintenanceCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.ScheduledMaintenanceAdmin,
+      Permission.ScheduledMaintenanceMember,
+      Permission.ScheduledMaintenanceViewer,
+      Permission.ReadScheduledMaintenanceCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditScheduledMaintenanceCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/StatusPageCustomField.ts

@@ -244,6 +244,43 @@ export default class StatusPageCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateStatusPageCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.StatusPageAdmin,
+      Permission.StatusPageMember,
+      Permission.StatusPageViewer,
+      Permission.ReadStatusPageCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditStatusPageCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,

package/Models/DatabaseModels/TableView.ts

@@ -22,6 +22,7 @@ import Query from "../../Types/BaseDatabase/Query";
 import BaseModel from "./DatabaseBaseModel/DatabaseBaseModel";
 import Sort from "../../Types/BaseDatabase/Sort";
 import AnalyticsBaseModel from "../AnalyticsModels/AnalyticsBaseModel/AnalyticsBaseModel";
+import { JSONObject } from "../../Types/JSON";
 
 @TableBillingAccessControl({
   create: PlanType.Growth,
@@ -515,4 +516,43 @@ export default class TableView extends BaseModel {
     default: 10,
   })
   public itemsOnPage?: number = undefined;
+
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateTableView,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.SettingsAdmin,
+      Permission.SettingsMember,
+      Permission.SettingsViewer,
+      Permission.ReadTableView,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditTableView,
+    ],
+  })
+  @TableColumn({
+    title: "Facets",
+    required: false,
+    unique: false,
+    type: TableColumnType.JSON,
+    canReadOnRelationQuery: true,
+    description:
+      "Facet selections (owner, labels, status, etc.) for this table view",
+    example: '{"selectedOwnerKeys": ["user:abc"], "facetSelections": {}}',
+  })
+  @Column({
+    type: ColumnType.JSON,
+    unique: false,
+    nullable: true,
+  })
+  public facets?: JSONObject = undefined;
 }

package/Models/DatabaseModels/TeamMemberCustomField.ts

@@ -248,6 +248,43 @@ export default class TeamMemberCustomField extends BaseModel {
   })
   public customFieldType?: CustomFieldType = undefined;
 
+  @ColumnAccessControl({
+    create: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.CreateTeamMemberCustomField,
+    ],
+    read: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.ProjectMember,
+      Permission.Viewer,
+      Permission.SettingsAdmin,
+      Permission.SettingsMember,
+      Permission.SettingsViewer,
+      Permission.ReadTeamMemberCustomField,
+    ],
+    update: [
+      Permission.ProjectOwner,
+      Permission.ProjectAdmin,
+      Permission.EditTeamMemberCustomField,
+    ],
+  })
+  @TableColumn({
+    required: false,
+    type: TableColumnType.LongText,
+    title: "Dropdown Options",
+    description:
+      "Options for the dropdown field, one per line. Only used when Custom Field Type is Dropdown.",
+    example: "Option 1\nOption 2\nOption 3",
+  })
+  @Column({
+    nullable: true,
+    type: ColumnType.LongText,
+    length: ColumnLength.LongText,
+  })
+  public dropdownOptions?: string = undefined;
+
   @ColumnAccessControl({
     create: [
       Permission.ProjectOwner,