@onerjs/core 9.0.2 → 9.0.4

package/Meshes/geometry.d.ts

@@ -141,11 +141,13 @@ export declare class Geometry implements IGetSetVerticesData {
     setVerticesData(kind: string, data: FloatArray, updatable?: boolean, stride?: number): void;
     /**
      * Removes a specific vertex data
+     * Invalidates cached WebGPU draws that may reference the removed buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      */
     removeVerticesData(kind: string): void;
     /**
      * Affect a vertex buffer to the geometry. the vertexBuffer.getKind() function is used to determine where to store the data
+     * Invalidates cached WebGPU draws so they use the new vertex buffer.
      * @param buffer defines the vertex buffer to use
      * @param totalVertices defines the total number of vertices for position kind (could be null)
      * @param disposeExistingBuffer disposes the existing buffer, if any (default: true)
@@ -155,6 +157,7 @@ export declare class Geometry implements IGetSetVerticesData {
      * Update a specific vertex buffer
      * This function will directly update the underlying DataBuffer according to the passed numeric array or Float32Array
      * It will do nothing if the buffer is not updatable
+     * Invalidates cached WebGPU draws if buffer alignment recreates the GPU buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      * @param data defines the data to use
      * @param offset defines the offset in the target buffer where to store the data
@@ -164,6 +167,7 @@ export declare class Geometry implements IGetSetVerticesData {
     /**
      * Update a specific vertex buffer
      * This function will create a new buffer if the current one is not updatable
+     * Invalidates cached WebGPU draws if buffer alignment recreates the GPU buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      * @param data defines the data to use
      * @param updateExtends defines if the geometry extends must be recomputed (false by default)
@@ -286,6 +290,7 @@ export declare class Geometry implements IGetSetVerticesData {
     applyToMesh(mesh: Mesh): void;
     private _updateExtend;
     private _applyToMesh;
+    private _invalidateVertexBuffers;
     private _notifyUpdate;
     /**
      * Load the geometry if it was flagged as delay loaded

package/Meshes/geometry.js

@@ -196,12 +196,14 @@ export class Geometry {
     }
     /**
      * Removes a specific vertex data
+     * Invalidates cached WebGPU draws that may reference the removed buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      */
     removeVerticesData(kind) {
         if (this._vertexBuffers[kind]) {
             this._vertexBuffers[kind].dispose();
             delete this._vertexBuffers[kind];
+            this._invalidateVertexBuffers();
         }
         if (this._vertexArrayObjects) {
             this._disposeVertexArrayObjects();
@@ -209,6 +211,7 @@ export class Geometry {
     }
     /**
      * Affect a vertex buffer to the geometry. the vertexBuffer.getKind() function is used to determine where to store the data
+     * Invalidates cached WebGPU draws so they use the new vertex buffer.
      * @param buffer defines the vertex buffer to use
      * @param totalVertices defines the total number of vertices for position kind (could be null)
      * @param disposeExistingBuffer disposes the existing buffer, if any (default: true)
@@ -239,12 +242,14 @@ export class Geometry {
                 mesh.synchronizeInstances();
             }
         }
+        this._invalidateVertexBuffers();
         this._notifyUpdate(kind);
     }
     /**
      * Update a specific vertex buffer
      * This function will directly update the underlying DataBuffer according to the passed numeric array or Float32Array
      * It will do nothing if the buffer is not updatable
+     * Invalidates cached WebGPU draws if buffer alignment recreates the GPU buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      * @param data defines the data to use
      * @param offset defines the offset in the target buffer where to store the data
@@ -255,12 +260,17 @@ export class Geometry {
         if (!vertexBuffer) {
             return;
         }
+        const alignedBuffer = vertexBuffer._alignedBuffer;
         vertexBuffer.updateDirectly(data, offset, useBytes);
+        if (vertexBuffer._alignedBuffer !== alignedBuffer) {
+            this._invalidateVertexBuffers();
+        }
         this._notifyUpdate(kind);
     }
     /**
      * Update a specific vertex buffer
      * This function will create a new buffer if the current one is not updatable
+     * Invalidates cached WebGPU draws if buffer alignment recreates the GPU buffer.
      * @param kind defines the data kind (Position, normal, etc...)
      * @param data defines the data to use
      * @param updateExtends defines if the geometry extends must be recomputed (false by default)
@@ -270,7 +280,11 @@ export class Geometry {
         if (!vertexBuffer) {
             return;
         }
+        const alignedBuffer = vertexBuffer._alignedBuffer;
         vertexBuffer.update(data);
+        if (vertexBuffer._alignedBuffer !== alignedBuffer) {
+            this._invalidateVertexBuffers();
+        }
         if (kind === VertexBuffer.PositionKind) {
             this._updateBoundingInfo(updateExtends, data);
         }
@@ -649,6 +663,17 @@ export class Geometry {
         // instances
         mesh.synchronizeInstances();
     }
+    _invalidateVertexBuffers() {
+        if (!this._engine.isWebGPU) {
+            return;
+        }
+        // Render bundles retain buffer bindings even when the vertex layout does not change.
+        for (const mesh of this._meshes) {
+            for (const subMesh of mesh.subMeshes) {
+                subMesh._invalidateVertexBuffers();
+            }
+        }
+    }
     _notifyUpdate(kind) {
         if (this.onGeometryUpdated) {
             this.onGeometryUpdated(this, kind);