@onerjs/core 8.54.1 → 8.54.3

package/Meshes/GaussianSplatting/gaussianSplattingMeshBase.pure.js

@@ -1044,7 +1044,11 @@ export class GaussianSplattingMeshBase extends Mesh {
             }
             return a.frameIdLastUpdate - b.frameIdLastUpdate;
         });
-        const hasSortFunction = this._worker || Native?.sortSplats || this._disableDepthSort;
+        // The native sort writes into _splatPositions/_splatIndex: both must be allocated (they still are
+        // null before any splat data has been committed) or the native binding throws on the conversion.
+        const hasNativeSort = !!Native?.sortSplats && !!this._splatPositions && !!this._splatIndex;
+        // When depth sort is disabled, no sort function must run: fall through to the no-sort path below.
+        const hasSortFunction = !this._disableDepthSort && (this._worker || hasNativeSort);
         if ((forced || outdated) && hasSortFunction && (this._scene.activeCameras?.length || this._scene.activeCamera) && this._canPostToWorker) {
             const worldMatrix = this.computeWorldMatrix(true);
             // view infos sorted by least recent updated frame id
@@ -1098,14 +1102,16 @@ export class GaussianSplattingMeshBase extends Mesh {
             });
         }
         else if (this._disableDepthSort) {
-            activeViewInfos.forEach((cameraViewInfos) => {
-                if (!cameraViewInfos.splatIndexBufferSet) {
-                    cameraViewInfos.mesh.thinInstanceSetBuffer("splatIndex", this._splatIndex, 16, false);
-                    cameraViewInfos.splatIndexBufferSet = true;
-                }
-            });
+            if (this._splatIndex) {
+                activeViewInfos.forEach((cameraViewInfos) => {
+                    if (!cameraViewInfos.splatIndexBufferSet) {
+                        cameraViewInfos.mesh.thinInstanceSetBuffer("splatIndex", this._splatIndex, 16, false);
+                        cameraViewInfos.splatIndexBufferSet = true;
+                    }
+                });
+                this._readyToDisplay = true;
+            }
             this._canPostToWorker = true;
-            this._readyToDisplay = true;
         }
     }
     /**
@@ -2161,6 +2167,18 @@ export class GaussianSplattingMeshBase extends Mesh {
             this._postToWorker(true);
         }
         else {
+            // Full rebuild: the texture size changed (or this is a size-changing reload), so the existing
+            // GPU textures cannot be reused. Dispose them before recreating to avoid leaking the old ones.
+            this._covariancesATexture?.dispose();
+            this._covariancesBTexture?.dispose();
+            this._centersTexture?.dispose();
+            this._colorsTexture?.dispose();
+            if (this._shTextures) {
+                for (const shTexture of this._shTextures) {
+                    shTexture.dispose();
+                }
+                this._shTextures = null;
+            }
             this._textureSize = textureSize;
             this._covariancesATexture = createTextureFromDataF16(covA, textureSize.x, textureSize.y, 5);
             this._covariancesBTexture = createTextureFromDataF16(covB, textureSize.x, textureSize.y, this._useRGBACovariants ? 5 : 7);
@@ -2550,10 +2568,12 @@ export class GaussianSplattingMeshBase extends Mesh {
         if (!this._vertexCount) {
             return;
         }
+        // The identity index buffer must exist even when no sort worker is needed: every render path
+        // (including the Native one) reads it, and a null buffer breaks the Native bindings.
+        this._updateSplatIndexBuffer(this._vertexCount);
         if (this._disableDepthSort) {
             return;
         }
-        this._updateSplatIndexBuffer(this._vertexCount);
         // no worker in native
         if (IsNative) {
             return;