@onerjs/core 8.52.3 → 8.52.5

package/Meshes/GaussianSplatting/gaussianSplattingMeshBase.pure.js

@@ -352,7 +352,7 @@ export class GaussianSplattingMeshBase extends Mesh {
         this._needsRotationScaleTextures = value;
         if (value && this._covariancesATexture) {
             if (this._splatsData) {
-                this.updateData(this._splatsData, this._shData ?? undefined, { flipY: false });
+                this.updateData(this._splatsData, this._shData ?? undefined, { flipY: false }, undefined, this._shDegree);
             }
             else {
                 Logger.Error("GaussianSplattingMeshBase: needsRotationScaleTextures was enabled after the mesh was already loaded, but the splat data is not kept in RAM. " +
@@ -659,10 +659,11 @@ export class GaussianSplattingMeshBase extends Mesh {
                     anyDirty = true;
                     continue;
                 }
-                // Also detect drift: if the world or camera state has changed since the last post,
-                // mark dirty so the next render does not silently queue a new sort that completes
-                // after isReady has reported true.
-                if (this._isSortStateDirty(cameraViewInfo, worldMatrix, camera)) {
+                // If world matrix drifted (user applied transforms after load), re-sort before first render.
+                // Camera drift is intentionally excluded here: checking camera movement would cause isReady()
+                // to return false indefinitely while the camera is moving. The render loop handles camera
+                // re-sorting continuously via _postToWorker() in render().
+                if (this._isSortStateDirty(cameraViewInfo, worldMatrix, camera, true)) {
                     anyDirty = true;
                 }
             }
@@ -735,7 +736,7 @@ export class GaussianSplattingMeshBase extends Mesh {
         localDirection.normalize();
         return localDirection;
     }
-    _isSortStateDirty(cameraViewInfo, worldMatrix, camera) {
+    _isSortStateDirty(cameraViewInfo, worldMatrix, camera, worldMatrixOnly = false) {
         const world = worldMatrix.m;
         const previousWorld = cameraViewInfo.sortWorldMatrix.m;
         for (let i = 0; i < previousWorld.length; i++) {
@@ -743,6 +744,9 @@ export class GaussianSplattingMeshBase extends Mesh {
                 return true;
             }
         }
+        if (worldMatrixOnly) {
+            return false;
+        }
         const cameraViewMatrix = camera.getViewMatrix();
         if (!Scalar.WithinEpsilon(cameraViewInfo.sortCameraForward.x, cameraViewMatrix.m[2], this.viewUpdateThreshold) ||
             !Scalar.WithinEpsilon(cameraViewInfo.sortCameraForward.y, cameraViewMatrix.m[6], this.viewUpdateThreshold) ||
@@ -1570,10 +1574,7 @@ export class GaussianSplattingMeshBase extends Mesh {
                 const width = engine.getCaps().maxTextureSize;
                 const height = Math.ceil(splatCount / width);
                 // create array for the number of textures needed.
-                for (let textureIndex = 0; textureIndex < textureCount; textureIndex++) {
-                    const texture = new Uint8Array(height * width * 4 * 4); // 4 components per texture, 4 sh per component
-                    sh.push(texture);
-                }
+                sh = AllocateShBuffers(textureCount, height * width * 4 * 4);
                 for (let i = 0; i < splatCount; i++) {
                     for (let shIndexWrite = 0; shIndexWrite < header.shCoefficientCount; shIndexWrite++) {
                         const shValue = ubuf[shIndexRead++];
@@ -2294,9 +2295,14 @@ export class GaussianSplattingMeshBase extends Mesh {
             const vertexCountPadded = (this._vertexCount + 15) & ~0xf;
             // If the vertex count changed, we discard this result and trigger a new sort
             if (e.data.depthMix.length != vertexCountPadded) {
-                this._canPostToWorker = true;
-                this._postToWorker(true);
-                this._sortIsDirty = false;
+                // Only re-enable posting and trigger a re-sort if the buffer is available.
+                // If byteLength === 0 the buffer is already in-flight for a newer sort;
+                // that sort's onmessage will handle things when it returns.
+                if (this._depthMix.buffer.byteLength > 0) {
+                    this._canPostToWorker = true;
+                    this._postToWorker(true);
+                    this._sortIsDirty = false;
+                }
                 return;
             }
             this._depthMix = e.data.depthMix;
@@ -2571,4 +2577,22 @@ GaussianSplattingMeshBase._CreateWorker = function (self) {
         }
     };
 };
+/**
+ * Allocates SH texture buffers pre-filled with 128 (the neutral encoding of ~0.0 in the
+ * shader's decompose() function). Padding bytes beyond the actual coefficients in the last
+ * texture are read as higher-order SH bands when the mesh is added to a compound with a
+ * higher degree; zero would decode to -1.0 instead, producing wrong colors.
+ * @param textureCount number of SH textures to allocate
+ * @param bytesEach byte size of each texture buffer
+ * @returns array of initialized Uint8Array buffers
+ */
+export function AllocateShBuffers(textureCount, bytesEach) {
+    const result = [];
+    for (let i = 0; i < textureCount; i++) {
+        const arr = new Uint8Array(bytesEach);
+        arr.fill(128);
+        result.push(arr);
+    }
+    return result;
+}
 //# sourceMappingURL=gaussianSplattingMeshBase.pure.js.map