@onekeyfe/hd-transport 1.1.27-patch.1 → 1.2.0-alpha.0

package/README.md

@@ -18,11 +18,9 @@ In order to be able to use new features of onekey-firmware you need to update pr
 
 1. `git submodule update --init --recursive` to initialize git submodules.
 1. `yarn update-submodules` to update firmware submodule
-1. `yarn update:protobuf` to generate new `./messages.json` and `./src/types/messages.ts`
+1. `yarn update-protobuf` to generate new `./messages.json`, `./messages-protocol-v2.json` and `./src/types/messages.ts`
 
-git submodule update --init --recursive to initialize firmware submodule
-yarn update-submodules to update firmware submodule
-yarn update:protobuf to generate new ./messages.json and ./src/types/messages.ts
+The same task can be run from the repository root with `yarn update-protobuf`. The Protocol V2 schema requires the `firmware-pro2` submodule checked out on branch `dev_romloader_split`.
 
 ## Docs
 

package/__tests__/build-receive.test.js

@@ -1,7 +1,5 @@
 const { parseConfigure } = require('../src/serialization/protobuf/messages');
-const { buildOne } = require('../src/serialization/send');
-const { receiveOne } = require('../src/serialization/receive');
-const { buildEncodeBuffers } = require('../src/serialization/send');
+const { ProtocolV1 } = require('../src/protocols');
 
 const messages = {
   StellarPaymentOp: {
@@ -96,17 +94,17 @@ const parsedMessages = parseConfigure({
 describe('encoding json -> protobuf -> json', () => {
   fixtures.forEach(f => {
     describe(f.name, () => {
-      test('buildOne - receiveOne', () => {
+      test('encodeEnvelope - decodeMessage', () => {
         // encoded message
-        const encodedMessage = buildOne(parsedMessages, f.name, f.in);
+        const encodedMessage = ProtocolV1.encodeEnvelope(parsedMessages, f.name, f.in);
         // then decode message and check, whether decoded message matches original json
-        const decodedMessage = receiveOne(parsedMessages, encodedMessage);
+        const decodedMessage = ProtocolV1.decodeMessage(parsedMessages, encodedMessage);
         expect(decodedMessage.type).toEqual(f.name);
         expect(decodedMessage.message).toEqual(f.in);
       });
 
-      test('buildBuffers - receiveAndParse', () => {
-        const result = buildEncodeBuffers(parsedMessages, f.name, f.in);
+      test('encodeMessageChunks - receiveAndParse', () => {
+        const result = ProtocolV1.encodeMessageChunks(parsedMessages, f.name, f.in);
         result.forEach(r => {
           expect(r.byteLength).toBeLessThanOrEqual(63);
         });

package/__tests__/decode-features.test.js

@@ -1,8 +1,9 @@
+/* eslint-disable import/order */
 const ProtoBuf = require('protobufjs/light');
 const ByteBuffer = require('bytebuffer');
 
 const { decode } = require('../src/serialization/protobuf/decode');
-const { decode: decodeProtocol } = require('../src/serialization/protocol/decode');
+const { decodeEnvelope } = require('../src/protocols/v1/decode');
 
 // Reuse the messages.json already committed alongside @onekeyfe/hd-core
 // (runtime data for DataManager). hd-transport's own messages.json is
@@ -61,7 +62,7 @@ describe('Fix messages decode', () => {
       test('decode', () => {
         // deserialize
         const encoded = ByteBuffer.fromHex(f.encodeMessage);
-        const { buffer } = decodeProtocol(encoded);
+        const { buffer } = decodeEnvelope(encoded);
         const decoded = decode(Message, buffer);
 
         // filter null values

package/__tests__/messages.test.js

@@ -83,4 +83,12 @@ describe('messages', () => {
 
     expect(() => createMessageFromName(messages, name)).not.toThrow();
   });
+
+  test('createMessageFromName throws when message type id is missing', () => {
+    const messages = parseConfigure(json);
+
+    expect(() => createMessageFromName(messages, 'TxAckInputWrapper')).toThrow(
+      'MessageType for "TxAckInputWrapper" is not defined in protobuf schema'
+    );
+  });
 });