@onekeyfe/hd-core 1.2.8-alpha.10 → 1.2.8-alpha.100

package/__tests__/DeviceCommands.test.ts

@@ -130,19 +130,6 @@ describe('DeviceCommands failure mapping', () => {
     );
   });
 
-  it('preserves the Protocol V2 peer-removed pairing error code', async () => {
-    const commands = createCommands();
-    const transportError = Object.assign(new Error('Peer removed pairing information'), {
-      errorCode: HardwareErrorCode.BlePeerRemovedPairingInformation,
-    });
-    commands.mainId = 'main-id';
-    commands.transport = {
-      call: jest.fn().mockRejectedValue(transportError),
-    } as any;
-
-    await expect(commands._commonCall('DeviceInfoGet', {})).rejects.toBe(transportError);
-  });
-
   it('logs canonical DeviceStatus response fields without exposing the device ID', async () => {
     const commands = createCommands();
     const log = getLogger(LoggerNames.DeviceCommands);
@@ -414,6 +401,27 @@ describe('DeviceCommands failure mapping', () => {
     ).rejects.toMatchObject({ errorCode: HardwareErrorCode.DeviceBusy });
   });
 
+  it('maps commands rejected during a Protocol V2 firmware update to DeviceBusy', async () => {
+    const commands = createCommands();
+    const message = 'Requested command not allowed while a firmware update is in progress';
+
+    await expect(
+      commands._filterCommonTypes(
+        {
+          type: 'Failure',
+          message: { code: 'Failure_ProcessError', message },
+        } as any,
+        'ProtocolInfoRequest'
+      )
+    ).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.DeviceBusy,
+      params: {
+        failureCode: 'Failure_ProcessError',
+        firmwareMessage: message,
+      },
+    });
+  });
+
   it('maps the current AskPin passphrase-disabled response without relying on a subcode', async () => {
     const commands = createCommands();
 
@@ -551,6 +559,51 @@ describe('DeviceCommands failure mapping', () => {
     }
   );
 
+  it('maps the Protocol V2 seed-session busy response to DeviceBusy', async () => {
+    const commands = createCommands();
+
+    await expect(
+      commands._filterCommonTypes(
+        {
+          type: 'Failure',
+          message: {
+            code: 'Failure_ProcessError',
+            subcode: DeviceSessionErrorCode.DeviceSessionError_UserCancelled,
+            message: 'PIN cancelled',
+          },
+        } as any,
+        'SignTx'
+      )
+    ).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.DeviceBusy,
+      params: {
+        failureCode: 'Failure_ProcessError',
+        subcode: DeviceSessionErrorCode.DeviceSessionError_UserCancelled,
+        firmwareMessage: 'PIN cancelled',
+      },
+    });
+  });
+
+  it('keeps the same Protocol V2 response as ActionCancelled for DeviceSession calls', async () => {
+    const commands = createCommands();
+
+    await expect(
+      commands._filterCommonTypes(
+        {
+          type: 'Failure',
+          message: {
+            code: 'Failure_ProcessError',
+            subcode: DeviceSessionErrorCode.DeviceSessionError_UserCancelled,
+            message: 'PIN cancelled',
+          },
+        } as any,
+        'DeviceSessionAskPin'
+      )
+    ).rejects.toMatchObject({
+      errorCode: HardwareErrorCode.ActionCancelled,
+    });
+  });
+
   it('does not use the legacy cancellation-message fallback for Protocol V1', async () => {
     const commands = createCommands();
     (commands.device.isProtocolV2 as jest.Mock).mockReturnValue(false);

package/__tests__/core-error-output.test.ts

@@ -3,7 +3,7 @@ import { ERRORS, HardwareErrorCode } from '@onekeyfe/hd-shared';
 import { initConnector, initCore } from '../src/core';
 import { DataManager } from '../src/data-manager';
 import TransportManager from '../src/data-manager/TransportManager';
-import { IFRAME } from '../src/events';
+import { IFRAME, createErrorMessage } from '../src/events';
 import SearchDevices from '../src/api/SearchDevices';
 import { DeviceList } from '../src/device/DeviceList';
 import { Device } from '../src/device/Device';
@@ -28,6 +28,23 @@ describe('Core 错误输出边界', () => {
     jest.restoreAllMocks();
   });
 
+  test('entry-point errors preserve USB recovery context across JSON serialization', () => {
+    const params = {
+      operation: 'open',
+      nativeErrorName: 'SecurityError',
+      nativeErrorMessage: 'Access denied',
+    };
+    const error = ERRORS.TypedError(
+      HardwareErrorCode.BridgeNeedsPermission,
+      'Access denied',
+      params
+    );
+    expect(JSON.parse(JSON.stringify(createErrorMessage(error)))).toEqual({
+      success: false,
+      payload: { code: HardwareErrorCode.BridgeNeedsPermission, error: 'Access denied', params },
+    });
+  });
+
   test.each([
     ['webusb', false],
     ['desktop-webusb', false],
@@ -108,14 +125,28 @@ describe('Core 错误输出边界', () => {
     HardwareErrorCode.BleDeviceBondedCanceled,
     HardwareErrorCode.BleDeviceDisconnected,
     HardwareErrorCode.PollingTimeout,
+    HardwareErrorCode.BlePoweredOff,
+    HardwareErrorCode.BleUnsupported,
+    HardwareErrorCode.BridgeNeedsPermission,
+    HardwareErrorCode.WebUsbDeviceAccessError,
   ])(
-    'preserves terminal BLE error %s in the public response without polling again',
+    'preserves terminal transport error %s in the public response without polling again',
     async errorCode => {
-      jest.spyOn(DataManager, 'getSettings').mockReturnValue('react-native' as never);
+      jest
+        .spyOn(DataManager, 'getSettings')
+        .mockReturnValue(
+          [
+            HardwareErrorCode.BridgeNeedsPermission,
+            HardwareErrorCode.WebUsbDeviceAccessError,
+          ].includes(errorCode)
+            ? ('desktop-webusb' as never)
+            : ('react-native' as never)
+        );
       const error = ERRORS.TypedError(errorCode);
       const acquire = jest.fn().mockRejectedValue(error);
       jest.spyOn(TransportManager, 'getTransport').mockReturnValue({
         acquire,
+        enumerate: jest.fn().mockResolvedValue([{ path: 'ble-pairing-test' }]),
         release: jest.fn().mockResolvedValue(true),
         stop: jest.fn().mockResolvedValue(undefined),
       } as never);

package/__tests__/device-lifecycle-events.test.ts

@@ -10,7 +10,6 @@ import {
   isMissingDetectedProtocolV2Error,
   isRetryableBleConnectionError,
   isRetryableBleProtocolV2ProbeError,
-  isTerminalBleStaleBondError,
   resolveBleConnectProtocol,
 } from '../src/core';
 import { DataManager } from '../src/data-manager';
@@ -613,7 +612,6 @@ describe('public device lifecycle events', () => {
   test.each([
     [HardwareErrorCode.RuntimeError, true],
     [HardwareErrorCode.BleDeviceBondError, false],
-    [HardwareErrorCode.BlePeerRemovedPairingInformation, false],
   ] as const)(
     'retries a Protocol V2 probe mismatch with error code %s: %s',
     (errorCode, expected) => {
@@ -633,8 +631,6 @@ describe('public device lifecycle events', () => {
     [HardwareErrorCode.BleTimeoutError, true],
     [HardwareErrorCode.PollingTimeout, false],
     [HardwareErrorCode.BleDeviceBondError, false],
-    [HardwareErrorCode.BlePeerRemovedPairingInformation, false],
-    [HardwareErrorCode.BleBondInvalid, false],
   ] as const)('retries a BLE connection error with error code %s: %s', (errorCode, expected) => {
     const method = { payload: { connectProtocol: 'V2' } } as never;
     const error = {
@@ -687,19 +683,6 @@ describe('public device lifecycle events', () => {
     }
   );
 
-  test.each([
-    [HardwareErrorCode.BleDeviceBondError, true],
-    [HardwareErrorCode.BlePeerRemovedPairingInformation, true],
-    [HardwareErrorCode.BleBondInvalid, true],
-    [HardwareErrorCode.DeviceNotFound, false],
-  ] as const)('treats BLE stale-bond error code %s as terminal: %s', (errorCode, expected) => {
-    const error = {
-      errorCode,
-    };
-
-    expect(isTerminalBleStaleBondError(error)).toBe(expected);
-  });
-
   test.each([
     [HardwareErrorCode.DeviceCheckDeviceIdError, true],
     [HardwareErrorCode.DeviceNotFound, false],
@@ -1058,6 +1041,28 @@ describe('public device lifecycle events', () => {
     expect(device.wasInterruptedByUser()).toBe(false);
   });
 
+  test.each(['V1', 'V2'] as const)(
+    'retires a failed USB %s session before the next user attempt',
+    async protocol => {
+      jest.spyOn(DataManager, 'getSettings').mockReturnValue('desktop-webusb' as never);
+      const device = createInitializedDevice(protocol);
+      device.originalDescriptor = { ...device.originalDescriptor, session: device.mainId };
+      const disconnect = jest.fn().mockResolvedValue(undefined);
+      const release = jest.fn().mockResolvedValue(undefined);
+      device.deviceConnector = { disconnect, release } as never;
+      device.commands = { disposed: false, dispose: jest.fn() } as never;
+      (device as unknown as { deviceAcquired: boolean }).deviceAcquired = true;
+      const error = ERRORS.TypedError(HardwareErrorCode.WebUsbDeviceAccessError);
+      await expect(device.run(() => Promise.reject(error))).rejects.toBe(error);
+      await new Promise(resolve => {
+        setImmediate(resolve);
+      });
+      expect(disconnect).toHaveBeenCalledWith(device.mainId);
+      expect(release).toHaveBeenCalledTimes(1);
+      expect(device.hasDeviceAcquire()).toBe(false);
+    }
+  );
+
   test('waits for the canceled run to finish releasing before cancellation completes', async () => {
     jest.spyOn(DataManager, 'getSettings').mockReturnValue('react-native' as never);
     const device = createInitializedDevice('V2');

package/__tests__/logBlockEvent.test.ts

@@ -5,6 +5,7 @@ import {
   getLogBlockLabel,
   getSafeLogPayload,
 } from '../src/events';
+import { getLog, initLog, setLoggerPostMessage } from '../src/utils/logger';
 
 describe('getLogBlockLabel', () => {
   it('keeps existing sensitive UI response blocking', () => {
@@ -96,4 +97,46 @@ describe('getLogBlockLabel', () => {
   it('does not classify events without an API method as method calls', () => {
     expect(getLogBlockLabel({ event: 'DEVICE_EVENT', type: 'device-connect' })).toBeUndefined();
   });
+
+  it.each(['zcashGetAddress', 'zcashGetUnifiedAddress', 'zcashSignPczt'])(
+    'keeps %s wallet data out of logger caches and events with debug disabled',
+    method => {
+      const postMessage = jest.fn();
+      const prefix = `sensitive-zcash-${method}`;
+      const logger = initLog(prefix, false);
+      setLoggerPostMessage(postMessage);
+      const request = {
+        event: 'iframe-call',
+        payload: { method, pczt: 'synthetic-pczt-marker', includeUfvk: true },
+      };
+      const response = {
+        success: true,
+        payload: [
+          {
+            ufvk: 'synthetic-viewing-key-marker',
+            seedFingerprint: 'synthetic-fingerprint-marker',
+            pczt: 'synthetic-signed-pczt-marker',
+          },
+        ],
+      };
+      const blockLabel = getLogBlockLabel(request);
+
+      expect(blockLabel).toBe(method);
+      expect(getLogBlockLabel(request.payload)).toBe(method);
+      logger.debug('request:', getSafeLogPayload(request, blockLabel));
+      logger.debug('response:', getSafeLogPayload(response, blockLabel));
+
+      const cached = getLog().filter(entry => entry.prefix === prefix);
+      expect(cached.map(entry => entry.message[1])).toEqual([
+        { method, payload: '[REDACTED]' },
+        { method, payload: '[REDACTED]' },
+      ]);
+      expect(postMessage).toHaveBeenCalledTimes(2);
+      for (const output of [JSON.stringify(cached), JSON.stringify(postMessage.mock.calls)]) {
+        expect(output).not.toContain('synthetic-');
+        expect(output).toContain('[REDACTED]');
+      }
+      expect(response.payload[0].ufvk).toBe('synthetic-viewing-key-marker');
+    }
+  );
 });

package/__tests__/protocol-v2-bootloader-mode.test.ts

@@ -1,3 +1,6 @@
+import { EDeviceType } from '@onekeyfe/hd-shared';
+
+import DeviceReboot from '../src/api/protocol-v2/DeviceReboot';
 import { Device } from '../src/device/Device';
 import { UI_REQUEST } from '../src/events/ui-request';
 
@@ -23,12 +26,50 @@ const createBootloaderDevice = (protocolType: 'V1' | 'V2') => {
 };
 
 describe('Pro2 bootloader mode', () => {
-  test('does not block Protocol V2 methods in bootloader mode', () => {
+  test('allows deviceReboot to return a Protocol V2 bootloader to normal mode', () => {
+    const device = createBootloaderDevice('V2');
+    const method = new DeviceReboot({
+      id: 1,
+      payload: { method: 'deviceReboot', rebootType: 'normal' },
+    });
+    method.init();
+
+    expect(device.hasUnexpectedMode(method.allowDeviceMode, method.requireDeviceMode)).toBeNull();
+  });
+
+  test('blocks Protocol V2 methods that are not allowed in bootloader mode', () => {
+    const device = createBootloaderDevice('V2');
+
+    expect(device.hasUnexpectedMode([], [])).toBe(UI_REQUEST.BOOTLOADER);
+  });
+
+  test('allows Protocol V2 methods that explicitly support bootloader mode', () => {
     const device = createBootloaderDevice('V2');
 
-    expect(device.hasUnexpectedMode([], [])).toBeNull();
+    expect(device.hasUnexpectedMode([UI_REQUEST.BOOTLOADER], [])).toBeNull();
   });
 
+  test.each([EDeviceType.Pro2, EDeviceType.Neo])(
+    'blocks unsupported Protocol V2 methods in %s romloader mode',
+    deviceType => {
+      const device = createBootloaderDevice('V2');
+      device.updateState(
+        {
+          protocol: 'V2',
+          identity: { deviceType },
+          status: { mode: 'romloader', initialized: null },
+        },
+        'initialize'
+      );
+
+      expect(device.hasUnexpectedMode([], [])).toBe(UI_REQUEST.BOOTLOADER);
+      expect(device.hasUnexpectedMode([UI_REQUEST.NOT_INITIALIZE], [])).toBe(UI_REQUEST.BOOTLOADER);
+      expect(
+        device.hasUnexpectedMode([UI_REQUEST.BOOTLOADER, UI_REQUEST.NOT_INITIALIZE], [])
+      ).toBeNull();
+    }
+  );
+
   test('keeps the Protocol V1 bootloader restriction', () => {
     const device = createBootloaderDevice('V1');
 

package/__tests__/protocol-v2.test.ts

@@ -4991,23 +4991,6 @@ describe('Protocol V2 firmware update targets', () => {
     expect(typedCall.mock.calls.map(call => call[0])).toEqual(['DeviceInfoGet']);
   });
 
-  test('stops V4 bootloader reconnect polling on a stale BLE bond', async () => {
-    const method = new FirmwareUpdateV4({
-      id: 1,
-      payload: {
-        method: 'firmwareUpdateV4',
-      },
-    });
-    const staleBondError = ERRORS.TypedError(HardwareErrorCode.BlePeerRemovedPairingInformation);
-    const reconnectProtocolV2Device = jest.fn().mockRejectedValue(staleBondError);
-    (method as any).reconnectProtocolV2Device = reconnectProtocolV2Device;
-
-    await expect((method as any).waitForProtocolV2BootloaderMode(60_000, 0)).rejects.toBe(
-      staleBondError
-    );
-    expect(reconnectProtocolV2Device).toHaveBeenCalledTimes(1);
-  });
-
   test('polls again when Protocol V2 bootloader serial is temporarily unavailable', async () => {
     const method = new FirmwareUpdateV4({
       id: 1,
@@ -9009,36 +8992,6 @@ describe('Protocol V2 firmware update targets', () => {
     );
   });
 
-  test('does not retry or wrap a stale BLE bond during a V4 file transfer', async () => {
-    const method = new FirmwareUpdateV4({
-      id: 1,
-      payload: {
-        method: 'firmwareUpdateV4',
-      },
-    });
-    const staleBondError = ERRORS.TypedError(HardwareErrorCode.BlePeerRemovedPairingInformation);
-    (method as any).fileWriteChunk = jest.fn().mockRejectedValue(staleBondError);
-    const recoverProtocolV2FileTransfer = jest.fn();
-    (method as any).recoverProtocolV2FileTransfer = recoverProtocolV2FileTransfer;
-    const source = await openFirmwareByteSource({
-      binary: new Uint8Array([1]).buffer,
-    });
-
-    try {
-      await expect(
-        (method as any).protocolV2SourceUpdateProcess({
-          source,
-          filePath: 'vol1:firmware.bin',
-          processedSize: 0,
-          totalSize: 1,
-        })
-      ).rejects.toBe(staleBondError);
-    } finally {
-      await source?.close();
-    }
-    expect(recoverProtocolV2FileTransfer).not.toHaveBeenCalled();
-  });
-
   test('does not recover or wrap a cancelled V4 file transfer', async () => {
     const method = new FirmwareUpdateV4({
       id: 1,

package/__tests__/refresh-device-state.test.ts

@@ -73,24 +73,26 @@ describe('live device state reads', () => {
     }
   );
 
-  test('rejects settings scope in loader mode after minimal mode detection', async () => {
-    const getDeviceState = jest.fn().mockResolvedValue({ status: { mode: 'bootloader' } });
-    const method = new GetDeviceState({
-      id: 1,
-      payload: { method: 'getDeviceState', scope: 'settings' },
-    });
-    method.init();
-    (method as any).device = {
-      isProtocolV2: () => true,
-      getCurrentFirmwareType: () => 'universal',
-      getDeviceState,
-    };
+  test.each(['bootloader', 'romloader'] as const)(
+    'reports %s mode for settings scope after minimal mode detection',
+    async mode => {
+      const getDeviceState = jest.fn().mockResolvedValue({ status: { mode } });
+      const method = new GetDeviceState({
+        id: 1,
+        payload: { method: 'getDeviceState', scope: 'settings' },
+      });
+      method.init();
+      (method as any).device = {
+        isProtocolV2: () => true,
+        getDeviceState,
+      };
 
-    await expect(method.run()).rejects.toMatchObject({
-      errorCode: HardwareErrorCode.DeviceNotSupportMethod,
-    });
-    expect(getDeviceState).toHaveBeenCalledWith({ refreshSections: ['status', 'settings'] });
-  });
+      await expect(method.run()).rejects.toMatchObject({
+        errorCode: HardwareErrorCode.NotAllowInBootloaderMode,
+      });
+      expect(getDeviceState).toHaveBeenCalledWith({ refreshSections: ['status', 'settings'] });
+    }
+  );
 
   test('rejects an unknown scope', () => {
     const method = new GetDeviceState({

package/__tests__/zcash-sign-pczt.test.ts

@@ -0,0 +1,212 @@
+import ZcashSignPczt, { ZCASH_PCZT_MAX_BYTES } from '../src/api/zcash/ZcashSignPczt';
+import ZcashGetAddress from '../src/api/zcash/ZcashGetAddress';
+
+import type { Device } from '../src/device/Device';
+
+jest.mock('../src/data/config', () => ({
+  getSDKVersion: jest.fn(() => '1.0.0'),
+  DEFAULT_DOMAIN: 'https://jssdk.onekey.so/1.0.0/',
+}));
+
+const hex = (byte: number, length: number) => byte.toString(16).padStart(2, '0').repeat(length);
+
+const createSignMethod = (pczt: string) =>
+  new ZcashSignPczt({ id: 1, payload: { method: 'zcashSignPczt', pczt } });
+
+const attachDevice = (method: ZcashSignPczt | ZcashGetAddress, typedCall: jest.Mock) => {
+  const commands = { typedCall };
+  method.device = {
+    commands,
+    getCommands: () => commands,
+    toMessageObject: () => ({}),
+  } as unknown as Device;
+  method.postMessage = jest.fn();
+};
+
+describe('ZcashSignPczt', () => {
+  test('uploads device-sized chunks and downloads host-sized chunks', async () => {
+    // 2500 bytes: initial 1024, then device asks 1000 + 476.
+    const pczt = hex(0xab, 2500);
+    const signed = Buffer.alloc(1500, 0xcd);
+    const method = createSignMethod(pczt);
+    method.init();
+
+    const typedCall = jest
+      .fn()
+      .mockResolvedValueOnce({ type: 'ZcashPcztChunkRequest', message: { chunk_length: 1000 } })
+      .mockResolvedValueOnce({ type: 'ZcashPcztChunkRequest', message: { chunk_length: 476 } })
+      .mockResolvedValueOnce({
+        type: 'ZcashSignedPczt',
+        message: {
+          pczt_length: signed.length,
+          pczt_initial_chunk: signed.subarray(0, 1024).toString('hex'),
+        },
+      })
+      .mockResolvedValueOnce({
+        type: 'ZcashPcztChunkAck',
+        message: { data_chunk: signed.subarray(1024).toString('hex') },
+      });
+    attachDevice(method, typedCall);
+
+    await expect(method.run()).resolves.toEqual({ pczt: signed.toString('hex') });
+
+    expect(typedCall.mock.calls[0]).toEqual([
+      'ZcashSignPczt',
+      ['ZcashSignedPczt', 'ZcashPcztChunkRequest'],
+      { pczt_length: 2500, pczt_initial_chunk: hex(0xab, 1024) },
+    ]);
+    expect(typedCall.mock.calls[1]).toEqual([
+      'ZcashPcztChunkAck',
+      ['ZcashSignedPczt', 'ZcashPcztChunkRequest'],
+      { data_chunk: hex(0xab, 1000) },
+    ]);
+    expect(typedCall.mock.calls[2][2]).toEqual({ data_chunk: hex(0xab, 476) });
+    expect(typedCall.mock.calls[3]).toEqual([
+      'ZcashSignedPcztChunkRequest',
+      'ZcashPcztChunkAck',
+      { chunk_length: 476 },
+    ]);
+    expect(typedCall).toHaveBeenCalledTimes(4);
+  });
+
+  test('single-message round trip when both sides fit in the initial chunk', async () => {
+    const method = createSignMethod(hex(0x01, 100));
+    method.init();
+    const typedCall = jest.fn().mockResolvedValueOnce({
+      type: 'ZcashSignedPczt',
+      message: { pczt_length: 80, pczt_initial_chunk: hex(0x02, 80) },
+    });
+    attachDevice(method, typedCall);
+
+    await expect(method.run()).resolves.toEqual({ pczt: hex(0x02, 80) });
+    expect(typedCall).toHaveBeenCalledTimes(1);
+  });
+
+  test('rejects a device chunk request past the end of the pczt', async () => {
+    const method = createSignMethod(hex(0x01, 1100));
+    method.init();
+    const typedCall = jest
+      .fn()
+      .mockResolvedValueOnce({ type: 'ZcashPcztChunkRequest', message: { chunk_length: 200 } });
+    attachDevice(method, typedCall);
+
+    await expect(method.run()).rejects.toThrow('device requested 200 bytes at offset 1024');
+  });
+
+  test('rejects completion before the entire input has been uploaded', async () => {
+    const method = createSignMethod(hex(0x01, 1100));
+    method.init();
+    const typedCall = jest.fn().mockResolvedValueOnce({
+      type: 'ZcashSignedPczt',
+      message: { pczt_length: 80, pczt_initial_chunk: hex(0x02, 80) },
+    });
+    attachDevice(method, typedCall);
+    await expect(method.run()).rejects.toThrow('before receiving the whole pczt');
+    expect(typedCall).toHaveBeenCalledTimes(1);
+  });
+
+  test('rejects an initial signed chunk larger than its announced total', async () => {
+    const method = createSignMethod(hex(0x01, 100));
+    method.init();
+    const typedCall = jest.fn().mockResolvedValueOnce({
+      type: 'ZcashSignedPczt',
+      message: { pczt_length: 80, pczt_initial_chunk: hex(0x02, 81) },
+    });
+    attachDevice(method, typedCall);
+    await expect(method.run()).rejects.toThrow('more initial pczt bytes than announced');
+    expect(typedCall).toHaveBeenCalledTimes(1);
+  });
+
+  test('rejects oversized and empty input', () => {
+    expect(() => createSignMethod('').init()).toThrow();
+    expect(() => createSignMethod(hex(0x00, ZCASH_PCZT_MAX_BYTES + 1)).init()).toThrow('exceeds');
+    expect(() => createSignMethod(hex(0x00, ZCASH_PCZT_MAX_BYTES)).init()).not.toThrow();
+  });
+});
+
+describe('ZcashGetAddress', () => {
+  test('maps params and response', async () => {
+    const method = new ZcashGetAddress({
+      id: 1,
+      payload: {
+        method: 'zcashGetAddress',
+        path: "m/32'/133'/0'",
+        showOnOneKey: false,
+        includeUfvk: true,
+        includeSeedFingerprint: true,
+      },
+    });
+    method.init();
+    const typedCall = jest.fn().mockResolvedValue({
+      message: { address: 'u1abc', ufvk: 'uview1abc', seed_fingerprint: hex(0x0f, 32) },
+    });
+    attachDevice(method, typedCall);
+
+    await expect(method.run()).resolves.toEqual({
+      path: "m/32'/133'/0'",
+      address: 'u1abc',
+      ufvk: 'uview1abc',
+      seedFingerprint: hex(0x0f, 32),
+    });
+    expect(typedCall).toHaveBeenCalledWith('ZcashGetAddress', 'ZcashAddress', {
+      address_n: [2147483680, 2147483781, 2147483648],
+      address_type: 0,
+      scope: 0,
+      diversifier_index: 0,
+      show_display: false,
+      include_ufvk: true,
+      include_seed_fingerprint: true,
+    });
+  });
+});
+
+describe('Zcash address protocol selection', () => {
+  const createAddress = (params: Record<string, unknown> = {}) =>
+    new ZcashGetAddress({
+      id: 1,
+      payload: { method: 'zcashGetAddress', path: "m/32'/133'/0'", ...params },
+    });
+  test('supports only Pro2 and protocol V2', () => {
+    for (const method of [createAddress(), createSignMethod(hex(1, 1))]) {
+      method.init();
+      expect(method.supportsProtocol('V1')).toBe(false);
+      expect(method.supportsProtocol('V2')).toBe(true);
+      expect(method.strictCheckDeviceSupport).toBe(true);
+      expect(Object.keys(method.getVersionRange())).toEqual(['model_pro2']);
+    }
+  });
+  test.each([0, 1, 2])('maps address type %s with internal scope and index', async addressType => {
+    const method = createAddress({ addressType, scope: 1, diversifierIndex: 37 });
+    method.init();
+    const typedCall = jest.fn().mockResolvedValue({ message: { address: 'device-address' } });
+    attachDevice(method, typedCall);
+    await method.run();
+    expect(typedCall).toHaveBeenCalledWith(
+      'ZcashGetAddress',
+      'ZcashAddress',
+      expect.objectContaining({
+        address_type: addressType,
+        scope: 1,
+        diversifier_index: 37,
+        show_display: true,
+      })
+    );
+  });
+  test.each([
+    { addressType: 3 },
+    { scope: 2 },
+    { diversifierIndex: -1 },
+    { diversifierIndex: 1.5 },
+    { diversifierIndex: 0x80000000 },
+    { addressType: 2, diversifierIndex: 0x100000000 },
+    { path: "m/44'/133'/0'" },
+    { path: "m/32'/133'/0'/0/0" },
+  ])('rejects invalid address requests %j', params => {
+    expect(() => createAddress(params).init()).toThrow();
+  });
+  test('accepts the uint32 limit only for an Orchard-only address', () => {
+    expect(() =>
+      createAddress({ addressType: 2, diversifierIndex: 0xffffffff }).init()
+    ).not.toThrow();
+  });
+});