@onekeyfe/hd-core 1.1.28 → 1.2.0-alpha.1

package/src/api/FileRead.ts

@@ -0,0 +1,167 @@
+import {
+  PROTOCOL_V2_BLE_FILE_CHUNK_SIZE,
+  PROTOCOL_V2_WEBUSB_FILE_CHUNK_SIZE,
+} from '@onekeyfe/hd-transport';
+import { ERRORS, HardwareErrorCode } from '@onekeyfe/hd-shared';
+
+import { BaseMethod } from './BaseMethod';
+import {
+  validateNonEmptyString,
+  validateNonNegativeInteger,
+  validateOptionalNonNegativeInteger,
+  validateOptionalPercentage,
+} from './helpers/filesystemValidation';
+import { hexToBytes, isHexString, stripHexPrefix } from './helpers/hexUtils';
+import { DataManager } from '../data-manager';
+
+export type FileReadParams = {
+  path: string;
+  offset?: number;
+  totalSize?: number;
+  chunkLen?: number;
+  uiPercentage?: number;
+};
+
+const MIN_FILE_READ_CHUNK_SIZE = 64;
+
+function getProtocolV2FileReadChunkLimit() {
+  const env = DataManager.getSettings('env');
+  if (env && DataManager.isBleConnect(env)) {
+    return PROTOCOL_V2_BLE_FILE_CHUNK_SIZE;
+  }
+  return PROTOCOL_V2_WEBUSB_FILE_CHUNK_SIZE;
+}
+
+function normalizeChunkSize(value: unknown, maxChunkSize: number): number {
+  const numeric = Number(value);
+  if (!Number.isFinite(numeric) || numeric <= 0) return maxChunkSize;
+  return Math.min(Math.max(Math.floor(numeric), MIN_FILE_READ_CHUNK_SIZE), maxChunkSize);
+}
+
+function toFiniteNumber(value: unknown): number | undefined {
+  if (typeof value === 'number' && Number.isFinite(value)) return value;
+  if (typeof value === 'string') {
+    const numeric = Number(value);
+    return Number.isFinite(numeric) ? numeric : undefined;
+  }
+  if (value && typeof value === 'object') {
+    const longLike = value as { toNumber?: () => number };
+    if (typeof longLike.toNumber === 'function') {
+      const numeric = longLike.toNumber();
+      return Number.isFinite(numeric) ? numeric : undefined;
+    }
+  }
+  return undefined;
+}
+
+function toUint8Array(value: unknown): Uint8Array {
+  if (value instanceof Uint8Array) return value;
+  if (value instanceof ArrayBuffer) return new Uint8Array(value);
+  if (ArrayBuffer.isView(value)) {
+    return new Uint8Array(value.buffer, value.byteOffset, value.byteLength);
+  }
+  if (typeof value === 'string') {
+    const hex = stripHexPrefix(value);
+    if (!hex) return new Uint8Array(0);
+    if (!isHexString(hex) || hex.length % 2 !== 0) return new Uint8Array(0);
+    return hexToBytes(hex);
+  }
+  return new Uint8Array(0);
+}
+
+export default class FileRead extends BaseMethod<FileReadParams> {
+  init() {
+    // Protocol V2 (Pro2) 专属方法，core 调度层统一做非 V2 设备守卫
+    this.requireProtocolV2 = true;
+    this.skipForceUpdateCheck = true;
+    this.useDevicePassphraseState = false;
+    const path = validateNonEmptyString(this.payload.path, 'path');
+    this.params = {
+      path,
+      offset: validateNonNegativeInteger(this.payload.offset, 'offset', 0),
+      totalSize: validateNonNegativeInteger(this.payload.totalSize, 'totalSize', 0),
+      chunkLen: validateOptionalNonNegativeInteger(this.payload.chunkLen, 'chunkLen'),
+      uiPercentage: validateOptionalPercentage(this.payload.uiPercentage, 'uiPercentage'),
+    };
+  }
+
+  async run() {
+    const startOffset = this.params.offset ?? 0;
+    const requestedLength = Number(this.params.totalSize);
+    const chunkSize = normalizeChunkSize(this.params.chunkLen, getProtocolV2FileReadChunkLimit());
+    let totalLength = Number.isFinite(requestedLength) && requestedLength > 0 ? requestedLength : 0;
+
+    if (totalLength === 0) {
+      const pathInfoRes = await this.device.commands.typedCall(
+        'FilesystemPathInfoQuery',
+        'FilesystemPathInfo',
+        {
+          path: this.params.path,
+        }
+      );
+      const fileSize = toFiniteNumber(pathInfoRes.message?.size);
+      if (!pathInfoRes.message?.exist || pathInfoRes.message?.directory) {
+        throw ERRORS.TypedError(
+          HardwareErrorCode.RuntimeError,
+          `FilesystemFileRead path is not a file: ${this.params.path}`
+        );
+      }
+      if (fileSize === undefined || fileSize < startOffset) {
+        throw ERRORS.TypedError(
+          HardwareErrorCode.RuntimeError,
+          `FilesystemFileRead invalid offset ${startOffset} for ${this.params.path}`
+        );
+      }
+      totalLength = fileSize - startOffset;
+    }
+
+    const chunks: Uint8Array[] = [];
+    let read = 0;
+    let lastMessage: Record<string, unknown> | undefined;
+
+    while (read < totalLength) {
+      const readLen = Math.min(chunkSize, totalLength - read);
+      const offset = startOffset + read;
+      const progress =
+        this.params.uiPercentage ??
+        Math.min(Math.ceil(((read + readLen) / Math.max(totalLength, 1)) * 100), 99);
+      const res = await this.device.commands.typedCall('FilesystemFileRead', 'FilesystemFile', {
+        file: {
+          path: this.params.path,
+          offset,
+          total_size: 0,
+        },
+        chunk_len: readLen,
+        ui_percentage: progress,
+      });
+      const data = toUint8Array(res.message?.data);
+      lastMessage = res.message;
+
+      if (data.byteLength === 0) {
+        throw ERRORS.TypedError(
+          HardwareErrorCode.RuntimeError,
+          `FilesystemFileRead received empty data at offset ${offset}`
+        );
+      }
+
+      chunks.push(data);
+      read += data.byteLength;
+    }
+
+    const combined = new Uint8Array(read);
+    let cursor = 0;
+    chunks.forEach(chunk => {
+      combined.set(chunk, cursor);
+      cursor += chunk.byteLength;
+    });
+
+    return Promise.resolve({
+      ...lastMessage,
+      path: this.params.path,
+      offset: startOffset,
+      total_size: totalLength,
+      data: combined,
+      chunks: chunks.length,
+    });
+  }
+}

package/src/api/FileWrite.ts

@@ -0,0 +1,216 @@
+import {
+  PROTOCOL_V2_BLE_FILE_CHUNK_SIZE,
+  PROTOCOL_V2_WEBUSB_FILE_CHUNK_SIZE,
+} from '@onekeyfe/hd-transport';
+import { ERRORS, HardwareErrorCode } from '@onekeyfe/hd-shared';
+
+import { BaseMethod } from './BaseMethod';
+import {
+  validateNonEmptyString,
+  validateNonNegativeInteger,
+  validateOptionalNonNegativeInteger,
+  validateOptionalPercentage,
+  validateRequiredData,
+} from './helpers/filesystemValidation';
+import { UI_REQUEST, createUiMessage } from '../events/ui-request';
+import { DataManager } from '../data-manager';
+
+export type FileWriteParams = {
+  path: string;
+  offset?: number;
+  totalSize?: number;
+  data: ArrayBuffer | Uint8Array | Blob | string;
+  chunkSize?: number;
+  chunkLen?: number;
+  overwrite?: boolean;
+  append?: boolean;
+  uiPercentage?: number;
+  timeoutMs?: number | string;
+};
+
+const MIN_FILE_CHUNK_SIZE = 64;
+
+function getProtocolV2FileChunkLimit() {
+  const env = DataManager.getSettings('env');
+  if (env && DataManager.isBleConnect(env)) {
+    return PROTOCOL_V2_BLE_FILE_CHUNK_SIZE;
+  }
+  return PROTOCOL_V2_WEBUSB_FILE_CHUNK_SIZE;
+}
+
+async function dataToUint8Array(data: FileWriteParams['data'] | Blob): Promise<Uint8Array> {
+  if (typeof data === 'string') {
+    return new TextEncoder().encode(data);
+  }
+
+  if (data instanceof ArrayBuffer) {
+    return new Uint8Array(data);
+  }
+
+  if (ArrayBuffer.isView(data)) {
+    return new Uint8Array(data.buffer, data.byteOffset, data.byteLength);
+  }
+
+  if (typeof Blob !== 'undefined' && data instanceof Blob) {
+    return new Uint8Array(await data.arrayBuffer());
+  }
+
+  throw ERRORS.TypedError(
+    HardwareErrorCode.CallMethodInvalidParameter,
+    'Unsupported FilesystemFileWrite data'
+  );
+}
+
+function normalizeChunkSize(value: unknown, maxChunkSize: number): number {
+  const numeric = Number(value);
+  if (!Number.isFinite(numeric) || numeric <= 0) return maxChunkSize;
+  return Math.min(Math.max(Math.floor(numeric), MIN_FILE_CHUNK_SIZE), maxChunkSize);
+}
+
+function getConfirmedProgress(
+  processedByte: number,
+  totalSize: number,
+  written: number,
+  dataLength: number
+) {
+  if (Number.isFinite(processedByte) && Number.isFinite(totalSize) && totalSize > 0) {
+    if (processedByte >= totalSize) return 100;
+    return Math.min(Math.max(Math.floor((processedByte / totalSize) * 100), 0), 99);
+  }
+  if (dataLength > 0) {
+    if (written >= dataLength) return 100;
+    return Math.min(Math.max(Math.floor((written / dataLength) * 100), 0), 99);
+  }
+  return 100;
+}
+
+export default class FileWrite extends BaseMethod<FileWriteParams> {
+  init() {
+    // Protocol V2 (Pro2) 专属方法，core 调度层统一做非 V2 设备守卫
+    this.requireProtocolV2 = true;
+    this.skipForceUpdateCheck = true;
+    this.useDevicePassphraseState = false;
+    validateRequiredData(this.payload.data, 'data');
+    const path = validateNonEmptyString(this.payload.path, 'path');
+    const offset = validateNonNegativeInteger(this.payload.offset, 'offset', 0);
+    this.params = {
+      path,
+      offset,
+      totalSize: validateNonNegativeInteger(this.payload.totalSize, 'totalSize', 0),
+      data: this.payload.data,
+      chunkSize: validateOptionalNonNegativeInteger(this.payload.chunkSize, 'chunkSize'),
+      chunkLen: validateOptionalNonNegativeInteger(this.payload.chunkLen, 'chunkLen'),
+      overwrite: this.payload.overwrite ?? offset === 0,
+      append: this.payload.append ?? false,
+      uiPercentage: validateOptionalPercentage(this.payload.uiPercentage, 'uiPercentage'),
+      timeoutMs: validateOptionalNonNegativeInteger(this.payload.timeoutMs, 'timeoutMs'),
+    };
+  }
+
+  async run() {
+    const data = await dataToUint8Array(this.params.data);
+    const dataLength = data.byteLength;
+    const offsetValue = Number(this.params.offset ?? 0);
+    const startOffset = Number.isFinite(offsetValue) && offsetValue > 0 ? offsetValue : 0;
+    const payloadTotalSize = Number(this.params.totalSize);
+    const totalSize =
+      Number.isFinite(payloadTotalSize) && payloadTotalSize > 0
+        ? payloadTotalSize
+        : startOffset + dataLength;
+
+    if (totalSize < startOffset + dataLength) {
+      throw ERRORS.TypedError(
+        HardwareErrorCode.RuntimeError,
+        `FilesystemFileWrite totalSize ${totalSize} is smaller than offset + data length ${
+          startOffset + dataLength
+        }`
+      );
+    }
+
+    const chunkSize = normalizeChunkSize(
+      this.params.chunkSize ?? this.params.chunkLen,
+      getProtocolV2FileChunkLimit()
+    );
+    const overwrite = this.params.overwrite ?? false;
+    const append = this.params.append ?? false;
+    let written = 0;
+    let chunkIndex = 0;
+    let lastMessage: Record<string, unknown> | undefined;
+    const startTime = Date.now();
+    const timeoutMs =
+      this.params.timeoutMs === undefined ? undefined : Number(this.params.timeoutMs);
+
+    while (written < dataLength) {
+      const chunkEnd = Math.min(written + chunkSize, dataLength);
+      const chunk = data.slice(written, chunkEnd);
+      const offset = startOffset + written;
+      const isFirstChunk = chunkIndex === 0;
+      const progress =
+        this.params.uiPercentage ??
+        Math.min(Math.ceil(((written + chunk.byteLength) / dataLength) * 100), 99);
+
+      const res = await this.device.commands.typedCall(
+        'FilesystemFileWrite',
+        'FilesystemFile',
+        {
+          file: {
+            path: this.params.path,
+            offset,
+            total_size: totalSize,
+            data: chunk,
+          },
+          overwrite: isFirstChunk ? overwrite : false,
+          append,
+          ui_percentage: progress,
+        },
+        {
+          timeoutMs,
+        }
+      );
+
+      lastMessage = res.message;
+      const processedByte = Number(res.message?.processed_byte);
+      if (Number.isFinite(processedByte) && processedByte > offset) {
+        written = processedByte - startOffset;
+      } else {
+        written += chunk.byteLength;
+      }
+
+      if (written > dataLength) {
+        throw ERRORS.TypedError(
+          HardwareErrorCode.RuntimeError,
+          `FilesystemFileWrite invalid processed_byte ${processedByte}`
+        );
+      }
+
+      const confirmedProcessedByte =
+        Number.isFinite(processedByte) && processedByte > offset
+          ? processedByte
+          : startOffset + written;
+      if (typeof this.postMessage === 'function') {
+        const elapsedMs = Date.now() - startTime;
+        const transferredBytes = Math.min(written, dataLength);
+        this.postMessage(
+          createUiMessage(UI_REQUEST.DEVICE_PROGRESS, {
+            progress: getConfirmedProgress(confirmedProcessedByte, totalSize, written, dataLength),
+            transferredBytes,
+            totalBytes: dataLength,
+            rateBytesPerSecond:
+              elapsedMs > 0 ? Math.round((transferredBytes / elapsedMs) * 1000) : undefined,
+            elapsedMs,
+          })
+        );
+      }
+      chunkIndex += 1;
+    }
+
+    return Promise.resolve({
+      ...lastMessage,
+      path: this.params.path,
+      offset: startOffset,
+      total_size: totalSize,
+      processed_byte: startOffset + written,
+      chunks: chunkIndex,
+    });
+  }
+}

package/src/api/FirmwareUpdate.ts

@@ -14,7 +14,7 @@ import { uploadFirmware } from './firmware/uploadFirmware';
 import { createUiMessage } from '../events';
 import { DeviceModelToTypes, type KnownDevice } from '../types';
 import { isEnteredManuallyBoot } from './firmware/bootloaderHelper';
-import { LoggerNames, getDeviceType, getDeviceUUID, getLogger, wait } from '../utils';
+import { LoggerNames, getDeviceUUID, getLogger, wait } from '../utils';
 import { DataManager } from '../data-manager';
 import { DevicePool } from '../device/DevicePool';
 
@@ -92,7 +92,7 @@ export default class FirmwareUpdate extends BaseMethod<Params> {
               true
             );
             await this.device.initialize();
-            if (this.device.features?.bootloader_mode) {
+            if (this.device.isBootloader()) {
               clearInterval(intervalTimer);
               this.checkPromise?.resolve(true);
             }
@@ -105,7 +105,7 @@ export default class FirmwareUpdate extends BaseMethod<Params> {
           const devicesDescriptor = deviceDiff?.descriptors ?? [];
           const { deviceList } = await DevicePool.getDevices(devicesDescriptor, connectId);
 
-          if (deviceList.length === 1 && deviceList[0]?.features?.bootloader_mode) {
+          if (deviceList.length === 1 && deviceList[0]?.isBootloader()) {
             // should update current device from cache
             // because device was reboot and had some new requests
             this.device.updateFromCache(deviceList[0]);
@@ -131,9 +131,17 @@ export default class FirmwareUpdate extends BaseMethod<Params> {
   async run() {
     const { device, params } = this;
     const { features, commands } = device;
-    const deviceType = getDeviceType(features);
+    const deviceType = device.getCurrentDeviceType();
+
+    // Protocol V2 (Pro2) 固件升级走 DeviceFirmwareUpdate 流程，禁止进入 legacy 入口
+    if (device.isProtocolV2()) {
+      throw ERRORS.TypedError(
+        HardwareErrorCode.RuntimeError,
+        'Protocol V2 firmware update must use firmwareUpdateV4'
+      );
+    }
 
-    if (!features?.bootloader_mode && features) {
+    if (!device.isBootloader() && features) {
       const uuid = getDeviceUUID(features);
       // should go to bootloader mode manually
       if (isEnteredManuallyBoot(features, params.updateType)) {

package/src/api/FirmwareUpdateV2.ts

@@ -17,10 +17,9 @@ import { getBinary, getInfo, getSysResourceBinary } from './firmware/getBinary';
 import { updateResources, uploadFirmware } from './firmware/uploadFirmware';
 import {
   LoggerNames,
+  getDeviceBootloaderVersion,
   getDeviceFirmwareVersion,
-  getDeviceType,
   getDeviceUUID,
-  getFirmwareType,
   getLogger,
   wait,
 } from '../utils';
@@ -30,7 +29,6 @@ import { DataManager } from '../data-manager';
 import { DEVICE } from '../events';
 
 import type { Features, KnownDevice } from '../types';
-import type { Device } from '../device/Device';
 
 type Params = {
   binary?: ArrayBuffer;
@@ -102,7 +100,7 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
     );
   };
 
-  private async _promptDeviceInBootloaderForWebDevice({ device }: { device: Device }) {
+  private async _promptDeviceInBootloaderForWebDevice() {
     return new Promise((resolve, reject) => {
       if (this.device.listenerCount(DEVICE.SELECT_DEVICE_IN_BOOTLOADER_FOR_WEB_DEVICE) > 0) {
         this.device.emit(
@@ -133,9 +131,8 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
     // eslint-disable-next-line prefer-const
     let timeoutTimer: ReturnType<typeof setTimeout> | undefined;
 
-    const isTouchOrProDevice =
-      getDeviceType(this?.device?.features) === EDeviceType.Touch ||
-      getDeviceType(this?.device?.features) === EDeviceType.Pro;
+    const deviceType = this.device?.getCurrentDeviceType();
+    const isTouchOrProDevice = deviceType === EDeviceType.Touch || deviceType === EDeviceType.Pro;
 
     const intervalTimer: ReturnType<typeof setInterval> | undefined = setInterval(
       async () => {
@@ -157,9 +154,7 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
 
           try {
             this.postTipMessage(FirmwareUpdateTipMessage.SelectDeviceInBootloaderForWebDevice);
-            const confirmed = await this._promptDeviceInBootloaderForWebDevice({
-              device: this.device,
-            });
+            const confirmed = await this._promptDeviceInBootloaderForWebDevice();
             if (confirmed) {
               await this._checkDeviceInBootloaderMode(connectId, intervalTimer, timeoutTimer);
             }
@@ -181,7 +176,7 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
               true
             );
             await this.device.initialize();
-            if (this.device.features?.bootloader_mode) {
+            if (this.device.isBootloader()) {
               clearInterval(intervalTimer);
               this.checkPromise?.resolve(true);
             }
@@ -214,7 +209,7 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
     const devicesDescriptor = deviceDiff?.descriptors ?? [];
     const { deviceList } = await DevicePool.getDevices(devicesDescriptor, connectId);
 
-    if (deviceList.length === 1 && deviceList[0]?.features?.bootloader_mode) {
+    if (deviceList.length === 1 && deviceList[0]?.isBootloader()) {
       // should update current device from cache
       // because device was reboot and had some new requests
       this.device.updateFromCache(deviceList[0]);
@@ -229,19 +224,19 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
   }
 
   isEnteredManuallyBoot(features: Features) {
-    const deviceType = getDeviceType(features);
+    const deviceType = this.device.getCurrentDeviceType();
     const isMini = deviceType === EDeviceType.Mini;
     const isBoot183ClassicUpBle =
       this.params.updateType === 'firmware' &&
       deviceType === EDeviceType.Classic &&
-      features.bootloader_version === '1.8.3';
+      getDeviceBootloaderVersion(features).join('.') === '1.8.3';
     return isMini || isBoot183ClassicUpBle;
   }
 
   isSupportResourceUpdate(features: Features, updateType: string) {
     if (updateType !== 'firmware') return false;
 
-    const deviceType = getDeviceType(features);
+    const deviceType = this.device.getCurrentDeviceType();
     const isTouchMode = deviceType === EDeviceType.Touch || deviceType === EDeviceType.Pro;
     const currentVersion = getDeviceFirmwareVersion(features).join('.');
 
@@ -254,7 +249,7 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
    */
   checkVersionForCopyTouchResource(features: Features | undefined, firmwareType: EFirmwareType) {
     if (!features) return;
-    const deviceType = getDeviceType(features);
+    const deviceType = this.device.getCurrentDeviceType();
     const currentVersion = getDeviceFirmwareVersion(features).join('.');
     const targetVersion = this.params.version?.join('.');
     const { updateType } = this.params;
@@ -279,14 +274,22 @@ export default class FirmwareUpdateV2 extends BaseMethod<Params> {
   async run() {
     const { device, params } = this;
     const { features, commands } = device;
-    const deviceType = getDeviceType(features);
+    const deviceType = device.getCurrentDeviceType();
 
-    const deviceFirmwareType = getFirmwareType(device.features);
+    // Protocol V2 (Pro2) 固件升级走 DeviceFirmwareUpdate 流程，禁止进入 legacy 入口
+    if (device.isProtocolV2()) {
+      throw ERRORS.TypedError(
+        HardwareErrorCode.RuntimeError,
+        'Protocol V2 firmware update must use firmwareUpdateV4'
+      );
+    }
+
+    const deviceFirmwareType = device.getCurrentFirmwareType();
     const firmwareType = params.firmwareType ?? deviceFirmwareType;
 
     this.checkVersionForCopyTouchResource(features, firmwareType);
 
-    if (!features?.bootloader_mode && features) {
+    if (!device.isBootloader() && features) {
       const uuid = getDeviceUUID(features);
       // should go to bootloader mode manually
       if (this.isEnteredManuallyBoot(features)) {

package/src/api/FirmwareUpdateV3.ts

@@ -18,6 +18,7 @@ import { DataManager } from '../data-manager';
 import { FirmwareUpdateBaseMethod } from './firmware/FirmwareUpdateBaseMethod';
 import { DevicePool } from '../device/DevicePool';
 import { DEVICE } from '../events';
+import { buildProtocolV1FeaturesPayload } from '../deviceProfile';
 
 import type { FirmwareUpdateV3Params } from '../types/api/firmwareUpdate';
 import type { Deferred, EFirmwareType } from '@onekeyfe/hd-shared';
@@ -79,6 +80,20 @@ export default class FirmwareUpdateV3 extends FirmwareUpdateBaseMethod<FirmwareU
   }
 
   async run() {
+    if (this.device.isProtocolV2()) {
+      throw ERRORS.TypedError(
+        HardwareErrorCode.RuntimeError,
+        'Protocol V2 firmware update must use firmwareUpdateV4'
+      );
+    }
+    Log.debug('FirmwareUpdateV3 strategy: Protocol V1');
+    return this.runProtocolV1();
+  }
+
+  /**
+   * Protocol V1 firmware update strategy for existing Pro devices.
+   */
+  private async runProtocolV1() {
     const { device } = this;
     const { features } = device;
 
@@ -251,6 +266,7 @@ export default class FirmwareUpdateV3 extends FirmwareUpdateBaseMethod<FirmwareU
     }
 
     this.postTipMessage(FirmwareUpdateTipMessage.StartTransferData);
+
     // Process resource zip contents
     if (resourceBinary) {
       const file = await JSZip.loadAsync(resourceBinary);
@@ -291,12 +307,10 @@ export default class FirmwareUpdateV3 extends FirmwareUpdateBaseMethod<FirmwareU
       }
     }
 
-    // trigger firmware update, support folder updates
+    // trigger firmware update
     try {
       this.postTipMessage(FirmwareUpdateTipMessage.ConfirmOnDevice);
-      await this.startEmmcFirmwareUpdate({
-        path: '0:updates',
-      });
+      await this.startEmmcFirmwareUpdate({ path: '0:updates' });
     } catch (error) {
       Log.error('triggerFirmwareUpdateEmmc error: ', error);
       // Re-throw errors with specific error codes that should not be ignored
@@ -373,7 +387,7 @@ export default class FirmwareUpdateV3 extends FirmwareUpdateBaseMethod<FirmwareU
           }),
         ]);
         getFeaturesTimeoutCount = 0;
-        const features = featuresRes.message;
+        const features = buildProtocolV1FeaturesPayload(featuresRes.message, this.device.features);
         const bootloaderVersion = getDeviceBootloaderVersion(features).join('.');
         const bleVersion = getDeviceBLEFirmwareVersion(features).join('.');
         const firmwareVersion = getDeviceFirmwareVersion(features).join('.');