@onehat/data 1.7.7 → 1.7.11

package/cypress/integration/Entity.spec.js

@@ -347,6 +347,18 @@ describe('Entity', function() {
 			expect(_.isEqual(result, expected)).to.be.true;
 		});
 
+		it('getChangedValues', function() {
+			this.entity.foo = 2;
+			const result = this.entity.getChangedValues(),
+				expected = {
+					foo: {
+						original: 1,
+						current: 2,
+					},
+				};
+			expect(_.isEqual(result, expected)).to.be.true;
+		});
+
 		it('data', function() {
 			const result = this.entity.data,
 				expected = {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@onehat/data",
-	"version": "1.7.7",
+	"version": "1.7.11",
 	"description": "JS data modeling package with adapters for many storage mediums.",
 	"main": "src/index.js",
 	"type": "module",

package/src/Entity.js

@@ -187,7 +187,7 @@ class Entity extends EventEmitter {
 		if (this.isDestroyed) {
 			throw Error('this._createStatics is no longer valid. Entity has been destroyed.');
 		}
-		const staticsDefinitions = this.schema.entity.methods;
+		const staticsDefinitions = this.schema.entity.statics;
 		if (!_.isEmpty(staticsDefinitions)) {
 			_.each(staticsDefinitions, (value, key) => {
 				this[key] = value;
@@ -711,21 +711,39 @@ class Entity extends EventEmitter {
 	 * @return {array|boolean} diff - Array of property names that have changed, or false
 	 */
 	getChanged = () => {
-		const obj1 = this._originalDataParsed,
-			obj2 = this.getRawValues(),
-			diff = Object.keys(obj1).reduce((result, key) => { // from https://stackoverflow.com/a/40610459/9163076
-				if (obj2 && !obj2.hasOwnProperty(key)) {
+		const original = this._originalDataParsed,
+			current = this.getRawValues(),
+			diff = Object.keys(original).reduce((result, key) => { // from https://stackoverflow.com/a/40610459/9163076
+				if (current && !current.hasOwnProperty(key)) {
 					result.push(key);
-				} else if (_.isEqual(obj1[key], obj2[key])) {
+				} else if (_.isEqual(original[key], current[key])) {
 					const resultKeyIndex = result.indexOf(key);
 					result.splice(resultKeyIndex, 1);
 				}
 				return result;
-			}, Object.keys(obj2));
+			}, Object.keys(current));
 	
 		return !_.isEmpty(diff) ? diff : false;
 	}
 
+	/**
+	 * Gets a comprehensive analysis of what has changed since the last save
+	 * @return {object} changedPropertyValues - Object representing each changed field and both its original and current value
+	 */
+	getChangedValues = () => {
+		const original = this._originalDataParsed,
+			current = this.getRawValues(),
+			names = this.getChanged();
+		const changedPropertyValues = {};
+		_.each(names, (name) => {
+			changedPropertyValues[name] = {
+				original: original[name],
+				current: current[name],
+			};
+		});
+		return changedPropertyValues;
+	}
+
 	/**
 	 * Alias for this.submitValues
 	 */

package/src/Repository/Ajax.js

@@ -834,6 +834,9 @@ class AjaxRepository extends Repository {
 	 * @private
 	 */
 	_finalizeSave = (promises) => {
+		if (!promises.length) {
+			return;
+		}
 		return this.axios.all(promises)
 						.then(this.axios.spread((...batchOperationResults) => {
 							// All requests are now complete

package/src/Repository/Repository.js

@@ -267,6 +267,10 @@ export default class Repository extends EventEmitter {
 
 		this._createMethods();
 
+		if (this.schema.repository.initialize) {
+			this.schema.repository.initialize();
+		}
+
 		this.isInitialized = true;
 		this.emit('initialize');
 	}
@@ -1398,7 +1402,9 @@ export default class Repository extends EventEmitter {
 							if (this.combineBatch) {
 
 								result = this.batchAsSynchronous ? await this._doBatchAdd(entities) : this._doBatchAdd(entities);
-								results.push(result);
+								if (result) {
+									results.push(result);
+								}
 		
 							} else {
 								for (i = 0; i < entities.length; i++) {
@@ -1411,7 +1417,9 @@ export default class Repository extends EventEmitter {
 									}
 	
 									result = this.batchAsSynchronous ? await this._doAdd(entity) : this._doAdd(entity);
-									results.push(result);
+									if (result) {
+										results.push(result);
+									}
 								}
 							}
 						}
@@ -1425,7 +1433,9 @@ export default class Repository extends EventEmitter {
 							if (this.combineBatch) {
 
 								result = this.batchAsSynchronous ? await this._doBatchEdit(entities) : this._doBatchEdit(entities);
-								results.push(result);
+								if (result) {
+									results.push(result);
+								}
 
 							} else {
 								for (i = 0; i < entities.length; i++) {
@@ -1438,7 +1448,9 @@ export default class Repository extends EventEmitter {
 									}
 
 									result = this.batchAsSynchronous ? await this._doEdit(entity) : this._doEdit(entity);
-									results.push(result);
+									if (result) {
+										results.push(result);
+									}
 								}
 							}
 						}
@@ -1452,7 +1464,9 @@ export default class Repository extends EventEmitter {
 							if (this.combineBatch) {
 
 								result = this.batchAsSynchronous ? await this._doBatchDelete(entities) : this._doBatchDelete(entities);
-								results.push(result);
+								if (result) {
+									results.push(result);
+								}
 
 							} else {
 								for (i = 0; i < entities.length; i++) {
@@ -1463,7 +1477,9 @@ export default class Repository extends EventEmitter {
 									} else {
 										result = this.batchAsSynchronous ? await this._doDelete(entity) : this._doDelete(entity);
 									}
-									results.push(result);
+									if (result) {
+										results.push(result);
+									}
 								}
 							}
 						}