@onehat/data 1.5.2 → 1.6.0

package/cypress/integration/Entity.spec.js

@@ -44,7 +44,7 @@ describe('Entity', function() {
 			expect(this.entity.id).to.be.eq(1);
 		});
 
-		it('createId, isTempId', function() {
+		it('createTempId, isTempId', function() {
 			const schema = new Schema({
 					name: 'baz',
 					model: {
@@ -62,33 +62,14 @@ describe('Entity', function() {
 				entity = new Entity(schema, data);
 			entity.initialize();
 			expect(entity.id).to.be.null;
+			expect(entity.isTempId).to.be.false;
 
-			entity.createId();
+			entity.createTempId();
 			expect(entity.id).to.be.not.null;
-			expect(Entity.isTempId(entity.id)).to.be.true;
+			expect(entity.isTempId).to.be.true;
 
-
-
-			const schema2 = new Schema({
-					name: 'baz',
-					model: {
-						idProperty: 'foo',
-						displayProperty: 'bar',
-						properties: [
-							{ name: 'foo', type: 'uuid' }, // MOD
-							{ name: 'bar' },
-						],
-					},
-				}),
-				entity2 = new Entity(schema2, data);
-			
-			entity2.initialize();
-			expect(entity2.id).to.be.null;
-
-			entity2.createId();
-			expect(entity2.id).to.be.not.null;
-			const idProperty = entity2.getIdProperty();
-			expect(Entity.isTempId(entity2.id)).to.be.false;
+			entity.markSaved();
+			expect(entity.isTempId).to.be.false;
 		});
 		
 	
@@ -407,6 +388,12 @@ describe('Entity', function() {
 			const entity = new Entity(this.schema, {});
 			entity.initialize();
 			expect(entity.isPhantom).to.be.true;
+
+			entity.createTempId();
+			expect(entity.isPhantom).to.be.true;
+			
+			entity.markSaved();
+			expect(entity.isPhantom).to.be.false;
 		});
 
 		it('isDirty', function() {
@@ -469,6 +456,15 @@ describe('Entity', function() {
 			expect(this.entity.isDirty).to.be.true;
 		});
 
+		it('setId', function() {
+			expect(this.entity.foo).to.be.eq(1);
+			expect(this.entity.isTempId).to.be.false;
+			
+			this.entity.setId(2);
+			expect(this.entity.foo).to.be.eq(2);
+			expect(this.entity.isTempId).to.be.false;
+		});
+
 		it('_recalculateDependentProperties', function() {
 			const schema = new Schema({
 					name: 'baz',
@@ -508,6 +504,7 @@ describe('Entity', function() {
 			
 			entity.bar = 'Test';
 			entity.markSaved();
+			expect(entity.isTempId).to.be.false;
 
 			expect(entity.isPersisted).to.be.true;
 			const expected = {

package/cypress/integration/Property/Integer.spec.js

@@ -19,6 +19,14 @@ describe('IntegerProperty', function() {
 			expect(className).to.be.eq('Integer');
 		});
 
+		it('newId', function() {
+			const id1 = this.property.newId();
+			expect(id1.valueOf()).to.be.eq(this.property.idStartsAt);
+
+			const id2 = this.property.newId();
+			expect(id2.valueOf()).to.be.eq(this.property.idStartsAt +1);
+		});
+
 		// it('default value', function() {
 		// 	const property = this.property,
 		// 		rawValue = property.getDefaultValue();

package/cypress/integration/Property/Property.spec.js

@@ -112,6 +112,20 @@ describe('Property', function() {
 		it('getMapping', function() {
 			expect(this.property.getMapping()).to.be.eq('id');
 		});
+	
+		it('getMapping', function() {
+			expect(this.property.getMapping()).to.be.eq('id');
+		});
+	
+		it('isTempId', function() {
+			const definition = {
+					type: 'int',
+					isTempId: true,
+				},
+				Property = PropertyTypes[definition.type];
+			const property = new Property(definition);
+			expect(property.isTempId).to.be.true;
+		});
 
 	});
 

package/cypress/integration/Property/String.spec.js

@@ -10,9 +10,21 @@ describe('StringProperty', function() {
 		this.property = new Property(definition);
 	});
 
-	it('className', function() {
-		const className = this.property.getClassName();
-		expect(className).to.be.eq('String');
+	describe('general', function() {
+
+		it('className', function() {
+			const className = this.property.getClassName();
+			expect(className).to.be.eq('String');
+		});
+
+		it('newId', function() {
+			const id1 = this.property.newId();
+			expect(id1.valueOf()).to.be.eq('TEMP-1');
+
+			const id2 = this.property.newId();
+			expect(id2.valueOf()).to.be.eq('TEMP-2');
+		});
+
 	});
 
 	describe('parse', function() {

package/cypress/integration/Repository/Repository.spec.js

@@ -622,11 +622,18 @@ describe('Repository Base', function() {
 			expect(_.isEqual(entity, deleted[0])).to.be.true;
 		});
 
-		it('isInRepository', function() {
+		it('isInRepository, hasId', function() {
 			this.repository.setAutoSave(false);
-			const entity = this.repository.getByIx(0),
-				result = this.repository.isInRepository(entity);
-			
+			const id = 1,
+				entity = this.repository.getById(id);
+
+			let result = this.repository.isInRepository(entity);
+			expect(result).to.be.true;
+
+			result = this.repository.isInRepository(id);
+			expect(result).to.be.true;
+
+			result = this.repository.hasId(id);
 			expect(result).to.be.true;
 		});
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@onehat/data",
-	"version": "1.5.2",
+	"version": "1.6.0",
 	"description": "JS data modeling package with adapters for many storage mediums.",
 	"main": "src/index.js",
 	"type": "module",

package/src/Entity.js

@@ -4,8 +4,6 @@ import EventEmitter from '@onehat/events';
 import PropertyTypes from './Property';
 import _ from 'lodash';
 
-const TEMP_PREFIX = 'TEMP-';
-
 /**
  * Class represents a single Entity (i.e. a record)
  * which is a collection of Properties with current values.
@@ -158,31 +156,24 @@ class Entity extends EventEmitter {
 
 	/**
 	 * Generates a new unique id and assigns it to this entity.
-	 * If the idProperty is of type 'uuid', then it generates a new UUID.
-	 * If not, then it generates a temp id.
 	 */
-	createId = () => {
+	createTempId = () => {
 		if (this.isDestroyed) {
-			throw Error('this.generateTempId is no longer valid. Entity has been destroyed.');
+			throw Error('this.createTempId is no longer valid. Entity has been destroyed.');
 		}
 		if (!_.isNil(this.id)) {
 			throw new Error('Entity id already exists.');
 		}
-		const idProperty = this.getIdProperty(),
-			id = (idProperty.type === 'uuid') ? idProperty.newId() : _.uniqueId(TEMP_PREFIX);
-		this.setId(id);
-	}
 
-	/**
-	 * Determines whether submitted id is a "temp" id.
-	 * @param {any} id
-	 * @return {boolean} isTempId
-	 */
-	static isTempId(id) {
-		if (_.isString(id) && id.match(new RegExp('^' + TEMP_PREFIX))) {
-			return true;
+		const idProperty = this.getIdProperty();
+		
+		if (!idProperty.newId) {
+			throw new Error('idProperty.newId() does not exist');
 		}
-		return false;
+
+		this.setId(idProperty.newId());
+
+		idProperty.isTempId = true;
 	}
 
 	/**
@@ -739,6 +730,14 @@ class Entity extends EventEmitter {
 		return this.getId();
 	}
 
+	/**
+	 * Is this Entity's idProperty using a temporary ID?
+	 * @return {boolean} isTempId
+	 */
+	get isTempId() {
+		return this.getIdProperty().isTempId;
+	}
+
 	/**
 	 * Gets the "Display" Property object for this Entity.
 	 * This is the Property whose value can easily identify the whole Entity itself.
@@ -793,13 +792,13 @@ class Entity extends EventEmitter {
 		const idProperty = this.getIdProperty(),
 			id = idProperty.getSubmitValue();
 
-		// No id
+		// No ID
 		if (_.isNil(id)) {
 			return true;
 		}
 
-		// Temp id
-		if (Entity.isTempId(id)) {
+		// ID is temporary
+		if (idProperty.isTempId) {
 			return true;
 		}
 
@@ -851,23 +850,25 @@ class Entity extends EventEmitter {
 	 */
 	setId = (id, force = false) => {
 		let isChanged = false;
-		const property = this.getIdProperty();
+		const idProperty = this.getIdProperty();
 
-		property.pauseEvents(); // We don't need property_change to fire
-		if (property.setValue(id)) {
+		idProperty.pauseEvents(); // We don't need property_change to fire
+		if (idProperty.setValue(id)) {
 			isChanged = true;
 		}
-		property.resumeEvents();
+		idProperty.resumeEvents();
 
 		if (isChanged || force) {
 			// Set this id on the _originalData* objects
-			if (property.hasMapping) {
-				_.merge(this._originalData, Entity.getReverseMappedRawValue(property));
+			if (idProperty.hasMapping) {
+				_.merge(this._originalData, Entity.getReverseMappedRawValue(idProperty));
 			} else {
-				this._originalData[property.name] = property.getRawValue();
+				this._originalData[idProperty.name] = idProperty.getRawValue();
 			}
-			this._originalDataParsed[property.name] = property.getParsedValue();
+			this._originalDataParsed[idProperty.name] = idProperty.getParsedValue();
 		}
+		
+		idProperty.isTempId = false;
 
 		return isChanged;
 	}
@@ -973,6 +974,7 @@ class Entity extends EventEmitter {
 			throw Error('this.markSaved is no longer valid. Entity has been destroyed.');
 		}
 		this.isPersisted = true;
+		this.getIdProperty().isTempId = false;
 		this._originalData = this._getReconstructedOriginalData();
 		this._originalDataParsed = this.getParsedValues();
 	}

package/src/Property/Integer.js

@@ -4,6 +4,8 @@ import Property from './Property';
 import Parsers from '../Util/Parsers';
 import _ from 'lodash';
 
+let lastId = 0;
+
 /**
  * Class represents a Property that stores an integer value.
  * @extends Property
@@ -15,6 +17,7 @@ export default class IntegerProperty extends Property {
 
 		const defaults = {
 			// defaultValue: 0,
+			idStartsAt: 100 * 1000 * 1000 * 1000, // 100 billion
 		};
 		
 		_.merge(this, defaults, config);
@@ -29,6 +32,32 @@ export default class IntegerProperty extends Property {
 		}
 		return Parsers.ParseInt(value);
 	}
+
+	/**
+	 * Generates a new id
+	 * Mainly for temporary, in-memory usage
+	 */
+	newId = () => {
+		let id,
+			hasId = false;
+
+		const entity = this.getEntity(),
+			repository = entity && entity.repository;
+
+		if (lastId < this.idStartsAt) {
+			lastId = this.idStartsAt;
+		}
+
+		id = lastId++;
+		hasId = repository ? repository.hasId(id) : false;
+
+		while(hasId) {
+			id = lastId++;
+			hasId = repository.hasId(id);
+		}
+		return id;
+	}
+
 	
 };
 

package/src/Property/Property.js

@@ -83,6 +83,12 @@ export default class Property extends EventEmitter {
 			 * @member {boolean} isSortable - Whether this property type is sortable
 			 */
 			isSortable: true,
+			
+			/**
+			 * @member {boolean} isTempId - Whether this property's ID is temporary
+			 */
+			isTempId: false,
+
 
 
 			// OneBuild META attributes, just bring these over wholesale for now

package/src/Property/String.js

@@ -4,6 +4,8 @@ import Property from './Property';
 import Parsers from '../Util/Parsers';
 import _ from 'lodash';
 
+const TEMP_PREFIX = 'TEMP-';
+
 /**
  * Class represents a Property that stores string data.
  * @extends Property
@@ -29,6 +31,23 @@ export default class StringProperty extends Property {
 		}
 		return Parsers.ParseString(value);
 	}
+
+	newId = () => {
+		let id,
+			hasId = false;
+
+		const entity = this.getEntity(),
+			repository = entity && entity.repository;
+
+		id = _.uniqueId(TEMP_PREFIX);
+		hasId = repository ? repository.hasId(id) : false;
+
+		while(hasId) {
+			id = _.uniqueId(TEMP_PREFIX);
+			hasId = repository.hasId(id);
+		}
+		return id;
+	}
 };
 
 StringProperty.className = 'String';

package/src/Repository/Ajax.js

@@ -395,7 +395,7 @@ class AjaxRepository extends Repository {
 						});
 				
 						// Set the total records that pass filter
-						this.total = total;				
+						this.total = total;
 						this._setPaginationVars();
 				
 						this.isLoading = false;

package/src/Repository/Memory.js

@@ -134,7 +134,7 @@ class MemoryRepository extends Repository {
 		// Add to internal store
 		_.each(entities, (entity) => {
 			if (entity.isPhantom) {
-				entity.createId();
+				entity.createTempId();
 			}
 			this._keyedEntities[entity.id] = entity;
 		});

package/src/Repository/Repository.js

@@ -865,8 +865,8 @@ export default class Repository extends EventEmitter {
 		this.entities.push(entity);
 
 		// Create id if needed
-		if (entity.isPhantom) {
-			entity.createId(); // either a UUID or a temp id
+		if (entity.isPhantom) { // i.e. idProperty has no value
+			entity.createTempId();
 		}
 
 		this.emit('add', entity);
@@ -893,7 +893,7 @@ export default class Repository extends EventEmitter {
 		const entity = Repository._createEntity(this.schema, data, this, isPersisted, originalIsMapped);
 
 		if (entity.isPhantom) {
-			entity.createId(); // either a UUID or a temp id
+			entity.createTempId();
 		}
 
 		return entity;
@@ -1168,6 +1168,15 @@ export default class Repository extends EventEmitter {
 		return !_.isNil(this.getById(idOrEntity));
 	}
 
+	/**
+	 * Convenience function
+	 * Alias for isInRepository
+	 * NOTE: It only searches in memory. Doesn't query server
+	 */
+	hasId = (id) => {
+		return this.isInRepository(id);
+	}
+
 	/**
 	 * Queues up batch operations for saving
 	 * new, edited, and deleted entities to storage medium.