@ondc/automation-mock-runner 1.3.50 → 1.3.51

package/dist/lib/validators/code-validator.js

@@ -342,7 +342,7 @@ class CodeValidator {
      */
     static checkBestPractices(ast, schema) {
         const warnings = [];
-        const hasReturn = this.collectTopLevelReturns(ast).length > 0;
+        const hasReturn = this.collectTopLevelReturns(ast, schema.name).length > 0;
         if (!hasReturn) {
             warnings.push(`Function should return a value (expected: ${schema.returnType.description})`);
         }

package/dist/test/CodeValidator.test.js

@@ -4,6 +4,7 @@ const code_validator_1 = require("../lib/validators/code-validator");
 const function_registry_1 = require("../lib/constants/function-registry");
 const validateSchema = (0, function_registry_1.getFunctionSchema)("validate");
 const meetsRequirementsSchema = (0, function_registry_1.getFunctionSchema)("meetsRequirements");
+const generateSchema = (0, function_registry_1.getFunctionSchema)("generate");
 describe("CodeValidator.validate — return structure", () => {
     it("accepts an outer return with the full expected shape", () => {
         const code = `
@@ -76,6 +77,26 @@ describe("CodeValidator.validate — return structure", () => {
 		`;
         const result = code_validator_1.CodeValidator.validate(code, validateSchema);
         expect(result.errors).toEqual([]);
+        expect(result.warnings).toEqual([]);
+        expect(result.isValid).toBe(true);
+    });
+    it("does not warn 'should return a value' when target fn has a return (validate)", () => {
+        const code = `
+			function validate(targetPayload, sessionData) {
+				return { valid: true, code: 200, description: "Valid request" };
+			}
+		`;
+        const result = code_validator_1.CodeValidator.validate(code, validateSchema);
+        expect(result.warnings.some((w) => w.includes("should return a value"))).toBe(false);
+    });
+    it("does not warn 'should return a value' for generate with a return", () => {
+        const code = `
+			async function generate(defaultPayload, sessionData) {
+				return defaultPayload;
+			}
+		`;
+        const result = code_validator_1.CodeValidator.validate(code, generateSchema);
+        expect(result.warnings.some((w) => w.includes("should return a value"))).toBe(false);
         expect(result.isValid).toBe(true);
     });
     it("ignores sibling top-level helper function returns (meetsRequirements)", () => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@ondc/automation-mock-runner",
-	"version": "1.3.50",
+	"version": "1.3.51",
 	"description": "A TypeScript library for ONDC automation mock runner",
 	"main": "dist/index.js",
 	"types": "dist/index.d.ts",