@omnimedia/omnitool 1.1.0-105 → 1.1.0-106

package/README.md

@@ -56,17 +56,19 @@ const timeline = omni.timeline(o => {
 })
 ```
 
-You can label your items:
+Items can have `label` and `enabled` fields:
 
 ```ts
 const visual = o.sequence(
 	"Main sequence",
 	o.video(clip, {label: "Intro"}),
-	o.transition.fade(500, {label: "Fade"}),
-	o.text("Hello world", {label: "Title"})
+	o.transition.fade(500, {label: "Fade", enabled: false}),
+	o.text("Hello world", {label: "Title", enabled: false})
 )
 ```
 
+Disabled items do not render or play audio, but still keep their timeline duration and occupy space.
+
 Declarative helper style (no explicit `o` in timeline declarations):
 
 ```ts

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@omnimedia/omnitool",
-	"version": "1.1.0-105",
+	"version": "1.1.0-106",
 	"description": "open source video processing tools",
 	"license": "MIT",
 	"author": "Przemysław Gałęzki",

package/s/timeline/parts/captions.ts

@@ -6,6 +6,7 @@ import {Transcription, TranscriptSegment} from "../../features/speech/transcribe
 
 export type CaptionOptions = {
 	label?: string
+	enabled?: boolean
 	itemId?: Item.Caption["itemId"]
 	start?: number
 	duration?: number

package/s/timeline/parts/item.ts

@@ -26,8 +26,9 @@ export enum Kind {
 	Image
 }
 
-export type ItemMeta = {
+export type ItemBase = {
 	label?: string
+	enabled?: boolean
 }
 
 export namespace Item {
@@ -35,6 +36,7 @@ export namespace Item {
 		id: Id
 		kind: Kind.TextStyle
 		style: TextStyleOptions
+		enabled?: boolean
 	}
 
 	export type Spatial = {
@@ -42,14 +44,14 @@ export namespace Item {
 		kind: Kind.Spatial
 		transform: Transform
 		crop?: Crop
-		enabled: boolean
+		enabled?: boolean
 	}
 
 	export type Animation = {
 		id: Id
 		kind: Kind.Animation
 		anims: VisualAnimations
-		enabled: boolean
+		enabled?: boolean
 	}
 
 	export type Filter<T extends FilterType = FilterType> = {
@@ -57,14 +59,14 @@ export namespace Item {
 		kind: Kind.Filter
 		type: T
 		params?: FilterParams<T>
-		enabled: boolean
+		enabled?: boolean
 	}
 
 	export type Gap = {
 		id: Id
 		kind: Kind.Gap
 		duration: number
-	} & ItemMeta
+	} & ItemBase
 
 	export type Sequence = {
 		id: Id
@@ -72,7 +74,7 @@ export namespace Item {
 		childrenIds: Id[]
 		spatialId?: Id
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 	export type Stack = {
 		id: Id
@@ -80,7 +82,7 @@ export namespace Item {
 		childrenIds: Id[]
 		spatialId?: Id
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 	export type Video = {
 		id: Id
@@ -91,7 +93,7 @@ export namespace Item {
 		spatialId?: Id
 		animationIds?: Id[]
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 	export type Image = {
 		id: Id
@@ -101,7 +103,7 @@ export namespace Item {
 		spatialId?: Id
 		animationIds?: Id[]
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 	export type Audio = {
 		id: Id
@@ -110,7 +112,7 @@ export namespace Item {
 		start: number
 		duration: number
 		gain?: number
-	} & ItemMeta
+	} & ItemBase
 
 	export type Text = {
 		id: Id
@@ -121,7 +123,7 @@ export namespace Item {
 		animationIds?: Id[]
 		styleId?: Id
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 
 	export type Caption = {
@@ -138,14 +140,14 @@ export namespace Item {
 		animationIds?: Id[]
 		styleId?: Id
 		filterIds?: Id[]
-	} & ItemMeta
+	} & ItemBase
 
 	export type Transition = {
 		id: Id
 		kind: Kind.Transition
 		name: TransitionName
 		duration: number
-	} & ItemMeta
+	} & ItemBase
 
 	export type Any = (
 		| Sequence

package/s/timeline/parts/transitions.ts

@@ -1,4 +1,4 @@
-import type {Item, ItemMeta} from "./item.js"
+import type {Item, ItemBase} from "./item.js"
 
 export const transitionNames = [
 	"Bounce",
@@ -78,7 +78,7 @@ export type Transition = {
 }
 
 export interface TransitionAction {
-	(duration: number, options?: ItemMeta): Item.Transition
+	(duration: number, options?: ItemBase): Item.Transition
 }
 
 export type TransitionActions = {

package/s/timeline/renderers/parts/handy.ts

@@ -110,7 +110,7 @@ function applySpatialIfAny(
 	let matrix = parentMatrix
 	if ("spatialId" in item && item.spatialId) {
 		const spatial = items.get(item.spatialId) as Item.Spatial | undefined
-		if (spatial?.enabled) {
+		if (spatial && spatial.enabled !== false) {
 			const local = transformToMat6(spatial.transform)
 			matrix = mul6(local, matrix)
 		}
@@ -120,7 +120,7 @@ function applySpatialIfAny(
 		for (const id of item.animationIds) {
 			const animation = items.get(id) as Item.Animation | undefined
 			const anim = animation?.anims.transform
-			if (animation?.enabled && anim && transformActiveAt(anim, time)) {
+			if (animation?.enabled !== false && anim && transformActiveAt(anim, time)) {
 				const local = transformToMat6(resolveTransformAnimation(time, anim))
 				matrix = mul6(local, matrix)
 			}
@@ -410,7 +410,7 @@ export function computeOpacity(
 	for (const id of item.animationIds) {
 		const animation = ctx.items.get(id) as Item.Animation | undefined
 		const anim = animation?.anims.opacity
-		if (animation?.enabled && anim && keyframesActiveAt(anim.track, time))
+		if (animation?.enabled !== false && anim && keyframesActiveAt(anim.track, time))
 			opacity = resolveScalarAnimation(time, anim)
 	}
 	return opacity

package/s/timeline/renderers/parts/samplers/audio/parts/init.ts

@@ -15,6 +15,8 @@ export async function initStreams(
 		items.map(async ({item, localTime}) => {
 			if (item.kind !== Kind.Audio)
 				return
+			if (item.enabled === false)
+				return
 
 			const sink = await pool.getSink(item.mediaHash)
 			if (!sink)

package/s/timeline/renderers/parts/samplers/visual/parts/sample.ts

@@ -17,6 +17,9 @@ export async function sampleVisual(
 		allowHandles?: boolean
 	} = {}
 ): Promise<Layer[]> {
+	if ("enabled" in item && item.enabled === false)
+		return item.kind === Kind.Gap ? [{id: item.id, kind: "gap"}] : []
+
 	const matrix = computeWorldMatrix(ctx.items, ancestors, item, time)
 	const alpha = computeOpacity(ctx, item, time)
 	const crop = "spatialId" in item && item.spatialId
@@ -25,7 +28,7 @@ export async function sampleVisual(
 	const filters = "filterIds" in item && item.filterIds
 		? item.filterIds
 			.map(id => ctx.items.get(id) as Item.Filter | undefined)
-			.filter((filter): filter is Item.Filter => !!filter?.enabled)
+			.filter((filter): filter is Item.Filter => !!filter && filter.enabled !== false)
 			.map(filter => ({type: filter.type, params: filter.params}) as FilterSpec)
 		: undefined
 
@@ -63,9 +66,10 @@ export async function sampleVisual(
 		case Kind.Text: {
 			if (!options.allowHandles && (time < 0 || time >= item.duration)) return []
 
-			const style = item.styleId
-				? (ctx.items.get(item.styleId) as Item.TextStyle)?.style
+			const textStyle = item.styleId
+				? ctx.items.get(item.styleId) as Item.TextStyle | undefined
 				: undefined
+			const style = textStyle?.enabled !== false ? textStyle?.style : undefined
 
 			return [{id: item.id, kind: "text", content: item.content, style, matrix, alpha, crop, filters}]
 		}
@@ -81,9 +85,10 @@ export async function sampleVisual(
 			if (!segment)
 				return []
 
-			const style = item.styleId
-				? (ctx.items.get(item.styleId) as Item.TextStyle)?.style
+			const textStyle = item.styleId
+				? ctx.items.get(item.styleId) as Item.TextStyle | undefined
 				: undefined
+			const style = textStyle?.enabled !== false ? textStyle?.style : undefined
 
 			return [{id: item.id, kind: "text", content: segment.text, style, matrix, alpha, crop, filters}]
 		}

package/s/timeline/renderers/parts/samplers/visual/parts/sequence.ts

@@ -53,6 +53,9 @@ function sampleSequenceAt(ctx: SampleContext, seq: Item.Sequence, time: Ms) {
 
 		const localTime = ms(time - cursor)
 
+		if (child.enabled === false)
+			return {isTransitioning: false, item: child, localTime} as const
+
 		if (child.kind !== Kind.Transition)
 			return {isTransitioning: false, item: child, localTime} as const
 

package/s/timeline/renderers/renderers.test.ts

@@ -92,6 +92,21 @@ export default Science.suite({
 		expect(textLayer[0].kind).is("text")
 	}),
 
+	"disabled visual item keeps sequence time but does not render": test(async () => {
+		const {omni, videoA, resolveMedia} = await setupTest()
+		const {timeline} = new O({timeline: omni.timeline(o => o.sequence(
+			o.video(videoA, {duration: 2000, enabled: false}),
+			o.video(videoA, {duration: 2000}),
+		))})
+		const sampler = createVisualSampler(resolveMedia)
+
+		const disabledLayers = await sampler.sample(timeline, ms(1000))
+		expect(disabledLayers.length).is(0)
+
+		const nextLayers = await sampler.sample(timeline, ms(2500))
+		expect(nextLayers[0].kind).is("image")
+	}),
+
 	"audio mix sums overlapping chunks": test(async () => {
 		const mixer = new AudioMix({chunkFrames: 4, clamp: false})
 		async function *samples() {

package/s/timeline/sugar/helpers.ts

@@ -10,7 +10,7 @@ import {filters, FilterParams, FilterType} from "../parts/filters.js"
 import {CaptionOptions, CaptionSourceItem} from "../parts/captions.js"
 import {Transcription} from "../../features/speech/transcribe/types.js"
 import {AnimationPreset, PresetOptions} from "../parts/animations/types.js"
-import {Crop, FilterableItem, Item, ItemMeta, VisualAnimatableItem} from "../parts/item.js"
+import {Crop, FilterableItem, Item, ItemBase, VisualAnimatableItem} from "../parts/item.js"
 import {animationPresets, visualAnimations} from "../parts/animations/registry.js"
 import {Anim, AnimateAction, Interpolation, Keyframes, TrackTransform, Transform, Vec2, VisualAnimationInput, VisualAnimations} from "../types.js"
 
@@ -22,7 +22,7 @@ type BuildPresetAnimateActions = {
 	[TKey in AnimationPreset]: BuildPresetAnimateAction
 }
 type BuildTransitionActions = {
-	[TKey in TransitionName]: (duration: number, options?: ItemMeta) => Build<Item.Transition>
+	[TKey in TransitionName]: (duration: number, options?: ItemBase) => Build<Item.Transition>
 }
 type ContainerInput = [label: string, ...items: Build[]] | Build[]
 
@@ -69,6 +69,7 @@ export function video(
 		start?: number,
 		duration?: number
 		label?: string
+		enabled?: boolean
 	}
 ): Build<Item.Video> {
 	return o => o.video(media, options)
@@ -79,6 +80,7 @@ export function image(
 	options?: {
 		duration?: number
 		label?: string
+		enabled?: boolean
 	}
 ): Build<Item.Image> {
 	return o => o.image(media, options)
@@ -91,6 +93,7 @@ export function audio(
 		duration?: number,
 		gain?: number
 		label?: string
+		enabled?: boolean
 	}
 ): Build<Item.Audio> {
 	return o => o.audio(media, options)
@@ -102,6 +105,7 @@ export function text(
 		duration?: number,
 		styles?: TextStyleOptions
 		label?: string
+		enabled?: boolean
 	}
 ): Build<Item.Text> {
 	return o => o.text(content, options)
@@ -115,7 +119,7 @@ export function captions(
 	return o => o.captions(item(o), transcript, options)
 }
 
-export function gap(duration: number, options?: ItemMeta): Build<Item.Gap> {
+export function gap(duration: number, options?: ItemBase): Build<Item.Gap> {
 	return o => o.gap(duration, options)
 }
 
@@ -249,7 +253,7 @@ export function textStyle(style: TextStyleOptions): Build<Item.TextStyle> {
 
 function makeTransitionActions(): BuildTransitionActions {
 	const entries = Object.keys(transitions)
-		.map(key => [key, (duration: number, options?: ItemMeta) => (o: O) => o.transition[key as TransitionName](duration, options)])
+		.map(key => [key, (duration: number, options?: ItemBase) => (o: O) => o.transition[key as TransitionName](duration, options)])
 	return Object.fromEntries(entries) as BuildTransitionActions
 }
 

package/s/timeline/sugar/o.ts

@@ -6,7 +6,7 @@ import {Id, TimelineFile} from "../parts/basics.js"
 import {FilterAction, FilterActions} from "../parts/filters.js"
 import {filters, FilterParams, FilterType} from "../parts/filters.js"
 import {Transcription} from "../../features/speech/transcribe/types.js"
-import {Crop, FilterableItem, Item, ItemMeta, Kind, VisualAnimatableItem} from "../parts/item.js"
+import {Crop, FilterableItem, Item, ItemBase, Kind, VisualAnimatableItem} from "../parts/item.js"
 import {animationPresets, makeAnimationPresets, visualAnimations} from "../parts/animations/registry.js"
 import {TransitionAction, TransitionActions, transitions, TransitionName} from "../parts/transitions.js"
 import {AnimationPreset, PresetAnimateAction, PresetAnimateActions, PresetAnimation, PresetOptions} from "../parts/animations/types.js"
@@ -52,7 +52,7 @@ export class O {
 		const item = {
 			id: this.getId(),
 			kind: Kind.TextStyle,
-			style
+			style,
 		} as Item.TextStyle
 		this.register(item)
 		return item
@@ -64,7 +64,6 @@ export class O {
   		kind: Kind.Spatial,
   		transform: transform ?? this.transform(),
   		crop,
-  		enabled: true
   	}
 		this.register(item)
   	return item
@@ -75,7 +74,6 @@ export class O {
 			id: this.getId(),
 			kind: Kind.Animation,
 			anims,
-			enabled: true
 		}
 		this.register(item)
 		return item
@@ -136,7 +134,6 @@ export class O {
 				kind: Kind.Filter,
 				type,
 				params,
-				enabled: true
 			}
 			this.register(item)
 			return item
@@ -265,6 +262,7 @@ export class O {
 			start?: number,
 			duration?: number
 			label?: string
+			enabled?: boolean
 		}): Item.Video => {
 
 		if(!media.hasVideo)
@@ -274,6 +272,7 @@ export class O {
 			kind: Kind.Video,
 			id: this.getId(),
 			label: options?.label,
+			enabled: options?.enabled,
 			mediaHash: media.datafile.checksum.hash,
 			start: options?.start ?? 0,
 			duration: options?.duration ?? media.duration
@@ -287,6 +286,7 @@ export class O {
 		options?: {
 			duration?: number
 			label?: string
+			enabled?: boolean
 		}): Item.Image => {
 
 		if(!media.isImage)
@@ -296,6 +296,7 @@ export class O {
 			kind: Kind.Image,
 			id: this.getId(),
 			label: options?.label,
+			enabled: options?.enabled,
 			mediaHash: media.datafile.checksum.hash,
 			duration: options?.duration ?? 2000
 		}
@@ -310,6 +311,7 @@ export class O {
 			duration?: number,
 			gain?: number
 			label?: string
+			enabled?: boolean
 		}): Item.Audio => {
 
 		if(!media.hasAudio)
@@ -319,6 +321,7 @@ export class O {
 			kind: Kind.Audio,
 			id: this.getId(),
 			label: options?.label,
+			enabled: options?.enabled,
 			mediaHash: media.datafile.checksum.hash,
 			start: options?.start ?? 0,
 			duration: options?.duration ?? media.duration,
@@ -332,11 +335,13 @@ export class O {
 			duration?: number,
 			styles?: TextStyleOptions
 			label?: string
+			enabled?: boolean
 		}): Item.Text => {
 
 		const item = {
 			id: this.getId(),
 			label: options?.label,
+			enabled: options?.enabled,
 			content,
 			kind: Kind.Text,
 			duration: options?.duration ?? 2000
@@ -360,6 +365,7 @@ export class O {
 			id: this.getId(),
 			kind: Kind.Caption,
 			label: options?.label,
+			enabled: options?.enabled,
 			transcript,
 			itemId: options?.itemId,
 			start,
@@ -405,11 +411,12 @@ export class O {
 		{presets: this.#makeCaptionPresetActions()}
 	) as CaptionActions
 
-	gap = (duration: number, options?: ItemMeta): Item.Gap => {
+	gap = (duration: number, options?: ItemBase): Item.Gap => {
 		const item = {
 			id: this.getId(),
 			kind: Kind.Gap,
 			label: options?.label,
+			enabled: options?.enabled,
 			duration
 		} as Item.Gap
 		this.register(item)
@@ -417,11 +424,12 @@ export class O {
 	}
 
 	#makeTransition = (key: TransitionName): TransitionAction => {
-		return (duration: number, options?: ItemMeta): Item.Transition => {
+		return (duration: number, options?: ItemBase): Item.Transition => {
 			const item: Item.Transition = {
 				id: this.getId(),
 				kind: Kind.Transition,
 				label: options?.label,
+				enabled: options?.enabled,
 				name: transitions[key].name,
 				duration,
 			}