@omicronenergy/oscd-scl-dialogs 0.0.9 → 0.0.11

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [0.0.11](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/compare/oscd-scl-dialogs-v0.0.10...oscd-scl-dialogs-v0.0.11) (2026-03-04)
+
+
+### Bug Fixes
+
+* for nullable fields prefer value over maybeValue ([d6caf79](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/commit/d6caf79197e6936bcce7f07ab826968db9374452))
+
+## [0.0.10](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/compare/oscd-scl-dialogs-v0.0.9...oscd-scl-dialogs-v0.0.10) (2026-02-16)
+
+
+### Features
+
+* copy in ace-custom-element to avoid scoping torture ([5b9b757](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/commit/5b9b7575f7b0db00175f52ce8f5b53adc4691329))
+
+
+### Bug Fixes
+
+* bundling ace-editor should not cause component scope issues ([769def5](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/commit/769def5eac0c75956e3f20bcb4fb06a379349db9))
+* ldevice updates should only update ldName when correctly set ([042ef2f](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/commit/042ef2f3f1da41f5464e0f1ab26da34faf7550bf))
+
 ## [0.0.9](https://github.com/OMICRONEnergyOSS/oscd-scl-dialogs/compare/oscd-scl-dialogs-v0.0.8...oscd-scl-dialogs-v0.0.9) (2026-02-16)
 
 

package/custom-elements.json

@@ -328,7 +328,7 @@
                 "text": "object"
               },
               "static": true,
-              "default": "{ // Left here for clarity sake. We need to dyn-import this so we have a chance of overriding the customElements.define to prevent // ace-editor from being registered globally and causing issues with other instances of ace-editor in the same document. //'ace-editor': AceEditor, }"
+              "default": "{ // Left here for clarity sake. We need to dyn-import this so we have a chance of overriding the customElements.define to prevent // ace-editor from being registered globally and causing issues with other instances of ace-editor in the same document. 'ace-editor': AceEditor, }"
             },
             {
               "kind": "field",
@@ -367,6 +367,29 @@
                 }
               ]
             },
+            {
+              "kind": "method",
+              "name": "firstUpdated",
+              "privacy": "protected",
+              "return": {
+                "type": {
+                  "text": "void"
+                }
+              },
+              "parameters": [
+                {
+                  "name": "_changedProperties",
+                  "type": {
+                    "text": "PropertyValues"
+                  }
+                }
+              ]
+            },
+            {
+              "kind": "method",
+              "name": "clearSelection",
+              "privacy": "private"
+            },
             {
               "kind": "method",
               "name": "updated",
@@ -394,10 +417,6 @@
               "name": "styles",
               "static": true,
               "default": "css` :host { height: 100%; width: 100%; overflow: auto; } ace-editor { height: 100%; width: 100%; } `"
-            },
-            {
-              "kind": "field",
-              "name": "define"
             }
           ],
           "events": [
@@ -903,6 +922,403 @@
         }
       ]
     },
+    {
+      "kind": "javascript-module",
+      "path": "ace-editor/AceEditor.ts",
+      "declarations": [
+        {
+          "kind": "class",
+          "description": "Custom element Ace code editor",
+          "name": "AceEditor",
+          "members": [
+            {
+              "kind": "field",
+              "name": "_observedAttributes",
+              "type": {
+                "text": "string[]"
+              },
+              "privacy": "private",
+              "static": true,
+              "default": "[]"
+            },
+            {
+              "kind": "field",
+              "name": "_editor",
+              "type": {
+                "text": "Ace.Editor | undefined"
+              },
+              "privacy": "private"
+            },
+            {
+              "kind": "field",
+              "name": "editor",
+              "type": {
+                "text": "Ace.Editor | undefined"
+              },
+              "readonly": true
+            },
+            {
+              "kind": "field",
+              "name": "version",
+              "type": {
+                "text": "{ [key: string]: string }"
+              },
+              "readonly": true
+            },
+            {
+              "kind": "field",
+              "name": "value",
+              "type": {
+                "text": "string | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "mode",
+              "type": {
+                "text": "string | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "theme",
+              "type": {
+                "text": "string | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "tabSize",
+              "type": {
+                "text": "number | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "readonly",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "softTabs",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "wrap",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "valueUpdateMode",
+              "type": {
+                "text": "ValueUpdateMode | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "hideActiveLineHighlight",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "hideGutter",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "hideGutterLineHighlight",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "hidePrintMargin",
+              "type": {
+                "text": "boolean | undefined"
+              }
+            },
+            {
+              "kind": "field",
+              "name": "basePath",
+              "type": {
+                "text": "string | undefined"
+              }
+            },
+            {
+              "kind": "method",
+              "name": "dispatch",
+              "privacy": "private",
+              "return": {
+                "type": {
+                  "text": "void"
+                }
+              },
+              "parameters": [
+                {
+                  "name": "type",
+                  "type": {
+                    "text": "string"
+                  }
+                },
+                {
+                  "name": "detail",
+                  "type": {
+                    "text": "T"
+                  }
+                }
+              ]
+            },
+            {
+              "kind": "field",
+              "name": "initializeEditor",
+              "privacy": "private"
+            },
+            {
+              "kind": "method",
+              "name": "appendStyles",
+              "privacy": "private"
+            },
+            {
+              "kind": "method",
+              "name": "notifyPropertyChanged",
+              "return": {
+                "type": {
+                  "text": "void"
+                }
+              },
+              "parameters": [
+                {
+                  "name": "name",
+                  "type": {
+                    "text": "string"
+                  }
+                }
+              ]
+            },
+            {
+              "kind": "method",
+              "name": "resize",
+              "return": {
+                "type": {
+                  "text": "void"
+                }
+              }
+            },
+            {
+              "kind": "field",
+              "name": "handleChange",
+              "privacy": "private"
+            },
+            {
+              "kind": "field",
+              "name": "handleBlur",
+              "privacy": "private"
+            }
+          ],
+          "events": [
+            {
+              "name": "type",
+              "type": {
+                "text": "CustomEvent"
+              }
+            }
+          ],
+          "superclass": {
+            "name": "HTMLElement"
+          },
+          "customElement": true
+        }
+      ],
+      "exports": [
+        {
+          "kind": "js",
+          "name": "default",
+          "declaration": {
+            "name": "AceEditor",
+            "module": "ace-editor/AceEditor.ts"
+          }
+        }
+      ]
+    },
+    {
+      "kind": "javascript-module",
+      "path": "ace-editor/debounce.ts",
+      "declarations": [
+        {
+          "kind": "function",
+          "name": "debounce",
+          "return": {
+            "type": {
+              "text": "() => Promise<T>"
+            }
+          },
+          "parameters": [
+            {
+              "name": "func",
+              "type": {
+                "text": "(...params: any[]) => T"
+              },
+              "description": "The function to invoke."
+            },
+            {
+              "name": "wait",
+              "default": "0",
+              "description": "The time in milliseconds to wait for idle invocations."
+            }
+          ],
+          "description": "Returns a new function that delays invocations to the original function\nwithin a specified wait period. The last invocation within this time period\ngets invoked. All earlier invocations are ignore."
+        }
+      ],
+      "exports": [
+        {
+          "kind": "js",
+          "name": "debounce",
+          "declaration": {
+            "name": "debounce",
+            "module": "ace-editor/debounce.ts"
+          }
+        }
+      ]
+    },
+    {
+      "kind": "javascript-module",
+      "path": "ace-editor/property-decorators.ts",
+      "declarations": [
+        {
+          "kind": "function",
+          "name": "NotifyAttribute",
+          "parameters": [
+            {
+              "name": "attribute",
+              "optional": true,
+              "type": {
+                "text": "string"
+              },
+              "description": "Override the attribute name to use. If ommitted, the\nproperty name is used (coverted from camelCase, to kebab-case)."
+            }
+          ],
+          "description": "Defines that the target property should be exposed as an attribute, and\nthat changes to the attribute should trigger a `notifyPropertyChanged`\ncallback."
+        },
+        {
+          "kind": "function",
+          "name": "NotifyBooleanAttribute",
+          "parameters": [
+            {
+              "name": "attribute",
+              "optional": true,
+              "type": {
+                "text": "string"
+              },
+              "description": "Override the attribute name to use. If ommitted, the\nproperty name is used (coverted from camelCase, to snake-case)."
+            }
+          ],
+          "description": "Defines that the target property should be exposed as boolean attribute, and\nthat changes to the attribute should trigger a `notifyPropertyChanged`\ncallback."
+        },
+        {
+          "kind": "function",
+          "name": "NotifyNumericAttribute",
+          "parameters": [
+            {
+              "name": "attribute",
+              "optional": true,
+              "type": {
+                "text": "string"
+              },
+              "description": "Override the attribute name to use. If ommitted, the\nproperty name is used (coverted from camelCase, to snake-case)."
+            }
+          ],
+          "description": "Defines that the target property should be exposed as numeric attribute, and\nthat changes to the attribute should trigger a `notifyPropertyChanged`\ncallback."
+        },
+        {
+          "kind": "function",
+          "name": "Notify",
+          "return": {
+            "type": {
+              "text": "(target: NotifyTarget & HTMLElement, key: string) => void"
+            }
+          },
+          "parameters": [
+            {
+              "name": "attribute",
+              "optional": true,
+              "type": {
+                "text": "string"
+              },
+              "description": "Expose the property as an attribute. Note that when\nattribute is specified, this method has the same behavior as\n`NotifyAttribute`."
+            }
+          ],
+          "description": "Defines that the target property should trigger a `notifyPropertyChanged`\ncallback when the property changes."
+        },
+        {
+          "kind": "function",
+          "name": "Alias",
+          "parameters": [
+            {
+              "name": "alias",
+              "type": {
+                "text": "string"
+              },
+              "description": "Name of the alias."
+            }
+          ],
+          "description": "Creates an alias for the given property with a getter and a setter."
+        }
+      ],
+      "exports": [
+        {
+          "kind": "js",
+          "name": "NotifyAttribute",
+          "declaration": {
+            "name": "NotifyAttribute",
+            "module": "ace-editor/property-decorators.ts"
+          }
+        },
+        {
+          "kind": "js",
+          "name": "NotifyBooleanAttribute",
+          "declaration": {
+            "name": "NotifyBooleanAttribute",
+            "module": "ace-editor/property-decorators.ts"
+          }
+        },
+        {
+          "kind": "js",
+          "name": "NotifyNumericAttribute",
+          "declaration": {
+            "name": "NotifyNumericAttribute",
+            "module": "ace-editor/property-decorators.ts"
+          }
+        },
+        {
+          "kind": "js",
+          "name": "Notify",
+          "declaration": {
+            "name": "Notify",
+            "module": "ace-editor/property-decorators.ts"
+          }
+        },
+        {
+          "kind": "js",
+          "name": "Alias",
+          "declaration": {
+            "name": "Alias",
+            "module": "ace-editor/property-decorators.ts"
+          }
+        }
+      ]
+    },
     {
       "kind": "javascript-module",
       "path": "demo/demo-editor-plugin.js",
@@ -921,6 +1337,15 @@
               "static": true,
               "default": "{ 'oscd-text-editor': OscdTextEditor, 'oscd-scl-dialogs': OscdSclDialogs, }"
             },
+            {
+              "kind": "field",
+              "name": "storageKeys",
+              "type": {
+                "text": "object"
+              },
+              "static": true,
+              "default": "{ parentSelector: 'demo-editor-parent-selector', newTagName: 'demo-editor-new-tag-name', tagSelector: 'demo-editor-tag-selector', }"
+            },
             {
               "kind": "field",
               "name": "properties",
@@ -928,7 +1353,7 @@
                 "text": "object"
               },
               "static": true,
-              "default": "{ doc: { type: Object }, docVersion: { type: Number }, editor: { type: Object }, docsState: { type: Object }, editedText: { state: true }, editorDirty: { state: true }, }"
+              "default": "{ doc: { type: Object }, docVersion: { type: Number }, editor: { type: Object }, docsState: { type: Object }, editedText: { state: true }, editorDirty: { state: true }, parentSelectorValue: { state: true }, newTagNameValue: { state: true }, tagSelectorValue: { state: true }, }"
             },
             {
               "kind": "method",
@@ -1025,6 +1450,18 @@
                 "text": "boolean"
               },
               "default": "false"
+            },
+            {
+              "kind": "field",
+              "name": "parentSelectorValue"
+            },
+            {
+              "kind": "field",
+              "name": "newTagNameValue"
+            },
+            {
+              "kind": "field",
+              "name": "tagSelectorValue"
             }
           ],
           "mixins": [
@@ -1059,6 +1496,12 @@
         }
       ]
     },
+    {
+      "kind": "javascript-module",
+      "path": "demo/index.js",
+      "declarations": [],
+      "exports": []
+    },
     {
       "kind": "javascript-module",
       "path": "scripts/update-readme.ts",

package/dist/OscdTextEditor.d.ts

@@ -1,16 +1,6 @@
-import { LitElement, type PropertyValueMap } from 'lit';
-import type * as AceGlobal from 'ace-builds';
-import 'ace-builds/src-noconflict/ace.js';
-import 'ace-builds/src-noconflict/theme-sqlserver.js';
-import 'ace-builds/src-noconflict/mode-xml.js';
-import 'ace-builds/src-noconflict/ext-searchbox.js';
-import type AceEditor from 'ace-custom-element';
+import { LitElement, type PropertyValueMap, PropertyValues } from 'lit';
+import AceEditor from './ace-editor/AceEditor.js';
 import { EditV2 } from '@openscd/oscd-api';
-declare global {
-    interface Window {
-        ace: typeof AceGlobal;
-    }
-}
 export declare function parseXml(xml: string): XMLDocument;
 export declare function serializeXml(xml: XMLDocument | Element): string;
 export declare function formatXml(rawXml: string | undefined, initialIndent?: string): string;
@@ -25,14 +15,17 @@ declare class BaseElement extends BaseElement_base {
  * Intent is to keep this generic so it can be migrated to oscd-ui.
  */
 export default class OscdTextEditor extends BaseElement {
-    static scopedElements: {};
-    constructor();
+    static scopedElements: {
+        'ace-editor': typeof AceEditor;
+    };
     value: string | undefined;
     aceEditor: AceEditor;
     format(): void;
     connectedCallback(): void;
     disconnectedCallback(): void;
     private handleAceChange;
+    protected firstUpdated(_changedProperties: PropertyValues): void;
+    private clearSelection;
     protected updated(changedProps: PropertyValueMap<OscdTextEditor>): void;
     render(): import("lit-html").TemplateResult<1>;
     static styles: import("lit").CSSResult;

package/dist/OscdTextEditor.js

@@ -1,11 +1,8 @@
 import { __decorate } from "tslib";
-import { LitElement, html, css } from 'lit';
+import { LitElement, html, css, } from 'lit';
 import { property, query } from 'lit/decorators.js';
 import { ScopedElementsMixin } from '@open-wc/scoped-elements/lit-element.js';
-import 'ace-builds/src-noconflict/ace.js';
-import 'ace-builds/src-noconflict/theme-sqlserver.js';
-import 'ace-builds/src-noconflict/mode-xml.js';
-import 'ace-builds/src-noconflict/ext-searchbox.js';
+import AceEditor from './ace-editor/AceEditor.js';
 const serializer = new XMLSerializer();
 const parser = new DOMParser();
 const ACE_DEFAULT_OPTIONS = {
@@ -132,24 +129,11 @@ class BaseElement extends ScopedElementsMixin(LitElement) {
  * Intent is to keep this generic so it can be migrated to oscd-ui.
  */
 class OscdTextEditor extends BaseElement {
-    constructor() {
-        super();
-        // Special handling to prevent ace-editor from being registered globally, which would cause issues with multiple instances in the same document.
-        // This will all go away once the oscd-ui version is implemented and this project is migrated to oscd-ui
-        const customElementsDefineFn = window.customElements.define;
-        window.customElements.define = (name, constructor) => {
-            if (name !== 'ace-editor') {
-                return customElementsDefineFn(name, constructor);
-            }
-        };
-        import('ace-custom-element').then(AceEditor => {
-            if (!this.registry?.get('ace-editor')) {
-                this.registry?.define('ace-editor', AceEditor.default);
-            }
-        });
-    }
     format() {
-        const rawXml = this.aceEditor?.editor?.getSelectedText() || this.aceEditor.value;
+        const rawXml = this.aceEditor?.editor?.getSelectedText() ||
+            this.aceEditor.editor?.getValue() ||
+            this.value ||
+            '';
         let initialIndent = '';
         if (this.aceEditor?.editor?.getSelectedText()) {
             const range = this.aceEditor.editor.getSelectionRange();
@@ -186,16 +170,32 @@ class OscdTextEditor extends BaseElement {
             }));
         }
     }
+    firstUpdated(_changedProperties) {
+        this.clearSelection();
+    }
+    clearSelection() {
+        // Clear selection when content updates
+        setTimeout(() => {
+            /* For reasons unknown the ace editor initially selects all code, so we need to clear that*/
+            const editor = this.aceEditor.editor;
+            if (editor) {
+                editor.selection.clearSelection();
+                editor.moveCursorTo(0, 0);
+            }
+        }, 100);
+    }
     updated(changedProps) {
         if (changedProps.has('value')) {
-            // Clear selection when content updates
-            setTimeout(() => {
-                if (this.aceEditor?.editor) {
-                    /* For reasons unknown the ace editor initially selects all code, so we need to clear that*/
-                    this.aceEditor.editor.selection.clearSelection();
-                    this.aceEditor.editor.moveCursorTo(0, 0);
-                }
-            }, 10);
+            const editor = this.aceEditor.editor;
+            if (!editor) {
+                return;
+            }
+            // Only update if content actually changed (prevents cursor jump)
+            // if (editor.getValue() !== this.value) {
+            //   editor.setValue(this.value ?? '');
+            // }
+            editor.selection.clearSelection();
+            editor.moveCursorTo(0, 0);
         }
     }
     render() {
@@ -213,9 +213,9 @@ class OscdTextEditor extends BaseElement {
     }
 }
 OscdTextEditor.scopedElements = {
-// Left here for clarity sake. We need to dyn-import this so we have a chance of overriding the customElements.define to prevent
-// ace-editor from being registered globally and causing issues with other instances of ace-editor in the same document.
-//'ace-editor': AceEditor,
+    // Left here for clarity sake. We need to dyn-import this so we have a chance of overriding the customElements.define to prevent
+    // ace-editor from being registered globally and causing issues with other instances of ace-editor in the same document.
+    'ace-editor': AceEditor,
 };
 OscdTextEditor.styles = css `
     :host {