@omg-dev/server 0.4.28 → 0.4.29

package/dist/index.mjs

@@ -1496,9 +1496,10 @@ async function registerTriggers(entries) {
 			storageHookHandlers.get(e.kind).add(e.handler);
 		}
 	}
-	const inProcessCron = vibesMode$1() === "dev" || cronDriver() === "in-process";
+	const inBuild = inBuildMode();
+	const inProcessCron = !inBuild && (vibesMode$1() === "dev" || cronDriver() === "in-process");
 	if (inProcessCron) scheduleAllCronInProcess();
-	console.log(`[vibes:triggers] registered ${entries.length} trigger(s) — mode=${vibesMode$1()}, cron=${inProcessCron ? "in-process" : "orchestrator"}`);
+	console.log(`[vibes:triggers] registered ${entries.length} trigger(s) — mode=${vibesMode$1()}, cron=${inBuild ? "unarmed (build)" : inProcessCron ? "in-process" : "orchestrator"}`);
 }
 /** Snapshot of the registry — used by the in-dev Inspect endpoints. */
 function listTriggers() {
@@ -1907,6 +1908,9 @@ function vibesMode$1() {
 	_vibesMode$1 = ((typeof process !== "undefined" ? process.env?.VIBES_MODE : void 0) ?? "") === "dev" ? "dev" : "prod";
 	return _vibesMode$1;
 }
+function inBuildMode() {
+	return (typeof process !== "undefined" ? process.env?.VIBES_BUILD : void 0) === "1";
+}
 function devInspectTriggers() {
 	return Array.from(triggerRegistry.values()).map(({ entry }, i) => ({
 		id: `trg_dev_${i}_${entry.handler}`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@omg-dev/server",
-  "version": "0.4.28",
+  "version": "0.4.29",
   "type": "module",
   "exports": {
     ".": {
@@ -14,9 +14,9 @@
   },
   "dependencies": {
     "@restatedev/restate-sdk": "1.14.5",
-    "@omg-dev/auth": "0.4.28",
-    "@omg-dev/schema": "0.4.28",
-    "@omg-dev/stream": "0.4.28",
+    "@omg-dev/auth": "0.4.29",
+    "@omg-dev/schema": "0.4.29",
+    "@omg-dev/stream": "0.4.29",
     "web-push": "^3.6.7"
   },
   "scripts": {

package/src/test/build-mode-cron.test.ts

@@ -0,0 +1,80 @@
+// Regression test for the vibes-build hang (confirmed: `[vibes-build] done.`
+// prints, process never exits when the project declares cron()/on()).
+//
+// Root cause: registerTriggers() arms an in-process setTimeout chain for
+// every cron() handler whenever vibesMode()==="dev" or cronDriver()===
+// "in-process" — including when createVibesServer() is constructed by the
+// vibes vite-plugin's configureServer hook, which prerenderApp() (part of
+// `vibes-build`) triggers indirectly via a nested Vite dev server. Those
+// timers keep the event loop alive forever with no caller left to clear
+// them, since a build process has no request loop to eventually close it.
+//
+// This can only be observed as a live-process behavior (does the process
+// exit on its own?), not through a return-value assertion on
+// registerTriggers() — so this test spawns a real Bun subprocess and checks
+// whether it terminates within a bounded window.
+
+import { describe, expect, test } from "bun:test"
+import fs from "node:fs"
+import os from "node:os"
+import path from "node:path"
+
+const triggersModulePath = path.join(import.meta.dir, "..", "triggers.ts")
+
+function writeRegisterScript(): string {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), "vibes-build-mode-cron-"))
+  const file = path.join(dir, "register.ts")
+  fs.writeFileSync(
+    file,
+    [
+      `import { registerTriggers } from ${JSON.stringify(triggersModulePath)}`,
+      "await registerTriggers([",
+      '  { handler: "trg.tick", kind: "cron", key: "* * * * *", module: "/dev/null", exportName: "tick", mod: { tick: async () => {} } },',
+      '  { handler: "trg.onEvt", kind: "on", key: "some.topic", module: "/dev/null", exportName: "onEvt", mod: { onEvt: async () => {} } },',
+      "])",
+      'console.log("REGISTERED")',
+      "",
+    ].join("\n"),
+  )
+  return file
+}
+
+// Runs `script` in a fresh Bun subprocess with `env` merged over the current
+// process env. Resolves `{ exited: true }` if the process exits within
+// `timeoutMs` on its own, or `{ exited: false }` (after force-killing it) if
+// it's still alive at the deadline — the exact symptom of the original bug.
+async function runAndWaitForExit(
+  script: string,
+  env: Record<string, string>,
+  timeoutMs: number,
+): Promise<{ exited: boolean }> {
+  const proc = Bun.spawn(["bun", "run", script], {
+    env: { ...process.env, ...env },
+    stdout: "pipe",
+    stderr: "pipe",
+  })
+  let timedOut = false
+  const timer = setTimeout(() => {
+    timedOut = true
+    proc.kill()
+  }, timeoutMs)
+  await proc.exited
+  clearTimeout(timer)
+  return { exited: !timedOut }
+}
+
+describe("registerTriggers build-mode cron gating", () => {
+  test("VIBES_BUILD=1: a cron()+on() project terminates on its own", async () => {
+    const script = writeRegisterScript()
+    const { exited } = await runAndWaitForExit(script, { VIBES_BUILD: "1", VIBES_MODE: "dev" }, 8000)
+    expect(exited).toBe(true)
+  }, 15000)
+
+  test("sanity: without VIBES_BUILD, dev-mode cron is still armed (stays alive)", async () => {
+    // Mirrors the fixed case above to prove the guard is scoped to build
+    // mode only — normal `bun dev` cron scheduling must be unaffected.
+    const script = writeRegisterScript()
+    const { exited } = await runAndWaitForExit(script, { VIBES_MODE: "dev" }, 2000)
+    expect(exited).toBe(false)
+  }, 15000)
+})

package/src/triggers.ts

@@ -242,12 +242,20 @@ export async function registerTriggers(entries: TriggerEntry[]): Promise<void> {
     }
   }
   void registeredFirstTime // suppress unused — kept for future HMR diff
-  const inProcessCron = vibesMode() === "dev" || cronDriver() === "in-process"
+  // vibes-build sets VIBES_BUILD=1 for its whole process, including the
+  // nested Vite dev server it spins up for prerender SSG. A build is not a
+  // runtime — nothing should ever arm a live setTimeout chain there, or the
+  // process hangs forever after writing its artifacts (confirmed hang: cron
+  // schedulers keep the event loop open with no caller left to clear them).
+  const inBuild = inBuildMode()
+  const inProcessCron = !inBuild && (vibesMode() === "dev" || cronDriver() === "in-process")
   if (inProcessCron) {
     scheduleAllCronInProcess()
   }
   console.log(
-    `[vibes:triggers] registered ${entries.length} trigger(s) — mode=${vibesMode()}, cron=${inProcessCron ? "in-process" : "orchestrator"}`,
+    `[vibes:triggers] registered ${entries.length} trigger(s) — mode=${vibesMode()}, cron=${
+      inBuild ? "unarmed (build)" : inProcessCron ? "in-process" : "orchestrator"
+    }`,
   )
 }
 
@@ -810,6 +818,15 @@ function vibesMode(): "dev" | "prod" {
   return _vibesMode
 }
 
+// Set for the whole lifetime of `vibes-build` (packages/vite-plugin/src/build.ts).
+// A build process has no caller left to clear timers once it "finishes" —
+// so cron must never be armed in-process while this is set, however
+// createVibesServer() got invoked (directly, or via prerender's nested dev
+// server).
+function inBuildMode(): boolean {
+  return (typeof process !== "undefined" ? process.env?.VIBES_BUILD : undefined) === "1"
+}
+
 // ── Dev Inspect data accessors ───────────────────────────────────────────────
 //
 // In dev mode, the dashboard's Inspect tabs read the in-memory rings