@omercnet/paseo-shared-browser 4.1.1-next.356.1 → 4.1.1-next.358.1

package/README.md

@@ -40,7 +40,7 @@ organization names.
   controller when a takeover is needed, and continues the selected action after control is granted.
   Closing a tab or browser still requires its own confirmation. Actions that need a fresh frame wait
   for one before sending input.
-- The plugin owns `agent-browser` version `0.39.4`, its IPC directory, and the Chromium executable.
+- The plugin owns `agent-browser` version `0.40.0`, its IPC directory, and the Chromium executable.
   It strips inherited `AGENT_BROWSER_*` variables and sets `AGENT_BROWSER_SOCKET_DIR`,
   `AGENT_BROWSER_IDLE_TIMEOUT_MS=0`, `AGENT_BROWSER_STREAM_PORT=0`, and
   `AGENT_BROWSER_NO_AUTO_DIALOG=1` itself.

package/npm-shrinkwrap.json

@@ -10,7 +10,7 @@
       "dependencies": {
         "@getpaseo/plugin": "0.14.0",
         "@modelcontextprotocol/sdk": "1.30.0",
-        "agent-browser": "0.39.4",
+        "agent-browser": "0.40.0",
         "esbuild": "0.28.2",
         "zod": "4.6.7"
       }
@@ -606,9 +606,9 @@
       }
     },
     "node_modules/agent-browser": {
-      "version": "0.39.4",
-      "resolved": "https://registry.npmjs.org/agent-browser/-/agent-browser-0.39.4.tgz",
-      "integrity": "sha512-R0ue5CWlpkGtbcXeq3ZKM96zLrCXkNKEGyttgWhi0eSNKoNSvxglvv1/D9NhKxe+MI+djiCFepPd4PYOM0H2Rg==",
+      "version": "0.40.0",
+      "resolved": "https://registry.npmjs.org/agent-browser/-/agent-browser-0.40.0.tgz",
+      "integrity": "sha512-uqDAR3ozwJKYzVENMr/ZKYTZT1LUZauI49rTiK/KsFBxQDVTdtmrWGWTMWZlaIIQWToEtZUfWVXBSSTY6aHzrA==",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "bin": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@omercnet/paseo-shared-browser",
-  "version": "4.1.1-next.356.1",
+  "version": "4.1.1-next.358.1",
   "description": "One real Chromium session per Paseo workspace, shared live across every connected client.",
   "keywords": [
     "browser",
@@ -57,7 +57,7 @@
   "dependencies": {
     "@getpaseo/plugin": "0.14.0",
     "@modelcontextprotocol/sdk": "1.30.0",
-    "agent-browser": "0.39.4",
+    "agent-browser": "0.40.0",
     "esbuild": "0.28.2",
     "zod": "4.6.7"
   },

package/scripts/prepare-runtime.mjs

@@ -18,7 +18,7 @@ function resolveDependencyRoot(packageName) {
 }
 
 const execFileAsync = promisify(execFile);
-const expectedVersion = "0.39.4";
+const expectedVersion = "0.40.0";
 const hostPlatform = platform();
 const hostArch = arch();
 const projectRoot = dirname(dirname(fileURLToPath(import.meta.url)));

package/server/agent-browser-runtime.ts

@@ -57,7 +57,7 @@ import { createScreencastSourceTime } from "./screencast-source-time";
 import { createVideoSourceRecovery } from "./video-source-recovery";
 
 const execFileAsync = promisify(execFile);
-export const AGENT_BROWSER_VERSION = "0.39.4";
+export const AGENT_BROWSER_VERSION = "0.40.0";
 const PRIVATE_DIRECTORY_MODE = 0o700;
 const PRIVATE_FILE_MODE = 0o600;
 const DEFAULT_TIMEOUT_MS = 15_000;
@@ -379,22 +379,30 @@ export class AgentBrowserRuntime {
     // From here a nonce-owned daemon may exist even if open rejects (e.g. navigation failure).
     this.daemonLaunched = true;
     this.daemon = null;
-    const opened = await this.invoke([
-      "--session",
-      this.session,
-      "--profile",
-      this.profilePath,
-      "--executable-path",
-      this.executablePath,
-      ...(videoExtension ? ["--extension", videoExtension] : []),
-      "--hide-scrollbars",
-      "false",
-      ...(this.headed ? ["--headed"] : []),
-      ...(chromiumArguments ? ["--args", chromiumArguments] : []),
-      "--json",
-      "open",
-      this.initialUrl,
-    ]);
+    let opened: unknown;
+    try {
+      opened = await this.invoke([
+        "--session",
+        this.session,
+        "--profile",
+        this.profilePath,
+        "--executable-path",
+        this.executablePath,
+        ...(videoExtension ? ["--extension", videoExtension] : []),
+        "--hide-scrollbars",
+        "false",
+        ...(this.headed ? ["--headed"] : []),
+        ...(chromiumArguments ? ["--args", chromiumArguments] : []),
+        "--json",
+        "open",
+        this.initialUrl,
+      ]);
+    } catch (error) {
+      // Record the daemon a failed open left behind: since agent-browser 0.40.0 `close`
+      // removes the PID file before returning, after which its exit is unobservable.
+      await this.captureDaemon().catch(() => undefined);
+      throw error;
+    }
     this.assertRuntimeOpen();
     const targetId = findString(opened, ["targetId", "target_id"]);
     await this.protectIpcMetadata();

package/server/daemon-shutdown.test.ts

@@ -1,10 +1,11 @@
 /** The session daemon is signalled only while it is still the exact process this runtime launched. */
 import { type ChildProcess, spawn } from "node:child_process";
+import { rmSync, writeFileSync } from "node:fs";
 import { mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { afterEach, describe, expect, it, vi } from "vitest";
-import { AgentBrowserRuntime } from "./agent-browser-runtime";
+import { AGENT_BROWSER_VERSION, AgentBrowserRuntime } from "./agent-browser-runtime";
 import { RUNTIME_OWNER_VARIABLE } from "./process-identity";
 
 const probe = vi.hoisted(() => ({
@@ -32,20 +33,31 @@ vi.mock("./process-identity", async (importOriginal) => {
   };
 });
 
-const cli = vi.hoisted(() => ({ onClose: null as null | (() => void), closes: 0 }));
+const cli = vi.hoisted(() => ({
+  onClose: null as null | (() => void),
+  closes: 0,
+  /** Set to make `open` fail after its side effect, like a navigation failure. */
+  onOpen: null as null | (() => void),
+  version: "0.37.1",
+}));
 vi.mock("node:child_process", async (importOriginal) => ({
   ...(await importOriginal<typeof import("node:child_process")>()),
   execFile: (
     _file: string,
     args: string[],
     _options: unknown,
-    callback: (error: null, result: { stdout: string }) => void,
+    callback: (error: Error | null, result?: { stdout: string }) => void,
   ) => {
     if (args.includes("close")) {
       cli.closes += 1;
       cli.onClose?.();
     }
-    callback(null, { stdout: args.includes("--version") ? "0.37.1\n" : "{}\n" });
+    if (args.includes("open") && cli.onOpen) {
+      cli.onOpen();
+      callback(new Error("Navigation failed: net::ERR_CONNECTION_REFUSED"));
+      return;
+    }
+    callback(null, { stdout: args.includes("--version") ? `${cli.version}\n` : "{}\n" });
   },
 }));
 
@@ -58,6 +70,8 @@ afterEach(async () => {
   );
   cli.onClose = null;
   cli.closes = 0;
+  cli.onOpen = null;
+  cli.version = "0.37.1";
   probe.unreadable = false;
   probe.simulated = null;
   vi.restoreAllMocks();
@@ -273,6 +287,27 @@ describe.each(ownershipModes)(
       expect(daemon.pid && alive(daemon.pid)).toBe(false);
     });
 
+    it("confirms the exit of a daemon left by a failed open even when close removes its PID file", async () => {
+      const f = await fixture();
+      const daemon = await ownChild(f.native.ownerNonce);
+      own(daemon);
+      const pidFile = join(f.ipc, "owned.pid");
+      cli.version = AGENT_BROWSER_VERSION;
+      // The daemon starts and records its PID, then the initial navigation fails.
+      cli.onOpen = () => writeFileSync(pidFile, String(daemon.pid));
+      // agent-browser >= 0.40.0: close returns only after the daemon removed its PID file.
+      cli.onClose = () => {
+        daemon.kill("SIGTERM");
+        rmSync(pidFile, { force: true });
+      };
+      await expect(f.runtime.launch()).rejects.toThrow("agent-browser command failed");
+      const kill = vi.spyOn(process, "kill");
+      await f.runtime.shutdown();
+      await exited(daemon);
+      expect(kill).not.toHaveBeenCalledWith(daemon.pid, "SIGKILL");
+      expect(daemon.pid && alive(daemon.pid)).toBe(false);
+    });
+
     it("shares one in-flight shutdown and never reports success after a failed one", async () => {
       const f = await fixture(150);
       const daemon = await ownChild();

package/server/runtime-launch-environment.test.ts

@@ -23,7 +23,7 @@ vi.mock("node:child_process", () => ({
     callback: (error: null, result: { stdout: string }) => void,
   ) => {
     exec.calls.push({ file, args, env: options.env });
-    callback(null, { stdout: args.includes("--version") ? "0.39.4\n" : "{}\n" });
+    callback(null, { stdout: args.includes("--version") ? "0.40.0\n" : "{}\n" });
   },
 }));
 

package/server/runtime-video-opt-in.test.ts

@@ -15,7 +15,7 @@ vi.mock("node:child_process", async (importOriginal) => ({
     _args: string[],
     _options: unknown,
     callback: (error: null, result: { stdout: string }) => void,
-  ) => callback(null, { stdout: "0.39.4\n" }),
+  ) => callback(null, { stdout: "0.40.0\n" }),
 }));
 
 const temporary: string[] = [];