@omercnet/paseo-omp 0.3.0-next.100.1 → 0.3.0-next.101.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@omercnet/paseo-omp",
-  "version": "0.3.0-next.100.1",
+  "version": "0.3.0-next.101.1",
   "type": "module",
   "description": "Paseo integration for OMP, including its direct provider and workspace tooling.",
   "license": "MIT",

package/server/provider/omp-rpc.ts

@@ -1303,6 +1303,7 @@ export interface OmpPersistedSessionMessages {
   nativeSessionId: string;
   byteLength: number;
   messages: OmpMessage[];
+  imageReplayWarning?: true;
 }
 
 export interface OmpStartOptions {

package/server/provider/session-descriptors.ts

@@ -4,6 +4,7 @@ import { type FileHandle, lstat, open, opendir, realpath } from "node:fs/promise
 import { homedir } from "node:os";
 import { basename, dirname, extname, isAbsolute, join, resolve } from "node:path";
 import { ompSessionDir } from "../paths";
+import { isValidImagePayload } from "./image";
 
 const MAX_DESCRIPTOR_PREFIX_BYTES = 64 * 1024;
 const MAX_DESCRIPTOR_SUFFIX_BYTES = 64 * 1024;
@@ -48,6 +49,7 @@ export interface OmpPersistedSessionTranscript {
   nativeSessionId: string;
   byteLength: number;
   messages: unknown[];
+  imageReplayWarning?: true;
 }
 export interface OmpSessionListOptions {
   cwd?: string;
@@ -66,6 +68,11 @@ interface ScanBudget {
   exhausted: boolean;
 }
 
+interface BlobReplayBudget {
+  bytes: number;
+  imageReplayWarning?: true;
+}
+
 export function validateNativeSessionId(value: unknown): string {
   if (typeof value !== "string" || !NATIVE_SESSION_ID.test(value)) {
     throw new Error("Invalid OMP session identifier");
@@ -156,6 +163,7 @@ async function yieldToEventLoop(): Promise<void> {
   setImmediate(result.resolve);
   await result.promise;
 }
+const UNAVAILABLE_IMAGE_MARKER = "[Image unavailable during session replay]";
 async function readStableFile(
   handle: FileHandle,
   byteLength: number,
@@ -213,6 +221,7 @@ async function hydrateBlobImageData(
     ) {
       throw new Error("OMP transcript image blob failed ownership or size validation");
     }
+    budget.bytes += stat.size;
     const bytes = await readStableFile(
       handle,
       stat.size,
@@ -222,7 +231,6 @@ async function hydrateBlobImageData(
     if (createHash("sha256").update(bytes).digest("hex") !== hash) {
       throw new Error("OMP transcript image blob failed integrity validation");
     }
-    budget.bytes += bytes.byteLength;
     return bytes.toString("base64");
   } finally {
     await handle.close().catch(() => undefined);
@@ -232,11 +240,13 @@ async function hydrateBlobImageData(
 async function hydrateImageParts(
   value: unknown,
   blobDirectory: string,
-  budget: { bytes: number },
+  budget: BlobReplayBudget,
+  failureMode: "marker" | "omit",
   signal?: AbortSignal,
 ): Promise<unknown> {
   if (!Array.isArray(value)) return value;
   let hydrated: unknown[] | undefined;
+  let omitted: boolean[] | undefined;
   for (let index = 0; index < value.length; index += 1) {
     const part = value[index];
     if (
@@ -251,30 +261,53 @@ async function hydrateImageParts(
     ) {
       continue;
     }
-    const data = await hydrateBlobImageData(part.data, blobDirectory, budget, signal);
-    hydrated ??= [...value];
-    hydrated[index] = { ...part, data };
+    try {
+      const data = await hydrateBlobImageData(part.data, blobDirectory, budget, signal);
+      const mimeType = "mimeType" in part ? part.mimeType : undefined;
+      if (typeof mimeType !== "string" || !isValidImagePayload(data, mimeType, data.length)) {
+        throw new Error("OMP transcript image blob failed MIME validation");
+      }
+      hydrated ??= [...value];
+      hydrated[index] = { ...part, data };
+    } catch {
+      signal?.throwIfAborted();
+      budget.imageReplayWarning = true;
+      hydrated ??= [...value];
+      if (failureMode === "marker") {
+        hydrated[index] = { type: "text", text: UNAVAILABLE_IMAGE_MARKER };
+      } else {
+        omitted ??= [];
+        omitted[index] = true;
+      }
+    }
   }
-  return hydrated ?? value;
+  if (!hydrated) return value;
+  return omitted ? hydrated.filter((_, index) => !omitted[index]) : hydrated;
 }
 
 async function hydratePersistedMessageImages(
   message: unknown,
   blobDirectory: string | undefined,
-  budget: { bytes: number },
+  budget: BlobReplayBudget,
   signal?: AbortSignal,
 ): Promise<unknown> {
   if (!blobDirectory || !message || typeof message !== "object" || Array.isArray(message)) {
     return message;
   }
   const record = message as Record<string, unknown>;
-  let content = await hydrateImageParts(record.content, blobDirectory, budget, signal);
+  let content = await hydrateImageParts(record.content, blobDirectory, budget, "marker", signal);
   if (content && typeof content === "object" && !Array.isArray(content)) {
     const contentRecord = content as Record<string, unknown>;
-    const nested = await hydrateImageParts(contentRecord.content, blobDirectory, budget, signal);
+    const nested = await hydrateImageParts(
+      contentRecord.content,
+      blobDirectory,
+      budget,
+      "marker",
+      signal,
+    );
     if (nested !== contentRecord.content) content = { ...contentRecord, content: nested };
   }
-  const images = await hydrateImageParts(record.images, blobDirectory, budget, signal);
+  const images = await hydrateImageParts(record.images, blobDirectory, budget, "omit", signal);
   if (content === record.content && images === record.images) return message;
   return { ...record, content, images };
 }
@@ -620,7 +653,7 @@ export async function readOmpPersistedSessionTranscript(
       throw new Error("OMP session transcript exceeds message limits");
     }
     const hydratedMessages: unknown[] = [];
-    const blobBudget = { bytes: 0 };
+    const blobBudget: BlobReplayBudget = { bytes: 0 };
     for (const message of messages) {
       signal?.throwIfAborted();
       hydratedMessages.push(
@@ -632,6 +665,7 @@ export async function readOmpPersistedSessionTranscript(
       nativeSessionId,
       byteLength: bytes.byteLength,
       messages: hydratedMessages,
+      ...(blobBudget.imageReplayWarning ? { imageReplayWarning: true as const } : {}),
     };
   } catch (error) {
     if (error instanceof Error) throw error;

package/server/provider/session.ts

@@ -1592,6 +1592,18 @@ export class OmpProviderSession {
             replay.signal,
           );
           messages = transcript.messages;
+          if (transcript.imageReplayWarning) {
+            this.emit({
+              type: "timeline.item",
+              sessionId: this.id,
+              item: {
+                id: "omp:replay-image-unavailable",
+                type: "notification",
+                level: "warning",
+                message: "OMP skipped one or more unavailable images while replaying this session.",
+              },
+            });
+          }
         } catch (error) {
           if (replay.signal.aborted) throw error;
           this.emit({