@omen.foundation/node-microservice-runtime 0.1.63 → 0.1.65

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@omen.foundation/node-microservice-runtime",
-  "version": "0.1.63",
+  "version": "0.1.65",
   "description": "Beamable microservice runtime for Node.js/TypeScript services.",
   "type": "module",
   "main": "dist/index.js",

package/src/collector-manager.ts

@@ -1049,14 +1049,41 @@ export function getCollectorProcessStatus(): {
   startError: string | null;
   initError: string | null;
   stderr: string[];
+  isPreInstalled?: boolean;
+  binaryPath?: string | null;
+  configPath?: string | null;
 } {
+  // Check if collector is actually running successfully - if so, clear stale initError
+  const processAlive = globalCollectorProcess !== null && 
+                       globalCollectorProcess.exitCode === null && 
+                       globalCollectorProcess.killed === false;
+  
+  const stderrText = globalCollectorStderr.join('\n');
+  const isReady = stderrText.includes('Everything is ready') || 
+                 stderrText.includes('Begin running and processing data');
+  
+  // If collector is running and ready, clear stale initError (might be from failed download attempt)
+  // The error could be from an initial download attempt that failed, but collector started successfully using pre-installed binary
+  const actualInitError = (processAlive && isReady) ? null : globalCollectorInitError;
+  
+  // Check if collector binary is pre-installed
+  const basePath = getCollectorStoragePath();
+  const binaryName = getCollectorBinaryName();
+  const configName = 'clickhouse-config.yaml';
+  const binaryPath = join(basePath, binaryName);
+  const configPath = join(basePath, configName);
+  const isPreInstalled = existsSync(binaryPath) && existsSync(configPath);
+  
   return {
     hasProcess: globalCollectorProcess !== null,
     pid: globalCollectorProcess?.pid ?? null,
     exitCode: globalCollectorExitCode,
     startError: globalCollectorStartError,
-    initError: globalCollectorInitError,
+    initError: actualInitError, // Clear if collector is running and ready
     stderr: [...globalCollectorStderr], // Return a copy
+    isPreInstalled,
+    binaryPath: isPreInstalled ? binaryPath : null,
+    configPath: isPreInstalled ? configPath : null,
   };
 }
 

package/src/logger.ts

@@ -562,50 +562,31 @@ export function createLogger(env: EnvironmentConfig, options: LoggerFactoryOptio
       level: 'info',
     }, process.stdout);
     
-    // Create provider synchronously - since endpoint is explicitly provided,
-    // initializeOtlpLogging will skip discovery and create provider directly
-    let provider: LoggerProvider | null = null;
-    let completed = false;
-    
+    // Create OTLP provider asynchronously (non-blocking)
+    // Since endpoint is explicitly provided and collector is already ready,
+    // this should complete quickly, but we don't block for it
     initializeOtlpLogging(
       options.serviceName,
       options.qualifiedServiceName,
       env,
       initLogger
-    ).then((result) => {
-      provider = result;
-      completed = true;
-      if (result) {
+    ).then((provider) => {
+      if (provider) {
+        otlpProviderRef.provider = provider;
         initLogger.info(`[OTLP] OTLP provider created using existing collector at ${options.otlpEndpoint}`);
+        initLogger.info(`[OTLP] OpenTelemetry logging initialized. Endpoint: ${options.otlpEndpoint}/v1/logs, Service: ${options.serviceName || 'unknown'}`);
+      } else {
+        initLogger.warn('[OTLP] OTLP provider creation returned null, structured logs will not be sent via OTLP');
+        otlpProviderRef.provider = null;
       }
     }).catch((error) => {
-      initLogger.error(`[OTLP] Failed to create OTLP provider: ${error instanceof Error ? error.message : String(error)}`);
-      completed = true;
-      provider = null;
-    });
-    
-    // Wait briefly for provider creation (should be very fast, < 1 second)
-    // eslint-disable-next-line @typescript-eslint/no-require-imports
-    const deasync = require('deasync');
-    const startTime = Date.now();
-    const timeout = 2000; // 2 second timeout (should be fast since no discovery needed)
-    
-    deasync.loopWhile(() => {
-      if (Date.now() - startTime >= timeout) {
-        return false;
-      }
-      return !completed;
+      const errorMsg = error instanceof Error ? error.message : String(error);
+      initLogger.error(`[OTLP] Failed to create OTLP provider: ${errorMsg}`);
+      otlpProviderRef.provider = null;
     });
     
-    // CRITICAL: Only set provider if it was successfully created
-    // This ensures structured logs are only created when OTLP is ready
-    if (provider) {
-      otlpProviderRef.provider = provider;
-      initLogger.info(`[OTLP] OpenTelemetry logging initialized. Endpoint: ${options.otlpEndpoint}/v1/logs, Service: ${options.serviceName || 'unknown'}`);
-    } else {
-      initLogger.warn('[OTLP] OTLP provider creation failed, structured logs will not be sent via OTLP');
-      otlpProviderRef.provider = null;
-    }
+    // Don't wait - logger will work immediately with console output,
+    // and OTLP will be added when the provider is ready (very quickly since collector is already running)
     
     // Restore original endpoint if it existed
     if (originalEndpoint !== undefined) {