@oliasoft-open-source/charts-library 2.10.1-beta-1 → 2.10.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oliasoft-open-source/charts-library",
-  "version": "2.10.1-beta-1",
+  "version": "2.10.2",
   "description": "React Chart Library (based on Chart.js and react-chart-js-2)",
   "homepage": "https://gitlab.com/oliasoft-open-source/charts-library",
   "bugs": {
@@ -39,16 +39,17 @@
     "chartjs-plugin-zoom": "^1.2.1",
     "classnames": "^2.3.1",
     "fraction.js": "^4.2.0",
-    "less-vars-to-js": "^1.3.0",
+    "lodash": "^4",
     "react-base64-downloader": "^2.1.7",
-    "react-chartjs-2": "^4.3.1"
+    "react-chartjs-2": "^4.3.1",
+    "react-icons": "^4"
   },
   "devDependencies": {
     "@babel/core": "^7.18.13",
     "@babel/eslint-parser": "^7.18.9",
     "@babel/preset-env": "^7.18.10",
     "@babel/preset-react": "^7.18.6",
-    "@oliasoft-open-source/react-ui-library": "^3",
+    "@oliasoft-open-source/react-ui-library": "3.3.11-beta-1",
     "@oliasoft-open-source/units": "^2",
     "@storybook/addon-actions": "^6.5.10",
     "@storybook/addon-docs": "^6.5.10",
@@ -86,7 +87,6 @@
     "prop-types": "^15",
     "react": "^17",
     "react-dom": "^17",
-    "react-icons": "^4",
     "storybook-dark-mode": "^1.1.0",
     "terser-webpack-plugin": "^5.3.6",
     "webpack": "^5.74.0",
@@ -100,7 +100,6 @@
     "immer": "^9",
     "prop-types": "^15",
     "react": "^17",
-    "react-dom": "^17",
-    "react-icons": "^4"
+    "react-dom": "^17"
   }
 }

package/release-notes.md

@@ -1,5 +1,9 @@
 # Charts Library Release Notes
 
+## 2.10.2
+
+- remove dead `less-vars-to-js` package ([OW-11017](https://oliasoft.atlassian.net/browse/OW-11017))
+
 ## 2.10.1
 
 - Use `peerDependencies` for common versions of shared packages like `units` and `react-ui-library` so reduce double

package/src/style/shared.less

@@ -1,10 +1,7 @@
 /*
- This file has shared variables that are re-used:
-   - in other LESS files/modules
-   - in JavaScript, via https://www.npmjs.com/package/less-vars-to-js
-
+ This file has shared variables that are re-used in other LESS files/modules
  Only use simple variables in this file
- */
+*/
 
 // Brand guidelines
 @colorPrimary: #eb6429;
@@ -12,13 +9,3 @@
 @colorWarning: #e2bd27;
 @colorSuccess: #3bbb3b;
 @colorInfo: #29a7eb;
-
-/*
-  Allow the parent project to optionally override the primary colour palette
-  by having an `override.less` file in its root directory
- */
-@import (optional) '../../../../override.less';
-
-/*
-  Other shared variables
- */

package/src/helpers/styles.js

@@ -1,68 +0,0 @@
-/*
-  This helper allows us to export simple LESS variables as JavaScript objects.
-  The intention is for keeping code DRY by allowing primary colour palettes etc
-  to be defined in one place only (LESS).
-
-  These simple variables should be defined in a files called `shared.less` that
-  can exist in one of two place:
-
-  - in `override.less` in the root of the parent project
-      (to allow overriding of the default values set in this project)
-  - in `src/style/shared.less in this project (default values)
-
-  The parent and local definitions are merged, with the parent taking
-  precedence.
-
-  The implementation uses Webpack raw-loader to load the shared LESS variables
-  file, and a 3rd party package (less-vars-to-js) to parse it, so they can be
-  exported for use in JavaScript.
-
-  When we upgrade to Webpack 5, we'll have to refactor this to use asset modules
-  instead.
- */
-
-import lessToJs from 'less-vars-to-js';
-
-// eslint-disable-next-line import/no-unresolved,import/no-webpack-loader-syntax
-import lessVariables from '../style/shared.less?raw';
-
-/*
-  We need to import the `shared.less` file from the root of the parent project
-  conditionally (it may not exist). Would love to use ES6 imports here, but they
-  don't allow optional files without throwing an error when the file doesn't
-  exist. ES6 dynamic imports would require `async` when we use this helper
-  (prefer to avoid that). So falling back to CommonJS require here.
-
-  Hopefully this will get better once we have Webpack 5 asset modules.
- */
-let lessParentVariables = '{}';
-try {
-  const parentPath = '../../../../override.less?raw';
-  // eslint-disable-next-line import/no-unresolved,global-require,import/no-webpack-loader-syntax,import/no-dynamic-require
-  lessParentVariables = require(`${parentPath}`).default;
-} catch (e) {
-  //do nothing (we fallback to the local definition anyway)
-}
-
-const load = () => {
-  /*
-    Merge the parent project shared.less with the local shared.less
-    (since less-vars-to-js doesn't handle import statements for us)
-
-    The parent definition takes precedence over the local definition
-   */
-  const parent = lessToJs(lessParentVariables, {
-    resolveVariables: true,
-    stripPrefix: true,
-  });
-  const local = lessToJs(lessVariables, {
-    resolveVariables: true,
-    stripPrefix: true,
-  });
-  return {
-    ...local,
-    ...parent,
-  };
-};
-
-export const styleVariables = load();