@olenbetong/appframe-ds 1.3.1 → 1.3.3

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @olenbetong/appframe-ds
 
+## 1.3.3
+
+### Patch Changes
+
+- Updated dependencies [04ff05a]
+  - @olenbetong/appframe-core@2.15.1
+  - @olenbetong/appframe-data@1.7.4
+  - @olenbetong/appframe-react@2.2.4
+
+## 1.3.2
+
+### Patch Changes
+
+- 48e6ac8: The filter builder adds the seconds to datetime values, which the datetime input leaves out. SQL Server rejected the value without them with "Conversion failed when converting date and/or time from character string".
+- Updated dependencies [a63831a]
+  - @olenbetong/appframe-core@2.15.0
+  - @olenbetong/appframe-react@2.2.3
+  - @olenbetong/appframe-data@1.7.3
+
 ## 1.3.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@olenbetong/appframe-ds",
-  "version": "1.3.1",
+  "version": "1.3.3",
   "description": "Components that bind Designsystemet components to Appframe data objects",
   "type": "module",
   "types": "./es/index.d.ts",
@@ -63,9 +63,9 @@
     "@atlaskit/pragmatic-drag-and-drop": "3.1.0",
     "@atlaskit/pragmatic-drag-and-drop-hitbox": "2.2.2",
     "@base-ui/react": "1.8.0",
-    "@olenbetong/appframe-core": "2.14.0",
-    "@olenbetong/appframe-data": "1.7.2",
-    "@olenbetong/appframe-react": "2.2.2",
+    "@olenbetong/appframe-core": "2.15.1",
+    "@olenbetong/appframe-data": "1.7.4",
+    "@olenbetong/appframe-react": "2.2.4",
     "clsx": "^2.1.1",
     "dockview-react": "8.3.1",
     "localforage": "^1.10.0",

package/src/filter/FilterEditor.test.tsx

@@ -1,5 +1,5 @@
 import type { FieldMetadata, FilterExpression, FilterTree } from "@olenbetong/appframe-core";
-import { render, screen } from "@testing-library/react";
+import { fireEvent, render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { describe, expect, it, vi } from "vitest";
 
@@ -131,6 +131,32 @@ describe("FilterEditor", () => {
 		expect(firstExpression(onChange)).toMatchObject({ value: "Yesterday", valueType: "special" });
 	});
 
+	it("adds the seconds a datetime input leaves out", () => {
+		let onChange = vi.fn();
+		render(
+			<FilterEditor fields={FIELDS} value={filterWith("Created", "equals", "", "datetime")} onChange={onChange} />,
+		);
+
+		fireEvent.change(screen.getByLabelText("Value"), { target: { value: "2026-09-25T00:00" } });
+
+		expect(firstExpression(onChange)).toMatchObject({ value: "2026-09-25T00:00:00" });
+	});
+
+	it("adds the seconds to both ends of a datetime range", () => {
+		let onChange = vi.fn();
+		render(
+			<FilterEditor
+				fields={FIELDS}
+				value={filterWith("Created", "between", ["2026-09-01T00:00:00", ""], "datetime")}
+				onChange={onChange}
+			/>,
+		);
+
+		fireEvent.change(screen.getByLabelText("To"), { target: { value: "2026-09-30T23:59" } });
+
+		expect(firstExpression(onChange)).toMatchObject({ value: ["2026-09-01T00:00:00", "2026-09-30T23:59:00"] });
+	});
+
 	it("does not offer relative values for numbers", () => {
 		render(<FilterEditor fields={FIELDS} value={filterWith("Age", "equals", "1", "number")} />);
 

package/src/filter/FilterValueEditor.tsx

@@ -47,6 +47,25 @@ function toStringValue(value: FilterExpression["value"]): string {
 	return String(value);
 }
 
+/**
+ * A `datetime-local` input reports `2026-09-25T00:00`, leaving out the seconds
+ * when they are zero. The value reaches SQL Server as a string, and SQL Server
+ * only accepts the ISO 8601 form with a `T` when the seconds are present, so
+ * the filter fails with "Conversion failed when converting date and/or time
+ * from character string" unless they are added.
+ */
+function withSeconds(value: string): string {
+	return /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}$/.test(value) ? `${value}:00` : value;
+}
+
+function toFilterValue(value: FilterExpression["value"], inputType: string): FilterExpression["value"] {
+	if (inputType !== "datetime-local") return value;
+	if (typeof value === "string") return withSeconds(value);
+	if (Array.isArray(value)) return value.map((item) => (typeof item === "string" ? withSeconds(item) : item));
+
+	return value;
+}
+
 function toArrayValue(value: FilterExpression["value"], length?: number): string[] {
 	let array = Array.isArray(value) ? value.map(toStringValue) : [];
 	if (length === undefined) return array;
@@ -75,7 +94,7 @@ export function FilterValueEditor({
 	let inputType = getInputType(field);
 
 	function setValue(value: FilterExpression["value"]) {
-		onChange({ ...expression, value });
+		onChange({ ...expression, value: isDynamic ? value : toFilterValue(value, inputType) });
 	}
 
 	function setDynamic(enabled: boolean) {