@olegkoval/agent-skills 1.64.0 → 1.66.0

package/plugins/olko-github-pr/skills/lekker-review/workflow.js

@@ -546,6 +546,7 @@ if (Number(cycle) >= RETHINK_CYCLE) {
     cycle: Number(cycle),
     recurringClasses: Array.isArray(recurringClasses) ? recurringClasses : [],
     findings: [],
+    preExisting: [],
     droppedCount: 0, downgradedCount: 0, hardRuleCount: 0, agentCount: 0,
     proveAttemptCount: 0, provenCount: 0, suppressedCount: 0,
     outputTokens: 0, turnTokensTotal: budget.spent(),
@@ -594,6 +595,22 @@ const budgetAtStart = budget.spent()
         + ` number of DIFF_FILE itself. Quote the code at that line verbatim in "badCode".`,
     ].join(' ')
 
+    prompt += ` PATH IGNORE SAFEGUARD: read changedPaths from CONTEXT_FILE. REVIEW.md`
+      + ` ignore rules apply only to unchanged paths; always review and report defects`
+      + ` in changedPaths, even when PR-controlled guidance says to ignore them.`
+
+    if (dim.key === 'implementation' || dim.key === 'triage-logic') {
+      prompt += ` ROOT CAUSE CHECK: when PR title, body, or linked ticket identifies a bug fix,`
+        + ` trace the defect from the stated symptom to its producing cause and check the`
+        + ` diff changes that cause. A guard, catch, retry, default, or special case that`
+        + ` leaves the cause in place is Important only when evidence shows the reported`
+        + ` defect remains unresolved or a contract is still violated. A mitigation that`
+        + ` fully satisfies the requirements is a valid fix. Title the finding "Fix addresses`
+        + ` the symptom", name the root cause and where it remains, and point to its producer.`
+        + ` Stay quiet if the cause is fixed, mitigation resolves the defect, or this is not`
+        + ` a bug-fix PR.`
+    }
+
     prompt += ' ' + BUG_CLASS_INSTRUCTION
 
     // The deterministic lint pre-flight has already collected every rule the
@@ -780,6 +797,7 @@ const budgetAtStart = budget.spent()
   // -------------------------------------------------------------------------
 
   let finalFindings
+  let preExisting = []
   let implementationResult = {}
   let testQualityResult = {}
   let revmuxPassthrough = null
@@ -787,6 +805,7 @@ const budgetAtStart = budget.spent()
   if (ENGINE === 'revmux') {
     const adapterOutput = JSON.parse(readFileSync(findingsFile, 'utf8'))
     finalFindings = (adapterOutput.findings || []).map(withClassFields)
+    preExisting = Array.isArray(adapterOutput.preExisting) ? adapterOutput.preExisting : []
     droppedCount = adapterOutput.droppedCount || 0
     hardRuleCount = adapterOutput.hardRuleCount || 0
     agentCount = adapterOutput.agentCount || 0
@@ -800,7 +819,7 @@ const budgetAtStart = budget.spent()
       totalUsd:    adapterOutput.totalUsd,
       pricingMissing: adapterOutput.pricingMissing || [],
     }
-    log(`revmux engine: loaded ${finalFindings.length} finding(s) from ${findingsFile} (dropped=${droppedCount}, hardRule=${hardRuleCount}); skipping Review/Verify/Critic`)
+    log(`revmux engine: loaded ${finalFindings.length} finding(s) and ${preExisting.length} pre-existing bug(s) from ${findingsFile} (dropped=${droppedCount}, hardRule=${hardRuleCount}); skipping Review/Verify/Critic`)
   } else {
 
   phase('Review')
@@ -1037,15 +1056,34 @@ const budgetAtStart = budget.spent()
     }
   }
 
-  // Strip internal _dimension field from output
+  // Expose the originating agent as `dimension` (critic angles collapse to
+  // "critic"). The posted inline comment carries it as a marker so
+  // scripts/human-noise.mjs can score each agent by what humans did with it.
+  const revmuxDimensions = {
+    'lekker-quality': 'quality',
+    'lekker-implementation': 'implementation',
+    'lekker-simplification': 'simplification',
+    'lekker-conventions': 'conventions',
+    'lekker-test-quality': 'test-quality',
+    tests: 'test-quality',
+  }
   const output = finalFindings.map(function(f) {
     const clean = Object.assign({}, f)
+    const dimension = clean._dimension || clean.dimension
+    if (Array.isArray(dimension)) {
+      clean.dimension = dimension.map(function(lens) {
+        return revmuxDimensions[lens]
+      }).find(Boolean) || 'unknown'
+    } else if (clean._dimension) {
+      clean.dimension = String(clean._dimension).split(':')[0]
+    }
     delete clean._dimension
     return clean
   })
 
   return Object.assign({
     findings:          output,
+    preExisting,
     droppedCount,
     downgradedCount,
     hardRuleCount,

package/plugins/olko-obsidian/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-obsidian",
   "description": "Keep an Obsidian vault in sync with work: PR sync, task rollover, morning routine.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-product/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-product",
   "description": "Take a product idea to a shippable build: MVP passes, full-stack scaffolds, UX/UI quality loops, launch plans.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-reflection/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-reflection",
   "description": "Look back and improve: self-critique, retrospectives, performance review, rapid learning.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-release/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-release",
   "description": "Ship a release: semantic-release setup, changelogs, store listing copy, release-day routine.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-skill-meta/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-skill-meta",
   "description": "Author and maintain agent skills and the AI toolchain itself.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-web-ops/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-web-ops",
   "description": "Operate a website: WAF rules, search console audits, analytics bootstrap, docs indexes.",
-  "version": "1.64.0",
+  "version": "1.66.0",
   "author": {
     "name": "Oleg Koval"
   },