@olegkoval/agent-skills 1.51.3 → 1.53.0

package/plugins/olko-github-pr/skills/lekker-review/references/artifact-page.md

@@ -38,6 +38,25 @@ All of the following are already in hand after Step 3 of SKILL.md:
 
 ### Claude Code
 
+The subagent RENDERS; the main loop PUBLISHES. Leaf agents run without the
+Artifact tool (a renderer can write the page and then be unable to publish
+it), so never ask the subagent to publish.
+
+**Closer image (main loop, before launching):** when `CLOSER` is set, fetch its
+image so the page can show it inline. The page CSP blocks external images but
+not `data:` URIs.
+
+```bash
+# xkcd: the strip image (`img`); gif: the gif itself (`url`). Cap 500 KB, 10 s.
+curl -sfL --max-time 10 --max-filesize 512000 -o <scratchpad>/closer-img <image url> \
+  && [ "$(wc -c < <scratchpad>/closer-img)" -le 512000 ] \
+  && echo "data:<image/png or image/gif>;base64,$(base64 < <scratchpad>/closer-img | tr -d '\n')" \
+     > <scratchpad>/closer-datauri.txt
+```
+
+Pass `CLOSER_DATAURI_FILE=<scratchpad>/closer-datauri.txt` when that file
+exists; otherwise omit it and the card stays link-only.
+
 Launch exactly ONE `general-purpose` agent, `model: sonnet`, in the
 background. Do not block printing the review on it (see Hard rules).
 
@@ -53,17 +72,12 @@ Read the findings at <findings.json path> and the saved review at
 Write ONE self-contained HTML file to the session scratchpad:
 review-pr-<PR_NUMBER>-<repo-short>.html
 
-Follow the page specification below exactly. Then publish it with the
-Artifact tool using:
-  - favicon: "🥩"   (keep this IDENTICAL on every republish)
-  - title: "Review: <repo-short> #<PR_NUMBER>"
-  - description: <one sentence, e.g. "Living code review for PR #<N> --
-    findings update as commits land">
-  - url: <PREV_ARTIFACT_TARGET>   (include ONLY when the target is a validated
-    http or https URL, so the SAME published artifact updates in place; omit
-    the `url` parameter for null or local-path targets)
+Follow the page specification below exactly. The <title> is
+"Review: <repo-short> #<PR_NUMBER>". CLOSER=<closer JSON, or empty>.
+CLOSER_DATAURI_FILE=<path, or empty>. Do NOT publish the page and do not look
+for an Artifact tool: the caller publishes it.
 
-Return ONLY the resulting artifact URL as your final text. No other output.
+Return ONLY the absolute path of the HTML file as your final text.
 
 --- PAGE SPECIFICATION ---
 <paste Step 3 verbatim here>
@@ -156,6 +170,12 @@ Hard requirements for the HTML page:
 - **Test Quality + Review Cost sections**, mirrored from the review file,
   kept concise (verdict + gaps + cost table; no need to reproduce every
   sentence).
+- **Closer footer** (when the caller passes `CLOSER`): a small last card with
+  the closer's title (or `alt`) as a link to its `url`. When
+  `CLOSER_DATAURI_FILE` is set, read it and render
+  `<img src="<its contents>" alt="<title or alt>">` above the link, at
+  `max-width:100%; height:auto`. Never point `<img>` at an external URL: the
+  CSP blocks it. Skip the card when `CLOSER` is empty.
 - **Layout:** every code block (`badCode`, `fix`, `redOutput`, `testCode`)
   horizontally scrollable within its own container; the page body itself must
   never scroll horizontally. Keep total page weight sane -- plain `<pre>`
@@ -167,7 +187,15 @@ Hard requirements for the HTML page:
 
 ## Step 4 -- Record the artifact target (fresh post-condition)
 
-When the renderer completes:
+When the renderer completes (Claude Code: the subagent returns the HTML path):
+
+1. Read the HTML file in full (the Artifact tool publishes only files that were
+   read), and check that it has a `<title>` and no external `<img src="http`.
+2. Publish with the Artifact tool: `file_path` = that path, `description` = one
+   sentence ("Living code review for PR #<N>; findings update as commits
+   land"), and `url: <PREV_ARTIFACT_TARGET>` ONLY when it is a validated `http`
+   or `https` URL, so the same artifact updates in place. On a first publish
+   add `icon: "review"`; omit `icon` on a republish so the page keeps its icon.
 
 **On success (URL or stable local HTML path returned):**
 1. Append or refresh a `**Artifact:** <target>` line in the saved review file's
@@ -200,5 +228,5 @@ When the renderer completes:
 - Never include secrets or tokens from context. The page contains only what
   the saved review file already contains -- nothing pulled fresh from
   scratchpad context that isn't already in the review.
-- Favicon stays `🥩` forever for this artifact -- never change it on
+- Set the artifact icon only on the first publish; never change it on
   republish.

package/plugins/olko-github-pr/skills/lekker-review/references/codex-workflow.md

@@ -60,6 +60,7 @@ unavailable; do not infer what it meant from prose.
 
 Select dimensions exactly as the Claude workflow does:
 
+- deps: `deps` (single checklist agent; no verifier, no prover)
 - scan: `triage-quality`, `triage-logic`
 - medium/deep: `quality`, `implementation`, `simplification`, `conventions`,
   `test-quality`

package/plugins/olko-github-pr/skills/lekker-review/references/fun.json

@@ -0,0 +1,222 @@
+{
+  "xkcd": [
+    {
+      "num": 1513,
+      "title": "Code Quality",
+      "url": "https://xkcd.com/1513/",
+      "img": "https://imgs.xkcd.com/comics/code_quality.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1695,
+      "title": "Code Quality 2",
+      "url": "https://xkcd.com/1695/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_2.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1833,
+      "title": "Code Quality 3",
+      "url": "https://xkcd.com/1833/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_3.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 2138,
+      "title": "Wanna See the Code?",
+      "url": "https://xkcd.com/2138/",
+      "img": "https://imgs.xkcd.com/comics/wanna_see_the_code.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1597,
+      "title": "Git",
+      "url": "https://xkcd.com/1597/",
+      "img": "https://imgs.xkcd.com/comics/git.png",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 303,
+      "title": "Compiling",
+      "url": "https://xkcd.com/303/",
+      "img": "https://imgs.xkcd.com/comics/compiling.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1296,
+      "title": "Git Commit",
+      "url": "https://xkcd.com/1296/",
+      "img": "https://imgs.xkcd.com/comics/git_commit.png",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 844,
+      "title": "Good Code",
+      "url": "https://xkcd.com/844/",
+      "img": "https://imgs.xkcd.com/comics/good_code.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1739,
+      "title": "Fixing Problems",
+      "url": "https://xkcd.com/1739/",
+      "img": "https://imgs.xkcd.com/comics/fixing_problems.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2347,
+      "title": "Dependency",
+      "url": "https://xkcd.com/2347/",
+      "img": "https://imgs.xkcd.com/comics/dependency.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 979,
+      "title": "Wisdom of the Ancients",
+      "url": "https://xkcd.com/979/",
+      "img": "https://imgs.xkcd.com/comics/wisdom_of_the_ancients.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1700,
+      "title": "New Bug",
+      "url": "https://xkcd.com/1700/",
+      "img": "https://imgs.xkcd.com/comics/new_bug.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2200,
+      "title": "Unreachable State",
+      "url": "https://xkcd.com/2200/",
+      "img": "https://imgs.xkcd.com/comics/unreachable_state.png",
+      "verdicts": [
+        "lgtm"
+      ]
+    }
+  ],
+  "gifs": [
+    {
+      "url": "https://media.giphy.com/media/13zeE9qQNC5IKk/giphy.gif",
+      "alt": "Seal of approval thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/SVDvVbkl359Xwzl3V4/giphy.gif",
+      "alt": "Approved",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/ely3apij36BJhoZ234/giphy.gif",
+      "alt": "Great job otter",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/rMEJyjch7L1tlRlCl3/giphy.gif",
+      "alt": "Cat says ok",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/XdUMQuuiaAEkOUtezd/giphy.gif",
+      "alt": "Animated thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/Qaxd5XpgDWMso/giphy.gif",
+      "alt": "Golden retriever almost has the ball",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/YT95XJOLvY1t2SJgpR/giphy.gif",
+      "alt": "Don't give up, so close",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/NWHBEsCcpuAPiAPMBQ/giphy.gif",
+      "alt": "Almost there, on my way",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/0yqoE9MFpFDNjCY9lr/giphy.gif",
+      "alt": "Rough draft, still thinking",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/yGREGYYecNd3pSrSU6/giphy.gif",
+      "alt": "Design thinking iteration loop",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/hsbwJSHExeC5bVenv7/giphy.gif",
+      "alt": "Work mood, back to work",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/CoND5j6Bn1QZUgm1xX/giphy.gif",
+      "alt": "Sorry, out of order",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/2zdnl4CB3OygOHe1kX/giphy.gif",
+      "alt": "Technical difficulties, not working",
+      "verdicts": [
+        "needs-work"
+      ]
+    }
+  ]
+}

package/plugins/olko-github-pr/skills/lekker-review/references/github-post.md

@@ -30,7 +30,9 @@ Rules:
   review programmatically.
 - Include one comment entry for every Critical and Important finding whose
   `file:line` falls within the diff hunks of this PR (see Step 2 for how to
-  determine commentability).
+  determine commentability). A finding with `line: null` (set by
+  `scripts/validate-lines.mjs` when its quoted code is not in the file) is
+  never an inline comment: list it in the review body instead.
 - **Keep every comment body to 2-4 sentences and under ~700 characters**
   (excluding any suggestion block). Inline comments are read one at a time in a
   narrow column; a long one does not get read, so length actively costs you the
@@ -95,6 +97,11 @@ Rules:
 
   Keep the body itself under ~2,500 characters. If it is longer, the asks are
   buried: cut prose, never cut the numbered asks.
+
+  **Closer:** when `CLOSER` is set (SKILL.md Step 3), append a blank line and
+  `CLOSER.md_github` as the very last lines of the body. It does not count
+  toward the ~2,500-character budget and is exempt from the no-praise rule
+  below, but the em-dash payload check still applies.
 - Do NOT prefix the body with a banner like "## Lekker review". Do NOT praise the
   PR or describe what it does well: no "solid", "handled well", "clean", "nice".
   State the risk and the asks only.

package/plugins/olko-github-pr/skills/lekker-review/references/output-format.md

@@ -23,7 +23,7 @@ Output the review as a markdown response (not via printf). No ANSI escapes.
 **Findings:** <X Critical / Y Important / Z Observations / W Idiomatic>
 **Proofs:** <M proven / N attempted> *(include only when N > 0)*
 **CI:** <✅ All passing | ⚠️ N failing: check-name | ⏳ Pending | N/A>
-**Depth:** <⚡ scan | 🔍 medium | 🔬 deep>
+**Depth:** <📦 deps | ⚡ scan | 🔍 medium | 🔬 deep>
 **Engine:** <workflow | codex | revmux>
 
 ---
@@ -215,7 +215,7 @@ if empty.)*
 ## 💰 Review Cost
 
 ```
-Depth:            <⚡ scan | 🔍 medium | 🔬 deep>
+Depth:            <📦 deps | ⚡ scan | 🔍 medium | 🔬 deep>
 Diff size:        ~<N> lines (~<N> tokens)
 Agents run:       <N total>: <breakdown, e.g. "5 reviewers (sonnet) + 6 verifiers (sonnet) + 2 provers (sonnet) + 1 critic (sonnet)">
 Rule checks:      <N> hard-rule finding(s) validated with rule-specific checks (omit the line when 0)
@@ -228,16 +228,17 @@ Input tokens:     ~<N>  ← estimated: diff tokens × agent passes + context fil
 Cost: ~$<X.XX>  (output actual, input estimated; blended across model tiers below)
 ```
 
-Per-MTok pricing (input/output), verified 2026-07-07 from the claude-api reference; re-check there if models changed. The Claude 5.5 rows and fable-5-1 are not yet on that sheet: they reuse the predecessor-tier rates and must be re-checked:
-- claude-fable-5-1: $10 / $50 (unverified, as claude-fable-5)
-- claude-opus-5-5: $15 / $75 (unverified; copied from the opus-5 rate in pricing.json, not checked)
-- claude-sonnet-5-5: $3 / $15 (unverified)
-- claude-haiku-5-5: $1 / $5 (unverified)
-- claude-fable-5: $10 / $50
-- claude-opus-4-8: $5 / $25
-- claude-sonnet-4-6 / claude-sonnet-5: $3 / $15
+Per-MTok pricing (input/output) - verified 2026-10-15 from the claude-api reference (`shared/models.md`); re-check there if models changed:
+- claude-fable-5-1 / claude-fable-5: $10 / $50
+- claude-opus-5-5: $4 / $20
+- claude-opus-5 / claude-opus-4-8: $5 / $25
+- claude-sonnet-5-5 / claude-sonnet-5: $2 / $10
+- claude-sonnet-4-6: $3 / $15
+- claude-haiku-5-5: $0.10 / $0.50 (prompt <=100K tokens; $0.50 / $2.50 above)
 - claude-haiku-4-5: $1 / $5
 
+The main-loop line uses the session model's rate from this list. When the session model is not listed, say so in the cost block rather than leaving the main loop out silently.
+
 Reviewer agents, verifiers, provers, and the critic all run on sonnet; triage and housekeeping on haiku. Only the main loop (context gathering + this synthesis) runs on the session model: use the session model's actual ID for that tier.
 
 For the Codex engine, use the model and usage metadata actually exposed by the
@@ -250,6 +251,10 @@ The hard rule against `<N>` placeholders still applies. When usage is exposed,
 report the real values and use an official or operator-configured pricing source,
 naming its date in the block.
 
+## 🎲 Closer
+
+<CLOSER.md_github verbatim. Omit this whole section when CLOSER is empty (--no-fun, or the picker printed nothing).>
+
 ---
 
 ### Finding format rules

package/plugins/olko-github-pr/skills/lekker-review/references/pricing.json

@@ -1,13 +1,14 @@
 {
-  "note": "USD per million tokens, keyed by revmux's actual_model. revmux runs `claude --print` under subscription (Max plan) auth, so nothing here is a real API bill; this is an API-list-price ESTIMATE for the cost block only. Where a model exposes separate input/output prices, usd = tokens/1e6 * output price (output-only, not blended), because revmux reports a single combined `tokens` figure per agent with no input/output split to weight a blend. verified:false entries are not confirmed against a current price sheet (no local claude-api pricing doc found on this machine as of 2026-09-09) and must be checked before this cost block is trusted for a real decision. The claude-*-5-5 and claude-fable-5-1 rows carry the prices of their predecessor tier (fable: $10/$50 as listed in output-format.md; opus/sonnet/haiku: the 5-family rates above) until a price sheet confirms the new models.",
-  "claude-fable-5-1": { "input": 10, "output": 50, "blended": 30, "verified": false },
-  "claude-opus-5-5":  { "input": 15,  "output": 75,  "blended": 45,  "verified": false },
-  "claude-sonnet-5-5": { "input": 3,  "output": 15,  "blended": 9,   "verified": false },
-  "claude-haiku-5-5": { "input": 1,  "output": 5,  "blended": 3,   "verified": false },
-  "claude-opus-5":   { "input": 15,  "output": 75,  "blended": 45,  "verified": false },
-  "claude-sonnet-5": { "input": 3,   "output": 15,  "blended": 9,   "verified": false },
-  "claude-haiku-4-5-20251001": { "input": 1, "output": 5, "blended": 3, "verified": false },
-  "opus":   { "input": 15, "output": 75, "blended": 45, "verified": false },
-  "sonnet": { "input": 3,  "output": 15, "blended": 9,  "verified": false },
-  "haiku":  { "input": 1,  "output": 5,  "blended": 3,  "verified": false }
+  "note": "USD per million tokens, keyed by revmux's actual_model. revmux runs `claude --print` under subscription (Max plan) auth, so nothing here is a real API bill; this is an API-list-price ESTIMATE for the cost block only. Where a model exposes separate input/output prices, usd = tokens/1e6 * output price (output-only, not blended), because revmux reports a single combined `tokens` figure per agent with no input/output split to weight a blend. Rates verified 2026-10-15 against the claude-api skill reference (shared/models.md, shared/model-migration.md). Haiku 5.5 has two rate cards; the entry is the <=100K-prompt card. The bare tier aliases (opus/sonnet/haiku) follow the current model of each tier. Re-check there when a model changes.",
+  "claude-fable-5-1": { "input": 10,  "output": 50,  "blended": 30,  "verified": "2026-10-15" },
+  "claude-fable-5":   { "input": 10,  "output": 50,  "blended": 30,  "verified": "2026-10-15" },
+  "claude-opus-5-5":  { "input": 4,   "output": 20,  "blended": 12,  "verified": "2026-10-15" },
+  "claude-opus-5":    { "input": 5,   "output": 25,  "blended": 15,  "verified": "2026-10-15" },
+  "claude-sonnet-5-5": { "input": 2,  "output": 10,  "blended": 6,   "verified": "2026-10-15" },
+  "claude-sonnet-5":  { "input": 2,   "output": 10,  "blended": 6,   "verified": "2026-10-15" },
+  "claude-haiku-5-5": { "input": 0.1, "output": 0.5, "blended": 0.3, "verified": "2026-10-15" },
+  "claude-haiku-4-5-20251001": { "input": 1, "output": 5, "blended": 3, "verified": "2026-10-15" },
+  "opus":   { "input": 4,   "output": 20,  "blended": 12,  "verified": "2026-10-15" },
+  "sonnet": { "input": 2,   "output": 10,  "blended": 6,   "verified": "2026-10-15" },
+  "haiku":  { "input": 0.1, "output": 0.5, "blended": 0.3, "verified": "2026-10-15" }
 }

package/plugins/olko-github-pr/skills/lekker-review/scripts/deps-only.mjs

@@ -0,0 +1,95 @@
+#!/usr/bin/env node
+// Decides whether a PR is a pure dependency change: every changed file is a
+// lockfile or a package.json, and each package.json differs only in its
+// dependency keys. Such a PR gets the one-agent `deps` depth; anything else is
+// `mixed` and falls back to the normal depth rules.
+//
+//   node deps-only.mjs <worktreePath> <mergeBase> <changed file>...
+//
+// Prints JSON: { kind: "deps"|"mixed", packageJsons, lockDirs, otherFiles }.
+// Exit 0 in both cases; exit 2 only on bad arguments.
+import { execFileSync } from 'node:child_process'
+import { realpathSync } from 'node:fs'
+import { fileURLToPath } from 'node:url'
+import { basename, dirname } from 'node:path'
+
+export const LOCKFILES = new Set([
+  'package-lock.json', 'npm-shrinkwrap.json', 'yarn.lock', 'pnpm-lock.yaml', 'bun.lock', 'bun.lockb',
+])
+// `engines` is here because a dependency bump that needs a newer runtime
+// raises it in the same PR; the deps agent checks it against the runtime image.
+export const DEP_KEYS = new Set([
+  'dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies',
+  'overrides', 'resolutions', 'engines',
+])
+
+function changedKeys(before, after) {
+  const keys = new Set([...Object.keys(before), ...Object.keys(after)])
+  return [...keys].filter(k => JSON.stringify(before[k]) !== JSON.stringify(after[k])).sort()
+}
+
+// readAt(rev, path) returns the file text at that revision, or null when the
+// file does not exist there. Injected so the selftest can drive it with fixtures.
+export function classify(files, readAt, base = 'BASE', head = 'HEAD') {
+  const packageJsons = []
+  const lockDirs = []
+  const otherFiles = []
+  for (const file of files) {
+    const name = basename(file)
+    if (LOCKFILES.has(name)) {
+      lockDirs.push(dirname(file))
+      continue
+    }
+    if (name !== 'package.json') {
+      otherFiles.push(file)
+      continue
+    }
+    let before, after
+    try {
+      const b = readAt(base, file), a = readAt(head, file)
+      if (b == null || a == null) throw new Error('missing on one side')
+      before = JSON.parse(b)
+      after = JSON.parse(a)
+      if (!before || !after || typeof before !== 'object' || typeof after !== 'object') throw new Error('not an object')
+    } catch {
+      // Added, deleted or unparseable: a new or removed workspace is not a bump.
+      packageJsons.push({ file, depKeysChanged: [], otherKeysChanged: ['<added, removed or unparseable>'] })
+      continue
+    }
+    const keys = changedKeys(before, after)
+    packageJsons.push({
+      file,
+      depKeysChanged: keys.filter(k => DEP_KEYS.has(k)),
+      otherKeysChanged: keys.filter(k => !DEP_KEYS.has(k)),
+    })
+  }
+  const pure = otherFiles.length === 0
+    && packageJsons.every(p => p.otherKeysChanged.length === 0)
+    && (lockDirs.length > 0 || packageJsons.length > 0)
+  return { kind: pure ? 'deps' : 'mixed', packageJsons, lockDirs: [...new Set(lockDirs)].sort(), otherFiles }
+}
+
+function gitReader(worktree) {
+  return (rev, path) => {
+    try {
+      return execFileSync('git', ['-C', worktree, 'show', `${rev}:${path}`], {
+        encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'], maxBuffer: 64 * 1024 * 1024,
+      })
+    } catch {
+      return null
+    }
+  }
+}
+
+function isMain() {
+  try { return realpathSync(process.argv[1]) === realpathSync(fileURLToPath(import.meta.url)) } catch { return false }
+}
+
+if (isMain()) {
+  const [worktree, mergeBase, ...files] = process.argv.slice(2)
+  if (!worktree || !mergeBase || files.length === 0) {
+    console.error('usage: deps-only.mjs <worktreePath> <mergeBase> <changed file>...')
+    process.exit(2)
+  }
+  console.log(JSON.stringify(classify(files, gitReader(worktree), mergeBase, 'HEAD'), null, 2))
+}

package/plugins/olko-github-pr/skills/lekker-review/scripts/pick-closer.mjs

@@ -0,0 +1,99 @@
+#!/usr/bin/env node
+// Picks the review's closing xkcd strip or GIF from references/fun.json,
+// matched to the verdict. The pool is curated and URL-verified, so the model
+// never invents a link at review time.
+//
+//   node pick-closer.mjs --verdict lgtm|lgtm-with-changes|needs-work
+//   node pick-closer.mjs --check
+//
+// Fails soft: a missing or broken pool prints nothing and exits 0, because a
+// joke must never break a review. Only --check exits 1.
+import { readFileSync, realpathSync } from 'node:fs'
+import { fileURLToPath } from 'node:url'
+import { dirname, join } from 'node:path'
+
+export const VERDICTS = ['lgtm', 'lgtm-with-changes', 'needs-work']
+const POOL_PATH = process.env.LEKKER_FUN_FILE ||
+  join(dirname(dirname(fileURLToPath(import.meta.url))), 'references', 'fun.json')
+
+/**
+ * Loads and flattens the curated fun pool from fun.json.
+ * @returns {Array<object>} xkcd and gif entries tagged with a `kind`.
+ */
+export function loadPool() {
+  const pool = JSON.parse(readFileSync(POOL_PATH, 'utf8'))
+  return [
+    ...(pool.xkcd || []).map(x => ({ kind: 'xkcd', ...x })),
+    ...(pool.gifs || []).map(g => ({ kind: 'gif', ...g })),
+  ]
+}
+
+/**
+ * Builds terminal and GitHub markdown renderings for a pool item.
+ * @param {object} item - A pool entry (xkcd or gif), as returned by loadPool.
+ * @returns {object} The item plus `md_terminal` and `md_github` strings.
+ */
+export function render(item) {
+  if (item.kind === 'xkcd') {
+    const label = `xkcd #${item.num} "${item.title}"`
+    return {
+      ...item,
+      md_terminal: `🎲 ${label} - ${item.url}`,
+      md_github: `![${label}](${item.img})\n[${label}](${item.url})`,
+    }
+  }
+  return {
+    ...item,
+    md_terminal: `🎬 ${item.alt} - ${item.url}`,
+    md_github: `![${item.alt}](${item.url})`,
+  }
+}
+
+/**
+ * Validates fun.json: required fields, known verdicts, coverage of every
+ * verdict, and no em dashes. Prints a summary and exits 1 on problems.
+ * @returns {void}
+ */
+function check() {
+  const items = loadPool()
+  const problems = []
+  for (const it of items) {
+    if (!it.url || !Array.isArray(it.verdicts) || it.verdicts.length === 0) problems.push(`incomplete: ${JSON.stringify(it)}`)
+    if (it.kind === 'xkcd' && (!it.img || !it.title || !it.num)) problems.push(`xkcd missing img/title/num: ${it.url}`)
+    if (it.kind === 'gif' && !it.alt) problems.push(`gif missing alt: ${it.url}`)
+    // title and alt become markdown link labels; these characters break them
+    if (/[[\]\n]/.test(it.title || it.alt || '')) problems.push(`"[", "]" or newline in title/alt: ${it.url}`)
+    for (const v of it.verdicts || []) if (!VERDICTS.includes(v)) problems.push(`unknown verdict "${v}": ${it.url}`)
+  }
+  for (const v of VERDICTS) if (!items.some(i => i.verdicts?.includes(v))) problems.push(`no entry for verdict ${v}`)
+  if (JSON.stringify(items).includes('\u2014')) problems.push('em dash in pool')
+  if (problems.length) { console.error(problems.join('\n')); process.exit(1) }
+  console.log(`fun.json ok: ${items.length} entries, ${VERDICTS.map(v => `${v}=${items.filter(i => i.verdicts.includes(v)).length}`).join(' ')}`)
+}
+
+/**
+ * Picks a random pool item matching the verdict and prints it as JSON.
+ * Fails soft: any error or empty match is silently swallowed.
+ * @param {string} verdict - One of VERDICTS.
+ * @returns {void}
+ */
+function pick(verdict) {
+  try {
+    const matches = loadPool().filter(i => i.verdicts?.includes(verdict))
+    if (matches.length === 0) return
+    console.log(JSON.stringify(render(matches[Math.floor(Math.random() * matches.length)])))
+  } catch { /* fail soft */ }
+}
+
+function isMain() {
+  try { return realpathSync(process.argv[1]) === realpathSync(fileURLToPath(import.meta.url)) } catch { return false }
+}
+
+if (isMain()) {
+  const args = process.argv.slice(2)
+  if (args.includes('--check')) check()
+  else {
+    const i = args.indexOf('--verdict')
+    if (i !== -1) pick(args[i + 1])
+  }
+}