@olegkoval/agent-skills 1.51.3 → 1.52.0

package/adapters/claude/olko-github-pr/skills/lekker-review/SKILL.md

@@ -280,6 +280,9 @@ in Step 4. Use it for a read-only pre-push look.
 **`--no-artifact` flag:** parse and store as `ARTIFACT=false` (default true).
 Skips Step 3.5 (living review artifact) silently.
 
+**`--no-fun` flag:** parse and store as `FUN=false` (default true). Skips the
+closer (Step 3) everywhere: terminal, saved file, artifact, GitHub body.
+
 **`--engine revmux|workflow|codex` flag:** parse and store as `ENGINE`. Default
 to `workflow` for `HOST=claude` and `codex` for `HOST=codex`. Reject an explicit
 engine that does not exist on the current host (`workflow` requires Claude's
@@ -725,6 +728,20 @@ codebase. Never on taste alone. These land in their own section, not in
 Critical/Important. A finding without a cited precedent from the codebase is
 dropped.
 
+**Pick the closer** (skip when `FUN=false`): once the verdict is decided, run
+the picker ONCE and keep its JSON as `CLOSER` for the rest of the run, so the
+terminal, saved file, artifact and GitHub body all show the same joke:
+
+```bash
+# verdict key: ✅ -> lgtm, ⚠️ -> lgtm-with-changes, 🚫 -> needs-work
+node ${SKILL_ROOT}/scripts/pick-closer.mjs --verdict <key>
+```
+
+Empty output means no closer (pool missing or broken): leave `CLOSER` empty and
+carry on. Never invent an xkcd number or GIF URL in its place; the pool in
+`references/fun.json` is URL-verified, a guessed link is not. Unattended runs
+include it too.
+
 **Format** the review per `references/output-format.md` (read it now). Key
 requirements:
 
@@ -799,6 +816,12 @@ that is about to be pushed, and a marker for a superseded sha would be a lie.
 
 Then print the full review as the response.
 
+**Closer goes last.** The run's FINAL message (this one, or the later summary
+after Step 4 / 4.6 / 5 when those run) ends with `CLOSER.md_terminal` as its
+last line. Print it once per run, on whichever message is last, not on every
+step. Pass `CLOSER` to the Step 3.5 artifact agent and to the Step 5 GitHub
+post.
+
 ---
 
 ## Step 3.5 - Living review artifact (skip when ARTIFACT=false)
@@ -977,6 +1000,7 @@ Follow `references/github-post.md`:
 - Verify post-condition: fetch review list, confirm PENDING state exists.
 - Print count + link.
 - Observation and Idiomatic findings go in the review body, never inline.
+- When `CLOSER` is set, its `md_github` is the last thing in the review body.
 - Never submit the review programmatically.
 - When fix mode applied and committed a finding, EXCLUDE it from the inline
   comments - do not ask for a change you already made. Mention the applied

package/adapters/claude/olko-github-pr/skills/lekker-review/references/artifact-page.md

@@ -156,6 +156,9 @@ Hard requirements for the HTML page:
 - **Test Quality + Review Cost sections**, mirrored from the review file,
   kept concise (verdict + gaps + cost table; no need to reproduce every
   sentence).
+- **Closer footer** (when the caller passes `CLOSER`): a small last card with
+  the closer's title (or `alt`) as a link to its `url`. Link only, no `<img>`:
+  the CSP blocks external images. Skip the card when `CLOSER` is empty.
 - **Layout:** every code block (`badCode`, `fix`, `redOutput`, `testCode`)
   horizontally scrollable within its own container; the page body itself must
   never scroll horizontally. Keep total page weight sane -- plain `<pre>`

package/adapters/claude/olko-github-pr/skills/lekker-review/references/fun.json

@@ -0,0 +1,222 @@
+{
+  "xkcd": [
+    {
+      "num": 1513,
+      "title": "Code Quality",
+      "url": "https://xkcd.com/1513/",
+      "img": "https://imgs.xkcd.com/comics/code_quality.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1695,
+      "title": "Code Quality 2",
+      "url": "https://xkcd.com/1695/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_2.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1833,
+      "title": "Code Quality 3",
+      "url": "https://xkcd.com/1833/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_3.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 2138,
+      "title": "Wanna See the Code?",
+      "url": "https://xkcd.com/2138/",
+      "img": "https://imgs.xkcd.com/comics/wanna_see_the_code.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1597,
+      "title": "Git",
+      "url": "https://xkcd.com/1597/",
+      "img": "https://imgs.xkcd.com/comics/git.png",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 303,
+      "title": "Compiling",
+      "url": "https://xkcd.com/303/",
+      "img": "https://imgs.xkcd.com/comics/compiling.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1296,
+      "title": "Git Commit",
+      "url": "https://xkcd.com/1296/",
+      "img": "https://imgs.xkcd.com/comics/git_commit.png",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 844,
+      "title": "Good Code",
+      "url": "https://xkcd.com/844/",
+      "img": "https://imgs.xkcd.com/comics/good_code.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1739,
+      "title": "Fixing Problems",
+      "url": "https://xkcd.com/1739/",
+      "img": "https://imgs.xkcd.com/comics/fixing_problems.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2347,
+      "title": "Dependency",
+      "url": "https://xkcd.com/2347/",
+      "img": "https://imgs.xkcd.com/comics/dependency.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 979,
+      "title": "Wisdom of the Ancients",
+      "url": "https://xkcd.com/979/",
+      "img": "https://imgs.xkcd.com/comics/wisdom_of_the_ancients.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1700,
+      "title": "New Bug",
+      "url": "https://xkcd.com/1700/",
+      "img": "https://imgs.xkcd.com/comics/new_bug.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2200,
+      "title": "Unreachable State",
+      "url": "https://xkcd.com/2200/",
+      "img": "https://imgs.xkcd.com/comics/unreachable_state.png",
+      "verdicts": [
+        "lgtm"
+      ]
+    }
+  ],
+  "gifs": [
+    {
+      "url": "https://media.giphy.com/media/13zeE9qQNC5IKk/giphy.gif",
+      "alt": "Seal of approval thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/SVDvVbkl359Xwzl3V4/giphy.gif",
+      "alt": "Approved",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/ely3apij36BJhoZ234/giphy.gif",
+      "alt": "Great job otter",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/rMEJyjch7L1tlRlCl3/giphy.gif",
+      "alt": "Cat says ok",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/XdUMQuuiaAEkOUtezd/giphy.gif",
+      "alt": "Animated thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/Qaxd5XpgDWMso/giphy.gif",
+      "alt": "Golden retriever almost has the ball",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/YT95XJOLvY1t2SJgpR/giphy.gif",
+      "alt": "Don't give up, so close",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/NWHBEsCcpuAPiAPMBQ/giphy.gif",
+      "alt": "Almost there, on my way",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/0yqoE9MFpFDNjCY9lr/giphy.gif",
+      "alt": "Rough draft, still thinking",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/yGREGYYecNd3pSrSU6/giphy.gif",
+      "alt": "Design thinking iteration loop",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/hsbwJSHExeC5bVenv7/giphy.gif",
+      "alt": "Work mood, back to work",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/CoND5j6Bn1QZUgm1xX/giphy.gif",
+      "alt": "Sorry, out of order",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/2zdnl4CB3OygOHe1kX/giphy.gif",
+      "alt": "Technical difficulties, not working",
+      "verdicts": [
+        "needs-work"
+      ]
+    }
+  ]
+}

package/adapters/claude/olko-github-pr/skills/lekker-review/references/github-post.md

@@ -95,6 +95,11 @@ Rules:
 
   Keep the body itself under ~2,500 characters. If it is longer, the asks are
   buried: cut prose, never cut the numbered asks.
+
+  **Closer:** when `CLOSER` is set (SKILL.md Step 3), append a blank line and
+  `CLOSER.md_github` as the very last lines of the body. It does not count
+  toward the ~2,500-character budget and is exempt from the no-praise rule
+  below, but the em-dash payload check still applies.
 - Do NOT prefix the body with a banner like "## Lekker review". Do NOT praise the
   PR or describe what it does well: no "solid", "handled well", "clean", "nice".
   State the risk and the asks only.

package/adapters/claude/olko-github-pr/skills/lekker-review/references/output-format.md

@@ -250,6 +250,10 @@ The hard rule against `<N>` placeholders still applies. When usage is exposed,
 report the real values and use an official or operator-configured pricing source,
 naming its date in the block.
 
+## 🎲 Closer
+
+<CLOSER.md_github verbatim. Omit this whole section when CLOSER is empty (--no-fun, or the picker printed nothing).>
+
 ---
 
 ### Finding format rules

package/adapters/claude/olko-github-pr/skills/lekker-review/scripts/pick-closer.mjs

@@ -0,0 +1,99 @@
+#!/usr/bin/env node
+// Picks the review's closing xkcd strip or GIF from references/fun.json,
+// matched to the verdict. The pool is curated and URL-verified, so the model
+// never invents a link at review time.
+//
+//   node pick-closer.mjs --verdict lgtm|lgtm-with-changes|needs-work
+//   node pick-closer.mjs --check
+//
+// Fails soft: a missing or broken pool prints nothing and exits 0, because a
+// joke must never break a review. Only --check exits 1.
+import { readFileSync, realpathSync } from 'node:fs'
+import { fileURLToPath } from 'node:url'
+import { dirname, join } from 'node:path'
+
+export const VERDICTS = ['lgtm', 'lgtm-with-changes', 'needs-work']
+const POOL_PATH = process.env.LEKKER_FUN_FILE ||
+  join(dirname(dirname(fileURLToPath(import.meta.url))), 'references', 'fun.json')
+
+/**
+ * Loads and flattens the curated fun pool from fun.json.
+ * @returns {Array<object>} xkcd and gif entries tagged with a `kind`.
+ */
+export function loadPool() {
+  const pool = JSON.parse(readFileSync(POOL_PATH, 'utf8'))
+  return [
+    ...(pool.xkcd || []).map(x => ({ kind: 'xkcd', ...x })),
+    ...(pool.gifs || []).map(g => ({ kind: 'gif', ...g })),
+  ]
+}
+
+/**
+ * Builds terminal and GitHub markdown renderings for a pool item.
+ * @param {object} item - A pool entry (xkcd or gif), as returned by loadPool.
+ * @returns {object} The item plus `md_terminal` and `md_github` strings.
+ */
+export function render(item) {
+  if (item.kind === 'xkcd') {
+    const label = `xkcd #${item.num} "${item.title}"`
+    return {
+      ...item,
+      md_terminal: `🎲 ${label} - ${item.url}`,
+      md_github: `![${label}](${item.img})\n[${label}](${item.url})`,
+    }
+  }
+  return {
+    ...item,
+    md_terminal: `🎬 ${item.alt} - ${item.url}`,
+    md_github: `![${item.alt}](${item.url})`,
+  }
+}
+
+/**
+ * Validates fun.json: required fields, known verdicts, coverage of every
+ * verdict, and no em dashes. Prints a summary and exits 1 on problems.
+ * @returns {void}
+ */
+function check() {
+  const items = loadPool()
+  const problems = []
+  for (const it of items) {
+    if (!it.url || !Array.isArray(it.verdicts) || it.verdicts.length === 0) problems.push(`incomplete: ${JSON.stringify(it)}`)
+    if (it.kind === 'xkcd' && (!it.img || !it.title || !it.num)) problems.push(`xkcd missing img/title/num: ${it.url}`)
+    if (it.kind === 'gif' && !it.alt) problems.push(`gif missing alt: ${it.url}`)
+    // title and alt become markdown link labels; these characters break them
+    if (/[[\]\n]/.test(it.title || it.alt || '')) problems.push(`"[", "]" or newline in title/alt: ${it.url}`)
+    for (const v of it.verdicts || []) if (!VERDICTS.includes(v)) problems.push(`unknown verdict "${v}": ${it.url}`)
+  }
+  for (const v of VERDICTS) if (!items.some(i => i.verdicts?.includes(v))) problems.push(`no entry for verdict ${v}`)
+  if (JSON.stringify(items).includes('\u2014')) problems.push('em dash in pool')
+  if (problems.length) { console.error(problems.join('\n')); process.exit(1) }
+  console.log(`fun.json ok: ${items.length} entries, ${VERDICTS.map(v => `${v}=${items.filter(i => i.verdicts.includes(v)).length}`).join(' ')}`)
+}
+
+/**
+ * Picks a random pool item matching the verdict and prints it as JSON.
+ * Fails soft: any error or empty match is silently swallowed.
+ * @param {string} verdict - One of VERDICTS.
+ * @returns {void}
+ */
+function pick(verdict) {
+  try {
+    const matches = loadPool().filter(i => i.verdicts?.includes(verdict))
+    if (matches.length === 0) return
+    console.log(JSON.stringify(render(matches[Math.floor(Math.random() * matches.length)])))
+  } catch { /* fail soft */ }
+}
+
+function isMain() {
+  try { return realpathSync(process.argv[1]) === realpathSync(fileURLToPath(import.meta.url)) } catch { return false }
+}
+
+if (isMain()) {
+  const args = process.argv.slice(2)
+  if (args.includes('--check')) check()
+  else {
+    const i = args.indexOf('--verdict')
+    if (i !== -1) pick(args[i + 1])
+  }
+}

package/adapters/claude/olko-github-pr/skills/lekker-review/scripts/selftest.mjs

@@ -259,5 +259,65 @@ console.log('\nrevmux adapter: fixture mapping')
   }
 }
 
+console.log('\ncloser picker: pool, exact rendering, fail-soft and --check')
+{
+  const { spawnSync } = await import('node:child_process')
+  const { writeFileSync, mkdtempSync } = await import('node:fs')
+  const { tmpdir } = await import('node:os')
+  const pickerPath = join(SKILL, 'scripts', 'pick-closer.mjs')
+  const { VERDICTS, render, loadPool } = await import(pickerPath)
+  const run = (args, pool) => spawnSync('node', [pickerPath, ...args], {
+    encoding: 'utf8', env: { ...process.env, ...(pool ? { LEKKER_FUN_FILE: pool } : {}) },
+  })
+  const tmp = mkdtempSync(join(tmpdir(), 'lekker-fun-'))
+  const writePool = (name, body) => {
+    const p = join(tmp, name)
+    writeFileSync(p, typeof body === 'string' ? body : JSON.stringify(body))
+    return p
+  }
+
+  check('fun.json passes --check', run(['--check']).status, 0)
+  for (const item of loadPool()) {
+    const r = render(item)
+    check(`renders ${item.url}`, r.md_github.includes(item.kind === 'xkcd' ? item.img : item.url) && r.md_terminal.endsWith(item.url), true)
+  }
+
+  const xkcd = { num: 1, title: 'T', url: 'https://xkcd.com/1/', img: 'https://imgs.xkcd.com/1.png', verdicts: ['lgtm'] }
+  const gif = { url: 'https://media.giphy.com/media/x/giphy.gif', alt: 'Nod', verdicts: ['lgtm-with-changes', 'needs-work'] }
+  check('xkcd md_terminal', render({ kind: 'xkcd', ...xkcd }).md_terminal, '🎲 xkcd #1 "T" - https://xkcd.com/1/')
+  check('xkcd md_github', render({ kind: 'xkcd', ...xkcd }).md_github, '![xkcd #1 "T"](https://imgs.xkcd.com/1.png)\n[xkcd #1 "T"](https://xkcd.com/1/)')
+  check('gif md_terminal', render({ kind: 'gif', ...gif }).md_terminal, '🎬 Nod - https://media.giphy.com/media/x/giphy.gif')
+  check('gif md_github', render({ kind: 'gif', ...gif }).md_github, '![Nod](https://media.giphy.com/media/x/giphy.gif)')
+
+  // One entry per verdict makes the random pick deterministic.
+  const fixture = writePool('fixture.json', { xkcd: [xkcd], gifs: [gif] })
+  for (const verdict of VERDICTS) {
+    const out = run(['--verdict', verdict], fixture)
+    const expected = render(verdict === 'lgtm' ? { kind: 'xkcd', ...xkcd } : { kind: 'gif', ...gif })
+    check(`${verdict}: picks the matching fixture entry`, out.stdout ? JSON.parse(out.stdout).md_github : null, expected.md_github)
+  }
+
+  for (const [label, pool] of [['missing pool', join(tmp, 'missing.json')], ['malformed pool', writePool('bad.json', '{not json')]]) {
+    const out = run(['--verdict', 'lgtm'], pool)
+    check(`${label} fails soft (exit 0, no output)`, [out.status, out.stdout], [0, ''])
+  }
+
+  for (const [label, pool] of [
+    ['unknown verdict', { xkcd: [xkcd], gifs: [{ ...gif, verdicts: ['lgtm-with-changes', 'needs-work', 'meh'] }] }],
+    ['xkcd without img', { xkcd: [{ ...xkcd, img: '' }], gifs: [gif] }],
+    ['bracket in title', { xkcd: [{ ...xkcd, title: 'a]b' }], gifs: [gif] }],
+    ['uncovered verdict', { xkcd: [xkcd], gifs: [{ ...gif, verdicts: ['needs-work'] }] }],
+    ['em dash in alt', { xkcd: [xkcd], gifs: [{ ...gif, alt: 'a \u2014 b' }] }],
+  ]) {
+    check(`--check rejects ${label}`, run(['--check'], writePool(`${label.replace(/ /g, '-')}.json`, pool)).status, 1)
+  }
+
+  const read = f => readFileSync(join(SKILL, f), 'utf8')
+  check('SKILL.md documents --no-fun', read('SKILL.md').includes('--no-fun') && read('SKILL.md').includes('FUN=false'), true)
+  const fmt = read('references/output-format.md')
+  check('Closer section follows the Review Cost pricing notes', fmt.indexOf('## 🎲 Closer') > fmt.indexOf('Per-MTok pricing'), true)
+  check('github-post and artifact-page both use CLOSER', read('references/github-post.md').includes('CLOSER') && read('references/artifact-page.md').includes('CLOSER'), true)
+}
+
 console.log(failed === 0 ? '\nall checks passed\n' : `\n${failed} check(s) FAILED\n`)
 process.exit(failed === 0 ? 0 : 1)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@olegkoval/agent-skills",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "private": false,
   "publishConfig": {
     "access": "public"

package/plugins/olko-apple-kit/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-apple-kit",
   "description": "Build and ship Apple platform apps: macOS menubar apps, App Store submissions.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-creative/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-creative",
   "description": "Creative and personal projects: photo galleries, music players, listings, wiki editing.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-garmin-kit/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-garmin-kit",
   "description": "Build, test and publish Garmin Connect IQ watch faces.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-git-tools/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-git-tools",
   "description": "Everyday git and GitHub CLI operations: conventional commits, branch hygiene.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-github-pr/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-github-pr",
   "description": "Drive GitHub pull requests to merge-ready: review-bot loops, CI fixes, descriptions, dependency triage.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-github-pr/skills/lekker-review/SKILL.md

@@ -279,6 +279,9 @@ in Step 4. Use it for a read-only pre-push look.
 **`--no-artifact` flag:** parse and store as `ARTIFACT=false` (default true).
 Skips Step 3.5 (living review artifact) silently.
 
+**`--no-fun` flag:** parse and store as `FUN=false` (default true). Skips the
+closer (Step 3) everywhere: terminal, saved file, artifact, GitHub body.
+
 **`--engine revmux|workflow|codex` flag:** parse and store as `ENGINE`. Default
 to `workflow` for `HOST=claude` and `codex` for `HOST=codex`. Reject an explicit
 engine that does not exist on the current host (`workflow` requires Claude's
@@ -724,6 +727,20 @@ codebase. Never on taste alone. These land in their own section, not in
 Critical/Important. A finding without a cited precedent from the codebase is
 dropped.
 
+**Pick the closer** (skip when `FUN=false`): once the verdict is decided, run
+the picker ONCE and keep its JSON as `CLOSER` for the rest of the run, so the
+terminal, saved file, artifact and GitHub body all show the same joke:
+
+```bash
+# verdict key: ✅ -> lgtm, ⚠️ -> lgtm-with-changes, 🚫 -> needs-work
+node ${SKILL_ROOT}/scripts/pick-closer.mjs --verdict <key>
+```
+
+Empty output means no closer (pool missing or broken): leave `CLOSER` empty and
+carry on. Never invent an xkcd number or GIF URL in its place; the pool in
+`references/fun.json` is URL-verified, a guessed link is not. Unattended runs
+include it too.
+
 **Format** the review per `references/output-format.md` (read it now). Key
 requirements:
 
@@ -798,6 +815,12 @@ that is about to be pushed, and a marker for a superseded sha would be a lie.
 
 Then print the full review as the response.
 
+**Closer goes last.** The run's FINAL message (this one, or the later summary
+after Step 4 / 4.6 / 5 when those run) ends with `CLOSER.md_terminal` as its
+last line. Print it once per run, on whichever message is last, not on every
+step. Pass `CLOSER` to the Step 3.5 artifact agent and to the Step 5 GitHub
+post.
+
 ---
 
 ## Step 3.5 - Living review artifact (skip when ARTIFACT=false)
@@ -976,6 +999,7 @@ Follow `references/github-post.md`:
 - Verify post-condition: fetch review list, confirm PENDING state exists.
 - Print count + link.
 - Observation and Idiomatic findings go in the review body, never inline.
+- When `CLOSER` is set, its `md_github` is the last thing in the review body.
 - Never submit the review programmatically.
 - When fix mode applied and committed a finding, EXCLUDE it from the inline
   comments - do not ask for a change you already made. Mention the applied

package/plugins/olko-github-pr/skills/lekker-review/references/artifact-page.md

@@ -156,6 +156,9 @@ Hard requirements for the HTML page:
 - **Test Quality + Review Cost sections**, mirrored from the review file,
   kept concise (verdict + gaps + cost table; no need to reproduce every
   sentence).
+- **Closer footer** (when the caller passes `CLOSER`): a small last card with
+  the closer's title (or `alt`) as a link to its `url`. Link only, no `<img>`:
+  the CSP blocks external images. Skip the card when `CLOSER` is empty.
 - **Layout:** every code block (`badCode`, `fix`, `redOutput`, `testCode`)
   horizontally scrollable within its own container; the page body itself must
   never scroll horizontally. Keep total page weight sane -- plain `<pre>`

package/plugins/olko-github-pr/skills/lekker-review/references/fun.json

@@ -0,0 +1,222 @@
+{
+  "xkcd": [
+    {
+      "num": 1513,
+      "title": "Code Quality",
+      "url": "https://xkcd.com/1513/",
+      "img": "https://imgs.xkcd.com/comics/code_quality.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1695,
+      "title": "Code Quality 2",
+      "url": "https://xkcd.com/1695/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_2.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1833,
+      "title": "Code Quality 3",
+      "url": "https://xkcd.com/1833/",
+      "img": "https://imgs.xkcd.com/comics/code_quality_3.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 2138,
+      "title": "Wanna See the Code?",
+      "url": "https://xkcd.com/2138/",
+      "img": "https://imgs.xkcd.com/comics/wanna_see_the_code.png",
+      "verdicts": [
+        "needs-work",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1597,
+      "title": "Git",
+      "url": "https://xkcd.com/1597/",
+      "img": "https://imgs.xkcd.com/comics/git.png",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 303,
+      "title": "Compiling",
+      "url": "https://xkcd.com/303/",
+      "img": "https://imgs.xkcd.com/comics/compiling.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1296,
+      "title": "Git Commit",
+      "url": "https://xkcd.com/1296/",
+      "img": "https://imgs.xkcd.com/comics/git_commit.png",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 844,
+      "title": "Good Code",
+      "url": "https://xkcd.com/844/",
+      "img": "https://imgs.xkcd.com/comics/good_code.png",
+      "verdicts": [
+        "lgtm",
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "num": 1739,
+      "title": "Fixing Problems",
+      "url": "https://xkcd.com/1739/",
+      "img": "https://imgs.xkcd.com/comics/fixing_problems.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2347,
+      "title": "Dependency",
+      "url": "https://xkcd.com/2347/",
+      "img": "https://imgs.xkcd.com/comics/dependency.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 979,
+      "title": "Wisdom of the Ancients",
+      "url": "https://xkcd.com/979/",
+      "img": "https://imgs.xkcd.com/comics/wisdom_of_the_ancients.png",
+      "verdicts": [
+        "lgtm",
+        "needs-work"
+      ]
+    },
+    {
+      "num": 1700,
+      "title": "New Bug",
+      "url": "https://xkcd.com/1700/",
+      "img": "https://imgs.xkcd.com/comics/new_bug.png",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "num": 2200,
+      "title": "Unreachable State",
+      "url": "https://xkcd.com/2200/",
+      "img": "https://imgs.xkcd.com/comics/unreachable_state.png",
+      "verdicts": [
+        "lgtm"
+      ]
+    }
+  ],
+  "gifs": [
+    {
+      "url": "https://media.giphy.com/media/13zeE9qQNC5IKk/giphy.gif",
+      "alt": "Seal of approval thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/SVDvVbkl359Xwzl3V4/giphy.gif",
+      "alt": "Approved",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/ely3apij36BJhoZ234/giphy.gif",
+      "alt": "Great job otter",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/rMEJyjch7L1tlRlCl3/giphy.gif",
+      "alt": "Cat says ok",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/XdUMQuuiaAEkOUtezd/giphy.gif",
+      "alt": "Animated thumbs up",
+      "verdicts": [
+        "lgtm"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/Qaxd5XpgDWMso/giphy.gif",
+      "alt": "Golden retriever almost has the ball",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/YT95XJOLvY1t2SJgpR/giphy.gif",
+      "alt": "Don't give up, so close",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/NWHBEsCcpuAPiAPMBQ/giphy.gif",
+      "alt": "Almost there, on my way",
+      "verdicts": [
+        "lgtm-with-changes"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/0yqoE9MFpFDNjCY9lr/giphy.gif",
+      "alt": "Rough draft, still thinking",
+      "verdicts": [
+        "lgtm-with-changes",
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/yGREGYYecNd3pSrSU6/giphy.gif",
+      "alt": "Design thinking iteration loop",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/hsbwJSHExeC5bVenv7/giphy.gif",
+      "alt": "Work mood, back to work",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/CoND5j6Bn1QZUgm1xX/giphy.gif",
+      "alt": "Sorry, out of order",
+      "verdicts": [
+        "needs-work"
+      ]
+    },
+    {
+      "url": "https://media.giphy.com/media/2zdnl4CB3OygOHe1kX/giphy.gif",
+      "alt": "Technical difficulties, not working",
+      "verdicts": [
+        "needs-work"
+      ]
+    }
+  ]
+}

package/plugins/olko-github-pr/skills/lekker-review/references/github-post.md

@@ -95,6 +95,11 @@ Rules:
 
   Keep the body itself under ~2,500 characters. If it is longer, the asks are
   buried: cut prose, never cut the numbered asks.
+
+  **Closer:** when `CLOSER` is set (SKILL.md Step 3), append a blank line and
+  `CLOSER.md_github` as the very last lines of the body. It does not count
+  toward the ~2,500-character budget and is exempt from the no-praise rule
+  below, but the em-dash payload check still applies.
 - Do NOT prefix the body with a banner like "## Lekker review". Do NOT praise the
   PR or describe what it does well: no "solid", "handled well", "clean", "nice".
   State the risk and the asks only.

package/plugins/olko-github-pr/skills/lekker-review/references/output-format.md

@@ -250,6 +250,10 @@ The hard rule against `<N>` placeholders still applies. When usage is exposed,
 report the real values and use an official or operator-configured pricing source,
 naming its date in the block.
 
+## 🎲 Closer
+
+<CLOSER.md_github verbatim. Omit this whole section when CLOSER is empty (--no-fun, or the picker printed nothing).>
+
 ---
 
 ### Finding format rules

package/plugins/olko-github-pr/skills/lekker-review/scripts/pick-closer.mjs

@@ -0,0 +1,99 @@
+#!/usr/bin/env node
+// Picks the review's closing xkcd strip or GIF from references/fun.json,
+// matched to the verdict. The pool is curated and URL-verified, so the model
+// never invents a link at review time.
+//
+//   node pick-closer.mjs --verdict lgtm|lgtm-with-changes|needs-work
+//   node pick-closer.mjs --check
+//
+// Fails soft: a missing or broken pool prints nothing and exits 0, because a
+// joke must never break a review. Only --check exits 1.
+import { readFileSync, realpathSync } from 'node:fs'
+import { fileURLToPath } from 'node:url'
+import { dirname, join } from 'node:path'
+
+export const VERDICTS = ['lgtm', 'lgtm-with-changes', 'needs-work']
+const POOL_PATH = process.env.LEKKER_FUN_FILE ||
+  join(dirname(dirname(fileURLToPath(import.meta.url))), 'references', 'fun.json')
+
+/**
+ * Loads and flattens the curated fun pool from fun.json.
+ * @returns {Array<object>} xkcd and gif entries tagged with a `kind`.
+ */
+export function loadPool() {
+  const pool = JSON.parse(readFileSync(POOL_PATH, 'utf8'))
+  return [
+    ...(pool.xkcd || []).map(x => ({ kind: 'xkcd', ...x })),
+    ...(pool.gifs || []).map(g => ({ kind: 'gif', ...g })),
+  ]
+}
+
+/**
+ * Builds terminal and GitHub markdown renderings for a pool item.
+ * @param {object} item - A pool entry (xkcd or gif), as returned by loadPool.
+ * @returns {object} The item plus `md_terminal` and `md_github` strings.
+ */
+export function render(item) {
+  if (item.kind === 'xkcd') {
+    const label = `xkcd #${item.num} "${item.title}"`
+    return {
+      ...item,
+      md_terminal: `🎲 ${label} - ${item.url}`,
+      md_github: `![${label}](${item.img})\n[${label}](${item.url})`,
+    }
+  }
+  return {
+    ...item,
+    md_terminal: `🎬 ${item.alt} - ${item.url}`,
+    md_github: `![${item.alt}](${item.url})`,
+  }
+}
+
+/**
+ * Validates fun.json: required fields, known verdicts, coverage of every
+ * verdict, and no em dashes. Prints a summary and exits 1 on problems.
+ * @returns {void}
+ */
+function check() {
+  const items = loadPool()
+  const problems = []
+  for (const it of items) {
+    if (!it.url || !Array.isArray(it.verdicts) || it.verdicts.length === 0) problems.push(`incomplete: ${JSON.stringify(it)}`)
+    if (it.kind === 'xkcd' && (!it.img || !it.title || !it.num)) problems.push(`xkcd missing img/title/num: ${it.url}`)
+    if (it.kind === 'gif' && !it.alt) problems.push(`gif missing alt: ${it.url}`)
+    // title and alt become markdown link labels; these characters break them
+    if (/[[\]\n]/.test(it.title || it.alt || '')) problems.push(`"[", "]" or newline in title/alt: ${it.url}`)
+    for (const v of it.verdicts || []) if (!VERDICTS.includes(v)) problems.push(`unknown verdict "${v}": ${it.url}`)
+  }
+  for (const v of VERDICTS) if (!items.some(i => i.verdicts?.includes(v))) problems.push(`no entry for verdict ${v}`)
+  if (JSON.stringify(items).includes('\u2014')) problems.push('em dash in pool')
+  if (problems.length) { console.error(problems.join('\n')); process.exit(1) }
+  console.log(`fun.json ok: ${items.length} entries, ${VERDICTS.map(v => `${v}=${items.filter(i => i.verdicts.includes(v)).length}`).join(' ')}`)
+}
+
+/**
+ * Picks a random pool item matching the verdict and prints it as JSON.
+ * Fails soft: any error or empty match is silently swallowed.
+ * @param {string} verdict - One of VERDICTS.
+ * @returns {void}
+ */
+function pick(verdict) {
+  try {
+    const matches = loadPool().filter(i => i.verdicts?.includes(verdict))
+    if (matches.length === 0) return
+    console.log(JSON.stringify(render(matches[Math.floor(Math.random() * matches.length)])))
+  } catch { /* fail soft */ }
+}
+
+function isMain() {
+  try { return realpathSync(process.argv[1]) === realpathSync(fileURLToPath(import.meta.url)) } catch { return false }
+}
+
+if (isMain()) {
+  const args = process.argv.slice(2)
+  if (args.includes('--check')) check()
+  else {
+    const i = args.indexOf('--verdict')
+    if (i !== -1) pick(args[i + 1])
+  }
+}

package/plugins/olko-github-pr/skills/lekker-review/scripts/selftest.mjs

@@ -259,5 +259,65 @@ console.log('\nrevmux adapter: fixture mapping')
   }
 }
 
+console.log('\ncloser picker: pool, exact rendering, fail-soft and --check')
+{
+  const { spawnSync } = await import('node:child_process')
+  const { writeFileSync, mkdtempSync } = await import('node:fs')
+  const { tmpdir } = await import('node:os')
+  const pickerPath = join(SKILL, 'scripts', 'pick-closer.mjs')
+  const { VERDICTS, render, loadPool } = await import(pickerPath)
+  const run = (args, pool) => spawnSync('node', [pickerPath, ...args], {
+    encoding: 'utf8', env: { ...process.env, ...(pool ? { LEKKER_FUN_FILE: pool } : {}) },
+  })
+  const tmp = mkdtempSync(join(tmpdir(), 'lekker-fun-'))
+  const writePool = (name, body) => {
+    const p = join(tmp, name)
+    writeFileSync(p, typeof body === 'string' ? body : JSON.stringify(body))
+    return p
+  }
+
+  check('fun.json passes --check', run(['--check']).status, 0)
+  for (const item of loadPool()) {
+    const r = render(item)
+    check(`renders ${item.url}`, r.md_github.includes(item.kind === 'xkcd' ? item.img : item.url) && r.md_terminal.endsWith(item.url), true)
+  }
+
+  const xkcd = { num: 1, title: 'T', url: 'https://xkcd.com/1/', img: 'https://imgs.xkcd.com/1.png', verdicts: ['lgtm'] }
+  const gif = { url: 'https://media.giphy.com/media/x/giphy.gif', alt: 'Nod', verdicts: ['lgtm-with-changes', 'needs-work'] }
+  check('xkcd md_terminal', render({ kind: 'xkcd', ...xkcd }).md_terminal, '🎲 xkcd #1 "T" - https://xkcd.com/1/')
+  check('xkcd md_github', render({ kind: 'xkcd', ...xkcd }).md_github, '![xkcd #1 "T"](https://imgs.xkcd.com/1.png)\n[xkcd #1 "T"](https://xkcd.com/1/)')
+  check('gif md_terminal', render({ kind: 'gif', ...gif }).md_terminal, '🎬 Nod - https://media.giphy.com/media/x/giphy.gif')
+  check('gif md_github', render({ kind: 'gif', ...gif }).md_github, '![Nod](https://media.giphy.com/media/x/giphy.gif)')
+
+  // One entry per verdict makes the random pick deterministic.
+  const fixture = writePool('fixture.json', { xkcd: [xkcd], gifs: [gif] })
+  for (const verdict of VERDICTS) {
+    const out = run(['--verdict', verdict], fixture)
+    const expected = render(verdict === 'lgtm' ? { kind: 'xkcd', ...xkcd } : { kind: 'gif', ...gif })
+    check(`${verdict}: picks the matching fixture entry`, out.stdout ? JSON.parse(out.stdout).md_github : null, expected.md_github)
+  }
+
+  for (const [label, pool] of [['missing pool', join(tmp, 'missing.json')], ['malformed pool', writePool('bad.json', '{not json')]]) {
+    const out = run(['--verdict', 'lgtm'], pool)
+    check(`${label} fails soft (exit 0, no output)`, [out.status, out.stdout], [0, ''])
+  }
+
+  for (const [label, pool] of [
+    ['unknown verdict', { xkcd: [xkcd], gifs: [{ ...gif, verdicts: ['lgtm-with-changes', 'needs-work', 'meh'] }] }],
+    ['xkcd without img', { xkcd: [{ ...xkcd, img: '' }], gifs: [gif] }],
+    ['bracket in title', { xkcd: [{ ...xkcd, title: 'a]b' }], gifs: [gif] }],
+    ['uncovered verdict', { xkcd: [xkcd], gifs: [{ ...gif, verdicts: ['needs-work'] }] }],
+    ['em dash in alt', { xkcd: [xkcd], gifs: [{ ...gif, alt: 'a \u2014 b' }] }],
+  ]) {
+    check(`--check rejects ${label}`, run(['--check'], writePool(`${label.replace(/ /g, '-')}.json`, pool)).status, 1)
+  }
+
+  const read = f => readFileSync(join(SKILL, f), 'utf8')
+  check('SKILL.md documents --no-fun', read('SKILL.md').includes('--no-fun') && read('SKILL.md').includes('FUN=false'), true)
+  const fmt = read('references/output-format.md')
+  check('Closer section follows the Review Cost pricing notes', fmt.indexOf('## 🎲 Closer') > fmt.indexOf('Per-MTok pricing'), true)
+  check('github-post and artifact-page both use CLOSER', read('references/github-post.md').includes('CLOSER') && read('references/artifact-page.md').includes('CLOSER'), true)
+}
+
 console.log(failed === 0 ? '\nall checks passed\n' : `\n${failed} check(s) FAILED\n`)
 process.exit(failed === 0 ? 0 : 1)

package/plugins/olko-obsidian/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-obsidian",
   "description": "Keep an Obsidian vault in sync with work: PR sync, task rollover, morning routine.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-product/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-product",
   "description": "Take a product idea to a shippable build: MVP passes, full-stack scaffolds, UX/UI quality loops, launch plans.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-reflection/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-reflection",
   "description": "Look back and improve: self-critique, retrospectives, performance review, rapid learning.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-release/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-release",
   "description": "Ship a release: semantic-release setup, changelogs, store listing copy, release-day routine.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-skill-meta/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-skill-meta",
   "description": "Author and maintain agent skills and the AI toolchain itself.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-web-ops/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-web-ops",
   "description": "Operate a website: WAF rules, search console audits, analytics bootstrap, docs indexes.",
-  "version": "1.51.3",
+  "version": "1.52.0",
   "author": {
     "name": "Oleg Koval"
   },