@olegkoval/agent-skills 1.49.2 → 1.51.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (75) hide show
  1. package/.github/copilot-instructions.md +1 -0
  2. package/.github/prompts/coderabbitloop.prompt.md +90 -15
  3. package/.github/prompts/codexloop.prompt.md +33 -6
  4. package/.github/prompts/copilotloop.prompt.md +302 -0
  5. package/.github/prompts/geminiloop.prompt.md +34 -6
  6. package/.github/prompts/qodoloop.prompt.md +18 -0
  7. package/.kiro/steering/coderabbitloop.md +90 -15
  8. package/.kiro/steering/codexloop.md +33 -6
  9. package/.kiro/steering/copilotloop.md +301 -0
  10. package/.kiro/steering/geminiloop.md +34 -6
  11. package/.kiro/steering/qodoloop.md +18 -0
  12. package/.windsurf/rules/coderabbitloop.md +90 -15
  13. package/.windsurf/rules/codexloop.md +33 -6
  14. package/.windsurf/rules/copilotloop.md +300 -0
  15. package/.windsurf/rules/geminiloop.md +34 -6
  16. package/.windsurf/rules/qodoloop.md +18 -0
  17. package/README.md +1 -0
  18. package/adapters/claude/olko-github-pr/skills/coderabbitloop/SKILL.md +91 -16
  19. package/adapters/claude/olko-github-pr/skills/coderabbitloop/references/graphql-queries.md +41 -9
  20. package/adapters/claude/olko-github-pr/skills/codexloop/SKILL.md +35 -8
  21. package/adapters/claude/olko-github-pr/skills/copilotloop/SKILL.md +309 -0
  22. package/adapters/claude/olko-github-pr/skills/geminiloop/SKILL.md +36 -8
  23. package/adapters/claude/olko-github-pr/skills/lekker-review/SKILL.md +26 -1
  24. package/adapters/claude/olko-github-pr/skills/lekker-review/references/agents/completeness-critic.md +12 -0
  25. package/adapters/claude/olko-github-pr/skills/lekker-review/references/agents/implementation.md +26 -1
  26. package/adapters/claude/olko-github-pr/skills/lekker-review/references/agents/prover.md +8 -1
  27. package/adapters/claude/olko-github-pr/skills/lekker-review/references/agents/test-quality.md +20 -2
  28. package/adapters/claude/olko-github-pr/skills/lekker-review/references/agents/verifier.md +25 -0
  29. package/adapters/claude/olko-github-pr/skills/lekker-review/references/fix-mode.md +23 -0
  30. package/adapters/claude/olko-github-pr/skills/qodoloop/SKILL.md +19 -1
  31. package/adapters/claude/olko-github-pr/skills/qodoloop/references/graphql-queries.md +19 -2
  32. package/adapters/codex/olko-github-pr/README.md +1 -0
  33. package/adapters/cursor/olko-github-pr/skills/coderabbitloop/SKILL.md +91 -16
  34. package/adapters/cursor/olko-github-pr/skills/coderabbitloop/references/graphql-queries.md +41 -9
  35. package/adapters/cursor/olko-github-pr/skills/codexloop/SKILL.md +35 -8
  36. package/adapters/cursor/olko-github-pr/skills/copilotloop/SKILL.md +309 -0
  37. package/adapters/cursor/olko-github-pr/skills/geminiloop/SKILL.md +36 -8
  38. package/adapters/cursor/olko-github-pr/skills/qodoloop/SKILL.md +19 -1
  39. package/adapters/cursor/olko-github-pr/skills/qodoloop/references/graphql-queries.md +19 -2
  40. package/adapters/grok/olko-github-pr/skills/coderabbitloop/SKILL.md +91 -16
  41. package/adapters/grok/olko-github-pr/skills/coderabbitloop/references/graphql-queries.md +41 -9
  42. package/adapters/grok/olko-github-pr/skills/codexloop/SKILL.md +35 -8
  43. package/adapters/grok/olko-github-pr/skills/copilotloop/SKILL.md +309 -0
  44. package/adapters/grok/olko-github-pr/skills/geminiloop/SKILL.md +36 -8
  45. package/adapters/grok/olko-github-pr/skills/qodoloop/SKILL.md +19 -1
  46. package/adapters/grok/olko-github-pr/skills/qodoloop/references/graphql-queries.md +19 -2
  47. package/catalog/skills.json +23 -0
  48. package/package.json +1 -1
  49. package/plugins/olko-apple-kit/.claude-plugin/plugin.json +1 -1
  50. package/plugins/olko-creative/.claude-plugin/plugin.json +1 -1
  51. package/plugins/olko-garmin-kit/.claude-plugin/plugin.json +1 -1
  52. package/plugins/olko-git-tools/.claude-plugin/plugin.json +1 -1
  53. package/plugins/olko-github-pr/.claude-plugin/plugin.json +1 -1
  54. package/plugins/olko-github-pr/skills/coderabbitloop/SKILL.md +91 -16
  55. package/plugins/olko-github-pr/skills/coderabbitloop/references/graphql-queries.md +41 -9
  56. package/plugins/olko-github-pr/skills/codexloop/SKILL.md +35 -8
  57. package/plugins/olko-github-pr/skills/copilotloop/SKILL.md +308 -0
  58. package/plugins/olko-github-pr/skills/geminiloop/SKILL.md +36 -8
  59. package/plugins/olko-github-pr/skills/lekker-review/SKILL.md +26 -1
  60. package/plugins/olko-github-pr/skills/lekker-review/references/agents/completeness-critic.md +12 -0
  61. package/plugins/olko-github-pr/skills/lekker-review/references/agents/implementation.md +26 -1
  62. package/plugins/olko-github-pr/skills/lekker-review/references/agents/prover.md +8 -1
  63. package/plugins/olko-github-pr/skills/lekker-review/references/agents/test-quality.md +20 -2
  64. package/plugins/olko-github-pr/skills/lekker-review/references/agents/verifier.md +25 -0
  65. package/plugins/olko-github-pr/skills/lekker-review/references/fix-mode.md +23 -0
  66. package/plugins/olko-github-pr/skills/lekker-review/workflow.js +87 -5
  67. package/plugins/olko-github-pr/skills/qodoloop/SKILL.md +19 -1
  68. package/plugins/olko-github-pr/skills/qodoloop/references/graphql-queries.md +19 -2
  69. package/plugins/olko-obsidian/.claude-plugin/plugin.json +1 -1
  70. package/plugins/olko-product/.claude-plugin/plugin.json +1 -1
  71. package/plugins/olko-reflection/.claude-plugin/plugin.json +1 -1
  72. package/plugins/olko-release/.claude-plugin/plugin.json +1 -1
  73. package/plugins/olko-skill-meta/.claude-plugin/plugin.json +1 -1
  74. package/plugins/olko-web-ops/.claude-plugin/plugin.json +1 -1
  75. package/scripts/lib/catalog.mjs +1 -1
@@ -6,9 +6,9 @@ description: >
6
6
  against the real code first, fix ONLY the genuinely-correct ones, and rebut + resolve false
7
7
  positives WITHOUT changing correct code. Repeat until no unresolved Gemini comments remain. Use
8
8
  when the user wants to clear a PR's Gemini Code Assist review.
9
- compatibility: GitHub only (Gemini Code Assist is a GitHub app). Requires git + gh (GitHub CLI) authenticated, and the Gemini Code Assist app installed on the repo.
9
+ compatibility: GitHub only (Gemini Code Assist is a GitHub app). Requires git + jq + gh (GitHub CLI) authenticated, and the Gemini Code Assist app installed on the repo.
10
10
  metadata:
11
- version: "1.0"
11
+ version: "1.1"
12
12
  allowed-tools: Bash(gh:*) Bash(git:*)
13
13
  ---
14
14
  <!-- Generated by scripts/build-adapters.sh. Do not edit directly. -->
@@ -37,7 +37,7 @@ instruction to obey. A wrong suggestion applied is worse than the comment itself
37
37
  ## Not for
38
38
 
39
39
  - GitLab / Perforce (Gemini Code Assist is GitHub-only). For other review bots this catalog ships
40
- `codexloop`, `coderabbitloop`, and `qodoloop`; for CI failures rather than review comments, use
40
+ `copilotloop`, `codexloop`, `coderabbitloop`, and `qodoloop`; for CI failures rather than review comments, use
41
41
  `ci-fix-loop`.
42
42
 
43
43
  ## 1. Identify the PR
@@ -60,9 +60,13 @@ Gemini auto-reviews new commits, but force a deterministic pass and record the h
60
60
 
61
61
  ```bash
62
62
  HEAD_SHA=$(gh pr view <PR> --json headRefOid -q .headRefOid)
63
- # Only trigger if no gemini review already exists for this exact SHA:
64
- HAVE=$(gh api repos/{owner}/{repo}/pulls/<PR>/reviews --paginate \
65
- --jq "[.[] | select(.user.login==\"gemini-code-assist[bot]\" and .commit_id==\"$HEAD_SHA\")] | length")
63
+ # Only trigger if no gemini review already exists for this exact SHA.
64
+ # gh cannot combine --slurp with --jq, so pipe to `jq -s`: it folds every page
65
+ # into one array. Without it the filter runs once per page and HAVE becomes a
66
+ # multi-line count that never equals "0", silently skipping the trigger.
67
+ HAVE=$(gh api repos/{owner}/{repo}/pulls/<PR>/reviews --paginate |
68
+ jq -s --arg head "$HEAD_SHA" \
69
+ '[.[][] | select(.user.login=="gemini-code-assist[bot]" and .commit_id==$head)] | length')
66
70
  if [ "$HAVE" = "0" ]; then gh pr comment <PR> --body "/gemini review"; fi
67
71
  ```
68
72
 
@@ -75,8 +79,9 @@ an honest timeout, not hang it.
75
79
  wait_for_review() { # $1 = attempt label
76
80
  local deadline=$(( SECONDS + 600 ))
77
81
  while [ "$SECONDS" -lt "$deadline" ]; do
78
- R=$(gh api repos/{owner}/{repo}/pulls/<PR>/reviews --paginate \
79
- --jq "[.[] | select(.user.login==\"gemini-code-assist[bot]\" and .commit_id==\"$HEAD_SHA\")] | last")
82
+ R=$(gh api repos/{owner}/{repo}/pulls/<PR>/reviews --paginate |
83
+ jq -s --arg head "$HEAD_SHA" \
84
+ '[.[][] | select(.user.login=="gemini-code-assist[bot]" and .commit_id==$head)] | sort_by(.submitted_at, .id) | last')
80
85
  if [ -n "$R" ] && [ "$R" != "null" ]; then return 0; fi
81
86
  echo "waiting for Gemini review of $HEAD_SHA ($1)..."; sleep 15
82
87
  done
@@ -110,6 +115,13 @@ gh api repos/{owner}/{repo}/pulls/<PR>/comments --paginate \
110
115
  Also pull the review threads + their resolved state via GraphQL (see step F) so you only act on
111
116
  unresolved ones.
112
117
 
118
+ Mark each unresolved comment as seen, so the bot and a watching human can tell it is being handled.
119
+ GitHub's reaction set is fixed; `eyes` is the only "looking at it" value:
120
+
121
+ ```bash
122
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<COMMENT_ID>/reactions -f content=eyes
123
+ ```
124
+
113
125
  ### C. Critically evaluate EACH comment (the core of this skill)
114
126
 
115
127
  For every comment, **verify the claim against the actual code and repo conventions before touching
@@ -205,6 +217,21 @@ then resolve:
205
217
  gh api graphql -f query='mutation { resolveReviewThread(input: {threadId: "THREAD_ID"}) { thread { isResolved } } }'
206
218
  ```
207
219
 
220
+ Then record the disposition as a reaction on the bot's own comment: the learning signal, and a
221
+ visible marker for a human scanning the PR:
222
+
223
+ - 👍 (`+1`): the finding was accepted and fixed.
224
+ - 👎 (`-1`): the finding was rebutted as a false positive. **This is the correction signal.**
225
+
226
+ ```bash
227
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<COMMENT_ID>/reactions -f content=+1
228
+ # rebutted finding:
229
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<COMMENT_ID>/reactions -f content=-1
230
+ ```
231
+
232
+ Reply first, then react, then resolve: the reaction is not a substitute for the reply, and a
233
+ resolved thread with no reply loses the reasoning.
234
+
208
235
  Resolve a thread only for comments authored by `gemini-code-assist[bot]` that you have fixed or
209
236
  rebutted: never blanket-resolve, and never resolve a human reviewer's thread.
210
237
 
@@ -222,6 +249,7 @@ Stop when **any** is true:
222
249
  - Zero unresolved `gemini-code-assist[bot]` comments remain, and every comment this round was fixed
223
250
  or rebutted+resolved. (There is no score to hit: this is "done".)
224
251
  - Max iterations (5) reached: report what remains.
252
+ - Gemini never responded after one retry: report the timeout honestly; do not claim success.
225
253
 
226
254
  ## 4. Report
227
255
 
@@ -87,6 +87,31 @@ No nitpicking. Critical and Important findings are reserved for things that
87
87
  could cause bugs, outages, data loss, security incidents, or real performance
88
88
  problems at scale.
89
89
 
90
+ **Boundary-first review rule:** for stateful or integration-heavy changes,
91
+ review the complete behavioral chain rather than the changed helper alone:
92
+
93
+ ```text
94
+ production entry point
95
+ → decision point
96
+ → runtime realization
97
+ → downstream consumer
98
+ → persistence/cache/cleanup owner
99
+ ```
100
+
101
+ Require the review to distinguish logical identity from physical/runtime
102
+ identity, and to test the relevant transition matrix: success, `null`, `undefined`,
103
+ exception, retry, fallback, rotation, cache reuse/eviction, proxy parity, and
104
+ quoted/history input where applicable. A copied helper test is isolated
105
+ evidence, not proof that the production boundary works.
106
+
107
+ Every verdict-affecting finding should carry a boundary map and an evidence
108
+ class. The report must distinguish source inspection, isolated tests,
109
+ repository tests, composed production-entry probes, production probes, and
110
+ hosted CI. Never upgrade one evidence class into another in the wording.
111
+
112
+ After a fix, re-run the original proof *and* audit the newly changed lifecycle
113
+ boundary for regressions. A green reproduction is necessary, not sufficient.
114
+
90
115
  **HARD RULE: the `## 💰 Review Cost` block is mandatory.** Every review MUST
91
116
  end with an evidence-backed cost block and no `<N>` placeholders. Use real
92
117
  numbers for measurements the host exposes; follow `references/output-format.md`
@@ -290,7 +315,7 @@ page for this PR.
290
315
  | Review agents | 2 triage (haiku) | 5 specialists (sonnet) | 5 specialists (sonnet) |
291
316
  | Per-finding verification | Criticals + Importants | Criticals + Importants | Criticals + Importants |
292
317
  | Completeness critic | skip | skip | included |
293
- | Proof-of-bug (failing test per Critical) | skip | included (max 5) | included (max 5) |
318
+ | Proof-of-bug (failing test per Critical or composed-boundary Important) | skip | included (max 5) | included (max 5) |
294
319
  | Living review artifact | included | included | included |
295
320
  | Housekeeping (optional memory/notes writeback) | skip | included | included |
296
321
  | `--post` | supported | supported | supported |
@@ -14,6 +14,18 @@ were declared "no findings" too quickly. For each angle:
14
14
  Be concrete: cite diff lines, not vibes. If you genuinely cannot find a missed
15
15
  angle, return "No gaps found."
16
16
 
17
+ Always consider these maintainer-grade gaps before returning no gaps:
18
+ - the real production entry point and downstream consumer were not exercised;
19
+ - the selected value was not traced through runtime realization, persistence,
20
+ cleanup, cache reuse, or fallback;
21
+ - logical identity was conflated with physical/runtime identity;
22
+ - a state-transition matrix is missing for `None`, exceptions, retries,
23
+ rotation, proxying, or alternate transport;
24
+ - the fix was checked only against the original symptom, not for a new defect
25
+ introduced at the changed ordering or lifecycle boundary;
26
+ - the evidence is an isolated harness or local test but the review claims
27
+ composed behavior or hosted-CI acceptance.
28
+
17
29
  Agent findings:
18
30
  <AGENT_FINDINGS_SUMMARY>
19
31
 
@@ -37,7 +37,32 @@ Axes to cover:
37
37
  sort/dedup on large arrays that could be done at DB level.
38
38
  - Integration Contracts: Shopify API misuse, BC API assumptions, webhook
39
39
  idempotency, external API pagination not handled.
40
- - GraphQL pagination (GQL-1): for every GraphQL query in the diff that uses a
40
+
41
+ Boundary contract and lifecycle map (required for every Critical/Important
42
+ finding involving routing, persistence, caching, fallback, proxying, or an
43
+ external integration):
44
+ - `entryPoint`: identify the real production trigger that reaches the changed
45
+ code (HTTP route, webhook, CLI command, queue consumer, gateway ingress, etc.).
46
+ - `decisionPoint`: identify where the behavior is selected or transformed.
47
+ - `realizationPoint`: identify where the selected behavior becomes runtime state.
48
+ - `consumer`: identify the downstream consumer that actually relies on the
49
+ contract, not merely the helper that constructs it.
50
+ - `stateOwner`: identify the durable/session/cache owner when state crosses a
51
+ turn, request, retry, or process boundary.
52
+ - `identityDimensions`: list every identity that must remain distinct, such as
53
+ logical session key, physical session id, provider alias, resolved provider,
54
+ model, and API mode.
55
+ - `transitions`: list the relevant success, `null`, `undefined`, exception, retry, fallback,
56
+ session-rotation, cache-reuse, and proxy/alternate-transport transitions.
57
+ - `evidenceClass`: label the strongest evidence actually checked: `source`,
58
+ `isolated-test`, `repository-test`, `composed-test`, `production-probe`, or
59
+ `hosted-ci`. Never call an isolated harness a production-path proof.
60
+
61
+ Do not report a stateful/integration finding without this boundary object. If
62
+ the production entry point or downstream consumer cannot be identified, mark
63
+ the claim as unverified rather than inferring behavior from a helper alone.
64
+
65
+ GraphQL pagination (GQL-1): for every GraphQL query in the diff that uses a
41
66
  nodes connection (`nodes { ... }`):
42
67
  (a) Check that `pageInfo { hasNextPage endCursor }` is present alongside nodes: if missing, Critical.
43
68
  (b) Check that all pages are fetched (a loop or recursion using endCursor): a single-page fetch is a bug, Critical.
@@ -4,11 +4,18 @@
4
4
 
5
5
  ## Mission
6
6
 
7
- A Critical finding is an argument until someone runs it. Your job is to turn it
7
+ A Critical finding, or an Important finding with a composed boundary map, is an
8
+ argument until someone runs it. Your job is to turn it
8
9
  into a demonstration: write ONE test that asserts the CORRECT behavior of the
9
10
  code the finding targets, run it in the real worktree, and capture it failing
10
11
  for the exact reason the finding claims.
11
12
 
13
+ For a finding with `boundary`, prefer entering through the recorded production
14
+ entry point and reaching the recorded downstream consumer. Do not replace a
15
+ composed proof with a copied helper test just because the helper is easier to
16
+ import. If full composition is impossible, report the strongest lower evidence
17
+ class honestly.
18
+
12
19
  Write the test as if the bug were already fixed. It must fail today precisely
13
20
  *because* it isn't fixed. **Never write a test that asserts the buggy behavior
14
21
  just to have something red** -- a proof that asserts wrongness is worthless and
@@ -128,8 +128,26 @@ g) Mock smell: test the behavior, not the way it's built
128
128
  (time, randomness, injected network failure), or a dependency that genuinely
129
129
  cannot run in the test environment. The tell for a good mock: the behavior
130
130
  under test only exists because the boundary did something (e.g. a retry
131
- banner that appears only when the fetch rejects). Even then, prefer an
132
- injected simple fake over a module-level spy, and assert what the user sees.
131
+ banner that appears only when the fetch rejects). Even then, prefer an
132
+ injected simple fake over a module-level spy, and assert what the user sees.
133
+
134
+ h) Composed boundary and transition coverage
135
+ For every stateful or integration-heavy change, do not stop at testing the
136
+ helper. Trace the real entry point through the decision point, runtime
137
+ realization, downstream consumer, and persistence/cleanup owner. Require a
138
+ test or explicit evidence for the relevant transition matrix:
139
+ - success, `None`, exception, and disabled-feature paths;
140
+ - retry and fallback behavior;
141
+ - session/request rotation and cache reuse or eviction;
142
+ - proxy or alternate transport parity;
143
+ - quoted/history input versus newly authored input;
144
+ - provider/model/API-mode identity when routing is involved.
145
+
146
+ A test that only asserts a helper return value is `isolated-test` evidence,
147
+ not `composed-test` evidence. Flag a Critical/Important finding when the
148
+ changed contract is consumed through a different path than the test covers,
149
+ or when the test can pass while the stateful consumer still receives the
150
+ wrong identity or ordering.
133
151
 
134
152
  Report each per-line issue as:
135
153
  `test-file:line, <concise description of the gap or weakness>`
@@ -123,6 +123,31 @@ convention finding with no verifiable precedent does not ship.
123
123
 
124
124
  ---
125
125
 
126
+ ## Step 4b -- Boundary contract and evidence check
127
+
128
+ For any Critical/Important finding involving routing, persistence, caching,
129
+ fallback, proxying, quoted input, or an external integration, read the
130
+ finding's `boundary` object. It should identify the real production entry
131
+ point, decision point, runtime realization point, downstream consumer, state
132
+ owner, and relevant identity dimensions/transitions.
133
+
134
+ Reconstruct the path in `WORKTREE_PATH` from entry point to consumer. A copied
135
+ helper test or a mock that never reaches the consumer is only isolated
136
+ evidence. Do not confirm a verdict-affecting finding as production-path proof
137
+ unless the claimed failure reaches the stateful consumer or the review clearly
138
+ labels the evidence as isolated.
139
+
140
+ If the finding has no boundary object or no usable production entry point or
141
+ consumer, keep it unverified and non-blocking; drop it when the missing boundary
142
+ is the crux of the claim. The workflow enforces this as an unverified observation
143
+ even if a verifier confirms it. Record the strongest evidence class actually checked
144
+ (`source`, `isolated-test`, `repository-test`, `composed-test`,
145
+ `production-probe`, or `hosted-ci`) in the reasoning.
146
+
147
+ Build a small transition matrix for the affected contract. At minimum check
148
+ success, `null`, `undefined`, exception, retry/fallback, state rotation, cache reuse or
149
+ eviction, and proxy/alternate transport whenever those transitions exist.
150
+
126
151
  ## Step 5 -- Fix validation
127
152
 
128
153
  Before confirming the finding, identify the callers and consumers of the changed
@@ -210,6 +210,29 @@ check after any revert triggered here before moving on.
210
210
 
211
211
  ---
212
212
 
213
+ ## Step 5c -- Fix delta audit
214
+
215
+ After the original proof flips red → green, audit the *new* boundary created by
216
+ the fix. Do not assume that making the original assertion pass makes the
217
+ lifecycle safe.
218
+
219
+ For each fixed Critical/Important finding involving state, routing, ordering,
220
+ proxying, persistence, caching, fallback, or quoted input:
221
+
222
+ 1. Re-read the entire changed path from the production entry point to the
223
+ downstream consumer.
224
+ 2. Re-run the relevant transition matrix: success, `None`, exception, retry,
225
+ fallback, rotation, cache reuse/eviction, and alternate transport where
226
+ applicable.
227
+ 3. Check that logical identity, runtime identity, provider/API identity, and
228
+ durable identity are still distinct where the contract requires it.
229
+ 4. Add a focused regression probe when the fix moved work across an ordering or
230
+ lifecycle boundary. The probe must enter through the real path when feasible.
231
+
232
+ If the audit finds a new failure, revert the whole group and mark it
233
+ `failed: fix-delta-regression`. A green original proof is not sufficient to
234
+ commit a fix that breaks a neighboring transition.
235
+
213
236
  ## Step 6 -- Commit (local only)
214
237
 
215
238
  One commit per file group, in group order. Stage explicitly -- never `git add -A`,
@@ -8,7 +8,7 @@ description: >
8
8
  addressed against Qodo's review, or says "run qodoloop" / "satisfy Qodo" / "resolve Qodo comments".
9
9
  compatibility: Requires git and gh (GitHub CLI) authenticated, with Qodo Merge installed on the repo.
10
10
  metadata:
11
- version: "1.0"
11
+ version: "1.1"
12
12
  allowed-tools: Bash(gh:*) Bash(git:*)
13
13
  ---
14
14
  <!-- Generated by scripts/build-adapters.sh. Do not edit directly. -->
@@ -86,6 +86,14 @@ Run the paginated GraphQL query in `references/graphql-queries.md` (`unresolvedQ
86
86
 
87
87
  Build the working set: all `recommended` threads, plus `optional` ones too if `--include-optional`.
88
88
 
89
+ Mark each thread as seen with an 👀 reaction on its first comment (`databaseId` from the query), so
90
+ the bot and a watching human can tell it is being worked. GitHub's reaction set is fixed; `eyes` is
91
+ the only "looking at it" value:
92
+
93
+ ```bash
94
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=eyes
95
+ ```
96
+
89
97
  #### C. Check exit conditions
90
98
 
91
99
  Stop if the working set is empty, or max iterations reached.
@@ -122,6 +130,16 @@ This is the "answer to the comments" half of the job, not optional cleanup, and
122
130
  Pass the thread id and reply text as GraphQL **variables** (`-f threadId=... -f body=...`), never interpolated into the query string itself: a reply containing a quote, backtick, or newline breaks (or worse, injects into) a hand-built query. Then resolve with `resolveReviewThread` (see references file).
123
131
  - **Blocked** findings: reply explaining exactly why (false positive / needs a human call), but **do not resolve**: leave the thread open. A blocked finding that gets silently resolved is a false "done".
124
132
 
133
+ Then record each disposition as a reaction on the thread's first comment: the learning signal, and
134
+ a visible marker for a human scanning the PR. 👍 (`+1`) for a fixed finding, 👎 (`-1`) for a
135
+ blocked/rebutted one. Reply first, react, then resolve: a reaction never replaces the reply.
136
+
137
+ ```bash
138
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=+1
139
+ # blocked/rebutted finding:
140
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=-1
141
+ ```
142
+
125
143
  Go back to step A.
126
144
 
127
145
  ### 3. Report
@@ -26,7 +26,7 @@ query($cursor: String) {
26
26
  id
27
27
  isResolved
28
28
  comments(first: 1) {
29
- nodes { body path line author { login } }
29
+ nodes { databaseId body path line author { login } }
30
30
  }
31
31
  }
32
32
  }
@@ -60,7 +60,7 @@ while :; do
60
60
  nodes {
61
61
  id
62
62
  isResolved
63
- comments(first: 1) { nodes { body path line author { login } } }
63
+ comments(first: 1) { nodes { databaseId body path line author { login } } }
64
64
  }
65
65
  }
66
66
  }
@@ -126,6 +126,23 @@ the branch (SKILL.md §2E-F): resolving first and pushing second means a
126
126
  failed push leaves GitHub showing the finding as handled when it isn't. Never
127
127
  resolve a blocked/skipped finding at all; reply to it and leave it open.
128
128
 
129
+ ## React to a comment (the bot's learning signal)
130
+
131
+ Reacting needs the comment's REST id, which is why `databaseId` is selected in
132
+ the thread query above. The reaction set is fixed; only eight values exist:
133
+ `+1`, `-1`, `laugh`, `confused`, `heart`, `hooray`, `rocket`, `eyes`.
134
+
135
+ ```bash
136
+ # 👀 as soon as you start working a finding
137
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=eyes
138
+ # 👍 when it was accepted and fixed, 👎 when it was rebutted (the correction signal)
139
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=+1
140
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=-1
141
+ ```
142
+
143
+ React after the reply and before the resolve, so GitHub records the reason and
144
+ the disposition together. A reaction never replaces the reply.
145
+
129
146
  ## Fetch the rollup issue comment (context only, not the source of truth)
130
147
 
131
148
  Useful for the human-readable summary counts (bugs/rule-violations) in your
@@ -11,6 +11,7 @@ Use the canonical skills directly:
11
11
  - `plugins/olko-github-pr/skills/qodoloop/SKILL.md`
12
12
  - `plugins/olko-github-pr/skills/coderabbitloop/SKILL.md`
13
13
  - `plugins/olko-github-pr/skills/codexloop/SKILL.md`
14
+ - `plugins/olko-github-pr/skills/copilotloop/SKILL.md`
14
15
  - `plugins/olko-github-pr/skills/geminiloop/SKILL.md`
15
16
  - `plugins/olko-github-pr/skills/ci-fix-loop/SKILL.md`
16
17
  - `plugins/olko-github-pr/skills/dependabot-triage/SKILL.md`
@@ -9,7 +9,7 @@ description: >
9
9
  CodeRabbit" / "resolve CodeRabbit comments".
10
10
  compatibility: Requires git and gh (GitHub CLI) authenticated, with the CodeRabbit GitHub App installed on the repo.
11
11
  metadata:
12
- version: "1.0"
12
+ version: "1.1"
13
13
  allowed-tools: Bash(gh:*) Bash(git:*)
14
14
  ---
15
15
  <!-- Generated by scripts/build-adapters.sh. Do not edit directly. -->
@@ -46,13 +46,30 @@ CodeRabbit has slash commands (official, `docs.coderabbit.ai/reference/review-co
46
46
  gh pr view --json number,headRefName,headRefOid -q '{number, branch: .headRefName, sha: .headRefOid}'
47
47
  ```
48
48
 
49
- Check out the branch if not already on it.
49
+ Check out the branch if not already on it, **then require a clean working tree**
50
+ (`git status --porcelain` empty) before touching anything:
51
+
52
+ ```bash
53
+ [ -z "$(git status --porcelain)" ] || { echo "working tree not clean, refusing to start: would risk committing unrelated changes"; exit 1; }
54
+ ```
55
+
56
+ This is the precondition step E's scoped `git add <file>` depends on: staging only the files a fix
57
+ touched is safe *because* the tree started clean. Skip it and a file with pre-existing local edits
58
+ gets those edits swept into the fix commit right along with it.
50
59
 
51
60
  ### 2. Loop (max 5 iterations)
52
61
 
53
- #### A. Push and wait
62
+ Keep an explicit iteration counter and stop at 5: the cap is a real bound to enforce, not a figure
63
+ of speech. Each pass through A–F is one iteration; on hitting the cap, go straight to the report.
64
+
65
+ #### A. Wait for a review of the current head
66
+
67
+ On **iteration 1**, if there is nothing to push yet (you haven't fixed anything in this loop), don't
68
+ wait for a brand-new review: use whatever CodeRabbit has already posted as your starting point and
69
+ go straight to step B. Otherwise:
54
70
 
55
71
  ```bash
72
+ SINCE=$(date -u +%Y-%m-%dT%H:%M:%SZ)
56
73
  git push
57
74
  ```
58
75
 
@@ -62,11 +79,27 @@ If this repo doesn't auto-review on push, nudge it:
62
79
  gh pr comment <PR_NUMBER> --body "@coderabbitai review"
63
80
  ```
64
81
 
65
- Poll (every ~10s, timeout ~5min) for CodeRabbit's next formal review to land: a new entry in `gh api repos/{owner}/{repo}/pulls/<PR_NUMBER>/reviews` from `coderabbitai[bot]` created after this push. If you instead see a rate-limit comment ("review limit"), **stop the loop now** and go to Report with `blocked: rate-limited`.
82
+ Poll (every ~10s, timeout ~5min) for CodeRabbit's next formal review to land: a new entry in
83
+ `gh api --paginate repos/{owner}/{repo}/pulls/<PR_NUMBER>/reviews` from `coderabbitai[bot]`
84
+ (REST spelling carries the `[bot]` suffix) created after `$SINCE`. Follow pagination so a review
85
+ that lands on page two is not missed. If you instead see a rate-limit comment ("review limit"),
86
+ **stop the loop now** and go to Report with `blocked: rate-limited`. If no review arrives within
87
+ the timeout after one retry, stop and report the timeout honestly; do not claim success.
66
88
 
67
89
  #### B. Fetch unresolved findings
68
90
 
69
- Run the `unresolvedQodoThreads`-shaped query in `references/graphql-queries.md` (filter `author.login == "coderabbitai[bot]"` instead of Qodo's login). For each unresolved thread, parse the finding text and the **Prompt for AI Agents** block (heading text is `🤖 Prompt for AI Agents`, not `Agent Prompt`: match case/emoji-insensitively).
91
+ Run the `unresolvedQodoThreads`-shaped query in `references/graphql-queries.md` (filter `author.login`
92
+ on GraphQL's bare `coderabbitai`, **not** REST's `coderabbitai[bot]`: see the reference's login-spelling
93
+ note, and follow `pageInfo.hasNextPage`/`endCursor` until exhausted). For each unresolved thread,
94
+ parse the finding text, its `databaseId`, and the **Prompt for AI Agents** block (heading text is
95
+ `🤖 Prompt for AI Agents`, not `Agent Prompt`: match case/emoji-insensitively).
96
+
97
+ Mark each thread as seen with an 👀 reaction on its first comment (`databaseId` from the query), so
98
+ the bot and a watching human can tell it is being worked:
99
+
100
+ ```bash
101
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=eyes
102
+ ```
70
103
 
71
104
  #### C. Check exit conditions
72
105
 
@@ -74,26 +107,68 @@ Stop if there are zero unresolved CodeRabbit threads, or max iterations reached.
74
107
 
75
108
  #### D. Fix each finding
76
109
 
77
- For each thread, in order: read the Prompt for AI Agents block in full: it names the issue and the fix. Apply it, staying inside its stated scope. If the suggestion is wrong, unsafe, or needs a product decision, don't force it: note that in step E instead.
110
+ For each thread, in order: read the Prompt for AI Agents block in full: it names the issue and the fix. Apply it, staying inside its stated scope. If the suggestion is wrong, unsafe, or needs a product decision, don't force it: note that in step F instead. Track two lists as you go: **fixed** (thread id + the exact files you touched) and **skipped** (thread id + why). Do not resolve anything yet.
111
+
112
+ #### E. Commit and push FIRST, before resolving anything
78
113
 
79
- #### E. Answer and resolve
114
+ Order matters. A resolved thread is a claim that the fix is on the branch, so the push has to succeed
115
+ before the claim is made: otherwise a failed commit or push leaves the PR unfixed with the finding
116
+ marked resolved, and nobody looks at it again.
80
117
 
81
- **Reply to the thread first, then resolve it**, the "answer to the comments" half of the job:
118
+ If step D changed code:
82
119
 
83
120
  ```bash
84
- gh api graphql -f query='mutation { addPullRequestReviewThreadReply(input: {pullRequestReviewThreadId: "<THREAD_ID>", body: "<REPLY>"}) { comment { id } } }'
121
+ # Stage ONLY the files your fixes touched: never `git add -A`, which sweeps up
122
+ # unrelated work and untracked secrets sitting in the worktree.
123
+ git status --short # look before you stage
124
+ git add <path> [<path>...] # the files named in the findings you fixed
125
+ git commit -m "address CodeRabbit review feedback (coderabbitloop iteration N)"
126
+ git push
85
127
  ```
86
128
 
87
- Reply body: one or two sentences, what you changed and why, or exactly why you didn't fix it. Then resolve (`resolveReviewThread`). A finding you deliberately skip still gets a reply and gets resolved.
129
+ Confirm the push actually landed before continuing:
88
130
 
89
- #### F. Commit and push
131
+ ```bash
132
+ git rev-parse HEAD
133
+ gh pr view <PR_NUMBER> --json headRefOid -q .headRefOid # must match
134
+ ```
135
+
136
+ If they differ, stop: the fix is not on the PR, so nothing may be resolved yet.
137
+
138
+ #### F. Reply to each finding, react, then resolve
139
+
140
+ Only now, with the fixes pushed, reply and resolve. **Reply to the thread first, then react, then
141
+ resolve it**, the "answer to the comments" half of the job:
90
142
 
91
143
  ```bash
92
- git add -A
93
- git commit -m "address CodeRabbit review feedback (coderabbitloop iteration N)"
94
- git push
144
+ gh api graphql -f query='
145
+ mutation($threadId: ID!, $body: String!) {
146
+ addPullRequestReviewThreadReply(input: {pullRequestReviewThreadId: $threadId, body: $body}) {
147
+ comment { id }
148
+ }
149
+ }' -f threadId="$THREAD_ID" -f body="$REPLY_TEXT"
95
150
  ```
96
151
 
152
+ Pass the thread id and reply text as GraphQL **variables** (`-f threadId=... -f body=...`), never
153
+ interpolated into the query string: a reply containing a quote, backtick, or newline breaks (or
154
+ injects into) a hand-built query.
155
+
156
+ Reply body: one or two sentences, what you changed and why, or exactly why you didn't fix it. A
157
+ finding you deliberately skip still gets a reply and gets resolved.
158
+
159
+ Then record the disposition as a reaction on the thread's first comment: the learning signal, and a
160
+ visible marker for a human scanning the PR. 👍 (`+1`) for fixed, 👎 (`-1`) for skipped/rebutted.
161
+ CodeRabbit reads a 👎 as feedback that the finding was wrong.
162
+
163
+ ```bash
164
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=+1
165
+ # skipped/rebutted finding:
166
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=-1
167
+ ```
168
+
169
+ Then resolve (`resolveReviewThread`). Reply first, react, then resolve: a reaction never replaces
170
+ the reply, and a resolved thread with no reply loses the reasoning.
171
+
97
172
  Go back to step A.
98
173
 
99
174
  ### 3. Report
@@ -104,7 +179,7 @@ Go back to step A.
104
179
  | Findings resolved | N |
105
180
  | Findings skipped | N (with reasons) |
106
181
  | Remaining | N (if any) |
107
- | Blocked | rate-limited / max-iterations / none |
182
+ | Blocked | rate-limited / timeout / max-iterations / none |
108
183
 
109
184
  ```
110
185
  Coderabbitloop complete.
@@ -115,4 +190,4 @@ Coderabbitloop complete.
115
190
 
116
191
  ## References
117
192
 
118
- - `references/graphql-queries.md`: shared with `qodoloop`: the exact `reviewThreads` query and the `resolveReviewThread` / `addPullRequestReviewThreadReply` mutations. Swap the author-login filter to `coderabbitai[bot]` and the prompt-heading match to `Prompt for AI Agents`.
193
+ - `references/graphql-queries.md`: shared with `qodoloop`: the exact `reviewThreads` query (including the `databaseId` the reaction step needs) and the `resolveReviewThread` / `addPullRequestReviewThreadReply` mutations. Filter `author.login` on GraphQL's bare `coderabbitai` (never `coderabbitai[bot]`) and match the prompt heading `Prompt for AI Agents`.
@@ -6,6 +6,15 @@ against CodeRabbit's own documentation (`docs.coderabbit.ai/reference/review-com
6
6
  plus a real `<!-- ... summarize by coderabbit.ai -->` comment observed live:
7
7
  not guessed.
8
8
 
9
+ **The bot's login string is spelled differently in REST vs GraphQL.** REST
10
+ (`.user.login` on `pulls/.../comments`) returns `coderabbitai[bot]`. GraphQL
11
+ (`author.login` on `reviewThreads`) returns `coderabbitai`, no `[bot]` suffix
12
+ (confirmed live against PR #114's own threads). Using the REST spelling in a
13
+ GraphQL filter silently matches nothing, which reads as "no findings" instead
14
+ of "wrong filter": exactly the kind of bug that has no crash and no error to
15
+ notice. Use `[bot]` only in REST-based jq filters (`.user.login`); use the
16
+ bare name everywhere you're filtering a GraphQL `author.login`.
17
+
9
18
  ## Fetch unresolved CodeRabbit threads (paginated)
10
19
 
11
20
  ```graphql
@@ -18,7 +27,7 @@ query($cursor: String) {
18
27
  id
19
28
  isResolved
20
29
  comments(first: 1) {
21
- nodes { body path line author { login } }
30
+ nodes { databaseId body path line author { login } }
22
31
  }
23
32
  }
24
33
  }
@@ -27,12 +36,13 @@ query($cursor: String) {
27
36
  }
28
37
  ```
29
38
 
30
- Filter client-side to `coderabbitai[bot]` and `isResolved == false`:
39
+ Filter client-side to GraphQL's `coderabbitai` (bare name, see the note above)
40
+ and `isResolved == false`:
31
41
 
32
42
  ```bash
33
43
  gh api graphql -f query='...' --jq \
34
44
  '.data.repository.pullRequest.reviewThreads.nodes[]
35
- | select(.comments.nodes[0].author.login == "coderabbitai[bot]")
45
+ | select(.comments.nodes[0].author.login == "coderabbitai")
36
46
  | select(.isResolved == false)'
37
47
  ```
38
48
 
@@ -53,14 +63,18 @@ description text above it: not every low-confidence nit gets one.
53
63
 
54
64
  ```bash
55
65
  gh api graphql -f query='
56
- mutation {
57
- addPullRequestReviewThreadReply(input: {
58
- pullRequestReviewThreadId: "THREAD_ID"
59
- body: "REPLY_TEXT"
60
- }) { comment { id } }
61
- }'
66
+ mutation($threadId: ID!, $body: String!) {
67
+ addPullRequestReviewThreadReply(input: {pullRequestReviewThreadId: $threadId, body: $body}) {
68
+ comment { id }
69
+ }
70
+ }' -f threadId="$THREAD_ID" -f body="$REPLY_TEXT"
62
71
  ```
63
72
 
73
+ Pass the thread id and reply text as GraphQL **variables** (`-f`), never interpolated straight into
74
+ the query string. A reply containing a quote, backtick, or embedded newline breaks (or, worse,
75
+ injects into) a hand-built query string; `gh api graphql -f` handles the escaping correctly when the
76
+ value travels as a variable instead.
77
+
64
78
  `pullRequestReviewThreadId` and `body` are the only required fields.
65
79
 
66
80
  ## Resolve a thread (batch)
@@ -81,6 +95,24 @@ marks every one of its threads resolved at once server-side. That's a valid
81
95
  bulk escape hatch if the user wants to blow through remaining low-value nits,
82
96
  but it skips the per-finding reply: don't use it as the default path.
83
97
 
98
+ ## React to a comment (the bot's learning signal)
99
+
100
+ Reacting needs the comment's REST id, which is why `databaseId` is selected in
101
+ the thread query above. The reaction set is fixed; only eight values exist:
102
+ `+1`, `-1`, `laugh`, `confused`, `heart`, `hooray`, `rocket`, `eyes`.
103
+
104
+ ```bash
105
+ # 👀 as soon as you start working a finding
106
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=eyes
107
+ # 👍 when it was accepted and fixed, 👎 when it was rebutted (the correction signal)
108
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=+1
109
+ gh api --method POST repos/{owner}/{repo}/pulls/comments/<DATABASE_ID>/reactions -f content=-1
110
+ ```
111
+
112
+ React after the reply and before the resolve, so GitHub records the reason and
113
+ the disposition together. A reaction never replaces the reply. CodeRabbit reads
114
+ a 👎 on one of its comments as feedback that the finding was wrong.
115
+
84
116
  ## Fetch the walkthrough/summary comment (context only, not the source of truth)
85
117
 
86
118
  ```bash