@olegkoval/agent-skills 1.43.0 → 1.44.0

package/plugins/olko-github-pr/skills/lekker-review/scripts/selftest.mjs

@@ -183,5 +183,81 @@ if (!hasRouting) {
   }
 }
 
+console.log('\nrevmux adapter: fixture mapping')
+{
+  const { execFileSync, spawnSync } = await import('node:child_process')
+  const fixturePath = join(SKILL, 'scripts', 'fixtures', 'revmux-report.json')
+  const contextPath = join(SKILL, 'scripts', 'fixtures', 'context.json')
+  const pricingPath = join(SKILL, 'references', 'pricing.json')
+  const adapterPath = join(SKILL, 'scripts', 'revmux-adapter.mjs')
+  const adapterArgs = [adapterPath, fixturePath, '--pricing', pricingPath, '--context', contextPath]
+  const out = execFileSync('node', adapterArgs, { encoding: 'utf8' })
+  const adapted = JSON.parse(out)
+
+  check('engine tag', adapted.engine, 'revmux')
+  check('critical confirmed kept critical',
+    adapted.findings.some(f => f.title.includes('Race between webhook retry') && f.severity === 'critical'), true)
+  check('major refined -> important, agreedBy from 2 sources',
+    (() => {
+      const f = adapted.findings.find(f => f.title.includes('Discount stacking'))
+      return f && f.severity === 'important' && Array.isArray(f.agreedBy) && f.agreedBy.length === 2
+    })(), true)
+  check('minor + lekker-conventions lens -> idiomatic',
+    adapted.findings.find(f => f.title.includes('naming matrix'))?.severity, 'idiomatic')
+  check('immaterial verdict dropped, not re-promoted',
+    adapted.findings.some(f => f.title.includes('Unused import')), false)
+  check('rejected non-hard-rule dropped',
+    adapted.findings.some(f => f.title.includes('double-count a tip')), false)
+  check('TS-1 rejected but corroborated by quoted code IS re-promoted to critical',
+    (() => {
+      const f = adapted.findings.find(f => f.title.includes('Unsafe cast on inventory adjustment'))
+      return f && f.severity === 'critical' && f.rule === 'TS-1'
+    })(), true)
+  check('TS-1 rejected with no corroborating code stays dropped',
+    adapted.findings.some(f => f.title.includes('Type safety concern in inventory handler')), false)
+  check('prose without an extracted snippet leaves badCode empty',
+    adapted.findings.find(f => f.title.includes('no retry backoff'))?.badCode, '')
+  check('configured custom hard rule with quoted code is re-promoted',
+    adapted.findings.find(f => f.title.includes('Session token is logged'))?.severity, 'critical')
+  check('configured custom hard rule without quoted code stays dropped',
+    adapted.findings.some(f => f.title.includes('Possible session concern')), false)
+  check('pre_existing becomes observation with Pre-existing: prefix',
+    (() => {
+      const f = adapted.findings.find(f => f.title.includes('no retry backoff'))
+      return f && f.severity === 'observation' && f.description.startsWith('Pre-existing:')
+    })(), true)
+  check('open_questions pass through as questions',
+    adapted.questions.length, 1)
+  check('degraded agent surfaced by name',
+    adapted.degraded, ['adversarial'])
+  check('droppedCount counts four rejected or immaterial findings', adapted.droppedCount, 4)
+  check('hardRuleCount counts built-in and custom re-promotions', adapted.hardRuleCount, 2)
+  check('totalUsd computed from known pricing', typeof adapted.totalUsd === 'number' && adapted.totalUsd > 0, true)
+  check('malformed token rows do not make totalUsd NaN', Number.isFinite(adapted.totalUsd), true)
+  check('malformed token rows keep their own usd unknown',
+    adapted.agents.find(a => a.name === 'malformed-cost')?.usd, null)
+  check('no pricingMissing when all models are priced', adapted.pricingMissing, undefined)
+  check('test-quality coverage verdict is populated from attributed findings',
+    adapted.coverageVerdict.includes('Operator-flip mutation'), true)
+  check('mutation-slip summary is populated from attributed findings',
+    adapted.mutationSlip.includes('retry guard'), true)
+  check('mock smells are structured from attributed findings', adapted.mockSmells.length, 1)
+
+  const noPricingOut = execFileSync('node', [adapterPath, fixturePath, '--context', contextPath], { encoding: 'utf8' })
+  const noPricingAdapted = JSON.parse(noPricingOut)
+  check('without a pricing file every model is pricingMissing',
+    noPricingAdapted.pricingMissing?.includes('claude-sonnet-5'), true)
+  check('without a pricing file totalUsd is null', noPricingAdapted.totalUsd, null)
+
+  for (const [label, badArgs] of [
+    ['report', [adapterPath, join(SKILL, 'SKILL.md')]],
+    ['pricing', [adapterPath, fixturePath, '--pricing', join(SKILL, 'SKILL.md'), '--context', contextPath]],
+  ]) {
+    const failedRun = spawnSync('node', badArgs, { encoding: 'utf8' })
+    check(`invalid ${label} JSON exits 2`, failedRun.status, 2)
+    check(`invalid ${label} JSON has a clear error`, failedRun.stderr.includes(`${label} JSON`), true)
+  }
+}
+
 console.log(failed === 0 ? '\nall checks passed\n' : `\n${failed} check(s) FAILED\n`)
 process.exit(failed === 0 ? 0 : 1)

package/plugins/olko-github-pr/skills/lekker-review/workflow.js

@@ -364,8 +364,14 @@ const {
   reviewBatchPlan,
   maxConcurrent,
   targetLabel: targetLabelArg,
+  engine: engineArg,
+  findingsFile,
 } = input
 
+// 'revmux' skips straight to Prove on pre-computed findings, so Prove's
+// worktree/depth rules aren't duplicated in the adapter.
+const ENGINE = (engineArg === 'revmux') ? 'revmux' : 'workflow'
+
 const targetLabel = targetLabelArg || `PR #${prNumber}`
 
 if (!repoSlug || (!prNumber && !targetLabelArg) || !depth || !diffFile || !contextFile || !promptDir) {
@@ -374,6 +380,9 @@ if (!repoSlug || (!prNumber && !targetLabelArg) || !depth || !diffFile || !conte
     '): ' + JSON.stringify({ repoSlug, prNumber, targetLabel, depth, diffFile, contextFile, promptDir })
   )
 }
+if (ENGINE === 'revmux' && !findingsFile) {
+  throw new Error('lekker-review workflow: engine "revmux" requires findingsFile (adapter output)')
+}
 
 // Concurrency. The review stage is self-limiting: five dimensions means five
 // agents, so it runs them all at once. The other stages are not. Verify,
@@ -386,7 +395,7 @@ const REVIEW_PLAN = (Array.isArray(reviewBatchPlan) && reviewBatchPlan.length >
 const FANOUT_PLAN = [Math.max(1, maxConcurrent || 5)]
 const targetMetadata = JSON.stringify({ targetLabel })
 
-log(`args ok: ${targetLabel} in ${repoSlug}, depth=${depth}, reviewPlan=[${REVIEW_PLAN}], fanout=${FANOUT_PLAN[0]}`)
+log(`args ok: ${targetLabel} in ${repoSlug}, depth=${depth}, reviewPlan=[${REVIEW_PLAN}], fanout=${FANOUT_PLAN[0]}, engine=${ENGINE}`)
 
 const budgetAtStart = budget.spent()
 
@@ -580,6 +589,32 @@ const budgetAtStart = budget.spent()
   // contradictory verdicts) on the same issue found by two dimensions.
   // -------------------------------------------------------------------------
 
+  let finalFindings
+  let implementationResult = {}
+  let testQualityResult = {}
+  let revmuxPassthrough = null
+
+  if (ENGINE === 'revmux') {
+    const adapterOutput = JSON.parse(readFileSync(findingsFile, 'utf8'))
+    finalFindings = (adapterOutput.findings || []).map(function(f) {
+      return Object.assign({}, f)
+    })
+    droppedCount = adapterOutput.droppedCount || 0
+    hardRuleCount = adapterOutput.hardRuleCount || 0
+    agentCount = adapterOutput.agentCount || 0
+    implementationResult = adapterOutput
+    testQualityResult = adapterOutput
+    revmuxPassthrough = {
+      questions:   adapterOutput.questions || [],
+      agents:      adapterOutput.agents || [],
+      degraded:    adapterOutput.degraded || [],
+      totalTokens: adapterOutput.totalTokens,
+      totalUsd:    adapterOutput.totalUsd,
+      pricingMissing: adapterOutput.pricingMissing || [],
+    }
+    log(`revmux engine: loaded ${finalFindings.length} finding(s) from ${findingsFile} (dropped=${droppedCount}, hardRule=${hardRuleCount}); skipping Review/Verify/Critic`)
+  } else {
+
   phase('Review')
 
   log(`Review: ${dimensions.length} dimension(s) in batches of [${REVIEW_PLAN}]`)
@@ -589,10 +624,10 @@ const budgetAtStart = budget.spent()
   }), REVIEW_PLAN)
 
   const reviewResults = reviewed.filter(Boolean)
-  const implementationResult = reviewResults.find(function(result) {
+  implementationResult = reviewResults.find(function(result) {
     return result.key === 'implementation'
   }) || {}
-  const testQualityResult = reviewResults.find(function(result) {
+  testQualityResult = reviewResults.find(function(result) {
     return result.key === 'test-quality'
   }) || {}
   const deduped = dedup(reviewResults.flatMap(function(result) {
@@ -613,7 +648,7 @@ const budgetAtStart = budget.spent()
   // Critic (deep only)
   // -------------------------------------------------------------------------
 
-  let finalFindings = verifiedFindings
+  finalFindings = verifiedFindings
 
   if (depth === 'deep') {
     phase('Critic')
@@ -712,6 +747,8 @@ const budgetAtStart = budget.spent()
     }
   }
 
+  } // end ENGINE === 'workflow' branch
+
   // -------------------------------------------------------------------------
   // Prove: for each Critical finding (excluding hard rules, which are policy
   // violations with no runtime failure to demonstrate), attempt to produce an
@@ -791,7 +828,7 @@ const budgetAtStart = budget.spent()
     return clean
   })
 
-  return {
+  return Object.assign({
     findings:          output,
     droppedCount,
     downgradedCount,
@@ -805,4 +842,4 @@ const budgetAtStart = budget.spent()
     mockSmells:        Array.isArray(testQualityResult.mockSmells) ? testQualityResult.mockSmells : [],
     outputTokens:      budget.spent() - budgetAtStart,
     turnTokensTotal:   budget.spent(),
-  }
+  }, Object.assign({ engine: ENGINE }, revmuxPassthrough || {}))

package/plugins/olko-obsidian/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-obsidian",
   "description": "Keep an Obsidian vault in sync with work: PR sync, task rollover, morning routine.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-product/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-product",
   "description": "Take a product idea to a shippable build: MVP passes, full-stack scaffolds, launch plans.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-reflection/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-reflection",
   "description": "Look back and improve: self-critique, retrospectives, performance review, rapid learning.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-release/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-release",
   "description": "Ship a release: semantic-release setup, changelogs, store listing copy, release-day routine.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-skill-meta/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-skill-meta",
   "description": "Author and maintain agent skills and the AI toolchain itself.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },

package/plugins/olko-web-ops/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "olko-web-ops",
   "description": "Operate a website: WAF rules, search console audits, analytics bootstrap, docs indexes.",
-  "version": "1.43.0",
+  "version": "1.44.0",
   "author": {
     "name": "Oleg Koval"
   },