npm - @ojiepermana/angular-navigation - Versions diffs - 22.0.44 → 22.0.46 - Mend

@ojiepermana/angular-navigation 22.0.44 → 22.0.46

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (10) hide show

package/fesm2022/ojiepermana-angular-navigation-service.mjs CHANGED Viewed

@@ -165,8 +165,12 @@ class NavigationService {
     routerLinkActiveOptions(item) {
         return item.isActiveMatchOptions ?? (item.exactMatch ? this.exactMatchOptions : this.subsetMatchOptions);
     }
-    itemRole(orientation, level) {
-        return orientation === 'horizontal' || level > 0 ? 'menuitem' : null;
+    itemRole(orientation, _level) {
+        // Horizontal navs are menubars/menus (arrow-key roving) → menuitem. Vertical
+        // navs are plain lists of links (tab navigation, no menu keyboard model), so
+        // their items must NOT be menuitems — a menuitem inside a `list` is an invalid
+        // ARIA parent (axe `aria-required-parent`).
+        return orientation === 'horizontal' ? 'menuitem' : null;
     }
     compactLabel(item, compact) {
         return compact ? (item.tooltip ?? item.title ?? null) : null;