@oisincoveney/pipeline 3.0.0 → 3.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (86) hide show
  1. package/dist/commands/ticket-command.js +4 -1
  2. package/dist/config/lint.js +0 -1
  3. package/dist/config/schemas.d.ts +4 -4
  4. package/dist/config/validate.js +0 -1
  5. package/dist/install-commands.js +6 -1
  6. package/dist/planning/generate.js +4 -8
  7. package/dist/runtime/agent-node/agent-node.js +6 -1
  8. package/dist/schedule/passes/drain-merge.js +58 -0
  9. package/dist/schedule/passes/index.js +1 -0
  10. package/dist/schedule/prompts.js +1 -0
  11. package/dist/schedule/scheduling-roles.js +18 -1
  12. package/dist/tickets/ticket-graph.js +3 -4
  13. package/package.json +1 -2
  14. package/.agents/skills/add-dark-mode/SKILL.md +0 -79
  15. package/.agents/skills/brand-kit/SKILL.md +0 -61
  16. package/.agents/skills/brand-kit/brand-kit-prompt.md +0 -158
  17. package/.agents/skills/canonicalize-tailwind/SKILL.md +0 -86
  18. package/.agents/skills/componentize/SKILL.md +0 -60
  19. package/.agents/skills/critique/SKILL.md +0 -374
  20. package/.agents/skills/dark-mode-image/SKILL.md +0 -64
  21. package/.agents/skills/design/SKILL.md +0 -58
  22. package/.agents/skills/design/design-guidelines.md +0 -74
  23. package/.agents/skills/design/guidelines/assets-api.md +0 -196
  24. package/.agents/skills/design/guidelines/avatars.md +0 -8
  25. package/.agents/skills/design/guidelines/badges.md +0 -5
  26. package/.agents/skills/design/guidelines/border-radius.md +0 -6
  27. package/.agents/skills/design/guidelines/buttons.md +0 -27
  28. package/.agents/skills/design/guidelines/colors.md +0 -6
  29. package/.agents/skills/design/guidelines/copywriting.md +0 -9
  30. package/.agents/skills/design/guidelines/custom-fonts.md +0 -7
  31. package/.agents/skills/design/guidelines/dark-mode.md +0 -29
  32. package/.agents/skills/design/guidelines/dashboards.md +0 -12
  33. package/.agents/skills/design/guidelines/description-lists.md +0 -5
  34. package/.agents/skills/design/guidelines/feature-lists.md +0 -5
  35. package/.agents/skills/design/guidelines/flexbox-layout.md +0 -6
  36. package/.agents/skills/design/guidelines/font-recommendations.md +0 -175
  37. package/.agents/skills/design/guidelines/footers.md +0 -13
  38. package/.agents/skills/design/guidelines/form-controls.md +0 -139
  39. package/.agents/skills/design/guidelines/general.md +0 -47
  40. package/.agents/skills/design/guidelines/headers.md +0 -8
  41. package/.agents/skills/design/guidelines/heading-groups.md +0 -19
  42. package/.agents/skills/design/guidelines/icons.md +0 -18
  43. package/.agents/skills/design/guidelines/images.md +0 -12
  44. package/.agents/skills/design/guidelines/interactivity.md +0 -6
  45. package/.agents/skills/design/guidelines/landing-pages.md +0 -11
  46. package/.agents/skills/design/guidelines/login-pages.md +0 -5
  47. package/.agents/skills/design/guidelines/logo-clouds.md +0 -6
  48. package/.agents/skills/design/guidelines/navigation.md +0 -10
  49. package/.agents/skills/design/guidelines/pagination.md +0 -5
  50. package/.agents/skills/design/guidelines/placeholder-content.md +0 -23
  51. package/.agents/skills/design/guidelines/pricing-cards.md +0 -42
  52. package/.agents/skills/design/guidelines/prose-content.md +0 -11
  53. package/.agents/skills/design/guidelines/responsive-design.md +0 -15
  54. package/.agents/skills/design/guidelines/section-layout.md +0 -23
  55. package/.agents/skills/design/guidelines/shadows.md +0 -6
  56. package/.agents/skills/design/guidelines/surfaces.md +0 -13
  57. package/.agents/skills/design/guidelines/svg.md +0 -7
  58. package/.agents/skills/design/guidelines/tables.md +0 -27
  59. package/.agents/skills/design/guidelines/team-sections.md +0 -13
  60. package/.agents/skills/design/guidelines/testimonials.md +0 -11
  61. package/.agents/skills/design/guidelines/typography.md +0 -18
  62. package/.agents/skills/diagnose/SKILL.md +0 -68
  63. package/.agents/skills/doubt/SKILL.md +0 -243
  64. package/.agents/skills/execute/SKILL.md +0 -211
  65. package/.agents/skills/fix/SKILL.md +0 -64
  66. package/.agents/skills/grill/SKILL.md +0 -43
  67. package/.agents/skills/ideas/SKILL.md +0 -161
  68. package/.agents/skills/imagegen/SKILL.md +0 -24
  69. package/.agents/skills/improve/SKILL.md +0 -51
  70. package/.agents/skills/inspect/SKILL.md +0 -19
  71. package/.agents/skills/library-first-development/SKILL.md +0 -108
  72. package/.agents/skills/make-responsive/SKILL.md +0 -91
  73. package/.agents/skills/markup-from-image/SKILL.md +0 -88
  74. package/.agents/skills/migrate/SKILL.md +0 -213
  75. package/.agents/skills/optimize/SKILL.md +0 -352
  76. package/.agents/skills/orchestrate/SKILL.md +0 -108
  77. package/.agents/skills/quality-gate/SKILL.md +0 -92
  78. package/.agents/skills/quick/SKILL.md +0 -20
  79. package/.agents/skills/research/SKILL.md +0 -71
  80. package/.agents/skills/schedule-graph-shaping/SKILL.md +0 -24
  81. package/.agents/skills/scope/SKILL.md +0 -130
  82. package/.agents/skills/secure/SKILL.md +0 -351
  83. package/.agents/skills/spec/SKILL.md +0 -221
  84. package/.agents/skills/test/SKILL.md +0 -70
  85. package/.agents/skills/trace/SKILL.md +0 -137
  86. package/.agents/skills/verify/SKILL.md +0 -125
@@ -1,86 +0,0 @@
1
- ---
2
- name: canonicalize-tailwind
3
- description: Sort, normalize, deduplicate, and resolve conflicting Tailwind utility classes.
4
- ---
5
-
6
- # Canonicalize Tailwind
7
-
8
- Use this when the user wants to clean up, canonicalize, or normalize Tailwind class lists.
9
-
10
- ## Activation
11
-
12
- ### Use For
13
-
14
- - cleaning up Tailwind classes
15
- - canonicalizing Tailwind utility lists
16
- - sorting, normalizing, or deduplicating Tailwind classes
17
- - resolving conflicting Tailwind utilities in class strings
18
-
19
- ### Do Not Use For
20
-
21
- - new design or layout work
22
- - component extraction or code organization
23
- - visual changes rather than class-list cleanup
24
-
25
- ## Load First
26
-
27
- - No companion modules are required.
28
-
29
- ## Progress Updates
30
-
31
- Keep the user informed so longer runs do not look stuck.
32
-
33
- - One-line status update before each major phase.
34
- - Concrete and lightweight: what you are doing now, not verbose logs.
35
-
36
- ## Workflow
37
-
38
- 1. Identify Tailwind class strings in the requested files or components.
39
- 2. Canonicalize class strings with `npx @tailwindcss/cli canonicalize`.
40
- 3. Apply changed class strings back to the source.
41
- 4. Run the project's formatter or relevant checks when available.
42
-
43
- ## Commands
44
-
45
- - Use `npx @tailwindcss/cli canonicalize` to clean up Tailwind class lists — collapses shorthands (`mt-2 mr-2 mb-2 ml-2` → `m-2`), resolves overrides (`py-3 p-1 px-3` → `p-3`), canonicalizes arbitrary values to named utilities, and sorts classes; pass `--css path/to/input.css` if the project uses a custom CSS entry file
46
-
47
- Single class string:
48
-
49
- ```sh
50
- npx @tailwindcss/cli canonicalize "mt-2 mr-2 mb-2 ml-2"
51
- # m-2
52
- ```
53
-
54
- Multiple class strings as positional args (each returned on its own line):
55
-
56
- ```sh
57
- npx @tailwindcss/cli canonicalize "py-3 p-1 px-3" "mt-2 mr-2 mb-2 ml-2"
58
- # p-3
59
- # m-2
60
- ```
61
-
62
- Pipe class strings via stdin (one per line):
63
-
64
- ```sh
65
- echo "py-3 p-1 px-3\nmt-2 mr-2 mb-2 ml-2" | npx @tailwindcss/cli canonicalize
66
- # p-3
67
- # m-2
68
- ```
69
-
70
- Use `--format json` or `--format jsonl` for structured output with `input`/`output`/`changed` fields:
71
-
72
- ```sh
73
- npx @tailwindcss/cli canonicalize --format json "py-3 p-1 px-3"
74
- # [{ "input": "py-3 p-1 px-3", "output": "p-3", "changed": true }]
75
- ```
76
-
77
- Use `--stream` to process stdin line-by-line without buffering:
78
-
79
- ```sh
80
- npx @tailwindcss/cli canonicalize --stream
81
- ```
82
-
83
- ## Verify
84
-
85
- - Confirm class strings still express the same visual intent after canonicalization.
86
- - Run relevant lint, typecheck, or formatting commands when available.
@@ -1,60 +0,0 @@
1
- ---
2
- name: componentize
3
- description: Extract and organize existing UI into reusable components with thoughtful APIs.
4
- ---
5
-
6
- # Componentize
7
-
8
- Use this when the user wants to componentize, extract, or organize UI code into reusable components.
9
-
10
- ## Activation
11
-
12
- ### Use For
13
-
14
- - componentizing an existing page, section, or prototype
15
- - extracting a page or section into components
16
- - extracting repeated UI into reusable components
17
- - reducing duplication in UI code
18
- - turning a draft implementation into production-ready code structure
19
- - splitting a large UI file into smaller, focused modules
20
-
21
- ### Do Not Use For
22
-
23
- - brand-new design or layout work
24
- - visual polish without code structure changes
25
- - Tailwind class cleanup without component extraction
26
- - responsive behavior, dark mode, or image adaptation only
27
-
28
- ## Load First
29
-
30
- - No companion modules are required.
31
-
32
- ## Progress Updates
33
-
34
- Keep the user informed so longer runs do not look stuck.
35
-
36
- - One-line status update before each major phase.
37
- - Concrete and lightweight: what you are doing now, not verbose logs.
38
-
39
- ## Workflow
40
-
41
- 1. Inspect existing project component patterns before creating new components.
42
- 2. Identify repeated patterns, logical sections, and self-contained UI blocks.
43
- 3. Extract components with call-site spacing and configurable class merging.
44
- 4. Reuse or extend existing project components where available.
45
- 5. Re-scan extracted components for remaining duplication.
46
-
47
- ## Rules
48
-
49
- - Break designs into small, focused components instead of rendering everything in a single large component — extract repeated patterns, logical sections, and self-contained UI blocks into their own components
50
- - Never bake margins into components — apply margins at the call site instead; every component must accept a `class` attribute and merge it with the classes on the component's top-level element
51
- - Use `clsx` or similar to merge classes together in client-side components
52
- - Always extract form controls into reusable components organized by HTML element — one `Input` component for all `<input>` types (text, email, password, etc.), one `Select` for `<select>`, one `Textarea` for `<textarea>`; never create type-specific components like `EmailInput` or `PasswordInput`; check the project for existing ones before creating new ones
53
- - When two or more elements share the same structure and styling but differ only in props like labels, placeholders, or types — extract them into a single reusable component parameterized by those differences
54
- - After extracting components, scan them for duplicated patterns and extract shared elements into reusable components — e.g. repeated section container/max-width/padding wrappers, repeated heading group structures (eyebrow + heading + subheading), repeated card shells, repeated button styles
55
- - Always use existing project components when they are available — reuse or extend them instead of creating new ones; buttons and form elements are especially common candidates
56
-
57
- ## Verify
58
-
59
- - Run relevant formatting, lint, typecheck, or tests when available.
60
- - Confirm extracted components preserve the original UI and behavior.
@@ -1,374 +0,0 @@
1
- ---
2
- name: critique
3
- description: Conducts multi-axis code review. Use before merging any change. Use when reviewing code written by yourself, another agent, or a human. Use when you need to assess code quality across multiple dimensions before it enters the main branch.
4
- ---
5
-
6
- # Code Review and Quality
7
-
8
- ## Overview
9
-
10
- Multi-dimensional code review with quality gates. Every change gets reviewed before merge — no exceptions. Review covers correctness, readability, architecture, security, performance, and the [[quality-gate]] smell check.
11
-
12
- **A review is the act of checking, not the act of approving.** "LGTM" with no findings and no evidence you walked the axes is not a review — it is a rubber stamp wearing one. The checkable signal (borrowed from [[doubt]]'s anti-theater rule): if the diff is non-trivial and you produced *zero* findings across all six axes, you almost certainly didn't review it — look again before you approve. You are also entitled to the upstream artifacts: the ticket's acceptance criteria, the test evidence ([[test]]), and the quality-gate evidence ([[quality-gate]]). A change that arrives without them isn't ready for review — send it back rather than reviewing a claim you can't check.
13
-
14
- **The approval standard:** Approve a change when it definitely improves overall code health, even if it isn't perfect. Perfect code doesn't exist — the goal is continuous improvement. Don't block a change because it isn't exactly how you would have written it. If it improves the codebase and follows the project's conventions, approve it.
15
-
16
- ## When to Use
17
-
18
- - Before merging any PR or change
19
- - After completing a feature implementation
20
- - When another agent or model produced code you need to evaluate
21
- - When refactoring existing code
22
- - After any bug fix (review both the fix and the regression test)
23
-
24
- ## The Five-Axis Review
25
-
26
- Every review evaluates code across these dimensions:
27
-
28
- ### 1. Correctness
29
-
30
- Does the code do what it claims to do?
31
-
32
- - Does it match the spec or task requirements?
33
- - Are edge cases handled (null, empty, boundary values)?
34
- - Are error paths handled (not just the happy path)?
35
- - Does it pass all tests? Are the tests actually testing the right things?
36
- - Are there off-by-one errors, race conditions, or state inconsistencies?
37
-
38
- ### 2. Readability & Simplicity
39
-
40
- Can another engineer (or agent) understand this code without the author explaining it?
41
-
42
- - Are names descriptive and consistent with project conventions? (No `temp`, `data`, `result` without context)
43
- - Is the control flow straightforward (avoid nested ternaries, deep callbacks)?
44
- - Is the code organized logically (related code grouped, clear module boundaries)?
45
- - Are there any "clever" tricks that should be simplified?
46
- - **Could this be done in fewer lines?** (1000 lines where 100 suffice is a failure)
47
- - **Are abstractions earning their complexity?** (Don't generalize until the third use case)
48
- - Would comments help clarify non-obvious intent? (But don't comment obvious code.)
49
- - Are there dead code artifacts: no-op variables (`_unused`), backwards-compat shims, or `// removed` comments?
50
-
51
- ### 3. Architecture
52
-
53
- Does the change fit the system's design?
54
-
55
- - Does it follow existing patterns or introduce a new one? If new, is it justified?
56
- - Does it maintain clean module boundaries?
57
- - Is there code duplication that should be shared?
58
- - Are dependencies flowing in the right direction (no circular dependencies)?
59
- - Is the abstraction level appropriate (not over-engineered, not too coupled)?
60
-
61
- ### 4. Security
62
-
63
- For detailed security guidance, use [[secure]]. Does the change introduce vulnerabilities?
64
-
65
- - Is user input validated and sanitized?
66
- - Are secrets kept out of code, logs, and version control?
67
- - Is authentication/authorization checked where needed?
68
- - Are SQL queries parameterized (no string concatenation)?
69
- - Are outputs encoded to prevent XSS?
70
- - Are dependencies from trusted sources with no known vulnerabilities?
71
- - Is data from external sources (APIs, logs, user content, config files) treated as untrusted?
72
- - Are external data flows validated at system boundaries before use in logic or rendering?
73
-
74
- ### 5. Performance
75
-
76
- For detailed profiling and optimization, use [[optimize]]. Does the change introduce performance problems?
77
-
78
- - Any N+1 query patterns?
79
- - Any unbounded loops or unconstrained data fetching?
80
- - Any synchronous operations that should be async?
81
- - Any unnecessary re-renders in UI components?
82
- - Any missing pagination on list endpoints?
83
- - Any large objects created in hot paths?
84
-
85
- ### 6. Quality Gate
86
-
87
- For detailed smell guidance, use [[quality-gate]]. Does the change contain a design smell that should block merge?
88
-
89
- - Any workaround, bandaid, broad fallback, swallowed error, sleep/retry patch, or TODO/FIXME temporary code?
90
- - Any unsafe type assertion/cast, `as any`, `as unknown as T`, non-null assertion, raw `any`, unsafe `any` flow, lint/type suppression, or assertion that only silences tooling?
91
- - Any massive `if/else` ladder, repeated `switch`, nested branching, boolean parameter matrix, duplicated condition cluster, or mode flag explosion?
92
- - Any shallow wrapper, manager/helper dumping ground, leaked abstraction, message chain, hidden global, or shotgun-surgery pattern?
93
- - Any long method/file/class, long parameter list, primitive obsession, data clump, speculative abstraction, dead code, or over-mocked test?
94
-
95
- ## Change Sizing
96
-
97
- Small, focused changes are easier to review, faster to merge, and safer to deploy. Target these sizes:
98
-
99
- ```
100
- ~100 lines changed → Good. Reviewable in one sitting.
101
- ~300 lines changed → Acceptable if it's a single logical change.
102
- ~1000 lines changed → Too large. Split it.
103
- ```
104
-
105
- **What counts as "one change":** A single self-contained modification that addresses one thing, includes related tests, and keeps the system functional after submission. One part of a feature — not the whole feature.
106
-
107
- **Splitting strategies when a change is too large:**
108
-
109
- | Strategy | How | When |
110
- |----------|-----|------|
111
- | **Stack** | Submit a small change, start the next one based on it | Sequential dependencies |
112
- | **By file group** | Separate changes for groups needing different reviewers | Cross-cutting concerns |
113
- | **Horizontal** | Create shared code/stubs first, then consumers | Layered architecture |
114
- | **Vertical** | Break into smaller full-stack slices of the feature | Feature work |
115
-
116
- **When large changes are acceptable:** Complete file deletions and automated refactoring where the reviewer only needs to verify intent, not every line.
117
-
118
- **Separate refactoring from feature work.** A change that refactors existing code and adds new behavior is two changes — submit them separately. Small cleanups (variable renaming) can be included at reviewer discretion.
119
-
120
- ## Change Descriptions
121
-
122
- Every change needs a description that stands alone in version control history.
123
-
124
- **First line:** Short, imperative, standalone. "Delete the FizzBuzz RPC" not "Deleting the FizzBuzz RPC." Must be informative enough that someone searching history can understand the change without reading the diff.
125
-
126
- **Body:** What is changing and why. Include context, decisions, and reasoning not visible in the code itself. Link to bug numbers, benchmark results, or design docs where relevant. Acknowledge approach shortcomings when they exist.
127
-
128
- **Anti-patterns:** "Fix bug," "Fix build," "Add patch," "Moving code from A to B," "Phase 1," "Add convenience functions."
129
-
130
- ## Review Process
131
-
132
- ### Step 1: Understand the Context
133
-
134
- Before looking at code, understand the intent:
135
-
136
- ```
137
- - What is this change trying to accomplish?
138
- - What spec or task does it implement?
139
- - What is the expected behavior change?
140
- ```
141
-
142
- ### Step 2: Review the Tests First
143
-
144
- Tests reveal intent and coverage:
145
-
146
- ```
147
- - Do tests exist for the change?
148
- - Do they test behavior (not implementation details)?
149
- - Are edge cases covered?
150
- - Do tests have descriptive names?
151
- - Would the tests catch a regression if the code changed?
152
- ```
153
-
154
- ### Step 3: Review the Implementation
155
-
156
- Walk through the code with all review axes in mind:
157
-
158
- ```
159
- For each file changed:
160
- 1. Correctness: Does this code do what the test says it should?
161
- 2. Readability: Can I understand this without help?
162
- 3. Architecture: Does this fit the system?
163
- 4. Security: Any vulnerabilities?
164
- 5. Performance: Any bottlenecks?
165
- 6. Quality gate: Any bandaid, unsafe cast/assertion, massive branch, or smell?
166
- ```
167
-
168
- ### Step 4: Categorize Findings
169
-
170
- Label every comment with its severity so the author knows what's required vs optional:
171
-
172
- | Prefix | Meaning | Author Action |
173
- |--------|---------|---------------|
174
- | *(no prefix)* | Required change | Must address before merge |
175
- | **Critical:** | Blocks merge | Security vulnerability, data loss, broken functionality |
176
- | **Nit:** | Minor, optional | Author may ignore — formatting, style preferences |
177
- | **Optional:** / **Consider:** | Suggestion | Worth considering but not required |
178
- | **FYI** | Informational only | No action needed — context for future reference |
179
-
180
- This prevents authors from treating all feedback as mandatory and wasting time on optional suggestions.
181
-
182
- ### Step 5: Verify the Verification
183
-
184
- Check the author's verification story:
185
-
186
- ```
187
- - What tests were run?
188
- - Did the build pass?
189
- - Was the change tested manually?
190
- - Are there screenshots for UI changes?
191
- - Is there a before/after comparison?
192
- ```
193
-
194
- ## Multi-Model Review Pattern
195
-
196
- Use different models for different review perspectives:
197
-
198
- ```
199
- Model A writes the code
200
-
201
-
202
- Model B reviews for correctness and architecture
203
-
204
-
205
- Model A addresses the feedback
206
-
207
-
208
- Human makes the final call
209
- ```
210
-
211
- This catches issues that a single model might miss — different models have different blind spots.
212
-
213
- **Example prompt for a review agent:**
214
- ```
215
- Review this code change for correctness, security, and adherence to
216
- our project conventions. The spec says [X]. The change should [Y].
217
- Flag any issues as Critical, Important, or Suggestion.
218
- ```
219
-
220
- ## Dead Code Hygiene
221
-
222
- After any refactoring or implementation change, check for orphaned code:
223
-
224
- 1. Identify code that is now unreachable or unused
225
- 2. List it explicitly
226
- 3. **Ask before deleting:** "Should I remove these now-unused elements: [list]?"
227
-
228
- Don't leave dead code lying around — it confuses future readers and agents. But don't silently delete things you're not sure about. When in doubt, ask.
229
-
230
- ```
231
- DEAD CODE IDENTIFIED:
232
- - formatLegacyDate() in src/utils/date.ts — replaced by formatDate()
233
- - OldTaskCard component in src/components/ — replaced by TaskCard
234
- - LEGACY_API_URL constant in src/config.ts — no remaining references
235
- → Safe to remove these?
236
- ```
237
-
238
- ## Specialized review lenses
239
-
240
- Use these lenses inside the same review, not as separate top-level skills:
241
-
242
- - **UI and accessibility:** check semantics, keyboard access, focus states, readable labels, responsive layout, loading/error states, and whether text or controls overlap at realistic viewport sizes.
243
- - **Strict maintainability:** look for giant files, spaghetti branching, shallow wrappers, unclear ownership, dead compatibility shims, and abstractions that do not earn their complexity.
244
- - **Quality gate:** load [[quality-gate]] and block workarounds, unsafe casts/assertions, type-system escapes, massive branching, duplicated condition clusters, shallow wrappers, dead code, and disabled checks.
245
- - **Requesting review:** package the diff with a short description, requirements/plan, base/head SHAs, verification run, and known risks. Do not hand the reviewer your whole session history.
246
- - **Receiving review:** verify each finding against the code before implementing it. Fix valid Critical and Important issues; push back with evidence when a comment is technically wrong.
247
-
248
- ## Review Speed
249
-
250
- Slow reviews block entire teams. The cost of context-switching to review is less than the waiting cost imposed on others.
251
-
252
- - **Respond within one business day** — this is the maximum, not the target
253
- - **Ideal cadence:** Respond shortly after a review request arrives, unless deep in focused coding. A typical change should complete multiple review rounds in a single day
254
- - **Prioritize fast individual responses** over quick final approval. Quick feedback reduces frustration even if multiple rounds are needed
255
- - **Large changes:** Ask the author to split them rather than reviewing one massive changeset
256
-
257
- ## Handling Disagreements
258
-
259
- When resolving review disputes, apply this hierarchy:
260
-
261
- 1. **Technical facts and data** override opinions and preferences
262
- 2. **Style guides** are the absolute authority on style matters
263
- 3. **Software design** must be evaluated on engineering principles, not personal preference
264
- 4. **Codebase consistency** is acceptable if it doesn't degrade overall health
265
-
266
- **Don't accept "I'll clean it up later."** Experience shows deferred cleanup rarely happens. Require cleanup before submission unless it's a genuine emergency. If surrounding issues can't be addressed in this change, require filing a bug with self-assignment.
267
-
268
- ## Honesty in Review
269
-
270
- When reviewing code — whether written by you, another agent, or a human:
271
-
272
- - **Don't rubber-stamp.** "LGTM" without evidence of review helps no one.
273
- - **Don't soften real issues.** "This might be a minor concern" when it's a bug that will hit production is dishonest.
274
- - **Quantify problems when possible.** "This N+1 query will add ~50ms per item in the list" is better than "this could be slow."
275
- - **Push back on approaches with clear problems.** Sycophancy is a failure mode in reviews. If the implementation has issues, say so directly and propose alternatives.
276
- - **Accept override gracefully.** If the author has full context and disagrees, defer to their judgment. Comment on code, not people — reframe personal critiques to focus on the code itself.
277
-
278
- ## Dependency Discipline
279
-
280
- Part of code review is dependency review:
281
-
282
- **Before adding any dependency:**
283
- 1. Does the existing stack solve this? (Often it does.)
284
- 2. How large is the dependency? (Check bundle impact.)
285
- 3. Is it actively maintained? (Check last commit, open issues.)
286
- 4. Does it have known vulnerabilities? (`npm audit`)
287
- 5. What's the license? (Must be compatible with the project.)
288
-
289
- **Rule:** Prefer standard library and existing utilities over new dependencies. Every dependency is a liability.
290
-
291
- ## The Review Checklist
292
-
293
- ```markdown
294
- ## Review: [PR/Change title]
295
-
296
- ### Context
297
- - [ ] I understand what this change does and why
298
-
299
- ### Correctness
300
- - [ ] Change matches spec/task requirements
301
- - [ ] Edge cases handled
302
- - [ ] Error paths handled
303
- - [ ] Tests cover the change adequately
304
-
305
- ### Readability
306
- - [ ] Names are clear and consistent
307
- - [ ] Logic is straightforward
308
- - [ ] No unnecessary complexity
309
-
310
- ### Architecture
311
- - [ ] Follows existing patterns
312
- - [ ] No unnecessary coupling or dependencies
313
- - [ ] Appropriate abstraction level
314
-
315
- ### Security
316
- - [ ] No secrets in code
317
- - [ ] Input validated at boundaries
318
- - [ ] No injection vulnerabilities
319
- - [ ] Auth checks in place
320
- - [ ] External data sources treated as untrusted
321
-
322
- ### Performance
323
- - [ ] No N+1 patterns
324
- - [ ] No unbounded operations
325
- - [ ] Pagination on list endpoints
326
-
327
- ### Verification
328
- - [ ] Tests pass
329
- - [ ] Build succeeds
330
- - [ ] Manual verification done (if applicable)
331
-
332
- ### Verdict
333
- - [ ] **Approve** — Ready to merge
334
- - [ ] **Request changes** — Issues must be addressed
335
- ```
336
- ## See Also
337
-
338
- - For detailed security review guidance, use [[secure]].
339
- - For performance review checks, use [[optimize]].
340
- - For code smells and no-bandaid/no-cast/no-assertion review, use [[quality-gate]].
341
- - Before claiming the change is ready, use [[verify]].
342
-
343
- ## Common Rationalizations
344
-
345
- | Rationalization | Reality |
346
- |---|---|
347
- | "It works, that's good enough" | Working code that's unreadable, insecure, or architecturally wrong creates debt that compounds. |
348
- | "I wrote it, so I know it's correct" | Authors are blind to their own assumptions. Every change benefits from another set of eyes. |
349
- | "We'll clean it up later" | Later never comes. The review is the quality gate — use it. Require cleanup before merge, not after. |
350
- | "AI-generated code is probably fine" | AI code needs more scrutiny, not less. It's confident and plausible, even when wrong. |
351
- | "The tests pass, so it's good" | Tests are necessary but not sufficient. They don't catch architecture problems, security issues, or readability concerns. |
352
-
353
- ## Red Flags
354
-
355
- - PRs merged without any review
356
- - Review that only checks if tests pass (ignoring other axes)
357
- - "LGTM" without evidence of actual review
358
- - Security-sensitive changes without security-focused review
359
- - Large PRs that are "too big to review properly" (split them)
360
- - No regression tests with bug fix PRs
361
- - Review comments without severity labels — makes it unclear what's required vs optional
362
- - Accepting "I'll fix it later" — it never happens
363
- - Accepting casts/assertions/workarounds/giant branches because tests happen to pass
364
-
365
- ## Verification
366
-
367
- After review is complete:
368
-
369
- - [ ] All Critical issues are resolved
370
- - [ ] All Important issues are resolved or explicitly deferred with justification
371
- - [ ] [[quality-gate]] was applied and no blocking smells remain
372
- - [ ] Tests pass
373
- - [ ] Build succeeds
374
- - [ ] The verification story is documented (what changed, how it was verified)
@@ -1,64 +0,0 @@
1
- ---
2
- name: dark-mode-image
3
- description: Create dark-mode variants of raster images for dark UI contexts.
4
- ---
5
-
6
- # Dark Mode Image
7
-
8
- Use this when the user wants to adapt a standalone source image into a dark-mode-suitable version.
9
-
10
- ## Activation
11
-
12
- ### Use For
13
-
14
- - creating a dark-mode version of an image, illustration, screenshot, photo, product mockup, decorative background, or texture
15
- - adapting an existing raster image so it presents correctly on a dark background
16
- - generating a dark-mode image variant for use in a dark-mode UI
17
-
18
- ### Do Not Use For
19
-
20
- - adding dark mode to a page, section, component, or site
21
- - SVG-only assets
22
- - general image styling in a UI without dark-mode conversion
23
-
24
- When the `add-dark-mode` skill identifies raster images that need dark-mode variants, use this skill for that image-generation work. This skill is the required handoff point between dark-mode UI work and raster image generation.
25
-
26
- ## Load First
27
-
28
- - Before image generation or editing, load and follow the `imagegen` skill.
29
-
30
- ## Progress Updates
31
-
32
- Keep the user informed so longer runs do not look stuck.
33
-
34
- - One-line status update before each major phase.
35
- - Concrete and lightweight: what you are doing now, not verbose logs.
36
-
37
- ## Workflow
38
-
39
- 1. Load `imagegen`.
40
- 2. Inspect the source image and the dark-mode UI context.
41
- 3. Generate or edit a dark-mode version with the same dimensions as the original.
42
- 4. Save the dark-mode image with a `-dark` suffix alongside the original.
43
- 5. Return the saved project path for the caller to wire into the UI.
44
-
45
- ## Rules
46
-
47
- - Before doing any image generation or editing, you MUST load and follow the `imagegen` skill
48
- - The `imagegen` skill invocation is not optional: do not skip it, do not replace it with an ad hoc image-generation workflow, and do not call image tooling directly without first applying `imagegen`
49
- - Let `imagegen` choose and run the correct image workflow; for normal dark-mode image variants, that will usually mean its default built-in `image_gen` tool mode
50
- - If the source image is a local file, follow `imagegen`'s local-image guidance before editing so the image is visible in the conversation context
51
- - Follow `imagegen`'s save-path policy: move or copy project-bound generated outputs into the workspace, and never leave a project-referenced dark-mode asset only under `$CODEX_HOME/*`
52
- - When generating a dark-mode image, choose a background color that feels like an appropriate inversion of the original background color: black or dark gray for white, dark gray for off-white, or the specific dark color provided by the user; if the original image's background matched the site background, match the dark-mode site background instead
53
- - Preserve the same contrast characteristics as the original image; light sections should become darker while relative separation and readability stay intact
54
- - Preserve blurs and softness; never sharpen anything that was blurry in the original image
55
- - Preserve the foreground color palette hues, adjusting saturation and lightness only as needed so the image presents correctly on a dark background
56
- - Preserve the original vibe as much as possible: bright and intense images should stay bright and intense, while subtle and muted images should stay subtle and muted
57
- - Pay attention to areas that fade out and preserve those fades in the dark-mode version
58
- - The generated dark-mode image must be exactly the same dimensions as the original image
59
- - Save dark-mode images with a `-dark` suffix, for example `bg.jpg` and `bg-dark.jpg`
60
-
61
- ## Verify
62
-
63
- - Confirm the generated image dimensions match the original exactly.
64
- - Confirm the dark-mode image preserves the original composition, softness, fades, and foreground palette.
@@ -1,58 +0,0 @@
1
- ---
2
- name: design
3
- description: Design and build new UI with the complete ui.sh design guideline system.
4
- ---
5
-
6
- # Design
7
-
8
- Use this when the user wants to create new UI that follows the full ui.sh design guideline system.
9
-
10
- ## Activation
11
-
12
- ### Use For
13
-
14
- - designing new UI, layouts, sections, components, or pages from scratch
15
- - implementing visually polished Tailwind CSS UI
16
- - adding a new section or page to an existing UI
17
- - applying reusable design, markup, and Tailwind authoring rules while building UI
18
-
19
- ### Do Not Use For
20
-
21
- - UI picker scaffolding only
22
- - semantic unstyled markup from screenshots, Figma exports, mockups, wireframes, or UI images
23
- - component extraction or code organization only
24
- - Tailwind class cleanup only
25
- - adding dark mode to an existing UI only
26
- - making an existing desktop-oriented UI responsive only
27
-
28
- ## Load First
29
-
30
- - Read [UI Design Guidelines](./design-guidelines.md) before writing UI code.
31
- - Scan the rule-file index and load every guideline file that could apply.
32
- - Load reference modules only when the request needs that reference material.
33
-
34
- ## Progress Updates
35
-
36
- Keep the user informed so longer runs do not look stuck.
37
-
38
- - One-line status update before each major phase.
39
- - Concrete and lightweight: what you are doing now, not verbose logs.
40
-
41
- ## Workflow
42
-
43
- 1. Inspect the user's request, target files, existing design conventions, and available components.
44
- 2. Load [UI Design Guidelines](./design-guidelines.md) plus every applicable rule file.
45
- 3. Implement the UI using the project's existing framework, component patterns, assets, and Tailwind conventions.
46
- 4. Check the result across responsive breakpoints and interaction states.
47
-
48
- ## Rules
49
-
50
- - Treat the guideline files in this skill as the source of truth for new UI design work.
51
- - Err on the side of loading too many applicable guideline files rather than too few.
52
- - Preserve user constraints unless a guideline explicitly requires asking about a design conflict.
53
-
54
- ## Verify
55
-
56
- - Check desktop and mobile layouts.
57
- - Confirm every applicable guideline file was loaded and followed.
58
- - Run relevant formatting, lint, typecheck, or tests when available.