@oisincoveney/pipeline 2.8.0 → 2.8.2

package/dist/runtime/agent-node/agent-node.js

@@ -6,80 +6,89 @@ import { normalizeJsonSource, readJsonSchemaSource, validateJsonSchemaSource } f
 import "../json-validation/index.js";
 import { emit, emitAgentFinish, emitAgentStart } from "../events/events.js";
 import "../events/index.js";
-import { estimateTokens } from "../../token-estimator.js";
-import { buildRepoMapContext } from "../../context/repo-map.js";
 import { gatewayServerForProfile } from "../../mcp/gateway.js";
 import { selectNodeModel } from "../../model-resolver.js";
+import { estimateTokens } from "../../token-estimator.js";
 import { handoffFinalizerPrompt, parseHandoff, renderHandoff, synthesizeMinimalHandoff } from "../handoff.js";
-import { readFileSync } from "node:fs";
+import { AgentNodeRuntimeService, AgentNodeRuntimeServiceLive } from "../services/agent-node-runtime-service.js";
+import { Effect } from "effect";
 //#region src/runtime/agent-node/agent-node.ts
-async function executeAgentNode(node, context, attempt) {
-	if (!node.profile) return {
-		evidence: [`node '${node.id}' has no profile`],
-		exitCode: 1,
-		output: ""
-	};
-	const prompt = await renderAgentPrompt(node, context);
-	const decision = decideNodeModel(prompt, node, context.config.token_budget);
-	if (decision.overBudget) return {
-		evidence: [
-			`agent boundary node=${node.id} profile=${node.profile}`,
-			`over token budget: ${decision.selection.reason}`,
-			...decision.selection.skipped.length ? [`model fallbacks skipped: ${decision.selection.skipped.join(", ")}`] : []
-		],
-		exitCode: 1,
-		output: ""
-	};
-	const modelSelection = decision.selection;
-	const plan = createRunnerLaunchPlan(context.config, {
-		model: modelSelection.model,
-		nodeId: node.id,
-		profileId: node.profile,
-		prompt,
-		worktreePath: context.worktreePath
-	});
-	if (node.timeoutMs) plan.timeoutMs = node.timeoutMs;
-	context.agentInvocations.push(plan);
-	emitAgentStart(context, plan, attempt);
-	const result = await context.executor(plan, {
-		onOutput: (event) => {
-			if (event.stream !== "stdout") return;
-			emit(context, {
-				attempt,
-				format: "text",
-				nodeId: node.id,
-				output: event.chunk,
-				...node.profile ? { profile: node.profile } : {},
-				type: "node.output.recorded"
-			});
-		},
-		signal: context.signal
-	});
-	emitAgentFinish(context, plan, attempt, result);
-	if (result.sessionId) context.nodeStateStore.recordSessionId(node.id, result.sessionId);
-	const finalized = await finalizeAgentOutput({
-		context,
-		node,
-		normalized: normalizeAgentOutput(plan, result.stdout),
-		plan,
-		result,
-		attempt
+function executeAgentNode(node, context, attempt) {
+	const program = executeAgentNodeEffect(node, context, attempt);
+	return Effect.runPromise(Effect.provide(program, AgentNodeRuntimeServiceLive));
+}
+function executeAgentNodeEffect(node, context, attempt) {
+	return Effect.gen(function* () {
+		if (!node.profile) return {
+			evidence: [`node '${node.id}' has no profile`],
+			exitCode: 1,
+			output: ""
+		};
+		const prompt = yield* renderAgentPromptEffect(node, context);
+		const decision = decideNodeModel(prompt, node, context.config.token_budget);
+		if (decision.overBudget) return {
+			evidence: [
+				`agent boundary node=${node.id} profile=${node.profile}`,
+				`over token budget: ${decision.selection.reason}`,
+				...decision.selection.skipped.length ? [`model fallbacks skipped: ${decision.selection.skipped.join(", ")}`] : []
+			],
+			exitCode: 1,
+			output: ""
+		};
+		const modelSelection = decision.selection;
+		const plan = createRunnerLaunchPlan(context.config, {
+			model: modelSelection.model,
+			nodeId: node.id,
+			profileId: node.profile,
+			prompt,
+			worktreePath: context.worktreePath
+		});
+		if (node.timeoutMs) plan.timeoutMs = node.timeoutMs;
+		context.agentInvocations.push(plan);
+		emitAgentStart(context, plan, attempt);
+		const result = yield* (yield* AgentNodeRuntimeService).executeRunner(context.executor, plan, {
+			onOutput: agentOutputRecorder(context, node, attempt),
+			signal: context.signal
+		});
+		emitAgentFinish(context, plan, attempt, result);
+		if (result.sessionId) context.nodeStateStore.recordSessionId(node.id, result.sessionId);
+		const finalized = yield* finalizeAgentOutputEffect({
+			context,
+			node,
+			normalized: normalizeAgentOutput(plan, result.stdout),
+			plan,
+			result,
+			attempt
+		});
+		const handoff = yield* maybeDeriveHandoffEffect(context, node, finalized.output, attempt);
+		return withOptionalHandoff({
+			evidence: [
+				`agent boundary node=${node.id} profile=${node.profile} runner=${plan.runnerId}`,
+				`estimated context tokens: ${decision.estimatedTokens}`,
+				`model selection: ${modelSelection.model ?? "profile/default"} (${modelSelection.reason})`,
+				...modelSelection.skipped.length ? [`model fallbacks skipped: ${modelSelection.skipped.join(", ")}`] : [],
+				...finalized.evidence,
+				...result.stderr ? [`stderr: ${result.stderr}`] : [],
+				...result.timedOut ? ["agent timed out"] : []
+			],
+			exitCode: result.exitCode,
+			output: finalized.output,
+			timedOut: result.timedOut
+		}, handoff);
 	});
-	const handoff = await maybeDeriveHandoff(context, node, finalized.output, attempt);
-	return withOptionalHandoff({
-		evidence: [
-			`agent boundary node=${node.id} profile=${node.profile} runner=${plan.runnerId}`,
-			`estimated context tokens: ${decision.estimatedTokens}`,
-			`model selection: ${modelSelection.model ?? "profile/default"} (${modelSelection.reason})`,
-			...modelSelection.skipped.length ? [`model fallbacks skipped: ${modelSelection.skipped.join(", ")}`] : [],
-			...finalized.evidence,
-			...result.stderr ? [`stderr: ${result.stderr}`] : [],
-			...result.timedOut ? ["agent timed out"] : []
-		],
-		exitCode: result.exitCode,
-		output: finalized.output,
-		timedOut: result.timedOut
-	}, handoff);
+}
+function agentOutputRecorder(context, node, attempt) {
+	return (event) => {
+		if (event.stream !== "stdout") return;
+		emit(context, {
+			attempt,
+			format: "text",
+			nodeId: node.id,
+			output: event.chunk,
+			...node.profile ? { profile: node.profile } : {},
+			type: "node.output.recorded"
+		});
+	};
 }
 function withOptionalHandoff(result, handoff) {
 	return handoff ? {
@@ -97,19 +106,22 @@ function profileRunner(context, node) {
 * raw output, falling back to a synthesized minimal handoff. Returns undefined
 * when disabled so behaviour is unchanged.
 */
-async function maybeDeriveHandoff(context, node, rawOutput, attempt) {
-	if (!context.config.context_handoff?.enabled) return;
-	return parseHandoff(rawOutput) ?? await runHandoffFinalizer(context, node, rawOutput, attempt);
-}
-async function runHandoffFinalizer(context, node, rawOutput, attempt) {
-	const runner = profileRunner(context, node);
-	if (!(runner && rawOutput.trim())) return synthesizeMinimalHandoff(rawOutput);
-	const plan = createHandoffFinalizerPlan(context, node, runner, rawOutput);
-	context.agentInvocations.push(plan);
-	emitAgentStart(context, plan, attempt);
-	const result = await context.executor(plan, { signal: context.signal });
-	emitAgentFinish(context, plan, attempt, result);
-	return parseHandoff(normalizeAgentOutput(plan, result.stdout).output) ?? synthesizeMinimalHandoff(rawOutput);
+function maybeDeriveHandoffEffect(context, node, rawOutput, attempt) {
+	if (!context.config.context_handoff?.enabled) return Effect.succeed(void 0);
+	const handoff = parseHandoff(rawOutput);
+	return handoff ? Effect.succeed(handoff) : runHandoffFinalizerEffect(context, node, rawOutput, attempt);
+}
+function runHandoffFinalizerEffect(context, node, rawOutput, attempt) {
+	return Effect.gen(function* () {
+		const runner = profileRunner(context, node);
+		if (!(runner && rawOutput.trim())) return synthesizeMinimalHandoff(rawOutput);
+		const plan = createHandoffFinalizerPlan(context, node, runner, rawOutput);
+		context.agentInvocations.push(plan);
+		emitAgentStart(context, plan, attempt);
+		const result = yield* (yield* AgentNodeRuntimeService).executeRunner(context.executor, plan, { signal: context.signal });
+		emitAgentFinish(context, plan, attempt, result);
+		return parseHandoff(normalizeAgentOutput(plan, result.stdout).output) ?? synthesizeMinimalHandoff(rawOutput);
+	}).pipe(Effect.catchAll(() => Effect.succeed(synthesizeMinimalHandoff(rawOutput))));
 }
 function createHandoffFinalizerPlan(context, node, runner, rawOutput) {
 	const finalizerProfileId = `${node.id}:handoff`;
@@ -160,13 +172,15 @@ function decideNodeModel(prompt, node, budget) {
 		selection
 	};
 }
-async function finalizeAgentOutput(inputs) {
-	const { attempt, context, node, normalized, plan, result } = inputs;
-	const validStructuredOutput = selectValidStructuredOutput(context, node, normalized, plan, result.stdout);
-	if (validStructuredOutput) return validStructuredOutput;
-	const repairContext = outputRepairContext(context, node, normalized, result);
-	if (!repairContext) return normalized;
-	return await runOutputRepair(context, node, normalized, repairContext, attempt);
+function finalizeAgentOutputEffect(inputs) {
+	return Effect.gen(function* () {
+		const { attempt, context, node, normalized, plan, result } = inputs;
+		const validStructuredOutput = selectValidStructuredOutput(context, node, normalized, plan, result.stdout);
+		if (validStructuredOutput) return validStructuredOutput;
+		const repairContext = outputRepairContext(context, node, normalized, result);
+		if (!repairContext) return normalized;
+		return yield* runOutputRepairEffect(context, node, normalized, repairContext, attempt);
+	});
 }
 function selectValidStructuredOutput(context, node, normalized, plan, stdout) {
 	const output = (node.profile ? context.config.profiles[node.profile] : void 0)?.output;
@@ -211,53 +225,56 @@ function outputRepairContext(context, node, normalized, result) {
 		validation: firstValidation
 	};
 }
-async function runOutputRepair(context, node, normalized, repairContext, nodeAttempt) {
-	let latest = normalized;
-	let latestValidation = repairContext.validation;
-	const evidence = [...repairContext.evidence];
-	for (let attempt = 1; attempt <= repairContext.maxAttempts; attempt += 1) {
-		const repairPlan = createOutputRepairPlan({
-			context,
-			node,
-			originalOutput: latest.output,
-			repairRunner: repairContext.runner,
-			schemaPath: repairContext.schemaPath,
-			validation: latestValidation
-		});
-		context.agentInvocations.push(repairPlan);
-		emitAgentStart(context, repairPlan, nodeAttempt);
-		const repairResult = await context.executor(repairPlan, { signal: context.signal });
-		emitAgentFinish(context, repairPlan, nodeAttempt, repairResult);
-		const repaired = normalizeAgentOutput(repairPlan, repairResult.stdout);
-		const repairedOutput = normalizeJsonSource(repaired.output);
-		const repairedValidation = validateJsonSchemaSource(repairedOutput, repairContext.schemaPath, context.worktreePath);
-		latest = {
-			evidence: [
-				...repaired.evidence,
-				...repairResult.stderr ? [`repair stderr: ${repairResult.stderr}`] : [],
-				...repairResult.timedOut ? ["output repair timed out"] : []
-			],
-			output: repairedOutput
-		};
-		latestValidation = repairedValidation;
-		const passed = repairResult.exitCode === 0 && repairedValidation.passed;
-		evidence.push(...repaired.evidence, passed ? `output repair passed for ${node.id} after attempt ${attempt}` : `output repair failed for ${node.id} after attempt ${attempt}`, ...repairedValidation.evidence.map((item) => `repaired output: ${item}`));
-		emit(context, {
-			attempt,
-			nodeId: node.id,
-			passed,
-			type: "output.repair",
-			...passed ? {} : { reason: repairedValidation.reason ?? "repair failed" }
-		});
-		if (passed) return {
+function runOutputRepairEffect(context, node, normalized, repairContext, nodeAttempt) {
+	return Effect.gen(function* () {
+		let latest = normalized;
+		let latestValidation = repairContext.validation;
+		const evidence = [...repairContext.evidence];
+		const service = yield* AgentNodeRuntimeService;
+		for (let attempt = 1; attempt <= repairContext.maxAttempts; attempt += 1) {
+			const repairPlan = createOutputRepairPlan({
+				context,
+				node,
+				originalOutput: latest.output,
+				repairRunner: repairContext.runner,
+				schemaPath: repairContext.schemaPath,
+				validation: latestValidation
+			});
+			context.agentInvocations.push(repairPlan);
+			emitAgentStart(context, repairPlan, nodeAttempt);
+			const repairResult = yield* service.executeRunner(context.executor, repairPlan, { signal: context.signal });
+			emitAgentFinish(context, repairPlan, nodeAttempt, repairResult);
+			const repaired = normalizeAgentOutput(repairPlan, repairResult.stdout);
+			const repairedOutput = normalizeJsonSource(repaired.output);
+			const repairedValidation = validateJsonSchemaSource(repairedOutput, repairContext.schemaPath, context.worktreePath);
+			latest = {
+				evidence: [
+					...repaired.evidence,
+					...repairResult.stderr ? [`repair stderr: ${repairResult.stderr}`] : [],
+					...repairResult.timedOut ? ["output repair timed out"] : []
+				],
+				output: repairedOutput
+			};
+			latestValidation = repairedValidation;
+			const passed = repairResult.exitCode === 0 && repairedValidation.passed;
+			evidence.push(...repaired.evidence, passed ? `output repair passed for ${node.id} after attempt ${attempt}` : `output repair failed for ${node.id} after attempt ${attempt}`, ...repairedValidation.evidence.map((item) => `repaired output: ${item}`));
+			emit(context, {
+				attempt,
+				nodeId: node.id,
+				passed,
+				type: "output.repair",
+				...passed ? {} : { reason: repairedValidation.reason ?? "repair failed" }
+			});
+			if (passed) return {
+				evidence,
+				output: repairedOutput
+			};
+		}
+		return {
 			evidence,
-			output: repairedOutput
+			output: latest.output
 		};
-	}
-	return {
-		evidence,
-		output: latest.output
-	};
+	});
 }
 function outputRepairOptions(output) {
 	const repair = output.repair;
@@ -308,24 +325,39 @@ function createOutputRepairPlan(inputs) {
 function normalizeAgentOutput(plan, stdout) {
 	return normalizeRunnerOutput(plan, stdout);
 }
-async function repoMapSection(node, context) {
+function repoMapSectionEffect(node, context) {
 	const repoMap = context.config.repo_map;
-	if (!repoMap?.enabled) return "";
-	try {
-		return (await buildRepoMapContext({
-			artifacts: node.needs.flatMap((need) => context.nodeStateStore.handoff(need)?.artifacts ?? []),
-			taskText: context.task,
-			tokenBudget: repoMap.token_budget,
-			worktreePath: context.worktreePath
+	if (!repoMap?.enabled) return Effect.succeed("");
+	return Effect.gen(function* () {
+		const service = yield* AgentNodeRuntimeService;
+		return (yield* Effect.tryPromise({
+			catch: () => "",
+			try: () => service.buildRepoMap({
+				artifacts: node.needs.flatMap((need) => context.nodeStateStore.handoff(need)?.artifacts ?? []),
+				taskText: context.task,
+				tokenBudget: repoMap.token_budget,
+				worktreePath: context.worktreePath
+			})
 		})).context;
-	} catch {
-		return "";
-	}
+	}).pipe(Effect.catchAll(() => Effect.succeed("")));
 }
-async function renderAgentPrompt(node, context) {
-	const profile = node.profile ? context.config.profiles[node.profile] : void 0;
-	const instructions = profile ? readInstructions(context.worktreePath, profile.instructions) : "";
-	const repoMap = await repoMapSection(node, context);
+function renderAgentPromptEffect(node, context) {
+	return Effect.gen(function* () {
+		const profile = node.profile ? context.config.profiles[node.profile] : void 0;
+		const instructions = profile ? yield* readInstructionsEffect(context.worktreePath, profile.instructions) : "";
+		const repoMap = yield* repoMapSectionEffect(node, context);
+		return agentPromptSections({
+			context,
+			instructions,
+			node,
+			pathReferences: yield* renderProfilePathReferences(profile, context),
+			profile,
+			repoMap
+		}).filter(Boolean).join("\n");
+	});
+}
+function agentPromptSections(inputs) {
+	const { context, instructions, node, pathReferences, profile, repoMap } = inputs;
 	return [
 		instructions.trim(),
 		"",
@@ -343,14 +375,16 @@ async function renderAgentPrompt(node, context) {
 		`- rules: ${(profile?.rules ?? []).join(", ") || "none"}`,
 		`- skills: ${(profile?.skills ?? []).join(", ") || "none"}`,
 		`- mcp_servers: ${(profile?.mcp_servers ?? []).join(", ") || "none"}`,
-		renderPathReferences("Loaded rules", profile?.rules, context.config.rules, context.worktreePath),
-		renderPathReferences("Loaded skills", profile?.skills, context.config.skills, context.worktreePath),
+		...pathReferences,
 		renderMcpReferences(context.config, profile),
 		"",
 		...inheritedOutputSections(node, context),
 		"Dependency outputs:",
 		...node.needs.map((need) => renderDependencySection(need, context))
-	].filter(Boolean).join("\n");
+	];
+}
+function renderProfilePathReferences(profile, context) {
+	return Effect.all([renderPathReferencesEffect("Loaded rules", profile?.rules, context.config.rules, context.worktreePath), renderPathReferencesEffect("Loaded skills", profile?.skills, context.config.skills, context.worktreePath)]);
 }
 /**
 * PIPE-83.5: render a dependency's curated NodeHandoff when one was derived
@@ -420,31 +454,38 @@ function renderTaskContext(taskContext) {
 		...acceptance.map((criterion) => `- ${criterion.id}: ${criterion.text}`)
 	].filter(Boolean).join("\n");
 }
-function readInstructions(worktreePath, instructions) {
-	if (instructions.inline) return instructions.inline;
-	if (instructions.path) return readFileSync(resolveFileReference(worktreePath, instructions.path), "utf8");
-	return "";
+function readInstructionsEffect(worktreePath, instructions) {
+	if (instructions.inline) return Effect.succeed(instructions.inline);
+	if (instructions.path) {
+		const instructionPath = instructions.path;
+		return AgentNodeRuntimeService.pipe(Effect.flatMap((service) => service.readText(resolveFileReference(worktreePath, instructionPath))));
+	}
+	return Effect.succeed("");
 }
-function renderPathReferences(heading, ids, registry, worktreePath) {
-	if (!ids?.length) return "";
-	return [
+function renderPathReferencesEffect(heading, ids, registry, worktreePath) {
+	if (!ids?.length) return Effect.succeed("");
+	return Effect.gen(function* () {
+		const sections = yield* Effect.all(ids.map((id) => renderPathReferenceEffect(id, registry, worktreePath)));
+		return [
+			"",
+			`${heading}:`,
+			...sections
+		].join("\n");
+	});
+}
+function renderPathReferenceEffect(id, registry, worktreePath) {
+	const ref = registry[id];
+	const path = ref?.path ?? "";
+	const resolved = resolveRuntimePathReference(worktreePath, ref);
+	return AgentNodeRuntimeService.pipe(Effect.flatMap((service) => service.readText(resolved)), Effect.map((content) => [
+		`## ${id}`,
+		`Path: ${path}`,
 		"",
-		`${heading}:`,
-		...ids.map((id) => {
-			const ref = registry[id];
-			const path = ref?.path ?? "";
-			const content = readFileSync(resolveRuntimePathReference(worktreePath, ref), "utf8").trimEnd();
-			return [
-				`## ${id}`,
-				`Path: ${path}`,
-				"",
-				content
-			].join("\n");
-		})
-	].join("\n");
+		content.trimEnd()
+	].join("\n")));
 }
 function resolveRuntimePathReference(worktreePath, ref) {
-	if (ref?.source_root === "package") return resolvePackageAssetPath(ref.path);
+	if (ref?.source_root === "package") return resolvePackageAssetPath(ref.path ?? "");
 	return resolveFileReference(worktreePath, ref?.path ?? "");
 }
 function renderMcpReferences(config, profile) {