@oino-ts/db-mssql 0.6.0 → 0.6.1

package/README.md

@@ -1,190 +1,183 @@
 # OINO TS
- OINO Is Not an ORM but it's trying to solve a similar problem for API development. Instead of mirroring your DB schema in code that needs manual updates, OINO will get the data schema from DBMS using SQL in real time. Every time your app starts, it has an updated data model which enables automatic (de)serialize SQL results to JSON/CSV and back. OINO works on the level below routing where you pass the method, URL ID, body and request parameters to the API-object. OINO will parse and validate the data against the data model and generate proper SQL for your DB. Because OINO knows how data is serialized (e.g. JSON), what column it belongs to (e.g. floating point number) and what the target database is, it knows how to parse, format and escape the value as valid SQL.
- 
- ```
- const result:OINOApiResult = await api_orderdetails.doRequest("GET", id, body, params)
- return new Response(result.modelset.writeString(OINOContentType.json))
- ```
- 
-
- # GETTING STARTED
- 
- ### Setup
- Install the `@oino-ts/db` npm package and necessary database packages and import them in your code.
- ```
- bun install @oino-ts/db
- bun install @oino-ts/db-bunsqlite
- ```
- 
- ```
- import { OINODb, OINOApi, OINOFactory } from "@oino-ts/db";
- import { OINODbBunSqlite } from "@oino-ts/db-bunsqlite"
- ```
- 
- ### Register database and logger
- Register your database implementation and logger (see [`OINOConsoleLog`](https://pragmatta.github.io/oino-ts/classes/types_src.OINOConsoleLog.html) how to implement your own)
-
- ```
- OINOLog.setLogger(new OINOConsoleLog())
- OINOFactory.registerDb("OINODbBunSqlite", OINODbBunSqlite)
- ```
-
- ### Create a database
- Creating a database connection [`OINODb`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODb.html) is done by passing [`OINODbParams`](https://pragmatta.github.io/oino-ts/types/db_src.OINODbParams.html) to the factory method. For [`OINODbBunSqlite`](https://pragmatta.github.io/oino-ts/classes/db_bunsqlite_src.OINODbBunSqlite.html) that means a file url for the database file, for others network host, port, credentials etc.
- ```
- const db:OINODb = await OINOFactory.createDb( { type: "OINODbBunSqlite", url: "file://../localDb/northwind.sqlite" } )
- ```
-
- ### Create an API
- From a database you can create an [`OINOApi`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbApi.html) by passing [`OINOApiParams`](https://pragmatta.github.io/oino-ts/types/db_src.OINODbApiParams.html) with table name and preferences to the factory method.
- ```
- const api_employees:OINOApi = await OINOFactory.createApi(db, { tableName: "Employees", excludeFields:["BirthDate"] })
- ```
-
- ### Pass HTTP requests to API
- When you receive a HTTP request, just pass the method, URL ID, body and params to the correct API, which will parse and validate input and return results.
-
- ```
- const result:OINOApiResult = await api_orderdetails.doRequest("GET", id, body, params)
- ```
-
- ### Write results back to HTTP Response
- The results for a GET request will contain [`OINOModelSet`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbModelSet.html) data that can be written out as JSON or CSV as needed. For other requests result is just success or error with messages.
- ```
- return new Response(result.data.writeString(OINOContentType.json))
- ```
- 
- 
- # FEATURES
- 
- ## RESTfull
- OINO maps HTTP methods GET/POST/PUT/DELETE to SQL operations SELECT/INSERT/UPDATE/DELETE. The GET/POST requests can be made without URL ID to get all rows or insert new ones and others target a single row using URL ID. 
-
- For example HTTP POST 
- ```
- Request and response:
- > curl.exe -X POST http://localhost:3001/orderdetails -H "Content-Type: application/json" --data '[{\"OrderID\":11077,\"ProductID\":99,\"UnitPrice\":19,\"Quantity\":1,\"Discount\":0}]'
- {"success":true,"statusCode":200,"statusMessage":"OK","messages":[]}
-
- SQL:
- INSERT INTO [OrderDetails] ("OrderID","ProductID","UnitPrice","Quantity","Discount") VALUES (11077,99,19,1,0);
- ```
-
-
- ## Universal Serialization
- OINO handles serialization of data to JSON/CSV/etc. and back based on the data model. It knows what columns exist, what is their data type and how to convert each to JSON/CSV and back. This allows also partial data to be sent, i.e. you can send only columns that need updating or even send extra columns and have them ignored.
-
- ### Features
- - Files can be sent to BLOB fields using BASE64 or MIME multipart encoding. Also supports standard HTML form file submission to blob fields and returning them data url images.
- - Datetimes are (optionally) normalized to ISO 8601 format.
- - Extended JSON-encoding
-   - Unquoted literal `undefined` can be used to represent non-existent values (leaving property out works too but preserving structure might be easier e.g. when translating data).
- - CSV
-   - Comma-separated, doublequotes.
-   - Unquoted literal `null` represents null values.
-   - Unquoted empty string represents undefined values.
- - Form data
-   - Multipart-mixed and binary files not supported.
-   - Non-existent value line (i.e. nothing after the empty line) treated as a null value.
- - Url-encoded
-   - No null values, missing properties treated as undefined.
-   - Multiple lines could be used to post multiple rows.
-
-
- ## Database Abstraction
- OINO functions as a database abstraction, providing a consistent interface for working with different databases. It abstracts out different conventions in connecting, making queries and formatting data.
-
- Currently supported databases:
- - Bun Sqlite through Bun native implementation
- - Postgresql through [pg](https://www.npmjs.com/package/pg)-package
- - Mariadb / Mysql-support through [mariadb](https://www.npmjs.com/package/mariadb)-package
- - Sql Server through [mssql](https://www.npmjs.com/package/mssql)-package
-
- ## Composite Keys
- To support tables with multipart primary keys OINO generates a composite key `_OINOID_` that is included in the result and can be used as the REST ID. For example in the example above table `OrderDetails` has two primary keys `OrderID` and `ProductID` making the `_OINOID_` of form `11077:99`. 
-
- ## Power Of SQL
- Since OINO is just generating SQL, WHERE-conditions can be defined with [`OINOSqlFilter`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlFilter.html), order with [`OINOSqlOrder`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlOrder.html) and limits/paging with [`OINOSqlLimit`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlLimit.html) that are passed as HTTP request parameters. No more API development where you make unique API endpoints for each filter that fetch all data with original API and filter in backend code. Every API can be filtered when and as needed without unnessecary data tranfer and utilizing SQL indexing when available.
-
- ## Swagger Support
- Swagger is great as long as the definitions are updated and with OINO you can automatically get a Swagger definition including a data model schema.
- ```
- if (url.pathname == "/swagger.json") {
-    return new Response(JSON.stringify(OINOSwagger.getApiDefinition(api_array)))
- }
- ```
- ![Swagger definition with a data model schema](img/readme-swagger.png)
-
- ## Node support
- OINO is developped Typescript first but compiles to standard CommonJS and the NPM packages should work on either ESM / CommonJS. Checkout sample apps `readmeApp` (ESM) and `nodeApp` (CommonJS).
-
- ## HTMX support
- OINO is [htmx.org](https://htmx.org) friendly, allowing easy translation of [`OINODataRow`](https://pragmatta.github.io/oino-ts/types/db_src.OINODataRow.html) to HTML output using templates (cf. the [htmx sample app](https://github.com/pragmatta/oino-ts/tree/main/samples/htmxApp)).
-
- ## Hashids
- Autoinc numeric id's are very pragmatic and fit well with OINO (e.g. using a form without primary key fields to insert new rows with database assigned ids). However it's not always sensible to share information about the sequence. Hashids solve this by masking the original values by encrypting the ids using AES-128 and some randomness. Length of the hashid can be chosen from 12-32 characters where longer ids provide more security. However this should not be considereded a cryptographic solution for keeping ids secret but rather making it infeasible to iterate all ids.
-
-
- # STATUS
- OINO is currently a hobby project which should and should considered in alpha status. That also means compatibility breaking changes can be made without prior notice when architectual issues are discovered.
-
- ## Beta 
- For a beta status following milestones are planned:
-
- ### Realistic app
- There needs to be a realistic app built on top of OINO to get a better grasp of the edge cases.
- 
- ## Roadmap
- Things that need to happen in some order before beta-status are at least following:
- 
- ### Support for views
- Simple cases of views would work already in some databases but edge cases might get complicated. For example 
- - How to handle a view which does not have a complete private key?
- - What edge cases exist in updating views?
-
- ### Batch updates
- Supporting batch updates similar to batch inserts is slightly bending the RESTfull principles but would still be a useful optional feature.
-
- ### Aggregation
- Similar to filtering, ordering and limits, aggregation could be implemented as HTTP request parameters telling what column is aggregated or used for ordering or how many results to return.
-
- ### Streaming
- One core idea is to be efficient in not making unnecessary copies of the data and minimizing garbage collection debt. This can be taken further by implementing streaming, allowing large dataset to be written to HTTP response as SQL result rows are received.
-
- ### SQL generation callbacks
- It would be useful to allow developer to validate / override SQL generation to cover cases OINO does not support or even workaround issues.
-
- ### Transactions
- Even though the basic case for OINO is executing SQL operations on individual rows, having an option to use SQL transactions could make sense at least for batch operations.
-
-
- # HELP
- 
- ## Bug reports
- Fixing bugs is a priority and getting good quality bug reports helps. It's recommended to use the sample Northwind database included with project to replicate issues or make an SQL script export of the relevant table.
-  
- ## Feedback
- Understanding and prioritizing the use cases for OINO is also important and feedback about how you'd use OINO is interesting. Feel free to raise issues and feature requests in Github, but understand that short term most of the effort goes towards reaching the beta stage.
-
- ## Typescript / Javascript architecture
- Typescript building with different targets and module-systemts and a ton of configuration is a complex domain and something I have little experience un so help in fixing problems and how thing ought to be done is appreciated.
- 
- # LINKS
- - [Github repository](https://github.com/pragmatta/oino-ts)
- - [NPM repository](https://www.npmjs.com/org/oino-ts) 
- 
- 
- # ACKNOWLEDGEMENTS
- 
- ## Libraries
- OINO uses the following open source libraries and npm packages and I would like to thank everyone for their contributions:
- - Postgresql [node-postgres package](https://www.npmjs.com/package/pg)
- - Mariadb / Mysql [mariadb package](https://www.npmjs.com/package/mariadb)
- - Sql Server [mssql package](https://www.npmjs.com/package/mssql)
- - Custom base encoding [base-x package](https://www.npmjs.com/package/base-x)
-
- ## Bun
- OINO has been developed using the Bun runtime, not because of the speed improvements but for the first class Typescript support and integrated developper experience. Kudos on the bun team for making Typescript work more exiting again.
- 
- ## SQL Scripts
- The SQL scripts for creating the sample Northwind database are based on [Google Code archive](https://code.google.com/archive/p/northwindextended/downloads) and have been further customized to ensure they would have identical data (in the scope of the automated testing).
+OINO Is Not an ORM but it's trying to solve a similar problem for API development. Instead of mirroring your DB schema in code that needs manual updates, OINO will get the data schema from DBMS using SQL in real time. Every time your app starts, it has an updated data model which enables automatic (de)serialize SQL results to JSON/CSV and back. OINO works on the level below routing where you pass the method, URL ID, body and request parameters to the API-object. OINO will parse and validate the data against the data model and generate proper SQL for your DB. Because OINO knows how data is serialized (e.g. JSON), what column it belongs to (e.g. floating point number) and what the target database is, it knows how to parse, format and escape the value as valid SQL.
+
+```
+const result:OINOApiResult = await api_orderdetails.doRequest("GET", id, body, params)
+return new Response(result.modelset.writeString(OINOContentType.json))
+```
+
+
+# GETTING STARTED
+
+### Setup
+Install the `@oino-ts/db` npm package and necessary database packages and import them in your code.
+```
+bun install @oino-ts/db
+bun install @oino-ts/db-bunsqlite
+```
+
+```
+import { OINODb, OINOApi, OINOFactory } from "@oino-ts/db";
+import { OINODbBunSqlite } from "@oino-ts/db-bunsqlite"
+```
+
+### Register database and logger
+Register your database implementation and logger (see [`OINOConsoleLog`](https://pragmatta.github.io/oino-ts/classes/types_src.OINOConsoleLog.html) how to implement your own)
+
+```
+OINOLog.setLogger(new OINOConsoleLog())
+OINOFactory.registerDb("OINODbBunSqlite", OINODbBunSqlite)
+```
+
+### Create a database
+Creating a database connection [`OINODb`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODb.html) is done by passing [`OINODbParams`](https://pragmatta.github.io/oino-ts/types/db_src.OINODbParams.html) to the factory method. For [`OINODbBunSqlite`](https://pragmatta.github.io/oino-ts/classes/db_bunsqlite_src.OINODbBunSqlite.html) that means a file url for the database file, for others network host, port, credentials etc.
+```
+const db:OINODb = await OINOFactory.createDb( { type: "OINODbBunSqlite", url: "file://../localDb/northwind.sqlite" } )
+```
+
+### Create an API
+From a database you can create an [`OINOApi`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbApi.html) by passing [`OINOApiParams`](https://pragmatta.github.io/oino-ts/types/db_src.OINODbApiParams.html) with table name and preferences to the factory method.
+```
+const api_employees:OINOApi = await OINOFactory.createApi(db, { tableName: "Employees", excludeFields:["BirthDate"] })
+```
+
+### Pass HTTP requests to API
+When you receive a HTTP request, just pass the method, URL ID, body and params to the correct API, which will parse and validate input and return results.
+
+```
+const result:OINOApiResult = await api_orderdetails.doRequest("GET", id, body, params)
+```
+
+### Write results back to HTTP Response
+The results for a GET request will contain [`OINOModelSet`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbModelSet.html) data that can be written out as JSON or CSV as needed. For other requests result is just success or error with messages.
+```
+return new Response(result.data.writeString(OINOContentType.json))
+```
+
+
+# MAIN FEATURES
+
+## RESTfull
+OINO maps HTTP methods GET/POST/PUT/DELETE to SQL operations SELECT/INSERT/UPDATE/DELETE. The GET/POST requests can be made without URL ID to get all rows or insert new ones and others target a single row using URL ID. 
+
+For example HTTP POST 
+```
+Request and response:
+> curl.exe -X POST http://localhost:3001/orderdetails -H "Content-Type: application/json" --data '[{\"OrderID\":11077,\"ProductID\":99,\"UnitPrice\":19,\"Quantity\":1,\"Discount\":0}]'
+{"success":true,"statusCode":200,"statusMessage":"OK","messages":[]}
+
+SQL:
+INSERT INTO [OrderDetails] ("OrderID","ProductID","UnitPrice","Quantity","Discount") VALUES (11077,99,19,1,0);
+```
+
+
+## Universal Serialization
+OINO handles serialization of data to JSON/CSV/etc. and back based on the data model. It knows what columns exist, what is their data type and how to convert each to JSON/CSV and back. This allows also partial data to be sent, i.e. you can send only columns that need updating or even send extra columns and have them ignored.
+
+- Files can be sent to BLOB fields using BASE64 or MIME multipart encoding. Also supports standard HTML form file submission to blob fields and returning them data url images.
+- Datetimes are (optionally) normalized to ISO 8601 format.
+- Extended JSON-encoding
+  - Unquoted literal `undefined` can be used to represent non-existent values (leaving property out works too but preserving structure might be easier e.g. when translating data).
+- CSV
+  - Comma-separated, doublequotes.
+  - Unquoted literal `null` represents null values.
+  - Unquoted empty string represents undefined values.
+- Form data
+  - Multipart-mixed and binary files not supported.
+  - Non-existent value line (i.e. nothing after the empty line) treated as a null value.
+- Url-encoded
+  - No null values, missing properties treated as undefined.
+  - Multiple lines could be used to post multiple rows.
+
+
+## Database Abstraction
+OINO functions as a database abstraction, providing a consistent interface for working with different databases. It abstracts out different conventions in connecting, making queries and formatting data.
+
+Currently supported databases:
+- Bun Sqlite through Bun native implementation
+- Postgresql through [pg](https://www.npmjs.com/package/pg)-package
+- Mariadb / Mysql-support through [mariadb](https://www.npmjs.com/package/mariadb)-package
+- Sql Server through [mssql](https://www.npmjs.com/package/mssql)-package
+
+## Composite Keys
+To support tables with multipart primary keys OINO generates a composite key `_OINOID_` that is included in the result and can be used as the REST ID. For example in the example above table `OrderDetails` has two primary keys `OrderID` and `ProductID` making the `_OINOID_` of form `11077:99`. 
+
+## Power Of SQL
+Since OINO is just generating SQL, WHERE-conditions can be defined with [`OINOSqlFilter`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlFilter.html), order with [`OINOSqlOrder`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlOrder.html) and limits/paging with [`OINOSqlLimit`](https://pragmatta.github.io/oino-ts/classes/db_src.OINODbSqlLimit.html) that are passed as HTTP request parameters. No more API development where you make unique API endpoints for each filter that fetch all data with original API and filter in backend code. Every API can be filtered when and as needed without unnessecary data tranfer and utilizing SQL indexing when available.
+
+## Swagger Support
+Swagger is great as long as the definitions are updated and with OINO you can automatically get a Swagger definition including a data model schema.
+```
+if (url.pathname == "/swagger.json") {
+  return new Response(JSON.stringify(OINOSwagger.getApiDefinition(api_array)))
+}
+```
+![Swagger definition with a data model schema](img/readme-swagger.png)
+
+## Node support
+OINO is developped Typescript first but compiles to standard CommonJS and the NPM packages should work on either ESM / CommonJS. Checkout sample apps `readmeApp` (ESM) and `nodeApp` (CommonJS).
+
+## HTMX support
+OINO is [htmx.org](https://htmx.org) friendly, allowing easy translation of [`OINODataRow`](https://pragmatta.github.io/oino-ts/types/db_src.OINODataRow.html) to HTML output using templates (cf. the [htmx sample app](https://github.com/pragmatta/oino-ts/tree/main/samples/htmxApp)).
+
+## Hashids
+Autoinc numeric id's are very pragmatic and fit well with OINO (e.g. using a form without primary key fields to insert new rows with database assigned ids). However it's not always sensible to share information about the sequence. Hashids solve this by masking the original values by encrypting the ids using AES-128 and some randomness. Length of the hashid can be chosen from 12-32 characters where longer ids provide more security. However this should not be considereded a cryptographic solution for keeping ids secret but rather making it infeasible to iterate all ids.
+
+
+# STATUS
+OINO is currently a side project which should considered in beta status. That means that semantic versioning is the goal but backwards incompatible changes can still happen in point releases if serious architectual issues are discovered.
+
+## Roadmap
+Major features that are considered in future releases ()
+
+### Support for views
+Simple cases of views probably work already in some databases but edge cases might get complicated.
+
+For example issues could be
+- How to handle a view which does not have a complete private key?
+- What edge cases exist in updating views?
+- Can views be handled transparently to the DBMS or is there some fundamentally platform specific behavior?
+
+### Batch updates
+Supporting batch updates similar to batch inserts is slightly bending the RESTfull principles but would still be a useful optional feature in some situations.
+
+### Streaming
+One core idea is to be efficient in not making unnecessary copies of the data and minimizing garbage collection debt. This can be taken further by implementing streaming, allowing large dataset to be written to HTTP response as SQL result rows are received.
+
+### SQL generation callbacks
+It would be useful to allow developer to validate / override SQL generation to cover cases OINO does not support or even workaround issues.
+
+### Transactions
+Even though the basic case for OINO is executing SQL operations on individual rows, having an option to use SQL transactions could make sense at least for batch operations.
+
+
+# HELP
+
+## Bug reports
+Fixing bugs is a priority and getting good quality bug reports helps. It's recommended to use the sample Northwind database included with project to replicate issues or make an SQL script export of the relevant table.
+
+## Feedback
+Understanding and prioritizing the use cases for OINO is also important and feedback about how you'd use OINO is interesting. Feel free to raise issues and feature requests in Github, but understand that short term most of the effort goes towards reaching the beta stage.
+
+## Typescript / Javascript architecture
+Typescript building with different targets and module-systemts and a ton of configuration is a complex domain and something I have little experience un so help in fixing problems and how thing ought to be done is appreciated.
+
+# LINKS
+- [Github repository](https://github.com/pragmatta/oino-ts)
+- [NPM repository](https://www.npmjs.com/org/oino-ts) 
+
+
+# ACKNOWLEDGEMENTS
+
+## Libraries
+OINO uses the following open source libraries and npm packages and I would like to thank everyone for their contributions:
+- Postgresql [node-postgres package](https://www.npmjs.com/package/pg)
+- Mariadb / Mysql [mariadb package](https://www.npmjs.com/package/mariadb)
+- Sql Server [mssql package](https://www.npmjs.com/package/mssql)
+- Custom base encoding [base-x package](https://www.npmjs.com/package/base-x)
+
+## Bun
+OINO has been developed using the Bun runtime, not because of the speed improvements but for the first class Typescript support and integrated developper experience. Kudos on the bun team for making Typescript work more exiting again.
+
+## SQL Scripts
+The SQL scripts for creating the sample Northwind database are based on [Google Code archive](https://code.google.com/archive/p/northwindextended/downloads) and have been further customized to ensure they would have identical data (in the scope of the automated testing).

package/dist/cjs/OINODbMsSql.js

@@ -109,11 +109,11 @@ class OINODbMsSql extends db_1.OINODb {
             throw new Error(db_1.OINO_ERROR_PREFIX + ": Not OINODbMsSql-type: " + this._params.type);
         }
         this._pool = new mssql_1.ConnectionPool({
-            user: params.user,
-            password: params.password,
-            server: params.url,
-            port: params.port,
-            database: params.database,
+            user: this._params.user,
+            password: this._params.password,
+            server: this._params.url,
+            port: this._params.port,
+            database: this._params.database,
             arrayRowMode: true,
             options: {
                 encrypt: true, // Use encryption for Azure SQL Database
@@ -122,18 +122,19 @@ class OINODbMsSql extends db_1.OINODb {
                 trustServerCertificate: true // Change to false for production
             }
         });
-        //this._pool = new ConnectionPool({connectionString: "Server=localhost,1433;Database=database;User Id=username;Password=" + params.password + ";Encrypt=true"})
+        delete this._params.password; // do not store password in db object
         this._pool.on("error", (conn) => {
-            // console.log("OINODbMsSql error", conn)
-        });
-        this._pool.on("debug", (event) => {
-            // console.log("OINODbMsSql debug",event)
+            db_1.OINOLog.error("OINODbMsSql error event", conn);
         });
+        // this._pool.on("debug", (event:any) => {
+        //     console.log("OINODbMsSql debug",event)
+        // })
     }
     async _query(sql) {
         // OINOLog.debug("OINODbMsSql._query", {sql:sql})
         try {
-            const sql_res = await this._pool.request().query(sql);
+            const request = this._pool.request(); // this does not need to be released but the pool will handle it
+            const sql_res = await request.query(sql);
             // console.log("OINODbMsSql._query result:" + JSON.stringify(sql_res.recordsets))
             const result = new OINOMsSqlData(sql_res.recordsets);
             return Promise.resolve(result);
@@ -294,45 +295,53 @@ class OINODbMsSql extends db_1.OINODb {
      *
      */
     async connect() {
+        let result = new db_1.OINOResult();
         try {
             // make sure that any items are correctly URL encoded in the connection string
             await this._pool.connect();
             // OINOLog.info("OINODbMsSql.connect: Connected to database server.")
-            await this._pool.request().query("SELECT 1 as test");
-            return Promise.resolve(true);
+            // await this._pool.request().query("SELECT 1 as test")
+            this.isConnected = true;
         }
         catch (err) {
             // ... error checks
-            throw new Error(db_1.OINO_ERROR_PREFIX + ": Error connecting to OINODbMsSql server: " + err);
+            result.setError(500, "Exception connecting to database: " + err.message, "OINODbMsSql.connect");
+            db_1.OINOLog.error(result.statusMessage, { error: err });
         }
+        return Promise.resolve(result);
     }
     /**
      * Validate connection to database is working.
      *
      */
     async validate() {
-        db_1.OINOBenchmark.start("OINODb", "validate");
         let result = new db_1.OINOResult();
+        if (!this.isConnected) {
+            result.setError(400, "Database is not connected!", "OINODbMsSql.validate");
+            return result;
+        }
+        db_1.OINOBenchmark.start("OINODb", "validate");
         try {
             const sql = this._getValidateSql(this._params.database);
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql:sql})
+            // OINOLog.debug("OINODbMsSql.validate", {sql:sql})
             const sql_res = await this.sqlSelect(sql);
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql_res:sql_res})
+            // OINOLog.debug("OINODbMsSql.validate", {sql_res:sql_res})
             if (sql_res.isEmpty()) {
-                result.setError(400, "DB returned no rows for select!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no rows for select!", "OINODbMsSql.validate");
             }
             else if (sql_res.getRow().length == 0) {
-                result.setError(400, "DB returned no values for database!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no values for database!", "OINODbMsSql.validate");
             }
             else if (sql_res.getRow()[0] == "0") {
-                result.setError(400, "DB returned no schema for database!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no schema for database!", "OINODbMsSql.validate");
             }
             else {
                 // connection is working
+                this.isValidated = true;
             }
         }
         catch (e) {
-            result.setError(500, db_1.OINO_ERROR_PREFIX + " (validate): OINODbBunSqlite.validate exception in _db.query: " + e.message, "OINODbBunSqlite.validate");
+            result.setError(500, "Exception in validating connection: " + e.message, "OINODbMsSql.validate");
         }
         db_1.OINOBenchmark.end("OINODb", "validate");
         return result;

package/dist/esm/OINODbMsSql.js

@@ -106,11 +106,11 @@ export class OINODbMsSql extends OINODb {
             throw new Error(OINO_ERROR_PREFIX + ": Not OINODbMsSql-type: " + this._params.type);
         }
         this._pool = new ConnectionPool({
-            user: params.user,
-            password: params.password,
-            server: params.url,
-            port: params.port,
-            database: params.database,
+            user: this._params.user,
+            password: this._params.password,
+            server: this._params.url,
+            port: this._params.port,
+            database: this._params.database,
             arrayRowMode: true,
             options: {
                 encrypt: true, // Use encryption for Azure SQL Database
@@ -119,18 +119,19 @@ export class OINODbMsSql extends OINODb {
                 trustServerCertificate: true // Change to false for production
             }
         });
-        //this._pool = new ConnectionPool({connectionString: "Server=localhost,1433;Database=database;User Id=username;Password=" + params.password + ";Encrypt=true"})
+        delete this._params.password; // do not store password in db object
         this._pool.on("error", (conn) => {
-            // console.log("OINODbMsSql error", conn)
-        });
-        this._pool.on("debug", (event) => {
-            // console.log("OINODbMsSql debug",event)
+            OINOLog.error("OINODbMsSql error event", conn);
         });
+        // this._pool.on("debug", (event:any) => {
+        //     console.log("OINODbMsSql debug",event)
+        // })
     }
     async _query(sql) {
         // OINOLog.debug("OINODbMsSql._query", {sql:sql})
         try {
-            const sql_res = await this._pool.request().query(sql);
+            const request = this._pool.request(); // this does not need to be released but the pool will handle it
+            const sql_res = await request.query(sql);
             // console.log("OINODbMsSql._query result:" + JSON.stringify(sql_res.recordsets))
             const result = new OINOMsSqlData(sql_res.recordsets);
             return Promise.resolve(result);
@@ -291,45 +292,53 @@ export class OINODbMsSql extends OINODb {
      *
      */
     async connect() {
+        let result = new OINOResult();
         try {
             // make sure that any items are correctly URL encoded in the connection string
             await this._pool.connect();
             // OINOLog.info("OINODbMsSql.connect: Connected to database server.")
-            await this._pool.request().query("SELECT 1 as test");
-            return Promise.resolve(true);
+            // await this._pool.request().query("SELECT 1 as test")
+            this.isConnected = true;
         }
         catch (err) {
             // ... error checks
-            throw new Error(OINO_ERROR_PREFIX + ": Error connecting to OINODbMsSql server: " + err);
+            result.setError(500, "Exception connecting to database: " + err.message, "OINODbMsSql.connect");
+            OINOLog.error(result.statusMessage, { error: err });
         }
+        return Promise.resolve(result);
     }
     /**
      * Validate connection to database is working.
      *
      */
     async validate() {
-        OINOBenchmark.start("OINODb", "validate");
         let result = new OINOResult();
+        if (!this.isConnected) {
+            result.setError(400, "Database is not connected!", "OINODbMsSql.validate");
+            return result;
+        }
+        OINOBenchmark.start("OINODb", "validate");
         try {
             const sql = this._getValidateSql(this._params.database);
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql:sql})
+            // OINOLog.debug("OINODbMsSql.validate", {sql:sql})
             const sql_res = await this.sqlSelect(sql);
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql_res:sql_res})
+            // OINOLog.debug("OINODbMsSql.validate", {sql_res:sql_res})
             if (sql_res.isEmpty()) {
-                result.setError(400, "DB returned no rows for select!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no rows for select!", "OINODbMsSql.validate");
             }
             else if (sql_res.getRow().length == 0) {
-                result.setError(400, "DB returned no values for database!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no values for database!", "OINODbMsSql.validate");
             }
             else if (sql_res.getRow()[0] == "0") {
-                result.setError(400, "DB returned no schema for database!", "OINODbBunSqlite.validate");
+                result.setError(400, "DB returned no schema for database!", "OINODbMsSql.validate");
             }
             else {
                 // connection is working
+                this.isValidated = true;
             }
         }
         catch (e) {
-            result.setError(500, OINO_ERROR_PREFIX + " (validate): OINODbBunSqlite.validate exception in _db.query: " + e.message, "OINODbBunSqlite.validate");
+            result.setError(500, "Exception in validating connection: " + e.message, "OINODbMsSql.validate");
         }
         OINOBenchmark.end("OINODb", "validate");
         return result;

package/dist/types/OINODbMsSql.d.ts

@@ -67,7 +67,7 @@ export declare class OINODbMsSql extends OINODb {
      * Connect to database.
      *
      */
-    connect(): Promise<boolean>;
+    connect(): Promise<OINOResult>;
     /**
      * Validate connection to database is working.
      *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oino-ts/db-mssql",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "OINO TS package for using Microsoft Sql databases.",
   "author": "Matias Kiviniemi (pragmatta)",
   "license": "MPL-2.0",
@@ -22,7 +22,7 @@
   "module": "./dist/esm/index.js",
   "types": "./dist/types/index.d.ts",
   "dependencies": {
-    "@oino-ts/db": "0.6.0",
+    "@oino-ts/db": "0.6.1",
     "mssql": "^11.0.1"
   },
   "devDependencies": {

package/src/OINODbMsSql.ts

@@ -117,11 +117,11 @@ export class OINODbMsSql extends OINODb {
             throw new Error(OINO_ERROR_PREFIX + ": Not OINODbMsSql-type: " + this._params.type)
         } 
         this._pool = new ConnectionPool({
-            user: params.user,
-            password: params.password,
-            server: params.url,
-            port: params.port,
-            database: params.database,
+            user: this._params.user,
+            password: this._params.password,
+            server: this._params.url,
+            port: this._params.port,
+            database: this._params.database,
             arrayRowMode:true,
             options: {
                 encrypt: true, // Use encryption for Azure SQL Database
@@ -130,20 +130,21 @@ export class OINODbMsSql extends OINODb {
                 trustServerCertificate: true // Change to false for production
             }
         })
-        //this._pool = new ConnectionPool({connectionString: "Server=localhost,1433;Database=database;User Id=username;Password=" + params.password + ";Encrypt=true"})
+        delete this._params.password // do not store password in db object
        
         this._pool.on("error", (conn:any) => {
-            // console.log("OINODbMsSql error", conn)
-        })
-        this._pool.on("debug", (event:any) => {
-            // console.log("OINODbMsSql debug",event)
+            OINOLog.error("OINODbMsSql error event", conn)
         })
+        // this._pool.on("debug", (event:any) => {
+        //     console.log("OINODbMsSql debug",event)
+        // })
     }
 
     private async _query(sql:string):Promise<OINOMsSqlData> {
         // OINOLog.debug("OINODbMsSql._query", {sql:sql})
         try {
-            const sql_res = await this._pool.request().query(sql);
+            const request = this._pool.request() // this does not need to be released but the pool will handle it
+            const sql_res = await request.query(sql)
             // console.log("OINODbMsSql._query result:" + JSON.stringify(sql_res.recordsets))
             const result:OINOMsSqlData = new OINOMsSqlData(sql_res.recordsets)
             return Promise.resolve(result)
@@ -309,17 +310,21 @@ export class OINODbMsSql extends OINODb {
      * Connect to database.
      *
      */
-    async connect(): Promise<boolean> {
+    async connect(): Promise<OINOResult> {
+        let result:OINOResult = new OINOResult()
         try {
             // make sure that any items are correctly URL encoded in the connection string
             await this._pool.connect()
             // OINOLog.info("OINODbMsSql.connect: Connected to database server.")
-            await this._pool.request().query("SELECT 1 as test")
-            return Promise.resolve(true)
-        } catch (err) {
+            // await this._pool.request().query("SELECT 1 as test")
+            this.isConnected = true
+            
+        } catch (err:any) {
             // ... error checks
-            throw new Error(OINO_ERROR_PREFIX + ": Error connecting to OINODbMsSql server: " + err)
+            result.setError(500, "Exception connecting to database: " + err.message, "OINODbMsSql.connect")
+            OINOLog.error(result.statusMessage, {error:err})
         }        
+        return Promise.resolve(result)
     }
 
     /**
@@ -327,27 +332,32 @@ export class OINODbMsSql extends OINODb {
      *
      */
     async validate(): Promise<OINOResult> {
-        OINOBenchmark.start("OINODb", "validate")
         let result:OINOResult = new OINOResult()
+        if (!this.isConnected) {
+            result.setError(400, "Database is not connected!", "OINODbMsSql.validate")
+            return result
+        }
+        OINOBenchmark.start("OINODb", "validate")
         try {
             const sql = this._getValidateSql(this._params.database)
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql:sql})
+            // OINOLog.debug("OINODbMsSql.validate", {sql:sql})
             const sql_res:OINODbDataSet = await this.sqlSelect(sql)
-            // OINOLog.debug("OINODbBunSqlite.validate", {sql_res:sql_res})
+            // OINOLog.debug("OINODbMsSql.validate", {sql_res:sql_res})
             if (sql_res.isEmpty()) {
-                result.setError(400, "DB returned no rows for select!", "OINODbBunSqlite.validate")
+                result.setError(400, "DB returned no rows for select!", "OINODbMsSql.validate")
 
             } else if (sql_res.getRow().length == 0) {
-                result.setError(400, "DB returned no values for database!", "OINODbBunSqlite.validate")
+                result.setError(400, "DB returned no values for database!", "OINODbMsSql.validate")
 
             } else if (sql_res.getRow()[0] == "0") {
-                result.setError(400, "DB returned no schema for database!", "OINODbBunSqlite.validate")
+                result.setError(400, "DB returned no schema for database!", "OINODbMsSql.validate")
 
             } else {
                 // connection is working
+                this.isValidated = true
             }
         } catch (e:any) {
-            result.setError(500, OINO_ERROR_PREFIX + " (validate): OINODbBunSqlite.validate exception in _db.query: " + e.message, "OINODbBunSqlite.validate")
+            result.setError(500, "Exception in validating connection: " + e.message, "OINODbMsSql.validate")
         }
         OINOBenchmark.end("OINODb", "validate")
         return result