@oh-my-tool/cli 0.3.4 → 0.3.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oh-my-tool/cli",
-  "version": "0.3.4",
+  "version": "0.3.6",
   "type": "module",
   "description": "Oh My Tool CLI - local and enterprise tools for agents",
   "keywords": [
@@ -29,7 +29,7 @@
   "dependencies": {
     "@clack/prompts": "^1.7.0",
     "@modelcontextprotocol/client": "2.0.0",
-    "@oh-my-tool/sdk": "0.3.4",
+    "@oh-my-tool/sdk": "0.3.6",
     "open": "11.0.0"
   },
   "engines": {

package/src/extension/discovery.ts

@@ -37,6 +37,7 @@ export function discoverExtensions(home: string): InstalledExtension[] {
   for (const id of readdirSync(root)) {
     const idDir = join(root, id);
     if (!statSync(idDir).isDirectory()) continue;
+    const candidates: InstalledExtension[] = [];
     for (const version of readdirSync(idDir)) {
       const versionDir = join(idDir, version);
       if (!statSync(versionDir).isDirectory()) continue;
@@ -46,7 +47,7 @@ export function discoverExtensions(home: string): InstalledExtension[] {
         const manifest = parseManifest(readFileSync(manifestPath, "utf8"));
         validateManifest(manifest);
         checkSdkCompatibility(manifest.sdkVersion);
-        out.push({
+        candidates.push({
           id,
           version,
           dir: versionDir,
@@ -57,6 +58,13 @@ export function discoverExtensions(home: string): InstalledExtension[] {
         // skip invalid or incompatible manifests
       }
     }
+    const active = candidates.reduce<InstalledExtension | undefined>((current, candidate) => {
+      if (current === undefined || Bun.semver.order(candidate.manifest.version, current.manifest.version) > 0) {
+        return candidate;
+      }
+      return current;
+    }, undefined);
+    if (active !== undefined) out.push(active);
   }
   return out;
-}
+}

package/src/extension/install.ts

@@ -1,4 +1,4 @@
-import { cp, mkdir, mkdtemp, readFile, rm, stat, writeFile } from "node:fs/promises";
+import { cp, mkdir, mkdtemp, readdir, readFile, rm, stat, writeFile } from "node:fs/promises";
 import { execFile as execFileCallback } from "node:child_process";
 import { promisify } from "node:util";
 import { tmpdir } from "node:os";
@@ -24,8 +24,21 @@ export interface NpmExtensionSpec {
 
 export class ExtensionInstallError extends Error {}
 
+export function npmExecutableForPlatform(platform: string = process.platform): string {
+  return platform === "win32" ? "npm.cmd" : "npm";
+}
+
+export function npmShellForPlatform(platform: string = process.platform): boolean {
+  return platform === "win32";
+}
+
 export interface NpmInstallDependencies {
   install(spec: string, tempDir: string): Promise<void>;
+  execFile?(
+    file: string,
+    args: string[],
+    options: { cwd: string; shell: boolean; timeout: number; maxBuffer: number },
+  ): Promise<unknown>;
 }
 
 export function normalizeNpmExtensionSpec(spec: string): NpmExtensionSpec {
@@ -75,9 +88,39 @@ async function installExtensionDirectory(home: string, srcDir: string, expectedP
     force: true,
     filter: (s: string) => basename(s) !== "node_modules",
   });
+  await retireInactiveVersions(home, manifest.id, manifest.version);
   return { id: manifest.id, version: manifest.version, target };
 }
 
+async function retireInactiveVersions(home: string, id: string, activeVersion: string): Promise<void> {
+  const extensionRoot = join(home, "extensions", id);
+  let entries: string[];
+  try {
+    entries = await readdir(extensionRoot);
+  } catch (error) {
+    if (isMissingPathError(error)) return;
+    const message = error instanceof Error ? error.message : String(error);
+    throw new ExtensionInstallError(`failed to inspect installed versions for '${id}': ${message}`);
+  }
+
+  for (const entry of entries) {
+    if (entry === activeVersion || !EXACT_VERSION_RE.test(entry)) continue;
+    const entryPath = join(extensionRoot, entry);
+    try {
+      if ((await stat(entryPath)).isDirectory()) {
+        await rm(entryPath, { recursive: true, force: true });
+      }
+    } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
+      throw new ExtensionInstallError(`failed to retire inactive extension '${id}/${entry}': ${message}`);
+    }
+  }
+}
+
+function isMissingPathError(error: unknown): boolean {
+  return error instanceof Error && "code" in error && error.code === "ENOENT";
+}
+
 export async function installLocalExtension(home: string, srcDir: string): Promise<InstalledRef> {
   return installExtensionDirectory(home, srcDir);
 }
@@ -95,19 +138,23 @@ export async function installNpmExtension(
       if (dependencies.install !== undefined) {
         await dependencies.install(normalized.npmSpec, temp);
       } else {
-        await execFile("npm", [
+        const runNpm: NonNullable<NpmInstallDependencies["execFile"]> = dependencies.execFile ?? (async (file, args, options) => {
+          await execFile(file, args, options);
+        });
+        await runNpm(npmExecutableForPlatform(), [
           "install",
-          "--prefix", temp,
+          "--prefix", ".",
           "--ignore-scripts",
           "--no-save",
           "--no-package-lock",
           "--omit=dev",
           "--registry=https://registry.npmjs.org",
           "--", normalized.npmSpec,
-        ], { timeout: 120_000, maxBuffer: 4 * 1024 * 1024 });
+        ], { cwd: temp, timeout: 120_000, maxBuffer: 4 * 1024 * 1024, shell: npmShellForPlatform() });
       }
-    } catch {
-      throw new ExtensionInstallError(`failed to download npm extension '${normalized.npmSpec}'`);
+    } catch (error) {
+      const message = error instanceof Error ? error.message : String(error);
+      throw new ExtensionInstallError(`failed to download npm extension '${normalized.npmSpec}': ${message}`);
     }
 
     const packageDir = join(temp, "node_modules", ...normalized.packageName.split("/"));

package/src/version.ts

@@ -1 +1 @@
-export const VERSION = "0.3.4";
+export const VERSION = "0.3.6";