@oh-my-pi/pi-utils 18.3.0 → 18.3.2

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [18.3.1] - 2026-09-25
+
+### Fixed
+
+- Fixed log rotation near local-day boundaries so dated log files are consistently assigned to the correct local date.
+
 ## [18.2.7] - 2026-09-21
 
 ### Changed

package/THIRD-PARTY-NOTICES.txt

@@ -78,8 +78,8 @@ below.
 uutils coreutils (https://github.com/uutils/coreutils), MIT
 --------------------------------------------------------------------------------
 Covers: base32, base64, basename, cat, cksum (shared checksum machinery),
-b2sum, md5sum, sha1sum, sha224sum, sha256sum, sha384sum, sha512sum, comm, cut,
-date, dirname, head, hostname, ln, ls, mkdir, mktemp, mv, nproc, paste,
+b2sum, md5sum, sha1sum, sha224sum, sha256sum, sha384sum, sha512sum, comm, cp,
+cut, date, dirname, head, hostname, ln, ls, mkdir, mktemp, mv, nproc, paste,
 printenv, readlink, realpath, rm, seq, sort, stat, tac, tail, tee, touch, tr,
 truncate, uname, uniq, wc, whoami, yes.
 

package/dist/types/dirs.d.ts

@@ -12,6 +12,8 @@
  */
 /** App name (e.g. "omp") */
 export declare const APP_NAME: string;
+/** Public homepage that inference gateways (OpenRouter, Vercel AI Gateway) credit omp traffic to. */
+export declare const APP_URL: string;
 /** Config directory name (e.g. ".omp") */
 export declare const CONFIG_DIR_NAME: string;
 /** Ordered main settings filenames: canonical write target first, legacy-compatible YAML fallback second. */
@@ -135,7 +137,16 @@ export declare function getProjectAgentDir(cwd?: string): string;
 export declare function getReportsDir(): string;
 /** Get the logs directory (~/.omp/logs). */
 export declare function getLogsDir(): string;
-/** Get this process's dated log path (~/.omp/logs/omp.YYYY-MM-DD.PID.log). */
+/**
+ * Local-timezone `YYYY-MM-DD` day key (zero-padded), formatted exactly like
+ * the rotating log sink's file naming: log files are named `omp.<day>.<pid>.log`
+ * with the LOCAL day, not the UTC day `toISOString()` yields. Anything that
+ * computes "today's" log path or matches same-day log files by name must use
+ * this key, or between local midnight and UTC midnight it points at files that
+ * do not exist (e.g. 00:00–08:00 in UTC+8).
+ */
+export declare function localDay(date: Date): string;
+/** Get this process's dated log path (~/.omp/logs/omp.YYYY-MM-DD.PID.log, local-day named like the rotating sink). */
 export declare function getLogPath(date?: Date, pid?: number): string;
 /**
  * Get the plugins directory (~/.omp/plugins or its XDG equivalent).

package/dist/types/fs-open.d.ts

@@ -0,0 +1,16 @@
+/**
+ * `fs.openSync` with close-on-exec, matching Node's default.
+ *
+ * libuv adds `O_CLOEXEC` inside `uv__fs_open`, so on Node every `fs` descriptor
+ * dies at `exec`. Bun's `fs.open*` does not, and descriptors it returns survive
+ * into any child spawned through a path that does not close strays itself — the
+ * bash tool's shell `fork`/`exec`s user commands and hands them the lot. Use
+ * this for every descriptor kept open past such a spawn (session transcripts,
+ * logs, spools); a child must never hold a writable handle to them (#13224).
+ *
+ * Flags are numeric only: the bit cannot be OR-ed into `"a"`/`"w+"` strings.
+ *
+ * @example
+ * const fd = openCloexecSync(logPath, fs.constants.O_WRONLY | fs.constants.O_CREAT | fs.constants.O_APPEND);
+ */
+export declare function openCloexecSync(filePath: string, flags: number, mode?: number): number;

package/dist/types/index.d.ts

@@ -10,6 +10,7 @@ export * from "./file-lock.js";
 export * from "./format.js";
 export * from "./frontmatter.js";
 export * from "./fs-error.js";
+export * from "./fs-open.js";
 export * from "./incoming-json.js";
 export * from "./json.js";
 export * from "./json-parse.js";

package/dist/types/procmgr.d.ts

@@ -65,6 +65,9 @@ export declare function resolveWindowsShell(env?: Record<string, string | undefi
  *    {@link resolveWindowsShell}) — never fails
  * 3. On Unix: $SHELL if bash/zsh, then fallback paths
  * 4. Fallback: sh
+ *
+ * Custom and auto-resolved configs are cached separately, so clearing
+ * `shellPath` mid-process immediately falls back to the platform default.
  */
 export declare function getShellConfig(customShellPath?: string, options?: ShellConfigOptions): ShellConfig;
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-utils",
-	"version": "18.3.0",
+	"version": "18.3.2",
 	"description": "Shared utilities for pi packages",
 	"keywords": [
 		"cli",
@@ -57,7 +57,7 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-natives": "18.3.0"
+		"@oh-my-pi/pi-natives": "18.3.2"
 	},
 	"devDependencies": {
 		"@types/bun": "^1.3.14"

package/src/dirs.ts

@@ -20,6 +20,9 @@ import { isEnoent, isEnotdir } from "./fs-error";
 /** App name (e.g. "omp") */
 export const APP_NAME: string = "omp";
 
+/** Public homepage that inference gateways (OpenRouter, Vercel AI Gateway) credit omp traffic to. */
+export const APP_URL: string = "https://omp.sh/";
+
 /** Config directory name (e.g. ".omp") */
 export const CONFIG_DIR_NAME: string = ".omp";
 
@@ -601,9 +604,21 @@ export function getLogsDir(): string {
 	return dirs.rootSubdir("logs", "state");
 }
 
-/** Get this process's dated log path (~/.omp/logs/omp.YYYY-MM-DD.PID.log). */
+/**
+ * Local-timezone `YYYY-MM-DD` day key (zero-padded), formatted exactly like
+ * the rotating log sink's file naming: log files are named `omp.<day>.<pid>.log`
+ * with the LOCAL day, not the UTC day `toISOString()` yields. Anything that
+ * computes "today's" log path or matches same-day log files by name must use
+ * this key, or between local midnight and UTC midnight it points at files that
+ * do not exist (e.g. 00:00–08:00 in UTC+8).
+ */
+export function localDay(date: Date): string {
+	return `${date.getFullYear()}-${String(date.getMonth() + 1).padStart(2, "0")}-${String(date.getDate()).padStart(2, "0")}`;
+}
+
+/** Get this process's dated log path (~/.omp/logs/omp.YYYY-MM-DD.PID.log, local-day named like the rotating sink). */
 export function getLogPath(date = new Date(), pid = process.pid): string {
-	return path.join(getLogsDir(), `${APP_NAME}.${date.toISOString().slice(0, 10)}.${pid}.log`);
+	return path.join(getLogsDir(), `${APP_NAME}.${localDay(date)}.${pid}.log`);
 }
 
 /**

package/src/fs-open.ts

@@ -0,0 +1,31 @@
+/** Close-on-exec file opens for descriptors held past a child spawn. */
+import * as fs from "node:fs";
+
+/**
+ * `O_CLOEXEC`, which neither Node nor Bun exposes in `fs.constants`.
+ *
+ * Kernel ABI values: `0o2000000` on Linux, `0x0100_0000` on Darwin. Windows has
+ * no `exec` and its CRT handles are inherited only when a spawn explicitly asks
+ * for it, so the bit is 0 there — as it is on any other platform, where adding
+ * an unknown flag bit would be worse than leaving the descriptor inheritable.
+ */
+const O_CLOEXEC = process.platform === "linux" ? 0o2000000 : process.platform === "darwin" ? 0x0100_0000 : 0;
+
+/**
+ * `fs.openSync` with close-on-exec, matching Node's default.
+ *
+ * libuv adds `O_CLOEXEC` inside `uv__fs_open`, so on Node every `fs` descriptor
+ * dies at `exec`. Bun's `fs.open*` does not, and descriptors it returns survive
+ * into any child spawned through a path that does not close strays itself — the
+ * bash tool's shell `fork`/`exec`s user commands and hands them the lot. Use
+ * this for every descriptor kept open past such a spawn (session transcripts,
+ * logs, spools); a child must never hold a writable handle to them (#13224).
+ *
+ * Flags are numeric only: the bit cannot be OR-ed into `"a"`/`"w+"` strings.
+ *
+ * @example
+ * const fd = openCloexecSync(logPath, fs.constants.O_WRONLY | fs.constants.O_CREAT | fs.constants.O_APPEND);
+ */
+export function openCloexecSync(filePath: string, flags: number, mode?: number): number {
+	return fs.openSync(filePath, flags | O_CLOEXEC, mode);
+}

package/src/index.ts

@@ -10,6 +10,7 @@ export * from "./file-lock";
 export * from "./format";
 export * from "./frontmatter";
 export * from "./fs-error";
+export * from "./fs-open";
 export * from "./incoming-json";
 export * from "./json";
 export * from "./json-parse";

package/src/logger/rotating-file.ts

@@ -2,6 +2,8 @@
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
+import { localDay } from "../dirs";
+import { openCloexecSync } from "../fs-open";
 
 interface AuditEntry {
 	readonly date: number;
@@ -62,7 +64,7 @@ export class RotatingFileSink {
 		this.#maxFiles = options.maxFiles;
 		this.#files = this.#readAudit();
 		const now = new Date();
-		this.#selectFile(this.#localDay(now));
+		this.#selectFile(localDay(now));
 		const activePath = this.#activePath;
 		if (activePath) {
 			this.#registerFile(activePath, now.getTime());
@@ -72,7 +74,7 @@ export class RotatingFileSink {
 
 	#openFd(filePath: string): void {
 		this.#closeFd();
-		this.#fd = fs.openSync(filePath, "a");
+		this.#fd = openCloexecSync(filePath, fs.constants.O_WRONLY | fs.constants.O_CREAT | fs.constants.O_APPEND);
 	}
 
 	#closeFd(): void {
@@ -91,7 +93,7 @@ export class RotatingFileSink {
 		if (this.#closed) return;
 		const prevPath = this.#activePath;
 		const now = new Date();
-		this.#selectFile(this.#localDay(now));
+		this.#selectFile(localDay(now));
 		const activePath = this.#activePath;
 		if (!activePath) return;
 		// Rotation moved the active path: close the old descriptor BEFORE
@@ -119,10 +121,6 @@ export class RotatingFileSink {
 		this.#closeFd();
 	}
 
-	#localDay(date: Date): string {
-		return `${date.getFullYear()}-${String(date.getMonth() + 1).padStart(2, "0")}-${String(date.getDate()).padStart(2, "0")}`;
-	}
-
 	#selectFile(day: string): void {
 		if (day !== this.#activeDay) {
 			this.#activeDay = day;

package/src/procmgr.ts

@@ -20,7 +20,10 @@ export interface ShellConfigOptions {
 	/** File path or runtime layer that supplied the active shell setting. */
 	configSource?: string;
 }
-let cachedShellConfig: ShellConfig | null = null;
+/** Auto-resolved shell (no custom path); stable for the process lifetime. */
+let cachedDefaultShellConfig: ShellConfig | null = null;
+/** Config for the most recent custom `shellPath`; never served once the path is cleared. */
+let cachedCustomShellConfig: ShellConfig | null = null;
 
 /**
  * Build the spawn environment (cached).
@@ -177,6 +180,9 @@ export function resolveWindowsShell(env: Record<string, string | undefined> = Bu
  *    {@link resolveWindowsShell}) — never fails
  * 3. On Unix: $SHELL if bash/zsh, then fallback paths
  * 4. Fallback: sh
+ *
+ * Custom and auto-resolved configs are cached separately, so clearing
+ * `shellPath` mid-process immediately falls back to the platform default.
  */
 export function getShellConfig(customShellPath?: string, options: ShellConfigOptions = {}): ShellConfig {
 	const configSource = options.configSource ?? path.join(getAgentDir(), MAIN_CONFIG_FILENAMES[0]);
@@ -187,36 +193,30 @@ export function getShellConfig(customShellPath?: string, options: ShellConfigOpt
 		if (!fs.existsSync(customShellPath)) {
 			throw new Error(`Custom shell path not found: ${customShellPath}\nPlease update shellPath in ${configSource}`);
 		}
-		if (cachedShellConfig?.shell !== customShellPath) {
-			cachedShellConfig = buildConfig(customShellPath);
+		if (cachedCustomShellConfig?.shell !== customShellPath) {
+			cachedCustomShellConfig = buildConfig(customShellPath);
 		}
-		return cachedShellConfig;
-	}
-	if (cachedShellConfig) {
-		return cachedShellConfig;
+		return cachedCustomShellConfig;
 	}
+	cachedDefaultShellConfig ??= buildConfig(resolveDefaultShell());
+	return cachedDefaultShellConfig;
+}
 
+/** Platform shell discovery used when no custom `shellPath` is configured. */
+function resolveDefaultShell(): string {
 	if (process.platform === "win32") {
-		cachedShellConfig = buildConfig(resolveWindowsShell());
-		return cachedShellConfig;
+		return resolveWindowsShell();
 	}
 
 	// Unix: prefer user's shell from $SHELL if it's bash/zsh and executable
 	const userShell = Bun.env.SHELL;
 	const isValidShell = userShell && (userShell.includes("bash") || userShell.includes("zsh"));
 	if (isValidShell && isExecutable(userShell)) {
-		cachedShellConfig = buildConfig(userShell);
-		return cachedShellConfig;
+		return userShell;
 	}
 
 	// 4. Fallback: use basic shell
-	const basicShell = resolveBasicShell();
-	if (basicShell) {
-		cachedShellConfig = buildConfig(basicShell);
-		return cachedShellConfig;
-	}
-	cachedShellConfig = buildConfig("sh");
-	return cachedShellConfig;
+	return resolveBasicShell() ?? "sh";
 }
 
 /**