@oh-my-pi/pi-utils 18.1.19 → 18.1.21

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## [Unreleased]
 
+## [18.1.21] - 2026-09-14
+
+### Added
+
+- Added `getBrowserProfilesDir()` (`~/.omp/browser-profiles`; XDG: `$XDG_STATE_HOME/omp/browser-profiles`) for profiles of Chromium browsers spawned by the browser tool.
+
+### Fixed
+
+- Timed out stalled Chrome-for-Testing metadata requests after 30 seconds when looking up download metadata
+- Concurrent browser installations share one download without replacing a running browser, and stalled downloads time out with partial files cleaned up for retry.
+
 ## [18.1.19] - 2026-09-12
 
 ### Added

package/dist/types/dirs.d.ts

@@ -40,6 +40,8 @@ export declare function normalizeProfileName(profile: string | undefined): strin
  * {@link normalizeProfileName} (which throws on a syntactically invalid value).
  */
 export declare function resolveProfileEnv(omp: string | undefined, pi: string | undefined): string | undefined;
+/** Profile-independent config root (~/.omp), shared by every omp profile. */
+export declare function getBaseConfigRoot(): string;
 export declare function resolveEquivalentPath(inputPath: string): string;
 export declare function normalizePathForComparison(inputPath: string): string;
 export declare function pathIsWithin(root: string, candidate: string): boolean;
@@ -176,6 +178,8 @@ export declare function getPythonGatewayDir(): string;
 export declare function getPuppeteerDir(): string;
 /** Get the browser relay extension install directory (~/.omp/browser-relay). */
 export declare function getBrowserRelayDir(): string;
+/** Get the profile root for Chromium browsers the browser tool spawns via `app.path` (~/.omp/browser-profiles). */
+export declare function getBrowserProfilesDir(): string;
 /** Get DOCS_RS cache directory () */
 export declare function getDocsRsCacheDir(): string;
 /** Get the auto-QA grievances SQLite database path (~/.omp/autoqa.db; XDG: $XDG_DATA_HOME/omp/autoqa.db). */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-utils",
-	"version": "18.1.19",
+	"version": "18.1.21",
 	"description": "Shared utilities for pi packages",
 	"keywords": [
 		"cli",
@@ -54,7 +54,7 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-natives": "18.1.19"
+		"@oh-my-pi/pi-natives": "18.1.21"
 	},
 	"devDependencies": {
 		"@types/bun": "^1.3.14"

package/src/browsers.ts

@@ -5,9 +5,13 @@ import * as fsp from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
 import { type ArchiveLimits, extractArchive } from "./ar";
+import { withFileLock } from "./file-lock";
 
 const CHROME_FOR_TESTING_BASE_URL = "https://storage.googleapis.com/chrome-for-testing-public";
 const CHROME_METADATA_BASE_URL = "https://googlechromelabs.github.io/chrome-for-testing";
+// Installation is outside browser/Eval operation deadlines, but a stalled CDN
+// must still release the cached install promise and permit a later attempt.
+const DOWNLOAD_TIMEOUT_MS = 5 * 60_000;
 
 /**
  * Archive ceilings for the managed browser download. The default archive
@@ -251,29 +255,39 @@ export async function install(options: InstallOptions): Promise<InstalledBrowser
 		return { browser: options.browser, buildId: options.buildId, platform, path: installPath, executablePath };
 	}
 
-	await fsp.mkdir(options.cacheDir, { recursive: true });
-	const nonce = `${process.pid}-${crypto.randomUUID()}`;
-	const archivePath = path.join(options.cacheDir, `.browser-${nonce}.zip`);
-	const stagingPath = path.join(options.cacheDir, `.browser-${nonce}`);
-	try {
-		await downloadArchive(
-			getDownloadUrl(options.browser, platform, options.buildId, options.baseUrl),
-			archivePath,
-			options.downloadProgressCallback,
-		);
-		await extractArchive(archivePath, stagingPath, { limits: BROWSER_ARCHIVE_LIMITS });
-		await fsp.mkdir(path.dirname(installPath), { recursive: true });
-		await fsp.rm(installPath, { recursive: true, force: true });
-		await fsp.rename(stagingPath, installPath);
-	} finally {
-		await Promise.all([
-			fsp.rm(archivePath, { force: true }).catch(() => {}),
-			fsp.rm(stagingPath, { recursive: true, force: true }).catch(() => {}),
-		]);
-	}
-	if (!(await pathExists(executablePath)))
-		throw new Error(`Browser archive did not contain its expected executable: ${executablePath}`);
-	return { browser: options.browser, buildId: options.buildId, platform, path: installPath, executablePath };
+	await fsp.mkdir(path.dirname(installPath), { recursive: true });
+	return withFileLock(
+		`${installPath}.install`,
+		async () => {
+			// The in-process launch promise cannot serialize separate OMP sessions.
+			// Recheck under the OS lock: never replace a winner's running Chrome.
+			if (!(await pathExists(executablePath))) {
+				const nonce = `${process.pid}-${crypto.randomUUID()}`;
+				const archivePath = path.join(options.cacheDir, `.browser-${nonce}.zip`);
+				const stagingPath = path.join(options.cacheDir, `.browser-${nonce}`);
+				try {
+					await downloadArchive(
+						getDownloadUrl(options.browser, platform, options.buildId, options.baseUrl),
+						archivePath,
+						options.downloadProgressCallback,
+					);
+					await extractArchive(archivePath, stagingPath, { limits: BROWSER_ARCHIVE_LIMITS });
+					if (!(await pathExists(path.join(stagingPath, path.relative(installPath, executablePath))))) {
+						throw new Error(`Browser archive did not contain its expected executable: ${executablePath}`);
+					}
+					await fsp.rm(installPath, { recursive: true, force: true });
+					await fsp.rename(stagingPath, installPath);
+				} finally {
+					await Promise.all([
+						fsp.rm(archivePath, { force: true }).catch(() => {}),
+						fsp.rm(stagingPath, { recursive: true, force: true }).catch(() => {}),
+					]);
+				}
+			}
+			return { browser: options.browser, buildId: options.buildId, platform, path: installPath, executablePath };
+		},
+		{ retries: Math.ceil(DOWNLOAD_TIMEOUT_MS / 100) + 1, retryDelayMs: 100 },
+	);
 }
 
 function chromeChannelName(tag: string): string | undefined {
@@ -292,7 +306,7 @@ function chromeChannelName(tag: string): string | undefined {
 }
 
 async function fetchMetadata<T>(filename: string): Promise<T> {
-	const response = await fetch(`${CHROME_METADATA_BASE_URL}/${filename}`);
+	const response = await fetch(`${CHROME_METADATA_BASE_URL}/${filename}`, { signal: AbortSignal.timeout(30_000) });
 	if (!response.ok)
 		throw new Error(`Failed to fetch Chrome-for-Testing metadata (${response.status} ${response.statusText})`);
 	return (await response.json()) as T;
@@ -345,7 +359,7 @@ async function downloadArchive(
 	destination: string,
 	onProgress: ((progress: BrowserDownloadProgress) => void) | undefined,
 ): Promise<void> {
-	const response = await fetch(url);
+	const response = await fetch(url, { signal: AbortSignal.timeout(DOWNLOAD_TIMEOUT_MS) });
 	if (!response.ok || !response.body) {
 		throw new Error(`Browser download failed (${response.status} ${response.statusText}) from ${url}`);
 	}

package/src/dirs.ts

@@ -107,7 +107,8 @@ function readProfileFromEnvSafe(): string | undefined {
 	}
 }
 
-function getBaseConfigRoot(): string {
+/** Profile-independent config root (~/.omp), shared by every omp profile. */
+export function getBaseConfigRoot(): string {
 	return path.join(os.homedir(), getConfigDirName());
 }
 
@@ -707,6 +708,11 @@ export function getBrowserRelayDir(): string {
 	return dirs.rootSubdir("browser-relay", "data");
 }
 
+/** Get the profile root for Chromium browsers the browser tool spawns via `app.path` (~/.omp/browser-profiles). */
+export function getBrowserProfilesDir(): string {
+	return dirs.rootSubdir("browser-profiles", "state");
+}
+
 /** Get DOCS_RS cache directory () */
 export function getDocsRsCacheDir(): string {
 	return dirs.rootSubdir("webcache", "cache");