@oh-my-pi/pi-tui 18.8.6 → 18.8.7

package/src/render/render-utils.ts

@@ -1128,6 +1128,9 @@ export function createCachedComponent(
 		invalidate() {
 			cached = undefined;
 		},
+		releaseRenderCaches() {
+			cached = undefined;
+		},
 	};
 }
 
@@ -1160,6 +1163,14 @@ export function invalidateRenderedStringCache(cache: RenderedStringCache): void
 	cache.theme = null;
 }
 
+export function releaseRenderedStringCache(cache: RenderedStringCache): void {
+	cache.theme = null;
+	cache.expanded = false;
+	cache.salt = "";
+	cache.content = "";
+	cache.value = "";
+}
+
 /** Reuse a rendered string while its theme, expansion, content, and salt match. */
 export function cachedRenderedString(
 	cache: RenderedStringCache | undefined,

package/src/render/tool-card.ts

@@ -69,6 +69,11 @@ export interface ToolCardOptions {
 	paddingY?: number;
 	ignoreTight?: boolean;
 	onInvalidate?: () => void;
+	/**
+	 * Drop builder-owned memos the next build recomputes. Called by
+	 * {@link ToolCard.releaseRenderCaches}, which never calls `onInvalidate`.
+	 */
+	onReleaseRenderCaches?: () => void;
 	onDispose?: () => void;
 }
 
@@ -381,6 +386,16 @@ export class ToolCard implements Component {
 		this.#options.onInvalidate?.();
 	}
 
+	releaseRenderCaches(): void {
+		this.#block.invalidate();
+		this.#lastBlockOptions = undefined;
+		this.#plainKey = "";
+		this.#plainText.setText("");
+		this.#plainText.releaseRenderCaches();
+		for (const child of this.#renderedChildren) child.releaseRenderCaches?.();
+		this.#options.onReleaseRenderCaches?.();
+	}
+
 	dispose(): void {
 		if (this.#disposed) return;
 		this.#disposed = true;

package/src/render/width-aware-text.ts

@@ -51,6 +51,11 @@ export class WidthAwareText implements Component {
 		this.#inner.invalidate();
 	}
 
+	/** The formatted text stays: the inner `Text` renders from it, so dropping it would free nothing. */
+	releaseRenderCaches(): void {
+		this.#inner.releaseRenderCaches();
+	}
+
 	/**
 	 * Re-run the formatter on the next render because its inputs changed.
 	 * Unlike {@link invalidate}, the inner `Text` keeps its wrap cache, so a

package/src/terminal.ts

@@ -501,7 +501,12 @@ export const CURSOR_SHAPE_CODES: Record<CursorShape, number> = {
 	bar: 6,
 };
 export interface Terminal {
-	// Start the terminal with input, resize, and host-disconnect handlers.
+	/**
+	 * Start the terminal with input, resize, and host-disconnect handlers.
+	 * Unless input is deferred, this sends capability probes; a terminal that
+	 * cannot parse one may leave concealed bytes on the cursor row, so the
+	 * caller repaints after starting.
+	 */
 	start(
 		onInput: (data: string) => void,
 		onResize: () => void,
@@ -513,8 +518,10 @@ export interface Terminal {
 	 * Take ownership of stdin after a `deferInput` start: enable raw mode,
 	 * attach input handlers, and run the capability probes start() skipped.
 	 * Bytes the user typed in cooked mode meanwhile are replayed through
-	 * `onInput`. No-op when input was never deferred. Optional so custom
-	 * Terminals built against older pi-tui versions keep working.
+	 * `onInput`. No-op when input was never deferred. Like {@link start}, the
+	 * probes may leave concealed bytes on the cursor row, so the caller
+	 * repaints afterwards. Optional so custom Terminals built against older
+	 * pi-tui versions keep working.
 	 */
 	enableInput?(): void;
 
@@ -707,6 +714,17 @@ function parseOsc99KeyValues(section: string): Map<string, string> {
 	}
 	return values;
 }
+/**
+ * Brackets the startup capability probes. A terminal that cannot parse a probe
+ * prints it as text at the cursor (Apple Terminal drops `ESC _`/`ESC \` and
+ * prints APC payloads, and abandons DECRQM at its `$`, printing the final `p`).
+ * DECSC, autowrap off, and SGR 8 (conceal) keep that text invisible and on the
+ * cursor row, so it can neither wrap nor scroll the screen; DECRC puts the
+ * cursor back. The screen owner repaints the row afterwards (see
+ * {@link Terminal.start} / {@link Terminal.enableInput}).
+ */
+const PROBE_GUARD_BEGIN = "\x1b7\x1b[?7l\x1b[8m";
+const PROBE_GUARD_END = "\x1b[28m\x1b[?7h\x1b8";
 const XTERM_SCROLL_TO_BOTTOM_MODES = [1010, 1011] as const;
 type Osc11QueryRoute = "direct" | "tmux";
 const TMUX_OSC11_CACHE_REFRESH_DELAY_MS = 100;
@@ -1099,6 +1117,8 @@ export class ProcessTerminal implements Terminal {
 		// events that lose modifier information. Must run after setRawMode(true)
 		// since that resets console mode flags.
 		this.#enableWindowsVTInput();
+		// Every response-eliciting probe goes out inside the leak guard.
+		this.#safeWrite(PROBE_GUARD_BEGIN);
 		// Query and enable Kitty keyboard protocol
 		// The query handler intercepts input temporarily, then installs the user's handler
 		// See: https://sw.kovidgoyal.net/kitty/keyboard-protocol/
@@ -1161,6 +1181,7 @@ export class ProcessTerminal implements Terminal {
 		for (const mode of XTERM_SCROLL_TO_BOTTOM_MODES) {
 			this.#queryPrivateMode(mode);
 		}
+		this.#safeWrite(PROBE_GUARD_END);
 	}
 
 	/**

package/src/tools/bash.ts

@@ -494,6 +494,15 @@ export function createShellRenderer<TArgs>(config: ShellRendererConfig<TArgs>) {
 			let cachedIsPartial: boolean | undefined;
 			let cachedPreviewWindow: number | undefined;
 			let cachedSnapshot: ToolCardSnapshot | undefined;
+			const dropSnapshot = () => {
+				cachedSnapshot = undefined;
+				cachedWidth = undefined;
+				cachedPreviewLines = undefined;
+				cachedExpanded = undefined;
+				cachedRawOutput = undefined;
+				cachedIsPartial = undefined;
+				cachedPreviewWindow = undefined;
+			};
 
 			return framedToolCard(
 				uiTheme,
@@ -596,17 +605,7 @@ export function createShellRenderer<TArgs>(config: ShellRendererConfig<TArgs>) {
 					cachedSnapshot = snapshot;
 					return snapshot;
 				},
-				{
-					onInvalidate: () => {
-						cachedSnapshot = undefined;
-						cachedWidth = undefined;
-						cachedPreviewLines = undefined;
-						cachedExpanded = undefined;
-						cachedRawOutput = undefined;
-						cachedIsPartial = undefined;
-						cachedPreviewWindow = undefined;
-					},
-				},
+				{ onInvalidate: dropSnapshot, onReleaseRenderCaches: dropSnapshot },
 			);
 		},
 		describeCall(args: TArgs, options: RenderResultOptions): NativeToolView {

package/src/tools/edit.ts

@@ -36,6 +36,7 @@ import {
 	invalidateRenderedStringCache,
 	PREVIEW_LIMITS,
 	previewWindowRows,
+	releaseRenderedStringCache,
 	type RenderedStringCache,
 	replaceTabs,
 	shortenPath,
@@ -1110,41 +1111,49 @@ export const editToolRenderer = {
 			return renderInlineEditRow(uiTheme, { op, rename, rawPath, pending: true });
 		}
 		const callPreviewCaches: RenderedStringCache[] = [];
-		return framedToolCard(uiTheme, ({ width }) => {
-			// No status icon on the head row: it's the head of the framed block,
-			// and native-scrollback commits are prefix-only — an animated glyph
-			// would pin the commit boundary at the top, and the pending hourglass
-			// just adds noise. The liveness cue rides the trailing "(preview)" /
-			// "(streaming)" line instead.
-			const header = renderEditHeader(width, uiTheme, {
-				op,
-				rawPath,
-				rename,
-				extraSuffix: fileCount > 1 ? uiTheme.fg("dim", ` (+${fileCount - 1} more)`) : undefined,
-			});
-			let body = getCallPreview(
-				editArgs,
-				rawPath,
-				width,
-				uiTheme,
-				renderContext,
-				options.expanded,
-				options?.spinnerFrame,
-				callPreviewCaches,
-			);
-			if (applyPatchError) {
-				body += `\n${uiTheme.fg("error", truncateToWidth(replaceTabs(applyPatchError), Math.max(1, width - 2)))}`;
-			}
-			const bodyLines = body ? body.split("\n") : [];
-			while (bodyLines.length > 0 && bodyLines[0].trim() === "") bodyLines.shift();
-			return {
-				header,
-				sections: bodyLines.length > 0 ? [{ content: bodyLines }] : [],
-				phase: applyPatchError ? "error" : "pending",
-				borderColor: applyPatchError ? "error" : "borderMuted",
-				contentPaddingLeft: 0,
-			};
-		});
+		return framedToolCard(
+			uiTheme,
+			({ width }) => {
+				// No status icon on the head row: it's the head of the framed block,
+				// and native-scrollback commits are prefix-only — an animated glyph
+				// would pin the commit boundary at the top, and the pending hourglass
+				// just adds noise. The liveness cue rides the trailing "(preview)" /
+				// "(streaming)" line instead.
+				const header = renderEditHeader(width, uiTheme, {
+					op,
+					rawPath,
+					rename,
+					extraSuffix: fileCount > 1 ? uiTheme.fg("dim", ` (+${fileCount - 1} more)`) : undefined,
+				});
+				let body = getCallPreview(
+					editArgs,
+					rawPath,
+					width,
+					uiTheme,
+					renderContext,
+					options.expanded,
+					options?.spinnerFrame,
+					callPreviewCaches,
+				);
+				if (applyPatchError) {
+					body += `\n${uiTheme.fg("error", truncateToWidth(replaceTabs(applyPatchError), Math.max(1, width - 2)))}`;
+				}
+				const bodyLines = body ? body.split("\n") : [];
+				while (bodyLines.length > 0 && bodyLines[0].trim() === "") bodyLines.shift();
+				return {
+					header,
+					sections: bodyLines.length > 0 ? [{ content: bodyLines }] : [],
+					phase: applyPatchError ? "error" : "pending",
+					borderColor: applyPatchError ? "error" : "borderMuted",
+					contentPaddingLeft: 0,
+				};
+			},
+			{
+				onReleaseRenderCaches: () => {
+					for (const cache of callPreviewCaches) releaseRenderedStringCache(cache);
+				},
+			},
+		);
 	},
 
 	describeCall(
@@ -1452,74 +1461,54 @@ function renderSingleFileResult(
 	const renderedDiffCache = createRenderedStringCache();
 	const statsSuffixCache = createRenderedStringCache();
 
-	return framedToolCard(uiTheme, ({ width }) => {
-		const { expanded, renderContext } = options;
-		// A finalized result is authoritative: its `details` describe exactly
-		// what happened. The shared streaming `editDiffPreview` is a call-phase
-		// artifact (in a batch it reflects only the first file), so consulting it
-		// for an empty-diff delete/move/no-op result mislabels the card. Fall
-		// back to the preview only when no details exist yet.
-		const editDiffPreview = details ? undefined : renderContext?.editDiffPreview;
-		const renderDiffFn = renderContext?.renderDiff ?? renderFallbackDiff;
-
-		if (diffSectionRenderDiffFn !== renderDiffFn) {
-			diffSectionRenderDiffFn = renderDiffFn;
-			invalidateRenderedStringCache(diffSectionCache);
-			invalidateRenderedStringCache(renderedDiffCache);
-		}
-		const firstChangedLine =
-			(editDiffPreview && "firstChangedLine" in editDiffPreview ? editDiffPreview.firstChangedLine : undefined) ||
-			(details && !isError ? details.firstChangedLine : undefined);
-		const linkPath = details && "path" in details ? details.path : undefined;
-
-		// Change stats ride inline on the header bar next to the path.
-		const previewDiff = editDiffPreview && !("error" in editDiffPreview) ? editDiffPreview.diff : undefined;
-		const headerDiff = isError ? undefined : details?.diff || previewDiff;
-		const statsSuffix = headerDiff
-			? cachedRenderedString(statsSuffixCache, uiTheme, false, "", headerDiff, () =>
-					formatDiffStatsSuffix(headerDiff, uiTheme),
-				)
-			: "";
-		const header = renderEditHeader(width, uiTheme, {
-			icon: isError ? "error" : "success",
-			iconOverride: !isError && !options.isPartial ? uiTheme.styledSymbol("tool.edit", "accent") : undefined,
-			op,
-			rawPath,
-			rename,
-			firstChangedLine,
-			linkPath,
-			statsSuffix,
-		});
-		const innerWidth = Math.max(1, width - 2);
-
-		let body = "";
-		if (isError) {
-			if (errorText) body = uiTheme.fg("error", replaceTabs(errorText));
-		} else if (details?.diff) {
-			body = renderDiffSection(
-				details.diff,
-				rawPath,
-				expanded,
-				innerWidth,
-				uiTheme,
-				renderDiffFn,
-				renderedDiffCache,
-				diffSectionCache,
-			);
-		} else if (details) {
-			// Authoritative result with no textual diff: a delete, a move-only
-			// rename, or a genuine no-op. The header already names the op
-			// (Delete / `src → dst`); only a true no-op needs an explanatory
-			// body so an empty card isn't mistaken for a stalled edit.
-			if (op !== "delete" && op !== "create" && !rename) {
-				const noChangePath = linkPath ? shortenPath(linkPath) : rawPath ? shortenPath(rawPath) : "";
-				body = uiTheme.fg("dim", `No changes were made${noChangePath ? ` to ${noChangePath}` : ""}.`);
+	return framedToolCard(
+		uiTheme,
+		({ width }) => {
+			const { expanded, renderContext } = options;
+			// A finalized result is authoritative: its `details` describe exactly
+			// what happened. The shared streaming `editDiffPreview` is a call-phase
+			// artifact (in a batch it reflects only the first file), so consulting it
+			// for an empty-diff delete/move/no-op result mislabels the card. Fall
+			// back to the preview only when no details exist yet.
+			const editDiffPreview = details ? undefined : renderContext?.editDiffPreview;
+			const renderDiffFn = renderContext?.renderDiff ?? renderFallbackDiff;
+
+			if (diffSectionRenderDiffFn !== renderDiffFn) {
+				diffSectionRenderDiffFn = renderDiffFn;
+				invalidateRenderedStringCache(diffSectionCache);
+				invalidateRenderedStringCache(renderedDiffCache);
 			}
-		} else if (editDiffPreview) {
-			if ("error" in editDiffPreview) body = uiTheme.fg("error", replaceTabs(editDiffPreview.error));
-			else if (editDiffPreview.diff)
+			const firstChangedLine =
+				(editDiffPreview && "firstChangedLine" in editDiffPreview ? editDiffPreview.firstChangedLine : undefined) ||
+				(details && !isError ? details.firstChangedLine : undefined);
+			const linkPath = details && "path" in details ? details.path : undefined;
+
+			// Change stats ride inline on the header bar next to the path.
+			const previewDiff = editDiffPreview && !("error" in editDiffPreview) ? editDiffPreview.diff : undefined;
+			const headerDiff = isError ? undefined : details?.diff || previewDiff;
+			const statsSuffix = headerDiff
+				? cachedRenderedString(statsSuffixCache, uiTheme, false, "", headerDiff, () =>
+						formatDiffStatsSuffix(headerDiff, uiTheme),
+					)
+				: "";
+			const header = renderEditHeader(width, uiTheme, {
+				icon: isError ? "error" : "success",
+				iconOverride: !isError && !options.isPartial ? uiTheme.styledSymbol("tool.edit", "accent") : undefined,
+				op,
+				rawPath,
+				rename,
+				firstChangedLine,
+				linkPath,
+				statsSuffix,
+			});
+			const innerWidth = Math.max(1, width - 2);
+
+			let body = "";
+			if (isError) {
+				if (errorText) body = uiTheme.fg("error", replaceTabs(errorText));
+			} else if (details?.diff) {
 				body = renderDiffSection(
-					editDiffPreview.diff,
+					details.diff,
 					rawPath,
 					expanded,
 					innerWidth,
@@ -1528,27 +1517,56 @@ function renderSingleFileResult(
 					renderedDiffCache,
 					diffSectionCache,
 				);
-		}
-		if (details?.diagnostics) {
-			body += formatDiagnostics(details.diagnostics, expanded, uiTheme, (fp: string) =>
-				uiTheme.getLangIcon(getLanguageFromPath(fp)),
-			);
-		}
+			} else if (details) {
+				// Authoritative result with no textual diff: a delete, a move-only
+				// rename, or a genuine no-op. The header already names the op
+				// (Delete / `src → dst`); only a true no-op needs an explanatory
+				// body so an empty card isn't mistaken for a stalled edit.
+				if (op !== "delete" && op !== "create" && !rename) {
+					const noChangePath = linkPath ? shortenPath(linkPath) : rawPath ? shortenPath(rawPath) : "";
+					body = uiTheme.fg("dim", `No changes were made${noChangePath ? ` to ${noChangePath}` : ""}.`);
+				}
+			} else if (editDiffPreview) {
+				if ("error" in editDiffPreview) body = uiTheme.fg("error", replaceTabs(editDiffPreview.error));
+				else if (editDiffPreview.diff)
+					body = renderDiffSection(
+						editDiffPreview.diff,
+						rawPath,
+						expanded,
+						innerWidth,
+						uiTheme,
+						renderDiffFn,
+						renderedDiffCache,
+						diffSectionCache,
+					);
+			}
+			if (details?.diagnostics) {
+				body += formatDiagnostics(details.diagnostics, expanded, uiTheme, (fp: string) =>
+					uiTheme.getLangIcon(getLanguageFromPath(fp)),
+				);
+			}
 
-		// Diff lines self-wrap with a continuation gutter; pre-wrap to the frame's
-		// inner width so renderOutputBlock's generic wrap is a no-op. Edit frames
-		// use a flush left border because code-frame gutters already provide padding.
-		const bodyLines = body.length > 0 ? body.split("\n").flatMap(line => wrapEditRendererLine(line, innerWidth)) : [];
-		while (bodyLines.length > 0 && bodyLines[0].trim() === "") bodyLines.shift();
+			// Diff lines self-wrap with a continuation gutter; pre-wrap to the frame's
+			// inner width so renderOutputBlock's generic wrap is a no-op. Edit frames
+			// use a flush left border because code-frame gutters already provide padding.
+			const bodyLines =
+				body.length > 0 ? body.split("\n").flatMap(line => wrapEditRendererLine(line, innerWidth)) : [];
+			while (bodyLines.length > 0 && bodyLines[0].trim() === "") bodyLines.shift();
 
-		return {
-			header,
-			sections: bodyLines.length > 0 ? [{ content: bodyLines }] : [],
-			phase: isError ? "error" : options.isPartial ? "partial" : "success",
-			borderColor: isError ? "error" : "borderMuted",
-			contentPaddingLeft: 0,
-		};
-	});
+			return {
+				header,
+				sections: bodyLines.length > 0 ? [{ content: bodyLines }] : [],
+				phase: isError ? "error" : options.isPartial ? "partial" : "success",
+				borderColor: isError ? "error" : "borderMuted",
+				contentPaddingLeft: 0,
+			};
+		},
+		{
+			// Only the width-keyed diff section goes; the highlighted diff and stats suffix do not depend on width, and
+			// re-highlighting every committed card on each resize replay costs seconds.
+			onReleaseRenderCaches: () => releaseRenderedStringCache(diffSectionCache),
+		},
+	);
 }
 
 function renderMultiFileResult(
@@ -1603,5 +1621,9 @@ function renderMultiFileResult(
 			cached = undefined;
 			for (const c of fileComponents) c.invalidate?.();
 		},
+		releaseRenderCaches() {
+			cached = undefined;
+			for (const c of fileComponents) c.releaseRenderCaches?.();
+		},
 	};
 }

package/src/tools/fetch.ts

@@ -282,6 +282,10 @@ export function renderReadUrlResult(
 
 	let lastExpanded: boolean | undefined;
 	let contentPreviewLines: string[] | undefined;
+	const dropPreview = () => {
+		lastExpanded = undefined;
+		contentPreviewLines = undefined;
+	};
 	return framedToolCard(
 		uiTheme,
 		() => {
@@ -315,11 +319,6 @@ export function renderReadUrlResult(
 				applyBg: false,
 			};
 		},
-		{
-			onInvalidate: () => {
-				lastExpanded = undefined;
-				contentPreviewLines = undefined;
-			},
-		},
+		{ onInvalidate: dropPreview, onReleaseRenderCaches: dropPreview },
 	);
 }

package/src/tools/index.ts

@@ -27,6 +27,7 @@ import { todoToolRenderer } from "./todo";
 import { createVibeToolRenderer } from "./vibe";
 import { webSearchToolRenderer } from "./web-search";
 import { writeToolRenderer } from "./write";
+import { yieldToolRenderer } from "./yield";
 import { setXdevRendererLookup } from "./xdev";
 
 export * from "./renderer";
@@ -67,6 +68,7 @@ export const toolRenderers: Record<string, ToolRenderer> = {
 	vibe_kill: createVibeToolRenderer("kill"),
 	vibe_list: createVibeToolRenderer("list"),
 	write: writeToolRenderer,
+	yield: yieldToolRenderer,
 };
 
 // Wire the xd:// render delegation without the xdev module importing this registry.

package/src/tools/mcp.ts

@@ -121,7 +121,15 @@ function renderMarkdownMCPResult(
 				applyBg: false,
 			};
 		},
-		{ paddingX: 0, paddingY: 0, onInvalidate: () => (bodyMemo = undefined) },
+		{
+			paddingX: 0,
+			paddingY: 0,
+			onInvalidate: () => (bodyMemo = undefined),
+			onReleaseRenderCaches: () => {
+				bodyMemo = undefined;
+				markdown.releaseRenderCaches();
+			},
+		},
 	);
 }
 
@@ -208,7 +216,12 @@ export function renderMCPResult(
 			}
 			return { status, phase, body: bodyMemo.lines, applyBg: false };
 		},
-		{ paddingX: 0, paddingY: 0, onInvalidate: () => (bodyMemo = undefined) },
+		{
+			paddingX: 0,
+			paddingY: 0,
+			onInvalidate: () => (bodyMemo = undefined),
+			onReleaseRenderCaches: () => (bodyMemo = undefined),
+		},
 	);
 
 	function buildMcpResultBody(contentWidth: number): string[] {

package/src/tools/read.ts

@@ -600,6 +600,11 @@ export const readToolRenderer = {
 		let cachedWidth: number | undefined;
 		let cachedExpanded: boolean | undefined;
 		let cachedLines: string[] | undefined;
+		const dropCache = () => {
+			cachedWidth = undefined;
+			cachedExpanded = undefined;
+			cachedLines = undefined;
+		};
 		return markFramedBlockComponent({
 			render: (width: number) => {
 				const expanded = options.expanded;
@@ -634,11 +639,8 @@ export const readToolRenderer = {
 				cachedExpanded = expanded;
 				return cachedLines;
 			},
-			invalidate: () => {
-				cachedWidth = undefined;
-				cachedExpanded = undefined;
-				cachedLines = undefined;
-			},
+			invalidate: dropCache,
+			releaseRenderCaches: dropCache,
 		});
 	},
 	describeCall(args: ReadRenderArgs): NativeToolView {