@oh-my-pi/pi-tui 15.1.2 → 15.1.4

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [15.1.4] - 2026-05-19
+
+### Fixed
+
+- Fixed `renderInlineMarkdown` crashing with `TypeError: undefined is not an object (evaluating 'e.replace')` when called with a non-string value during streaming — partial JSON parsing leaves option label fields temporarily unpopulated, causing the ask tool renderer to fail. ([#1176](https://github.com/can1357/oh-my-pi/issues/1176))
+
 ## [15.0.2] - 2026-05-15
 
 ### Added

package/dist/types/autocomplete.d.ts

@@ -35,6 +35,18 @@ export interface AutocompleteProvider {
         items: AutocompleteItem[];
         prefix: string;
     } | null;
+    /**
+     * Synchronously try to expand text immediately before the cursor (no async I/O).
+     * Called after every single-character insert. Implementations MUST cheaply
+     * early-return when the trailing context cannot trigger them.
+     * Returns the number of characters to delete immediately before the cursor
+     * and the literal string to insert in their place, or null to leave the
+     * buffer untouched.
+     */
+    trySyncInlineReplace?(textBeforeCursor: string): {
+        replaceLen: number;
+        insert: string;
+    } | null;
 }
 export declare class CombinedAutocompleteProvider implements AutocompleteProvider {
     #private;

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-tui",
-	"version": "15.1.2",
+	"version": "15.1.4",
 	"description": "Terminal User Interface library with differential rendering for efficient text-based applications",
 	"homepage": "https://omp.sh",
 	"author": "Can Boluk",
@@ -37,8 +37,8 @@
 		"fmt": "biome format --write ."
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-natives": "15.1.2",
-		"@oh-my-pi/pi-utils": "15.1.2",
+		"@oh-my-pi/pi-natives": "15.1.4",
+		"@oh-my-pi/pi-utils": "15.1.4",
 		"lru-cache": "11.3.6",
 		"marked": "^18.0.3"
 	},

package/src/autocomplete.ts

@@ -199,6 +199,15 @@ export interface AutocompleteProvider {
 	/** Synchronously try to complete a slash command at the start of a line (no async I/O). */
 	/** Returns matched items and the full prefix, or null if not applicable. */
 	trySyncSlashCompletion?(textBeforeCursor: string): { items: AutocompleteItem[]; prefix: string } | null;
+	/**
+	 * Synchronously try to expand text immediately before the cursor (no async I/O).
+	 * Called after every single-character insert. Implementations MUST cheaply
+	 * early-return when the trailing context cannot trigger them.
+	 * Returns the number of characters to delete immediately before the cursor
+	 * and the literal string to insert in their place, or null to leave the
+	 * buffer untouched.
+	 */
+	trySyncInlineReplace?(textBeforeCursor: string): { replaceLen: number; insert: string } | null;
 }
 
 // Combined provider that handles both slash commands and file paths.

package/src/components/editor.ts

@@ -985,6 +985,7 @@ export class Editor implements Component, Focusable {
 						this.#setCursorCol(result.cursorCol);
 
 						this.#cancelAutocomplete();
+						this.onAutocompleteUpdate?.();
 
 						if (this.onChange) {
 							this.onChange(this.getText());
@@ -1044,6 +1045,7 @@ export class Editor implements Component, Focusable {
 						this.#setCursorCol(result.cursorCol);
 
 						this.#cancelAutocomplete();
+						this.onAutocompleteUpdate?.();
 
 						if (this.onChange) {
 							this.onChange(this.getText());
@@ -1493,6 +1495,29 @@ export class Editor implements Component, Focusable {
 			this.onChange(this.getText());
 		}
 
+		// Synchronous inline replacement (e.g. emoji shortcodes `:joy:` → 😂).
+		// Runs before autocomplete trigger so the popup doesn't briefly chase a
+		// prefix that's about to be rewritten.
+		if (char.length === 1 && this.#autocompleteProvider?.trySyncInlineReplace) {
+			const replaceLine = this.#state.lines[this.#state.cursorLine] || "";
+			const textBeforeCursor = replaceLine.slice(0, this.#state.cursorCol);
+			const replacement = this.#autocompleteProvider.trySyncInlineReplace(textBeforeCursor);
+			if (replacement) {
+				const before = replaceLine.slice(0, this.#state.cursorCol - replacement.replaceLen);
+				const after = replaceLine.slice(this.#state.cursorCol);
+				this.#state.lines[this.#state.cursorLine] = before + replacement.insert + after;
+				this.#setCursorCol(before.length + replacement.insert.length);
+				if (this.onChange) {
+					this.onChange(this.getText());
+				}
+				if (this.#autocompleteState) {
+					this.#cancelAutocomplete();
+					this.onAutocompleteUpdate?.();
+				}
+				return;
+			}
+		}
+
 		// Check if we should trigger or update autocomplete
 		if (!this.#autocompleteState) {
 			// Auto-trigger for "/" at the start of a line (slash commands)
@@ -1529,6 +1554,10 @@ export class Editor implements Component, Focusable {
 				else if (textBeforeCursor.match(/#[^\s#]*$/)) {
 					this.#tryTriggerAutocomplete();
 				}
+				// Check if we're in a :emoji shortcode context
+				else if (textBeforeCursor.match(/(?:^|[\s([{>]):[a-zA-Z0-9_+-]*$/)) {
+					this.#tryTriggerAutocomplete();
+				}
 			}
 		} else {
 			this.#debouncedUpdateAutocomplete();

package/src/components/markdown.ts

@@ -47,14 +47,16 @@ export function clearRenderCache(): void {
 }
 
 // Stable numeric IDs for structural theme/style objects (no ID field on type).
-// WeakMap so GC can collect orphaned themes/styles without a leak.
-const objectIds = new WeakMap<object, number>();
+// Symbol-keyed so the id travels with the object and is invisible to consumers.
+const kObjectId = Symbol("markdown.objectId");
+type WithObjectId = object & { [kObjectId]?: number };
 let nextObjectId = 0;
 function objectId(o: object): number {
-	let id = objectIds.get(o);
+	const tagged = o as WithObjectId;
+	let id = tagged[kObjectId];
 	if (id === undefined) {
 		id = nextObjectId++;
-		objectIds.set(o, id);
+		tagged[kObjectId] = id;
 	}
 	return id;
 }
@@ -944,6 +946,8 @@ export class Markdown implements Component {
  * Unlike the full Markdown component, this produces a single line with no block-level elements.
  */
 export function renderInlineMarkdown(text: string, mdTheme: MarkdownTheme, baseColor?: (t: string) => string): string {
+	// Guard against undefined/null during streaming — partial JSON can leave fields unpopulated.
+	if (typeof text !== "string") return (baseColor ?? (t => t))(text != null ? String(text) : "");
 	const tokens = marked.lexer(text);
 	const applyText = baseColor ?? ((t: string) => t);
 	let result = "";

package/src/terminal.ts

@@ -591,6 +591,9 @@ export class ProcessTerminal implements Terminal {
 
 	#safeWrite(data: string): void {
 		if (this.#dead) return;
+		// Skip control sequences when stdout isn't a TTY (piped output, tests, log
+		// files). They serve no purpose there and would surface as visible noise.
+		if (!process.stdout.isTTY) return;
 		try {
 			process.stdout.write(data);
 		} catch (err) {