@oh-my-pi/pi-mnemopi 18.8.4 → 18.8.5

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [18.8.5] - 2026-10-08
+
+### Fixed
+
+- Fixed new memories gaining graph links (`related_to`, `references`, `ctx`) to memories that were already invalidated, superseded, or expired; proactive linking and consolidation now link only to memories recall can still return, so the graph stops growing toward retired memories ([#14427](https://github.com/can1357/oh-my-pi/pull/14427) by [@tickernelz](https://github.com/tickernelz)).
+
 ## [18.5.1] - 2026-10-03
 
 ### Changed

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-mnemopi",
-	"version": "18.8.4",
+	"version": "18.8.5",
 	"description": "Local SQLite memory engine for omp agents",
 	"homepage": "https://omp.sh",
 	"author": {
@@ -42,10 +42,10 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-ai": "18.8.4",
-		"@oh-my-pi/pi-catalog": "18.8.4",
-		"@oh-my-pi/pi-natives": "18.8.4",
-		"@oh-my-pi/pi-utils": "18.8.4"
+		"@oh-my-pi/pi-ai": "18.8.5",
+		"@oh-my-pi/pi-catalog": "18.8.5",
+		"@oh-my-pi/pi-natives": "18.8.5",
+		"@oh-my-pi/pi-utils": "18.8.5"
 	},
 	"peerDependencies": {
 		"fastembed": "3.0.0",

package/src/core/episodic-graph.ts

@@ -98,14 +98,27 @@ interface EdgeRow {
 	readonly timestamp: string | null;
 }
 
+interface MemoryLivenessRow {
+	readonly id: string;
+	readonly live: number;
+}
+
 const EXTRACT_FACTS_MAX_CONTENT_LEN = 4096;
 const MAX_FACTS_PER_MEMORY = 5;
 const DEFAULT_LINK_THRESHOLD = 0.35;
+const LIVE_MEMORY_SQL = "superseded_by IS NULL AND (valid_until IS NULL OR valid_until > ?)";
 
 function nowIso(): string {
 	return new Date().toISOString();
 }
 
+function partitionByLiveness(rows: readonly MemoryLivenessRow[], live: Set<string>, retired: Set<string>): void {
+	for (const row of rows) {
+		if (row.live === 1) live.add(row.id);
+		else retired.add(row.id);
+	}
+}
+
 function unique(values: Iterable<string>, limit = Number.MAX_SAFE_INTEGER): string[] {
 	const seen = new Set<string>();
 	const out: string[] = [];
@@ -518,7 +531,7 @@ export class EpisodicGraph {
 		if (linkExisting) {
 			const sourceTokens = contentTokenSet(content);
 			for (const otherId of previousMemoryIds) {
-				const otherContent = this.memoryContent(otherId);
+				const otherContent = this.memoryContent(otherId, timestamp);
 				const lexicalScore = Math.round(jaccard(sourceTokens, contentTokenSet(otherContent)) * 1000) / 1000;
 				let wroteCtxEdge = false;
 				if (lexicalScore >= minLinkScore) {
@@ -646,33 +659,40 @@ export class EpisodicGraph {
 	}
 
 	private knownMemoryIds(exclude: string): string[] {
+		const now = nowIso();
 		const ids = new Set<string>();
+		const live = new Set<string>();
+		const retired = new Set<string>();
 		const gistRows = this.db
 			.query("SELECT DISTINCT memory_id FROM gists WHERE memory_id IS NOT NULL AND memory_id != ?")
 			.all(exclude) as { memory_id: string }[];
 		for (const row of gistRows) ids.add(row.memory_id);
 		try {
-			const workingRows = this.db.query("SELECT id FROM working_memory WHERE id != ?").all(exclude) as {
-				id: string;
-			}[];
-			for (const row of workingRows) ids.add(row.id);
+			const workingRows = this.db
+				.query(`SELECT id, ${LIVE_MEMORY_SQL} AS live FROM working_memory WHERE id != ?`)
+				.all(now, exclude) as MemoryLivenessRow[];
+			partitionByLiveness(workingRows, live, retired);
 		} catch {
 			// Standalone graph stores do not have Beam memory tables.
 		}
 		try {
-			const episodicRows = this.db.query("SELECT id FROM episodic_memory WHERE id != ?").all(exclude) as {
-				id: string;
-			}[];
-			for (const row of episodicRows) ids.add(row.id);
+			const episodicRows = this.db
+				.query(`SELECT id, ${LIVE_MEMORY_SQL} AS live FROM episodic_memory WHERE id != ?`)
+				.all(now, exclude) as MemoryLivenessRow[];
+			partitionByLiveness(episodicRows, live, retired);
 		} catch {
 			// Standalone graph stores do not have Beam memory tables.
 		}
+		for (const id of live) ids.add(id);
+		for (const id of retired) if (!live.has(id)) ids.delete(id);
 		return [...ids];
 	}
 
-	private memoryContent(memoryId: string): string {
+	private memoryContent(memoryId: string, now: string): string {
 		try {
-			const working = this.db.query("SELECT content FROM working_memory WHERE id = ?").get(memoryId) as {
+			const working = this.db
+				.query(`SELECT content FROM working_memory WHERE id = ? AND ${LIVE_MEMORY_SQL}`)
+				.get(memoryId, now) as {
 				content: string;
 			} | null;
 			if (working !== null) return working.content;
@@ -680,7 +700,9 @@ export class EpisodicGraph {
 			// Standalone EpisodicGraph users may not have Beam tables.
 		}
 		try {
-			const episodic = this.db.query("SELECT content FROM episodic_memory WHERE id = ?").get(memoryId) as {
+			const episodic = this.db
+				.query(`SELECT content FROM episodic_memory WHERE id = ? AND ${LIVE_MEMORY_SQL}`)
+				.get(memoryId, now) as {
 				content: string;
 			} | null;
 			if (episodic !== null) return episodic.content;