@oh-my-pi/pi-mnemopi 18.4.0 → 18.4.2

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [18.4.1] - 2026-09-28
+
+### Fixed
+
+- Fixed extracted facts still being recalled after their source memory was invalidated or expired. ([#12825](https://github.com/can1357/oh-my-pi/pull/12825) by [@Jpei1994](https://github.com/Jpei1994))
+
 ## [18.3.3] - 2026-09-27
 
 ### Fixed

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-mnemopi",
-	"version": "18.4.0",
+	"version": "18.4.2",
 	"description": "Local SQLite memory engine for omp agents",
 	"homepage": "https://omp.sh",
 	"author": {
@@ -42,10 +42,10 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-ai": "18.4.0",
-		"@oh-my-pi/pi-catalog": "18.4.0",
-		"@oh-my-pi/pi-natives": "18.4.0",
-		"@oh-my-pi/pi-utils": "18.4.0"
+		"@oh-my-pi/pi-ai": "18.4.2",
+		"@oh-my-pi/pi-catalog": "18.4.2",
+		"@oh-my-pi/pi-natives": "18.4.2",
+		"@oh-my-pi/pi-utils": "18.4.2"
 	},
 	"peerDependencies": {
 		"fastembed": "2.1.0",

package/src/core/beam/recall.ts

@@ -404,10 +404,17 @@ function factsHaveScopeColumn(beam: BeamMemoryState): boolean {
 
 function factVisibilityWhere(beam: BeamMemoryState, tableAlias: string): { where: string; params: DbValue[] } {
 	const prefix = tableAlias.length === 0 ? "" : `${tableAlias}.`;
-	if (factsHaveScopeColumn(beam)) {
-		return { where: `(${prefix}session_id = ? OR ${prefix}scope = 'global')`, params: [beam.sessionId] };
-	}
-	return { where: `${prefix}session_id = ?`, params: [beam.sessionId] };
+	const scope = factsHaveScopeColumn(beam)
+		? `(${prefix}session_id = ? OR ${prefix}scope = 'global')`
+		: `${prefix}session_id = ?`;
+	// A fact is a derivative of the working_memory row it was extracted from: once that row is
+	// explicitly superseded (`memory_edit invalidate`) or has expired, the fact must stop
+	// surfacing — otherwise an explicit invalidation is silently defeated at the fact layer.
+	// Correlated EXISTS probes the source's primary key (same shape as the fts_working /
+	// fts_episodes visibility predicates). Facts whose source row no longer exists stay
+	// visible: nothing contradicts them.
+	const sourceSuperseded = `NOT EXISTS (SELECT 1 FROM working_memory w WHERE w.id = ${prefix}source_msg_id AND (w.superseded_by IS NOT NULL OR (w.valid_until IS NOT NULL AND w.valid_until <= ?)))`;
+	return { where: `${scope} AND ${sourceSuperseded}`, params: [beam.sessionId, nowIso()] };
 }
 
 function buildWhere(