@oh-my-pi/pi-mnemopi 18.2.0 → 18.2.2

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## [Unreleased]
 
+## [18.2.1] - 2026-09-15
+
+### Fixed
+
+- Fixed an explicitly invalidated memory still being returned by an identical repeat query until the recall cache expired.
+- Fixed recall continuing to serve a stale, pre-embedding ranking for up to an hour after background embeddings finished, when the enhanced recall cache is enabled.
+
 ## [18.0.11] - 2026-08-29
 
 ### Fixed

package/package.json

@@ -1,7 +1,7 @@
 {
 	"type": "module",
 	"name": "@oh-my-pi/pi-mnemopi",
-	"version": "18.2.0",
+	"version": "18.2.2",
 	"description": "Local SQLite memory engine for Oh My Pi agents",
 	"homepage": "https://omp.sh",
 	"author": "Stencil Labs, Inc.",
@@ -39,10 +39,10 @@
 		"fmt": "oxfmt --no-error-on-unmatched-pattern 'src/**/*.{ts,tsx}' '{test,bench,examples,scripts}/**/*.ts' '*.ts'"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-ai": "18.2.0",
-		"@oh-my-pi/pi-catalog": "18.2.0",
-		"@oh-my-pi/pi-natives": "18.2.0",
-		"@oh-my-pi/pi-utils": "18.2.0"
+		"@oh-my-pi/pi-ai": "18.2.2",
+		"@oh-my-pi/pi-catalog": "18.2.2",
+		"@oh-my-pi/pi-natives": "18.2.2",
+		"@oh-my-pi/pi-utils": "18.2.2"
 	},
 	"peerDependencies": {
 		"fastembed": "2.1.0",

package/src/core/beam/consolidate.ts

@@ -576,8 +576,26 @@ export function extractAndStoreFacts(
 		const rawUnit = match[2] ?? "";
 		let unit = rawUnit.toLowerCase();
 		if (unit.endsWith("s") && !unit.endsWith("ms")) unit = unit.slice(0, -1);
-		const prefixWords = text
-			.slice(Math.max(0, (match.index ?? 0) - 50), match.index ?? 0)
+		// The naive fixed 50-char lookbehind can cross a markdown table cell, a code fence, or
+		// a sentence boundary and glue unrelated words into one underscore-joined key (e.g.
+		// "iam-role_smrx/sm-secrets_ssm-parameters_api" -> "2api" from a table row, or
+		// "cadence_90/60/5_30-_second" from a run-on list). Clamping the window to start after
+		// the nearest preceding structural boundary -- newline, table pipe, sentence-ending
+		// punctuation, or a backtick -- keeps the phrase within one cell/sentence/line, matching
+		// what a human would read as "the words right before this number" rather than 50 raw
+		// characters regardless of what they cross.
+		//
+		// A bare `.` is NOT always a sentence boundary: "v1.2", "3.14", "18.0.8" all contain
+		// dots that are part of a version/decimal number, not sentence punctuation. Only count
+		// `.`/`!`/`?` as a boundary when followed by whitespace or the end of the window -- i.e.
+		// it actually ends a sentence.
+		const windowStart = Math.max(0, (match.index ?? 0) - 50);
+		let window = text.slice(windowStart, match.index ?? 0);
+		const boundaryMatch = /\n|\||`|[.!?](?=\s|$)|;/g;
+		let lastBoundary = -1;
+		for (let m = boundaryMatch.exec(window); m; m = boundaryMatch.exec(window)) lastBoundary = m.index;
+		if (lastBoundary !== -1) window = window.slice(lastBoundary + 1);
+		const prefixWords = window
 			.replace(/`[^`]*`/g, " ")
 			.split(/\s+/)
 			.map(w => w.replace(/[.,:;!?()[\]"'`*_]/g, ""))

package/src/core/beam/helpers.ts

@@ -794,15 +794,31 @@ async function runEmbedding(beam: BeamMemoryState, items: readonly EmbedItem[]):
 		using insertEmbedding = beam.db.prepare(
 			"INSERT OR REPLACE INTO memory_embeddings(memory_id, embedding_json, model) VALUES (?, ?, ?)",
 		);
+		let committed = 0;
 		const insertMany = beam.db.transaction((rows: readonly EmbedItem[]) => {
 			for (let i = 0; i < rows.length; i += 1) {
 				const vector = matrix[i];
 				const item = rows[i];
 				if (vector === undefined || item === undefined) continue;
 				insertEmbedding.run(item.memoryId, JSON.stringify(Array.from(vector)), model);
+				committed += 1;
 			}
 		});
 		insertMany(items);
+		// A recall taken while these vectors were still generating cached an FTS-only ranking, and
+		// committing vectors changes what recall returns -- so that cache must be dropped, or the
+		// pre-embedding order keeps being served for the whole cache TTL. Gated on `committed`: a
+		// batch whose provider returned a short or empty matrix inserts nothing, changes no ranking,
+		// and invalidating there would only discard a still-valid cache. Only the query cache is
+		// affected; the polyphonic subject dictionary is built from facts/gists, which an embedding
+		// batch never touches.
+		if (committed > 0) {
+			const caches = beam.caches as
+				| { queryCache?: { invalidate?: () => void }; _queryCache?: { invalidate?: () => void } }
+				| undefined;
+			caches?.queryCache?.invalidate?.();
+			caches?._queryCache?.invalidate?.();
+		}
 	} catch (error) {
 		// Background embedding generation is best-effort: a failing provider, a closed DB
 		// during shutdown, or a transient API error must never disrupt the synchronous

package/src/core/beam/store.ts

@@ -651,7 +651,16 @@ export function invalidate(beam: BeamMemoryState, memoryId: string, replacementI
 		`,
 		[now, replacementId, memoryId, beam.sessionId],
 	);
-	if (working.changes > 0) return true;
+	if (working.changes > 0) {
+		// Recall filters `valid_until`/`superseded_by` in SQL, but the enhanced path consults the
+		// query cache BEFORE it reaches SQL. Without this the row a caller just retired keeps being
+		// served to an identical query for the rest of the cache TTL -- the one thing an explicit
+		// invalidation is supposed to guarantee against. Every other mutator here already does this;
+		// this one was the omission. Gated on an actual row change, like `forgetWorking`, so a
+		// no-op invalidation never discards a valid cache.
+		invalidateCaches(beam);
+		return true;
+	}
 	const episodic = beam.db.run(
 		`
 			UPDATE episodic_memory
@@ -660,7 +669,11 @@ export function invalidate(beam: BeamMemoryState, memoryId: string, replacementI
 		`,
 		[now, replacementId, memoryId, beam.sessionId],
 	);
-	return episodic.changes > 0;
+	if (episodic.changes > 0) {
+		invalidateCaches(beam);
+		return true;
+	}
+	return false;
 }
 
 export function getWorkingStats(

package/src/core/local-llm.ts

@@ -189,18 +189,20 @@ export async function callConfiguredCompletion(
 		return null;
 	}
 	try {
-		const message = await retryTransientCompletion(() =>
-			completeSimple(
-				model,
-				{
-					messages: [{ role: "user", content: prompt, timestamp: Date.now() }],
-				},
-				{
-					apiKey: llmApiKey() || undefined,
-					maxTokens: opts.maxTokens ?? llmMaxTokens(),
-					temperature,
-				},
-			),
+		const message = await retryTransientCompletion(
+			() =>
+				completeSimple(
+					model,
+					{
+						messages: [{ role: "user", content: prompt, timestamp: Date.now() }],
+					},
+					{
+						apiKey: llmApiKey() || undefined,
+						maxTokens: opts.maxTokens ?? llmMaxTokens(),
+						temperature,
+					},
+				),
+			{ provider: model.provider },
 		);
 		return assistantText(message).trim() || null;
 	} catch {