@oh-my-pi/pi-coding-agent 9.6.0 → 9.6.3

package/src/tools/read.ts

@@ -1003,7 +1003,7 @@ export const readToolRenderer = {
 		const offset = args.offset;
 		const limit = args.limit;
 
-		let pathDisplay = filePath || uiTheme.format.ellipsis;
+		let pathDisplay = filePath || "…";
 		if (offset !== undefined || limit !== undefined) {
 			const startLine = offset ?? 1;
 			const endLine = limit !== undefined ? startLine + limit - 1 : "";

package/src/tools/render-utils.ts

@@ -5,9 +5,12 @@
  * tool renderers to ensure a unified TUI experience.
  */
 import * as os from "node:os";
+import { type Ellipsis, truncateToWidth } from "@oh-my-pi/pi-tui";
 import type { Theme } from "../modes/theme/theme";
 import { getTreeBranch } from "../tui/utils";
 
+export { Ellipsis, truncateToWidth } from "@oh-my-pi/pi-tui";
+
 // =============================================================================
 // Standardized Display Constants
 // =============================================================================
@@ -47,22 +50,12 @@ export const EXPAND_HINT = "(Ctrl+O for more)";
 // Text Truncation Utilities
 // =============================================================================
 
-/**
- * Truncate text to max length with ellipsis.
- * The most commonly duplicated utility across renderers.
- */
-export function truncate(text: string, maxLen: number, ellipsis: string): string {
-	if (text.length <= maxLen) return text;
-	const sliceLen = Math.max(0, maxLen - ellipsis.length);
-	return `${text.slice(0, sliceLen)}${ellipsis}`;
-}
-
 /**
  * Get first N lines of text as preview, with each line truncated.
  */
-export function getPreviewLines(text: string, maxLines: number, maxLineLen: number, ellipsis: string): string[] {
+export function getPreviewLines(text: string, maxLines: number, maxLineLen: number, ellipsis?: Ellipsis): string[] {
 	const lines = text.split("\n").filter(l => l.trim());
-	return lines.slice(0, maxLines).map(l => truncate(l.trim(), maxLineLen, ellipsis));
+	return lines.slice(0, maxLines).map(l => truncateToWidth(l.trim(), maxLineLen, ellipsis));
 }
 
 // =============================================================================
@@ -194,9 +187,9 @@ export function formatBadge(label: string, color: ToolUIColor, theme: Theme): st
  * Build a "more items" suffix line for truncated lists.
  * Uses consistent wording pattern.
  */
-export function formatMoreItems(remaining: number, itemType: string, theme: Theme): string {
+export function formatMoreItems(remaining: number, itemType: string): string {
 	const safeRemaining = Number.isFinite(remaining) ? remaining : 0;
-	return `${theme.format.ellipsis} ${safeRemaining} more ${pluralize(itemType, safeRemaining)}`;
+	return `… ${safeRemaining} more ${pluralize(itemType, safeRemaining)}`;
 }
 
 export function formatMeta(meta: string[], theme: Theme): string {
@@ -252,7 +245,7 @@ export class ToolUIKit {
 	}
 
 	moreItems(remaining: number, itemType: string): string {
-		return formatMoreItems(remaining, itemType, this.theme);
+		return formatMoreItems(remaining, itemType);
 	}
 
 	expandHint(expanded: boolean, hasMore: boolean): string {
@@ -288,11 +281,11 @@ export class ToolUIKit {
 	}
 
 	truncate(text: string, maxLen: number): string {
-		return truncate(text, maxLen, this.theme.format.ellipsis);
+		return truncateToWidth(text, maxLen);
 	}
 
 	previewLines(text: string, maxLines: number, maxLineLen: number): string[] {
-		return getPreviewLines(text, maxLines, maxLineLen, this.theme.format.ellipsis);
+		return getPreviewLines(text, maxLines, maxLineLen);
 	}
 
 	formatBytes(bytes: number): string {
@@ -457,7 +450,7 @@ export function formatDiagnostics(
 		const remaining = totalDiags - diagsShown;
 		output += `\n ${theme.fg("dim", theme.tree.last)} ${theme.fg(
 			"muted",
-			`${theme.format.ellipsis} ${remaining} more`,
+			`… ${remaining} more`,
 		)} ${formatExpandHint(theme)}`;
 	}
 
@@ -697,9 +690,7 @@ export function renderTreeList<T>(
 
 	if (!expanded && items.length > maxCollapsed) {
 		const remaining = items.length - maxCollapsed;
-		lines.push(
-			` ${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, itemType, theme))}`,
-		);
+		lines.push(` ${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, itemType))}`);
 	}
 
 	return lines;

package/src/tools/review.ts

@@ -181,13 +181,7 @@ subprocessToolRegistry.register<ReportFindingDetails>("report_finding", {
 		}
 
 		if (allData.length > displayCount) {
-			container.addChild(
-				new Text(
-					theme.fg("dim", `  ${theme.format.ellipsis} ${allData.length - displayCount} more findings`),
-					0,
-					0,
-				),
-			);
+			container.addChild(new Text(theme.fg("dim", `  … ${allData.length - displayCount} more findings`), 0, 0));
 		}
 
 		return container;

package/src/tools/ssh.ts

@@ -237,8 +237,8 @@ interface SshRenderContext {
 
 export const sshToolRenderer = {
 	renderCall(args: SshRenderArgs, uiTheme: Theme): Component {
-		const host = args.host || uiTheme.format.ellipsis;
-		const command = args.command || uiTheme.format.ellipsis;
+		const host = args.host || "…";
+		const command = args.command || "…";
 		const text = renderStatusLine({ icon: "pending", title: "SSH", description: `[${host}] $ ${command}` }, uiTheme);
 		return new Text(text, 0, 0);
 	},
@@ -254,8 +254,8 @@ export const sshToolRenderer = {
 	): Component {
 		const { expanded, renderContext } = options;
 		const details = result.details;
-		const host = args?.host || uiTheme.format.ellipsis;
-		const command = args?.command || uiTheme.format.ellipsis;
+		const host = args?.host || "…";
+		const command = args?.command || "…";
 		const header = renderStatusLine(
 			{ icon: "success", title: "SSH", description: `[${host}] $ ${command}` },
 			uiTheme,
@@ -274,7 +274,7 @@ export const sshToolRenderer = {
 					outputLines.push(
 						uiTheme.fg(
 							"dim",
-							`${uiTheme.format.ellipsis} (${skippedCount} earlier lines, showing ${visualLines.length} of ${totalVisualLines}) (ctrl+o to expand)`,
+							`… (${skippedCount} earlier lines, showing ${visualLines.length} of ${totalVisualLines}) (ctrl+o to expand)`,
 						),
 					);
 				}
@@ -289,9 +289,7 @@ export const sshToolRenderer = {
 				const remaining = outputLinesRaw.length - maxLines;
 				outputLines.push(...displayLines.map(line => uiTheme.fg("toolOutput", line)));
 				if (remaining > 0) {
-					outputLines.push(
-						uiTheme.fg("dim", `${uiTheme.format.ellipsis} (${remaining} more lines) (ctrl+o to expand)`),
-					);
+					outputLines.push(uiTheme.fg("dim", `… (${remaining} more lines) (ctrl+o to expand)`));
 				}
 			}
 		}

package/src/tools/write.ts

@@ -155,12 +155,12 @@ function formatStreamingContent(content: string, uiTheme: Theme, ui: ToolUIKit):
 
 	let text = "\n\n";
 	if (hidden > 0) {
-		text += uiTheme.fg("dim", `${uiTheme.format.ellipsis} (${hidden} earlier lines)\n`);
+		text += uiTheme.fg("dim", `… (${hidden} earlier lines)\n`);
 	}
 	for (const line of displayLines) {
 		text += `${uiTheme.fg("toolOutput", ui.truncate(line, 80))}\n`;
 	}
-	text += uiTheme.fg("dim", `${uiTheme.format.ellipsis} (streaming)`);
+	text += uiTheme.fg("dim", `… (streaming)`);
 	return text;
 }
 
@@ -177,7 +177,7 @@ function renderContentPreview(content: string, expanded: boolean, uiTheme: Theme
 	}
 	if (!expanded && hidden > 0) {
 		const hint = formatExpandHint(uiTheme, expanded, hidden > 0);
-		const moreLine = `${formatMoreItems(hidden, "line", uiTheme)}${hint ? ` ${hint}` : ""}`;
+		const moreLine = `${formatMoreItems(hidden, "line")}${hint ? ` ${hint}` : ""}`;
 		text += uiTheme.fg("dim", moreLine);
 	}
 	return text;
@@ -190,7 +190,7 @@ export const writeToolRenderer = {
 		const filePath = shortenPath(rawPath);
 		const lang = getLanguageFromPath(rawPath) ?? "text";
 		const langIcon = uiTheme.fg("muted", uiTheme.getLangIcon(lang));
-		const pathDisplay = filePath ? uiTheme.fg("accent", filePath) : uiTheme.fg("toolOutput", uiTheme.format.ellipsis);
+		const pathDisplay = filePath ? uiTheme.fg("accent", filePath) : uiTheme.fg("toolOutput", "…");
 		const spinner =
 			options?.spinnerFrame !== undefined ? formatStatusIcon("running", uiTheme, options.spinnerFrame) : "";
 
@@ -218,7 +218,7 @@ export const writeToolRenderer = {
 		const fileContent = args?.content || "";
 		const lang = getLanguageFromPath(rawPath);
 		const langIcon = uiTheme.fg("muted", uiTheme.getLangIcon(lang));
-		const pathDisplay = filePath ? uiTheme.fg("accent", filePath) : uiTheme.fg("toolOutput", uiTheme.format.ellipsis);
+		const pathDisplay = filePath ? uiTheme.fg("accent", filePath) : uiTheme.fg("toolOutput", "…");
 		const lineCount = countLines(fileContent);
 
 		// Build header with status icon

package/src/tui/code-cell.ts

@@ -80,7 +80,7 @@ export function renderCodeCell(options: CodeCellOptions, theme: Theme): string[]
 	const hiddenCodeLines = rawCodeLines.length - codeLines.length;
 	if (hiddenCodeLines > 0) {
 		const hint = formatExpandHint(theme, expanded, hiddenCodeLines > 0);
-		const moreLine = `${formatMoreItems(hiddenCodeLines, "line", theme)}${hint ? ` ${hint}` : ""}`;
+		const moreLine = `${formatMoreItems(hiddenCodeLines, "line")}${hint ? ` ${hint}` : ""}`;
 		codeLines.push(theme.fg("dim", moreLine));
 	}
 
@@ -95,7 +95,7 @@ export function renderCodeCell(options: CodeCellOptions, theme: Theme): string[]
 		const remaining = rawLines.length - maxLines;
 		if (remaining > 0) {
 			const hint = formatExpandHint(theme, expanded, remaining > 0);
-			const moreLine = `${formatMoreItems(remaining, "line", theme)}${hint ? ` ${hint}` : ""}`;
+			const moreLine = `${formatMoreItems(remaining, "line")}${hint ? ` ${hint}` : ""}`;
 			outputLines.push(theme.fg("dim", moreLine));
 		}
 	}

package/src/tui/output-block.ts

@@ -42,7 +42,7 @@ export function renderOutputBlock(options: OutputBlockOptions, theme: Theme): st
 		const leftWidth = visibleWidth(left);
 		const rightWidth = visibleWidth(right);
 		const maxLabelWidth = Math.max(0, lineWidth - leftWidth - rightWidth);
-		const trimmedLabel = truncateToWidth(rawLabel, maxLabelWidth, theme.format.ellipsis);
+		const trimmedLabel = truncateToWidth(rawLabel, maxLabelWidth);
 		const labelWidth = visibleWidth(trimmedLabel);
 		const fillCount = Math.max(0, lineWidth - leftWidth - labelWidth - rightWidth);
 		return `${left}${trimmedLabel}${border(h.repeat(fillCount))}${right}`;
@@ -69,7 +69,7 @@ export function renderOutputBlock(options: OutputBlockOptions, theme: Theme): st
 		}
 		const allLines = section.lines.flatMap(l => l.split("\n"));
 		for (const line of allLines) {
-			const text = truncateToWidth(line, contentWidth, theme.format.ellipsis);
+			const text = truncateToWidth(line, contentWidth);
 			const innerPadding = padding(Math.max(0, contentWidth - visibleWidth(text)));
 			const fullLine = `${contentPrefix}${text}${innerPadding}${contentSuffix}`;
 			lines.push(padToWidth(fullLine, lineWidth, bgFn));

package/src/tui/tree-list.ts

@@ -46,9 +46,7 @@ export function renderTreeList<T>(options: TreeListOptions<T>, theme: Theme): st
 
 	if (!expanded && items.length > maxItems) {
 		const remaining = items.length - maxItems;
-		lines.push(
-			`${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, itemType, theme))}`,
-		);
+		lines.push(`${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, itemType))}`);
 	}
 
 	return lines;

package/src/tui/utils.ts

@@ -1,10 +1,12 @@
 /**
  * Shared helpers for tool-rendered UI components.
  */
-import { padding, truncateToWidth as truncateToWidthBase, visibleWidth } from "@oh-my-pi/pi-tui";
+import { padding, visibleWidth } from "@oh-my-pi/pi-tui";
 import type { Theme, ThemeBg } from "../modes/theme/theme";
 import type { IconType, State } from "./types";
 
+export { truncateToWidth } from "@oh-my-pi/pi-tui";
+
 export function buildTreePrefix(ancestors: boolean[], theme: Theme): string {
 	return ancestors.map(hasNext => (hasNext ? `${theme.tree.vertical}  ` : "   ")).join("");
 }
@@ -17,10 +19,6 @@ export function getTreeContinuePrefix(isLast: boolean, theme: Theme): string {
 	return isLast ? "   " : `${theme.tree.vertical}  `;
 }
 
-export function truncateToWidth(text: string, width: number, ellipsis: string): string {
-	return truncateToWidthBase(text, width, ellipsis);
-}
-
 export function padToWidth(text: string, width: number, bgFn?: (s: string) => string): string {
 	if (width <= 0) return bgFn ? bgFn(text) : text;
 	const paddingNeeded = Math.max(0, width - visibleWidth(text));

package/src/web/search/render.ts

@@ -17,7 +17,7 @@ import {
 	getPreviewLines,
 	PREVIEW_LIMITS,
 	TRUNCATE_LENGTHS,
-	truncate,
+	truncateToWidth,
 } from "../../tools/render-utils";
 import { renderOutputBlock, renderStatusLine, renderTreeList } from "../../tui";
 import type { WebSearchResponse } from "./types";
@@ -35,7 +35,7 @@ const MAX_REQUEST_ID_LEN = 36;
 function renderFallbackText(contentText: string, expanded: boolean, theme: Theme): Component {
 	const lines = contentText.split("\n").filter(line => line.trim());
 	const maxLines = expanded ? lines.length : 6;
-	const displayLines = lines.slice(0, maxLines).map(line => truncate(line.trim(), 110, theme.format.ellipsis));
+	const displayLines = lines.slice(0, maxLines).map(line => truncateToWidth(line.trim(), 110));
 	const remaining = lines.length - displayLines.length;
 
 	const headerIcon = formatStatusIcon("warning", theme);
@@ -54,7 +54,7 @@ function renderFallbackText(contentText: string, expanded: boolean, theme: Theme
 	}
 
 	if (!expanded && remaining > 0) {
-		text += `\n ${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, "line", theme))}`;
+		text += `\n ${theme.fg("dim", theme.tree.last)} ${theme.fg("muted", formatMoreItems(remaining, "line"))}`;
 	}
 
 	return new Text(text, 0, 0);
@@ -104,9 +104,7 @@ export function renderWebSearchResult(
 	const contentText = answerText || rawText;
 	const totalAnswerLines = contentText ? contentText.split("\n").filter(l => l.trim()).length : 0;
 	const answerLimit = expanded ? MAX_EXPANDED_ANSWER_LINES : MAX_COLLAPSED_ANSWER_LINES;
-	const answerPreview = contentText
-		? getPreviewLines(contentText, answerLimit, MAX_ANSWER_LINE_LEN, theme.format.ellipsis)
-		: [];
+	const answerPreview = contentText ? getPreviewLines(contentText, answerLimit, MAX_ANSWER_LINE_LEN) : [];
 
 	const providerLabel =
 		provider === "anthropic"
@@ -117,9 +115,9 @@ export function renderWebSearchResult(
 					? "Exa"
 					: "Unknown";
 	const queryPreview = args?.query
-		? truncate(args.query, 80, theme.format.ellipsis)
+		? truncateToWidth(args.query, 80)
 		: searchQueries[0]
-			? truncate(searchQueries[0], 80, theme.format.ellipsis)
+			? truncateToWidth(searchQueries[0], 80)
 			: undefined;
 	const header = renderStatusLine(
 		{
@@ -144,7 +142,7 @@ export function renderWebSearchResult(
 		theme,
 	);
 	if (remainingAnswer > 0) {
-		answerTree.push(theme.fg("muted", formatMoreItems(remainingAnswer, "line", theme)));
+		answerTree.push(theme.fg("muted", formatMoreItems(remainingAnswer, "line")));
 	}
 
 	const sourceTree = renderTreeList(
@@ -160,7 +158,7 @@ export function renderWebSearchResult(
 						: typeof src.url === "string" && src.url.trim()
 							? src.url
 							: "Untitled";
-				const title = truncate(titleText, 70, theme.format.ellipsis);
+				const title = truncateToWidth(titleText, 70);
 				const url = typeof src.url === "string" ? src.url : "";
 				const domain = url ? getDomain(url) : "";
 				const age = formatAge(src.ageSeconds) || (typeof src.publishedDate === "string" ? src.publishedDate : "");
@@ -173,12 +171,7 @@ export function renderWebSearchResult(
 				const lines: string[] = [`${theme.fg("accent", title)}${metaSuffix}`];
 				const snippetText = typeof src.snippet === "string" ? src.snippet : "";
 				if (snippetText.trim()) {
-					const snippetLines = getPreviewLines(
-						snippetText,
-						MAX_SNIPPET_LINES,
-						MAX_SNIPPET_LINE_LEN,
-						theme.format.ellipsis,
-					);
+					const snippetLines = getPreviewLines(snippetText, MAX_SNIPPET_LINES, MAX_SNIPPET_LINE_LEN);
 					for (const snippetLine of snippetLines) {
 						lines.push(theme.fg("muted", `${theme.format.dash} ${snippetLine}`));
 					}
@@ -202,7 +195,7 @@ export function renderWebSearchResult(
 		theme,
 	);
 	if (!expanded && relatedCount > MAX_COLLAPSED_ITEMS) {
-		relatedTree.push(theme.fg("muted", formatMoreItems(relatedCount - MAX_COLLAPSED_ITEMS, "question", theme)));
+		relatedTree.push(theme.fg("muted", formatMoreItems(relatedCount - MAX_COLLAPSED_ITEMS, "question")));
 	}
 
 	const metaLines: string[] = [];
@@ -223,16 +216,13 @@ export function renderWebSearchResult(
 	}
 	if (response.requestId) {
 		metaLines.push(
-			`${theme.fg("muted", "Request:")} ${theme.fg(
-				"text",
-				truncate(response.requestId, MAX_REQUEST_ID_LEN, theme.format.ellipsis),
-			)}`,
+			`${theme.fg("muted", "Request:")} ${theme.fg("text", truncateToWidth(response.requestId, MAX_REQUEST_ID_LEN))}`,
 		);
 	}
 	if (searchQueries.length > 0) {
 		const queriesPreview = searchQueries.slice(0, MAX_QUERY_PREVIEW);
-		const queryList = queriesPreview.map(q => truncate(q, MAX_QUERY_LEN, theme.format.ellipsis));
-		const suffix = searchQueries.length > queriesPreview.length ? theme.format.ellipsis : "";
+		const queryList = queriesPreview.map(q => truncateToWidth(q, MAX_QUERY_LEN));
+		const suffix = searchQueries.length > queriesPreview.length ? "…" : "";
 		metaLines.push(`${theme.fg("muted", "Queries:")} ${theme.fg("text", queryList.join("; "))}${suffix}`);
 	}
 
@@ -274,7 +264,7 @@ export function renderWebSearchCall(
 	theme: Theme,
 ): Component {
 	const provider = args.provider ?? "auto";
-	const query = truncate(args.query, 80, theme.format.ellipsis);
+	const query = truncateToWidth(args.query, 80);
 	const text = renderStatusLine({ icon: "pending", title: "Web Search", description: query, meta: [provider] }, theme);
 	return new Text(text, 0, 0);
 }