@oh-my-pi/pi-coding-agent 9.2.2 → 9.2.3

package/CHANGELOG.md

@@ -2,6 +2,33 @@
 
 ## [Unreleased]
 
+## [9.2.3] - 2026-01-31
+### Added
+
+- Persistent shell session support for bash tool with environment variable preservation across commands
+- New `shellForceBasic` setting to force bash/sh even if user's default shell is different (default: true)
+- New `OMP_SHELL_PERSIST` environment variable to control persistent shell behavior (set to 0 to disable)
+
+### Changed
+
+- Bash tool now reuses a persistent shell session by default on Unix systems for improved performance and state preservation
+- Replaced Bun file APIs with Node.js `fs` module for better cross-runtime compatibility
+- LSP configuration loading is now synchronous instead of async
+- Shell snapshot generation now sanitizes `BASH_ENV` and `ENV` variables to prevent shell exit issues
+- Shell snapshot caching now per-shell-binary instead of global to avoid cross-shell contamination
+- System prompt restructured with coordinator-specific guidance for parallel task delegation
+- Bash tool now reuses a persistent shell session by default on Unix. Set `OMP_SHELL_PERSIST=0` to disable or fall back to per-command execution on Windows/unsupported shells.
+- Added a shellForceBasic setting to force bash/sh and keep environment changes across bash commands (default: true).
+
+### Fixed
+
+- Shell snapshots now filter unsafe bash options (onecmd, monitor, restricted) to prevent session exits
+- Git branch detection in status line now works synchronously without race conditions
+- Shell session initialization properly restores trap handlers and shell functions after command execution
+- Sanitized `BASH_ENV`/`ENV` during persistent shell startup and snapshot creation to prevent basic shells from exiting immediately.
+- Cached shell snapshots per shell binary to avoid sourcing zsh snapshots in bash sessions.
+- Filtered unsafe bash options (onecmd/monitor/restricted) out of shell snapshots to prevent session exits.
+
 ## [9.2.2] - 2026-01-31
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "9.2.2",
+	"version": "9.2.3",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"type": "module",
 	"ompConfig": {
@@ -79,12 +79,12 @@
 		"test": "bun test"
 	},
 	"dependencies": {
-		"@oh-my-pi/omp-stats": "9.2.2",
-		"@oh-my-pi/pi-agent-core": "9.2.2",
-		"@oh-my-pi/pi-ai": "9.2.2",
-		"@oh-my-pi/pi-natives": "9.2.2",
-		"@oh-my-pi/pi-tui": "9.2.2",
-		"@oh-my-pi/pi-utils": "9.2.2",
+		"@oh-my-pi/omp-stats": "9.2.3",
+		"@oh-my-pi/pi-agent-core": "9.2.3",
+		"@oh-my-pi/pi-ai": "9.2.3",
+		"@oh-my-pi/pi-natives": "9.2.3",
+		"@oh-my-pi/pi-tui": "9.2.3",
+		"@oh-my-pi/pi-utils": "9.2.3",
 		"@openai/agents": "^0.4.4",
 		"@sinclair/typebox": "^0.34.48",
 		"ajv": "^8.17.1",

package/src/cli/update-cli.ts

@@ -195,15 +195,10 @@ async function updateViaBinary(release: ReleaseInfo): Promise<void> {
 		console.log(chalk.green(`\n${theme.status.success} Updated to ${release.version}`));
 		console.log(chalk.dim(`Restart ${APP_NAME} to use the new version`));
 	} catch (err) {
-		const [backupExists, execExists, tempExists] = await Promise.all([
-			Bun.file(backupPath).exists(),
-			Bun.file(execPath).exists(),
-			Bun.file(tempPath).exists(),
-		]);
-		if (backupExists && !execExists) {
+		if (fs.existsSync(backupPath) && !fs.existsSync(execPath)) {
 			await fs.promises.rename(backupPath, execPath);
 		}
-		if (tempExists) {
+		if (fs.existsSync(tempPath)) {
 			await fs.promises.unlink(tempPath);
 		}
 		throw err;

package/src/commit/changelog/detect.ts

@@ -1,3 +1,4 @@
+import * as fs from "node:fs";
 import * as path from "node:path";
 import type { ChangelogBoundary } from "../../commit/types";
 
@@ -25,7 +26,7 @@ async function findNearestChangelog(cwd: string, filePath: string): Promise<stri
 	const root = path.resolve(cwd);
 	while (true) {
 		const candidate = path.resolve(current, CHANGELOG_NAME);
-		if (await Bun.file(candidate).exists()) {
+		if (fs.existsSync(candidate)) {
 			return candidate;
 		}
 		if (current === root) return null;

package/src/commit/changelog/index.ts

@@ -1,3 +1,4 @@
+import * as fs from "node:fs";
 import * as path from "node:path";
 import type { Api, Model } from "@oh-my-pi/pi-ai";
 import { logger } from "@oh-my-pi/pi-utils";
@@ -108,7 +109,7 @@ export async function applyChangelogProposals({
 		)
 			continue;
 		onProgress?.(`Applying entries for ${proposal.path}...`);
-		const exists = await Bun.file(proposal.path).exists();
+		const exists = fs.existsSync(proposal.path);
 		if (!exists) {
 			logger.warn("commit changelog path missing", { path: proposal.path });
 			continue;

package/src/config/prompt-templates.ts

@@ -1,3 +1,4 @@
+import * as fs from "node:fs";
 import * as path from "node:path";
 import { logger } from "@oh-my-pi/pi-utils";
 import Handlebars from "handlebars";
@@ -435,7 +436,7 @@ async function loadTemplatesFromDir(
 			}
 		}
 	} catch (error) {
-		if (!(await Bun.file(dir).exists())) {
+		if (!fs.existsSync(dir)) {
 			return [];
 		}
 		logger.warn("Failed to scan prompt templates directory", { dir, error: String(error) });

package/src/config/settings-manager.ts

@@ -1,4 +1,4 @@
-import * as fs from "node:fs/promises";
+import * as fs from "node:fs";
 import * as path from "node:path";
 import { isEnoent, logger, procmgr } from "@oh-my-pi/pi-utils";
 import { YAML } from "bun";
@@ -222,6 +222,7 @@ export interface Settings {
 	retry?: RetrySettings;
 	hideThinkingBlock?: boolean;
 	shellPath?: string; // Custom shell path (e.g., for Cygwin users on Windows)
+	shellForceBasic?: boolean; // Force bash/sh even if user's default shell is different
 	collapseChangelog?: boolean; // Show condensed changelog after update (use /changelog for full)
 	startup?: StartupSettings;
 	doubleEscapeAction?: "branch" | "tree"; // Action for double-escape with empty editor (default: "tree")
@@ -635,7 +636,7 @@ export class SettingsManager {
 				migrated = true;
 				// Backup settings.json
 				try {
-					await fs.rename(settingsJsonPath, `${settingsJsonPath}.bak`);
+					fs.renameSync(settingsJsonPath, `${settingsJsonPath}.bak`);
 				} catch (error) {
 					logger.warn("SettingsManager failed to backup settings.json", { error: String(error) });
 				}
@@ -1061,12 +1062,22 @@ export class SettingsManager {
 		return this.settings.shellPath;
 	}
 
+	getShellForceBasic(): boolean {
+		return this.settings.shellForceBasic ?? true;
+	}
+
 	async setShellPath(path: string | undefined): Promise<void> {
 		this.globalSettings.shellPath = path;
 		this.markModified("shellPath");
 		await this.save();
 	}
 
+	async setShellForceBasic(force: boolean): Promise<void> {
+		this.globalSettings.shellForceBasic = force;
+		this.markModified("shellForceBasic");
+		await this.save();
+	}
+
 	getCollapseChangelog(): boolean {
 		return this.settings.collapseChangelog ?? false;
 	}
@@ -1963,7 +1974,13 @@ export class SettingsManager {
 	 * Gets the shell configuration
 	 * @returns The shell configuration
 	 */
-	async getShellConfig() {
+	getShellConfig() {
+		if (this.getShellForceBasic()) {
+			const basicShell = resolveBasicShell();
+			if (basicShell) {
+				return procmgr.getShellConfig(basicShell);
+			}
+		}
 		const shell = this.getShellPath();
 		return procmgr.getShellConfig(shell);
 	}
@@ -1977,3 +1994,22 @@ export class SettingsManager {
 		return settings.getShellConfig();
 	}
 }
+
+function resolveBasicShell(): string | undefined {
+	const searchPaths = ["/bin", "/usr/bin", "/usr/local/bin", "/opt/homebrew/bin"];
+	const candidates = ["bash", "sh"];
+
+	for (const name of candidates) {
+		for (const dir of searchPaths) {
+			const fullPath = path.join(dir, name);
+			if (fs.existsSync(fullPath)) return fullPath;
+		}
+	}
+
+	for (const name of ["bash", "bash.exe", "sh", "sh.exe"]) {
+		const resolved = Bun.which(name);
+		if (resolved) return resolved;
+	}
+
+	return undefined;
+}

package/src/exec/bash-executor.ts

@@ -7,6 +7,7 @@ import { Exception, ptree } from "@oh-my-pi/pi-utils";
 import { SettingsManager } from "../config/settings-manager";
 import { OutputSink } from "../session/streaming-output";
 import { getOrCreateSnapshot, getSnapshotSourceCommand } from "../utils/shell-snapshot";
+import { executeShellCommand } from "./shell-session";
 
 export interface BashExecutorOptions {
 	cwd?: string;
@@ -34,13 +35,62 @@ export interface BashResult {
 
 export async function executeBash(command: string, options?: BashExecutorOptions): Promise<BashResult> {
 	const { shell, args, env, prefix } = await SettingsManager.getGlobalShellConfig();
+	const snapshotPath = await getOrCreateSnapshot(shell, env);
+
+	if (shouldUsePersistentShell(shell)) {
+		return await executeShellCommand({ shell, env, prefix, snapshotPath }, command, {
+			cwd: options?.cwd,
+			timeout: options?.timeout,
+			signal: options?.signal,
+			onChunk: options?.onChunk,
+			env: options?.env,
+			artifactPath: options?.artifactPath,
+			artifactId: options?.artifactId,
+		});
+	}
+
+	return await executeBashOnce(command, options, { shell, args, env, prefix, snapshotPath });
+}
+
+function shouldUsePersistentShell(shell: string): boolean {
+	const flag = parseEnvFlag(process.env.OMP_SHELL_PERSIST);
+	if (flag !== undefined) return flag;
+	if (process.platform === "win32") return false;
+	const normalized = shell.toLowerCase();
+	return (
+		normalized.includes("bash") ||
+		normalized.includes("zsh") ||
+		normalized.includes("fish") ||
+		normalized.endsWith("/sh") ||
+		normalized.endsWith("\\\\sh") ||
+		normalized.endsWith("sh")
+	);
+}
+
+function parseEnvFlag(value: string | undefined): boolean | undefined {
+	if (!value) return undefined;
+	const normalized = value.toLowerCase();
+	if (["1", "true", "yes", "on"].includes(normalized)) return true;
+	if (["0", "false", "no", "off"].includes(normalized)) return false;
+	return undefined;
+}
+
+async function executeBashOnce(
+	command: string,
+	options: BashExecutorOptions | undefined,
+	config: {
+		shell: string;
+		args: string[];
+		env: Record<string, string | undefined>;
+		prefix?: string;
+		snapshotPath: string | null;
+	},
+): Promise<BashResult> {
+	const { shell, args, env, prefix, snapshotPath } = config;
 
 	// Merge additional env vars if provided
 	const finalEnv = options?.env ? { ...env, ...options.env } : env;
-
-	const snapshotPath = await getOrCreateSnapshot(shell, env);
 	const snapshotPrefix = getSnapshotSourceCommand(snapshotPath);
-
 	const prefixedCommand = prefix ? `${prefix} ${command}` : command;
 	const finalCommand = `${snapshotPrefix}${prefixedCommand}`;