@oh-my-pi/pi-coding-agent 8.0.16 → 8.1.0

package/src/commit/prompts/changelog-system.md

@@ -0,0 +1,56 @@
+You are an expert changelog writer who analyzes git diffs and produces Keep a Changelog entries. Get this right—changelogs are how users understand what changed.
+
+<instructions>
+Analyze the diff and return JSON changelog entries.
+
+1. Identify user-visible changes only
+2. Categorize each change (Added, Changed, Deprecated, Removed, Fixed, Security, Breaking Changes)
+3. Write entries starting with past-tense verb describing user impact
+4. Omit categories with no entries
+5. Return empty entries object for internal-only changes
+
+This matters. Be thorough but precise.
+</instructions>
+
+<categories>
+- Added: New features, public APIs, user-facing capabilities
+- Changed: Modified existing behavior
+- Deprecated: Features scheduled for removal
+- Removed: Deleted features or APIs
+- Fixed: Bug corrections with observable impact
+- Security: Vulnerability fixes
+- Breaking Changes: API-incompatible modifications (use sparingly)
+</categories>
+
+<entry_format>
+- Start with past-tense verb (Added, Fixed, Implemented, Updated)
+- Describe user-visible impact, not implementation
+- Name the specific feature, option, or behavior
+- Keep to 1-2 lines, no trailing periods
+</entry_format>
+
+<examples>
+Good:
+- Added --dry-run flag to preview changes without applying them
+- Fixed memory leak when processing large files
+- Changed default timeout from 30s to 60s for slow connections
+
+Bad:
+- **cli**: Added dry-run flag -> scope prefix redundant
+- Added new feature. -> vague, has trailing period
+- Refactored parser internals -> not user-visible
+
+Breaking Changes example:
+- Removed legacy auth flow; users must re-authenticate with OAuth tokens
+</examples>
+
+<exclude>
+Internal refactoring, code style changes, test-only modifications, minor doc updates, anything invisible to users.
+</exclude>
+
+<output_format>
+Return ONLY valid JSON. No markdown fences, no explanation.
+
+With entries: {"entries": {"Added": ["entry 1"], "Fixed": ["entry 2"]}}
+No changelog-worthy changes: {"entries": {}}
+</output_format>

package/src/commit/prompts/changelog-user.md

@@ -0,0 +1,19 @@
+<context>
+Changelog: {{ changelog_path }}
+{{#if is_package_changelog}}Scope: Package-level changelog. Omit package name prefix from entries.{{/if}}
+</context>
+{{#if existing_entries}}
+
+<existing_entries>
+Already documented—skip these:
+{{ existing_entries }}
+</existing_entries>
+{{/if}}
+
+<diff_summary>
+{{ stat }}
+</diff_summary>
+
+<diff>
+{{ diff }}
+</diff>

package/src/commit/prompts/file-observer-system.md

@@ -0,0 +1,26 @@
+<role>Expert code analyst extracting structured observations from diffs.</role>
+
+<instructions>
+Extract factual observations from the diff. This matters—be precise.
+
+1. Use past-tense verb + specific target + optional purpose
+2. Max 100 characters per observation
+3. Consolidate related changes (e.g., "renamed 5 helper functions")
+4. Return 1-5 observations only
+</instructions>
+
+<scope>
+Include: functions, methods, types, API changes, behavior/logic changes, error handling, performance, security.
+
+Exclude: import reordering, whitespace/formatting, comment-only changes, debug statements.
+</scope>
+
+<output_format>
+Plain list, no preamble, no summary, no markdown formatting.
+
+- added 'parse_config()' function for TOML configuration loading
+- removed deprecated 'legacy_init()' and all callers
+- changed 'Connection::new()' to accept '&Config' instead of individual params
+</output_format>
+
+Observations only. Classification happens in reduce phase.

package/src/commit/prompts/file-observer-user.md

@@ -0,0 +1,9 @@
+<file path="{{ filename }}">
+{{ diff }}
+</file>
+{{#if context_header}}
+
+<related_files>
+{{ context_header }}
+</related_files>
+{{/if}}

package/src/commit/prompts/reduce-system.md

@@ -0,0 +1,60 @@
+You are a senior engineer synthesizing file-level observations into a conventional commit analysis.
+
+<context>
+Given map-phase observations from analyzed files, produce a unified commit classification with changelog metadata.
+</context>
+
+<instructions>
+Determine:
+1. TYPE: Single classification for entire commit
+2. SCOPE: Primary component (null if multi-component)
+3. DETAILS: 3-4 summary points (max 6)
+4. CHANGELOG: Metadata for user-visible changes
+
+Get this right. Accuracy matters.
+</instructions>
+
+<scope_rules>
+- Use component name if >=60% of changes target it
+- Use null if spread across multiple components
+- Use scope_candidates as primary source
+- Valid scopes only: specific component names (api, parser, config, etc.)
+</scope_rules>
+
+<output_format>
+Each detail point:
+- Past-tense verb start (added, fixed, moved, extracted)
+- Under 120 characters, ends with period
+- Group related cross-file changes
+
+Priority: user-visible behavior > performance/security > architecture > internal implementation
+
+changelog_category: Added | Changed | Fixed | Deprecated | Removed | Security
+user_visible: true for features, user-facing bugs, breaking changes, security fixes
+</output_format>
+
+<example>
+Input observations:
+- api/client.ts: added token refresh guard to prevent duplicate refreshes
+- api/http.ts: introduced retry wrapper for 429 responses
+- api/index.ts: updated exports for retry helper
+
+Output:
+{
+  "type": "fix",
+  "scope": "api",
+  "details": [
+    {
+      "text": "Added token refresh guard to prevent duplicate refreshes.",
+      "changelog_category": "Fixed",
+      "user_visible": true
+    },
+    {
+      "text": "Introduced retry wrapper for 429 responses.",
+      "changelog_category": "Fixed",
+      "user_visible": true
+    }
+  ],
+  "issue_refs": []
+}
+</example>

package/src/commit/prompts/reduce-user.md

@@ -0,0 +1,17 @@
+{{#if types_description}}
+<type_definitions>
+{{ types_description }}
+</type_definitions>
+{{/if}}
+
+<observations>
+{{ observations }}
+</observations>
+
+<diff_statistics>
+{{ stat }}
+</diff_statistics>
+
+<scope_candidates>
+{{ scope_candidates }}
+</scope_candidates>

package/src/commit/prompts/summary-retry.md

@@ -0,0 +1,4 @@
+{{#if base_context}}
+{{ base_context }}
+
+{{/if}}Previous summary failed validation: {{ errors }}

package/src/commit/prompts/summary-system.md

@@ -0,0 +1,52 @@
+You are a commit message specialist generating precise, informative descriptions.
+
+<context>
+Output: ONLY the description after "{{ commit_type }}{{ scope_prefix }}:".
+Constraint: {{ chars }} characters max, no trailing period, no type prefix in output.
+</context>
+
+<instructions>
+1. Start with lowercase past-tense verb (must differ from "{{ commit_type }}")
+2. Name the specific subsystem/component affected
+3. Include WHY when it clarifies intent
+4. One focused concept per message
+
+Get this right.
+</instructions>
+
+<verb_reference>
+| Type     | Use instead                                     |
+|----------|-------------------------------------------------|
+| feat     | added, introduced, implemented, enabled         |
+| fix      | corrected, resolved, patched, addressed         |
+| refactor | restructured, reorganized, migrated, simplified |
+| perf     | optimized, reduced, eliminated, accelerated     |
+| docs     | documented, clarified, expanded                 |
+| build    | upgraded, pinned, configured                    |
+| chore    | cleaned, removed, renamed, organized            |
+</verb_reference>
+
+<examples>
+feat | TLS encryption added to HTTP client for MITM prevention
+-> added TLS support to prevent man-in-the-middle attacks
+
+refactor | Consolidated HTTP transport into unified builder pattern
+-> migrated HTTP transport to unified builder API
+
+fix | Race condition in connection pool causing exhaustion under load
+-> corrected race condition causing connection pool exhaustion
+
+perf | Batch processing optimized to reduce memory allocations
+-> eliminated allocation overhead in batch processing
+
+build | Updated serde to fix CVE-2024-1234
+-> upgraded serde to 1.0.200 for CVE-2024-1234
+</examples>
+
+<banned_words>
+comprehensive, various, several, improved, enhanced, quickly, simply, basically, this change, this commit, now
+</banned_words>
+
+<output_format>
+Output the description text only. Include motivation, name specifics, stay focused.
+</output_format>

package/src/commit/prompts/summary-user.md

@@ -0,0 +1,13 @@
+{{#if user_context}}
+<user_context>
+{{ user_context }}
+</user_context>
+{{/if}}
+
+<detail_points>
+{{ details }}
+</detail_points>
+
+<diff_stat>
+{{ stat }}
+</diff_stat>

package/src/commit/prompts/types-description.md

@@ -0,0 +1,2 @@
+Types: feat, fix, refactor, perf, docs, test, build, ci, chore, style, revert.
+Format: <type>(<scope>): <summary> with past-tense summary.

package/src/commit/types.ts

@@ -0,0 +1,109 @@
+/**
+ * Types for the omp commit pipeline.
+ */
+
+export type CommitType =
+	| "feat"
+	| "fix"
+	| "refactor"
+	| "perf"
+	| "docs"
+	| "test"
+	| "build"
+	| "ci"
+	| "chore"
+	| "style"
+	| "revert";
+
+export type ChangelogCategory =
+	| "Breaking Changes"
+	| "Added"
+	| "Changed"
+	| "Deprecated"
+	| "Removed"
+	| "Fixed"
+	| "Security";
+
+export interface CommitCommandArgs {
+	/** Push after commit */
+	push: boolean;
+	/** Preview without committing */
+	dryRun: boolean;
+	/** Skip changelog updates */
+	noChangelog: boolean;
+	/** Use legacy deterministic pipeline */
+	legacy?: boolean;
+	/** Additional user context for the model */
+	context?: string;
+	/** Override the model selection */
+	model?: string;
+}
+
+export interface NumstatEntry {
+	path: string;
+	additions: number;
+	deletions: number;
+}
+
+export interface ConventionalDetail {
+	text: string;
+	changelogCategory?: ChangelogCategory;
+	userVisible: boolean;
+}
+
+export interface ConventionalAnalysis {
+	type: CommitType;
+	scope: string | null;
+	details: ConventionalDetail[];
+	issueRefs: string[];
+}
+
+export interface CommitSummary {
+	summary: string;
+}
+
+export interface FileObservation {
+	file: string;
+	observations: string[];
+	additions: number;
+	deletions: number;
+}
+
+export interface FileDiff {
+	filename: string;
+	content: string;
+	additions: number;
+	deletions: number;
+	isBinary: boolean;
+}
+
+export interface DiffHunk {
+	index: number;
+	header: string;
+	oldStart: number;
+	oldLines: number;
+	newStart: number;
+	newLines: number;
+	content: string;
+}
+
+export interface FileHunks {
+	filename: string;
+	isBinary: boolean;
+	hunks: DiffHunk[];
+}
+
+export interface ChangelogBoundary {
+	changelogPath: string;
+	files: string[];
+}
+
+export interface UnreleasedSection {
+	startLine: number;
+	endLine: number;
+	entries: Record<string, string[]>;
+}
+
+export interface ChangelogGenerationResult {
+	entries: Record<string, string[]>;
+}

package/src/commit/utils/exclusions.ts

@@ -0,0 +1,42 @@
+const EXCLUDED_FILES = [
+	"Cargo.lock",
+	"package-lock.json",
+	"npm-shrinkwrap.json",
+	"yarn.lock",
+	"pnpm-lock.yaml",
+	"shrinkwrap.yaml",
+	"bun.lock",
+	"bun.lockb",
+	"deno.lock",
+	"composer.lock",
+	"Gemfile.lock",
+	"poetry.lock",
+	"Pipfile.lock",
+	"pdm.lock",
+	"uv.lock",
+	"go.sum",
+	"flake.lock",
+	"pubspec.lock",
+	"Podfile.lock",
+	"Packages.resolved",
+	"mix.lock",
+	"packages.lock.json",
+	"config.yml.lock",
+	"config.yaml.lock",
+	"settings.yml.lock",
+	"settings.yaml.lock",
+];
+
+const EXCLUDED_SUFFIXES = [".lock.yml", ".lock.yaml", "-lock.yml", "-lock.yaml"];
+
+export function isExcludedFile(path: string): boolean {
+	const lower = path.toLowerCase();
+	if (EXCLUDED_FILES.some((name) => lower.endsWith(name.toLowerCase()))) {
+		return true;
+	}
+	return EXCLUDED_SUFFIXES.some((suffix) => lower.endsWith(suffix));
+}
+
+export function filterExcludedFiles<T extends { filename: string }>(files: T[]): T[] {
+	return files.filter((file) => !isExcludedFile(file.filename));
+}

package/src/config/file-lock.ts

@@ -0,0 +1,111 @@
+import { existsSync } from "node:fs";
+import { mkdir, readFile, rm } from "node:fs/promises";
+
+export interface FileLockOptions {
+	staleMs?: number;
+	retries?: number;
+	retryDelayMs?: number;
+}
+
+const DEFAULT_OPTIONS: Required<FileLockOptions> = {
+	staleMs: 10_000,
+	retries: 50,
+	retryDelayMs: 100,
+};
+
+interface LockInfo {
+	pid: number;
+	timestamp: number;
+}
+
+function getLockPath(filePath: string): string {
+	return `${filePath}.lock`;
+}
+
+async function writeLockInfo(lockPath: string): Promise<void> {
+	const info: LockInfo = { pid: process.pid, timestamp: Date.now() };
+	await Bun.write(`${lockPath}/info`, JSON.stringify(info));
+}
+
+async function readLockInfo(lockPath: string): Promise<LockInfo | null> {
+	try {
+		const content = await readFile(`${lockPath}/info`, "utf-8");
+		return JSON.parse(content) as LockInfo;
+	} catch {
+		return null;
+	}
+}
+
+function isProcessAlive(pid: number): boolean {
+	try {
+		process.kill(pid, 0);
+		return true;
+	} catch {
+		return false;
+	}
+}
+
+async function isLockStale(lockPath: string, staleMs: number): Promise<boolean> {
+	const info = await readLockInfo(lockPath);
+	if (!info) return true;
+
+	if (!isProcessAlive(info.pid)) return true;
+
+	if (Date.now() - info.timestamp > staleMs) return true;
+
+	return false;
+}
+
+async function tryAcquireLock(lockPath: string): Promise<boolean> {
+	try {
+		await mkdir(lockPath);
+		await writeLockInfo(lockPath);
+		return true;
+	} catch (error) {
+		if ((error as NodeJS.ErrnoException).code === "EEXIST") {
+			return false;
+		}
+		throw error;
+	}
+}
+
+async function releaseLock(lockPath: string): Promise<void> {
+	try {
+		await rm(lockPath, { recursive: true });
+	} catch {
+		// Ignore errors on release
+	}
+}
+
+async function acquireLock(filePath: string, options: FileLockOptions = {}): Promise<() => Promise<void>> {
+	const opts = { ...DEFAULT_OPTIONS, ...options };
+	const lockPath = getLockPath(filePath);
+
+	for (let attempt = 0; attempt < opts.retries; attempt++) {
+		if (await tryAcquireLock(lockPath)) {
+			return () => releaseLock(lockPath);
+		}
+
+		if (existsSync(lockPath) && (await isLockStale(lockPath, opts.staleMs))) {
+			await releaseLock(lockPath);
+			continue;
+		}
+
+		await new Promise((resolve) => setTimeout(resolve, opts.retryDelayMs));
+	}
+
+	throw new Error(`Failed to acquire lock for ${filePath} after ${opts.retries} attempts`);
+}
+
+export async function withFileLock<T>(
+	filePath: string,
+	fn: () => Promise<T>,
+	options: FileLockOptions = {},
+): Promise<T> {
+	const release = await acquireLock(filePath, options);
+	try {
+		return await fn();
+	} finally {
+		await release();
+	}
+}

package/src/config/model-registry.ts

@@ -3,6 +3,7 @@
  */
 
 import { existsSync, readFileSync } from "node:fs";
+import { extname } from "node:path";
 import {
 	type Api,
 	getGitHubCopilotBaseUrl,
@@ -15,6 +16,7 @@ import type { AuthStorage } from "@oh-my-pi/pi-coding-agent/session/auth-storage
 import { logger } from "@oh-my-pi/pi-utils";
 import { type Static, Type } from "@sinclair/typebox";
 import AjvModule from "ajv";
+import { YAML } from "bun";
 
 const Ajv = (AjvModule as any).default || AjvModule;
 
@@ -262,14 +264,21 @@ export class ModelRegistry {
 			});
 	}
 
-	private loadCustomModels(modelsJsonPath: string): CustomModelsResult {
-		if (!existsSync(modelsJsonPath)) {
+	private loadCustomModels(modelsPath: string): CustomModelsResult {
+		if (!existsSync(modelsPath)) {
 			return emptyCustomModelsResult();
 		}
 
 		try {
-			const content = readFileSync(modelsJsonPath, "utf-8");
-			const config: ModelsConfig = JSON.parse(content);
+			const content = readFileSync(modelsPath, "utf-8");
+			const ext = extname(modelsPath).toLowerCase();
+			let config: ModelsConfig;
+
+			if (ext === ".yaml" || ext === ".yml") {
+				config = YAML.parse(content) as ModelsConfig;
+			} else {
+				config = JSON.parse(content) as ModelsConfig;
+			}
 
 			// Validate schema
 			const ajv = new Ajv();
@@ -278,7 +287,7 @@ export class ModelRegistry {
 				const errors =
 					validate.errors?.map((e: any) => `  - ${e.instancePath || "root"}: ${e.message}`).join("\n") ||
 					"Unknown schema error";
-				return emptyCustomModelsResult(`Invalid models.json schema:\n${errors}\n\nFile: ${modelsJsonPath}`);
+				return emptyCustomModelsResult(`Invalid models config schema:\n${errors}\n\nFile: ${modelsPath}`);
 			}
 
 			// Additional validation
@@ -309,10 +318,10 @@ export class ModelRegistry {
 			return { models: this.parseModels(config), replacedProviders, overrides, error: undefined };
 		} catch (error) {
 			if (error instanceof SyntaxError) {
-				return emptyCustomModelsResult(`Failed to parse models.json: ${error.message}\n\nFile: ${modelsJsonPath}`);
+				return emptyCustomModelsResult(`Failed to parse models config: ${error.message}\n\nFile: ${modelsPath}`);
 			}
 			return emptyCustomModelsResult(
-				`Failed to load models.json: ${error instanceof Error ? error.message : error}\n\nFile: ${modelsJsonPath}`,
+				`Failed to load models config: ${error instanceof Error ? error.message : error}\n\nFile: ${modelsPath}`,
 			);
 		}
 	}