@oh-my-pi/pi-coding-agent 6.2.0 → 6.7.0

package/src/modes/interactive/controllers/event-controller.ts

@@ -134,6 +134,8 @@ export class EventController {
 								content.arguments,
 								{
 									showImages: this.ctx.settingsManager.getShowImages(),
+									editFuzzyThreshold: this.ctx.settingsManager.getEditFuzzyThreshold(),
+									editAllowFuzzy: this.ctx.settingsManager.getEditFuzzyMatch(),
 								},
 								tool,
 								this.ctx.ui,
@@ -174,26 +176,9 @@ export class EventController {
 					}
 
 					if (
-						this.ctx.streamingMessage.stopReason === "aborted" ||
-						this.ctx.streamingMessage.stopReason === "error"
+						this.ctx.streamingMessage.stopReason !== "aborted" &&
+						this.ctx.streamingMessage.stopReason !== "error"
 					) {
-						if (!this.ctx.session.isTtsrAbortPending) {
-							if (!errorMessage) {
-								errorMessage = this.ctx.streamingMessage.errorMessage || "Error";
-							}
-							for (const [toolCallId, component] of this.ctx.pendingTools.entries()) {
-								component.updateResult(
-									{
-										content: [{ type: "text", text: errorMessage }],
-										isError: true,
-									},
-									false,
-									toolCallId,
-								);
-							}
-						}
-						this.ctx.pendingTools.clear();
-					} else {
 						for (const [toolCallId, component] of this.ctx.pendingTools.entries()) {
 							component.setArgsComplete(toolCallId);
 						}
@@ -223,6 +208,8 @@ export class EventController {
 						event.args,
 						{
 							showImages: this.ctx.settingsManager.getShowImages(),
+							editFuzzyThreshold: this.ctx.settingsManager.getEditFuzzyThreshold(),
+							editAllowFuzzy: this.ctx.settingsManager.getEditFuzzyMatch(),
 						},
 						tool,
 						this.ctx.ui,

package/src/modes/interactive/controllers/input-controller.ts

@@ -338,7 +338,7 @@ export class InputController {
 
 			// Generate session title on first message
 			const hasUserMessages = this.ctx.agent.state.messages.some((m: AgentMessage) => m.role === "user");
-			if (!hasUserMessages && !this.ctx.sessionManager.getSessionTitle()) {
+			if (!hasUserMessages && !this.ctx.sessionManager.getSessionTitle() && !process.env.OMP_NO_TITLE) {
 				const registry = this.ctx.session.modelRegistry;
 				const smolModel = this.ctx.settingsManager.getModelRole("smol");
 				generateSessionTitle(text, registry, smolModel, this.ctx.session.sessionId)

package/src/modes/interactive/utils/ui-helpers.ts

@@ -206,7 +206,11 @@ export class UiHelpers {
 					const component = new ToolExecutionComponent(
 						content.name,
 						content.arguments,
-						{ showImages: this.ctx.settingsManager.getShowImages() },
+						{
+							showImages: this.ctx.settingsManager.getShowImages(),
+							editFuzzyThreshold: this.ctx.settingsManager.getEditFuzzyThreshold(),
+							editAllowFuzzy: this.ctx.settingsManager.getEditFuzzyMatch(),
+						},
 						tool,
 						this.ctx.ui,
 						this.ctx.sessionManager.getCwd(),

package/src/modes/rpc/rpc-mode.ts

@@ -67,55 +67,60 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 	// Shutdown request flag (wrapped in object to allow mutation with const)
 	const shutdownState = { requested: false };
 
-	/** Helper for dialog methods with signal/timeout support */
-	function createDialogPromise<T>(
-		opts: ExtensionUIDialogOptions | undefined,
-		defaultValue: T,
-		request: Record<string, unknown>,
-		parseResponse: (response: RpcExtensionUIResponse) => T,
-	): Promise<T> {
-		if (opts?.signal?.aborted) return Promise.resolve(defaultValue);
-
-		const id = nanoid();
-		return new Promise((resolve, reject) => {
-			let timeoutId: ReturnType<typeof setTimeout> | undefined;
-
-			const cleanup = () => {
-				if (timeoutId) clearTimeout(timeoutId);
-				opts?.signal?.removeEventListener("abort", onAbort);
-				pendingExtensionRequests.delete(id);
-			};
-
-			const onAbort = () => {
-				cleanup();
-				resolve(defaultValue);
-			};
-			opts?.signal?.addEventListener("abort", onAbort, { once: true });
-
-			if (opts?.timeout !== undefined) {
-				timeoutId = setTimeout(() => {
+	/**
+	 * Extension UI context that uses the RPC protocol.
+	 */
+	class RpcExtensionUIContext implements ExtensionUIContext {
+		constructor(
+			private pendingRequests: Map<string, PendingExtensionRequest>,
+			private output: (obj: RpcResponse | RpcExtensionUIRequest | object) => void,
+		) {}
+
+		/** Helper for dialog methods with signal/timeout support */
+		private createDialogPromise<T>(
+			opts: ExtensionUIDialogOptions | undefined,
+			defaultValue: T,
+			request: Record<string, unknown>,
+			parseResponse: (response: RpcExtensionUIResponse) => T,
+		): Promise<T> {
+			if (opts?.signal?.aborted) return Promise.resolve(defaultValue);
+
+			const id = nanoid();
+			return new Promise((resolve, reject) => {
+				let timeoutId: ReturnType<typeof setTimeout> | undefined;
+
+				const cleanup = () => {
+					if (timeoutId) clearTimeout(timeoutId);
+					opts?.signal?.removeEventListener("abort", onAbort);
+					this.pendingRequests.delete(id);
+				};
+
+				const onAbort = () => {
 					cleanup();
 					resolve(defaultValue);
-				}, opts.timeout);
-			}
+				};
+				opts?.signal?.addEventListener("abort", onAbort, { once: true });
 
-			pendingExtensionRequests.set(id, {
-				resolve: (response: RpcExtensionUIResponse) => {
-					cleanup();
-					resolve(parseResponse(response));
-				},
-				reject,
+				if (opts?.timeout !== undefined) {
+					timeoutId = setTimeout(() => {
+						cleanup();
+						resolve(defaultValue);
+					}, opts.timeout);
+				}
+
+				this.pendingRequests.set(id, {
+					resolve: (response: RpcExtensionUIResponse) => {
+						cleanup();
+						resolve(parseResponse(response));
+					},
+					reject,
+				});
+				this.output({ type: "extension_ui_request", id, ...request } as RpcExtensionUIRequest);
 			});
-			output({ type: "extension_ui_request", id, ...request } as RpcExtensionUIRequest);
-		});
-	}
+		}
 
-	/**
-	 * Create an extension UI context that uses the RPC protocol.
-	 */
-	const createExtensionUIContext = (): ExtensionUIContext => ({
-		select: (title, options, dialogOptions) =>
-			createDialogPromise(
+		select(title: string, options: string[], dialogOptions?: ExtensionUIDialogOptions): Promise<string | undefined> {
+			return this.createDialogPromise(
 				dialogOptions,
 				undefined,
 				{ method: "select", title, options, timeout: dialogOptions?.timeout },
@@ -125,10 +130,11 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 						: "value" in response
 							? response.value
 							: undefined,
-			),
+			);
+		}
 
-		confirm: (title, message, dialogOptions) =>
-			createDialogPromise(
+		confirm(title: string, message: string, dialogOptions?: ExtensionUIDialogOptions): Promise<boolean> {
+			return this.createDialogPromise(
 				dialogOptions,
 				false,
 				{ method: "confirm", title, message, timeout: dialogOptions?.timeout },
@@ -138,10 +144,15 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 						: "confirmed" in response
 							? response.confirmed
 							: false,
-			),
+			);
+		}
 
-		input: (title, placeholder, dialogOptions) =>
-			createDialogPromise(
+		input(
+			title: string,
+			placeholder?: string,
+			dialogOptions?: ExtensionUIDialogOptions,
+		): Promise<string | undefined> {
+			return this.createDialogPromise(
 				dialogOptions,
 				undefined,
 				{ method: "input", title, placeholder, timeout: dialogOptions?.timeout },
@@ -151,34 +162,35 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 						: "value" in response
 							? response.value
 							: undefined,
-			),
+			);
+		}
 
 		notify(message: string, type?: "info" | "warning" | "error"): void {
 			// Fire and forget - no response needed
-			output({
+			this.output({
 				type: "extension_ui_request",
 				id: nanoid(),
 				method: "notify",
 				message,
 				notifyType: type,
 			} as RpcExtensionUIRequest);
-		},
+		}
 
 		setStatus(key: string, text: string | undefined): void {
 			// Fire and forget - no response needed
-			output({
+			this.output({
 				type: "extension_ui_request",
 				id: nanoid(),
 				method: "setStatus",
 				statusKey: key,
 				statusText: text,
 			} as RpcExtensionUIRequest);
-		},
+		}
 
 		setWidget(key: string, content: unknown): void {
 			// Only support string arrays in RPC mode - factory functions are ignored
 			if (content === undefined || Array.isArray(content)) {
-				output({
+				this.output({
 					type: "extension_ui_request",
 					id: nanoid(),
 					method: "setWidget",
@@ -187,53 +199,53 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 				} as RpcExtensionUIRequest);
 			}
 			// Component factories are not supported in RPC mode - would need TUI access
-		},
+		}
 
 		setFooter(_factory: unknown): void {
 			// Custom footer not supported in RPC mode - requires TUI access
-		},
+		}
 
 		setHeader(_factory: unknown): void {
 			// Custom header not supported in RPC mode - requires TUI access
-		},
+		}
 
 		setTitle(title: string): void {
 			// Fire and forget - host can implement terminal title control
-			output({
+			this.output({
 				type: "extension_ui_request",
 				id: nanoid(),
 				method: "setTitle",
 				title,
 			} as RpcExtensionUIRequest);
-		},
+		}
 
-		async custom() {
+		async custom(): Promise<never> {
 			// Custom UI not supported in RPC mode
 			return undefined as never;
-		},
+		}
 
 		setEditorText(text: string): void {
 			// Fire and forget - host can implement editor control
-			output({
+			this.output({
 				type: "extension_ui_request",
 				id: nanoid(),
 				method: "set_editor_text",
 				text,
 			} as RpcExtensionUIRequest);
-		},
+		}
 
 		getEditorText(): string {
 			// Synchronous method can't wait for RPC response
 			// Host should track editor state locally if needed
 			return "";
-		},
+		}
 
 		async editor(title: string, prefill?: string): Promise<string | undefined> {
 			const id = nanoid();
 			return new Promise((resolve, reject) => {
-				pendingExtensionRequests.set(id, {
+				this.pendingRequests.set(id, {
 					resolve: (response: RpcExtensionUIResponse) => {
-						pendingExtensionRequests.delete(id);
+						this.pendingRequests.delete(id);
 						if ("cancelled" in response && response.cancelled) {
 							resolve(undefined);
 						} else if ("value" in response) {
@@ -244,31 +256,37 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 					},
 					reject,
 				});
-				output({ type: "extension_ui_request", id, method: "editor", title, prefill } as RpcExtensionUIRequest);
+				this.output({
+					type: "extension_ui_request",
+					id,
+					method: "editor",
+					title,
+					prefill,
+				} as RpcExtensionUIRequest);
 			});
-		},
+		}
 
-		get theme() {
+		get theme(): Theme {
 			return theme;
-		},
+		}
 
-		getAllThemes() {
+		getAllThemes(): { name: string; path: string | undefined }[] {
 			return [];
-		},
+		}
 
-		getTheme(_name: string) {
+		getTheme(_name: string): Theme | undefined {
 			return undefined;
-		},
+		}
 
-		setTheme(_theme: string | Theme) {
+		setTheme(_theme: string | Theme): { success: boolean; error?: string } {
 			// Theme switching not supported in RPC mode
 			return { success: false, error: "Theme switching not supported in RPC mode" };
-		},
+		}
 
 		setEditorComponent(): void {
 			// Custom editor components not supported in RPC mode
-		},
-	});
+		}
+	}
 
 	// Set up extensions with RPC-based UI context
 	const extensionRunner = session.extensionRunner;
@@ -352,7 +370,7 @@ export async function runRpcMode(session: AgentSession): Promise<never> {
 					await session.compact(instructions, options);
 				},
 			},
-			createExtensionUIContext(),
+			new RpcExtensionUIContext(pendingExtensionRequests, output),
 		);
 		extensionRunner.onError((err) => {
 			output({ type: "extension_error", extensionPath: err.extensionPath, event: err.event, error: err.error });

package/src/prompts/tools/patch.md

@@ -0,0 +1,76 @@
+Performs patch operations on a file given a diff.
+This is your primary tool for making changes to existing files.
+
+<critical>
+- Always read the target file before editing.
+- Copy anchors + context lines verbatim (including whitespace).
+- Output the clean patch format below.
+</critical>
+
+<parameters>
+```ts
+type T = 
+   // Diff is one or more hunks, within the same file.
+   // - Each hunk begins with "@@" (optionally with an anchor).
+   // - Each hunk body contains only lines starting with: ' ' | '+' | '-'.
+   // - Each hunk must include at least one real change (+ or -). No no-op hunks.
+   | { path: string, op: "update", diff: string }
+   // Diff is the full file content, no prefixes.
+   | { path: string, op: "create", diff: string }
+   // Omit diff for delete operation.
+   | { path: string, op: "delete" }
+   // New path for update-and-move operation.
+   | { path: string, op: "update", rename: string, diff: string }
+```
+</parameters>
+
+<hunk_header>
+Allowed:
+- `@@`
+- `@@ $ANCHOR`
+
+ANCHOR RULES:
+- `$ANCHOR` MUST be copied verbatim from the file as either:
+  - a full existing line, OR
+  - a unique substring of a single existing line.
+- NEVER use it as a comment:
+  - line numbers / ranges: `line 207`, `lines 26-37`
+  - location labels: `top of file`, `start`, `near imports`
+  - placeholders: `@@ @@`, `...`
+</hunk_header>
+
+<anchor_selection>
+ANCHOR SELECTION ALGORITHM (use in this order):
+1) If the surrounding context lines are already unique in the file, use bare `@@`.
+2) Else choose an anchor that is highly specific and stable, copied from the file, e.g.:
+   - full function signature line
+   - class declaration line
+   - a unique string literal / error message
+   - a config key with uncommon name
+3) If you get "Found multiple matches", escalate by:
+   - adding more context lines, OR
+   - using multiple hunks with separate nearby anchors, OR
+   - using a more specific anchor substring (longer, includes identifiers).
+NEVER use generic anchors like `import`, `export`, `describe`, `function`, `const`.
+</anchor_selection>
+
+<context_rules>
+- Include enough context lines (' ' prefixed) to make the match unique (usually 2–8 total).
+- Context lines must exist in the file exactly as written; preserve indentation/trailing spaces.
+</context_rules>
+
+<example name="create">
+edit {"path":"hello.txt","op":"create","diff":"Hello\n"}
+</example>
+
+<example name="update">
+edit {"path":"src/app.py","op":"update","diff":"@@ def greet():\n def greet():\n-print('Hi')\n+print('Hello')\n"}
+</example>
+
+<example name="rename">
+edit {"path":"src/app.py","op":"update","rename":"src/main.py","diff":"@@\n ...\n"}
+</example>
+
+<example name="delete">
+edit {"path":"obsolete.txt","op":"delete"}
+</example>

package/src/prompts/tools/read.md

@@ -5,7 +5,7 @@ Usage:
 - By default, it reads up to {{DEFAULT_MAX_LINES}} lines starting from the beginning of the file
 - You can optionally specify a line offset and limit (especially handy for long files), but it's recommended to read the whole file by not providing these parameters
 - Any lines longer than 500 characters will be truncated
-- By default, results include line numbers (cat -n format). Use `lines: false` to omit them
+- By default, results omit line numbers. Use `lines: true` to include them
 - This tool allows Claude Code to read images (eg PNG, JPG, etc). When reading an image file the contents are presented visually as Claude Code is a multimodal LLM.
 - This tool can read PDF files (.pdf). PDFs are processed page by page, extracting both text and visual content for analysis.
 - This tool can read Jupyter notebooks (.ipynb files) and returns all cells with their outputs, combining code, text, and visualizations.

package/src/prompts/tools/{edit.md → replace.md}

@@ -2,6 +2,7 @@ Performs string replacements in files with fuzzy whitespace matching.
 
 Usage:
 - Use the smallest edit that uniquely identifies the change. To toggle a checkbox: `- [ ] Task` → `- [x] Task`, not the entire line.
+- If the old text is not unique, expand the replacement to a larger block (function/class/section) so it is unique.
 - You must use your read tool at least once in the conversation before editing. This tool will error if you attempt an edit without reading the file.
 - Fuzzy matching handles minor whitespace/indentation differences automatically - you don't need to match indentation exactly.
 - ALWAYS prefer editing existing files in the codebase. NEVER write new files unless explicitly required.

package/src/utils/shell.ts

@@ -181,46 +181,6 @@ export async function getShellConfig(): Promise<ShellConfig> {
 	return cachedShellConfig;
 }
 
-/**
- * Sanitize binary output for display/storage.
- * Removes characters that crash string-width or cause display issues:
- * - Control characters (except tab, newline, carriage return)
- * - Lone surrogates
- * - Unicode Format characters (crash string-width due to a bug)
- * - Characters with undefined code points
- */
-export function sanitizeBinaryOutput(str: string): string {
-	// Use Array.from to properly iterate over code points (not code units)
-	// This handles surrogate pairs correctly and catches edge cases where
-	// codePointAt() might return undefined
-	return Array.from(str)
-		.filter((char) => {
-			// Filter out characters that cause string-width to crash
-			// This includes:
-			// - Unicode format characters
-			// - Lone surrogates (already filtered by Array.from)
-			// - Control chars except \t \n \r
-			// - Characters with undefined code points
-
-			const code = char.codePointAt(0);
-
-			// Skip if code point is undefined (edge case with invalid strings)
-			if (code === undefined) return false;
-
-			// Allow tab, newline, carriage return
-			if (code === 0x09 || code === 0x0a || code === 0x0d) return true;
-
-			// Filter out control characters (0x00-0x1F, except 0x09, 0x0a, 0x0x0d)
-			if (code <= 0x1f) return false;
-
-			// Filter out Unicode format characters
-			if (code >= 0xfff9 && code <= 0xfffb) return false;
-
-			return true;
-		})
-		.join("");
-}
-
 let pgrepAvailable: boolean | null = null;
 
 /**