@oh-my-pi/pi-coding-agent 5.5.0 → 5.6.70

package/src/core/python-modules.test.ts

@@ -0,0 +1,102 @@
+import { afterEach, describe, expect, it } from "bun:test";
+import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { basename, join, resolve } from "node:path";
+import { discoverPythonModules, loadPythonModules, type PythonModuleExecutor } from "./python-modules";
+
+const fixturesDir = resolve(__dirname, "../../test/fixtures/python-modules");
+
+const readFixture = (name: string): string => readFileSync(join(fixturesDir, name), "utf-8");
+
+const writeModule = (dir: string, name: string, tag: string) => {
+	mkdirSync(dir, { recursive: true });
+	const base = readFixture(name);
+	writeFileSync(join(dir, name), `${base}\n# ${tag}`);
+};
+
+const createTempRoot = () => mkdtempSync(join(tmpdir(), "omp-python-modules-"));
+
+describe("python modules", () => {
+	let tempRoot: string | null = null;
+
+	afterEach(() => {
+		if (tempRoot) {
+			rmSync(tempRoot, { recursive: true, force: true });
+		}
+		tempRoot = null;
+	});
+
+	it("discovers modules with project override and sorted order", async () => {
+		tempRoot = createTempRoot();
+		const homeDir = join(tempRoot, "home");
+		const cwd = join(tempRoot, "project");
+
+		writeModule(join(homeDir, ".omp", "agent", "modules"), "alpha.py", "user-omp");
+		writeModule(join(homeDir, ".pi", "agent", "modules"), "beta.py", "user-pi");
+		writeModule(join(homeDir, ".pi", "agent", "modules"), "delta.py", "user-pi");
+
+		writeModule(join(cwd, ".omp", "modules"), "alpha.py", "project-omp");
+		writeModule(join(cwd, ".omp", "modules"), "beta.py", "project-omp");
+		writeModule(join(cwd, ".pi", "modules"), "gamma.py", "project-pi");
+
+		const modules = await discoverPythonModules({ cwd, homeDir });
+		const names = modules.map((module) => basename(module.path));
+		expect(names).toEqual(["alpha.py", "beta.py", "delta.py", "gamma.py"]);
+		expect(modules.map((module) => ({ name: basename(module.path), source: module.source }))).toEqual([
+			{ name: "alpha.py", source: "project" },
+			{ name: "beta.py", source: "project" },
+			{ name: "delta.py", source: "user" },
+			{ name: "gamma.py", source: "project" },
+		]);
+		expect(modules.find((module) => module.path.endsWith("alpha.py"))?.content).toContain("project-omp");
+		expect(modules.find((module) => module.path.endsWith("delta.py"))?.content).toContain("user-pi");
+	});
+
+	it("loads modules in sorted order with silent execution", async () => {
+		tempRoot = createTempRoot();
+		const homeDir = join(tempRoot, "home");
+		const cwd = join(tempRoot, "project");
+
+		writeModule(join(homeDir, ".omp", "agent", "modules"), "beta.py", "user-omp");
+		writeModule(join(homeDir, ".omp", "agent", "modules"), "alpha.py", "user-omp");
+
+		const calls: Array<{ name: string; options?: { silent?: boolean; storeHistory?: boolean } }> = [];
+		const executor: PythonModuleExecutor = {
+			execute: async (code: string, options?: { silent?: boolean; storeHistory?: boolean }) => {
+				const name = code.includes("def alpha") ? "alpha" : "beta";
+				calls.push({ name, options });
+				return { status: "ok", cancelled: false };
+			},
+		};
+
+		await loadPythonModules(executor, { cwd, homeDir });
+		expect(calls.map((call) => call.name)).toEqual(["alpha", "beta"]);
+		for (const call of calls) {
+			expect(call.options).toEqual({ silent: true, storeHistory: false });
+		}
+	});
+
+	it("fails fast when a module fails to execute", async () => {
+		tempRoot = createTempRoot();
+		const homeDir = join(tempRoot, "home");
+		const cwd = join(tempRoot, "project");
+
+		writeModule(join(homeDir, ".omp", "agent", "modules"), "alpha.py", "user-omp");
+		writeModule(join(cwd, ".omp", "modules"), "beta.py", "project-omp");
+
+		const executor: PythonModuleExecutor = {
+			execute: async (code: string) => {
+				if (code.includes("def beta")) {
+					return {
+						status: "error",
+						cancelled: false,
+						error: { name: "Error", value: "boom", traceback: [] },
+					};
+				}
+				return { status: "ok", cancelled: false };
+			},
+		};
+
+		await expect(loadPythonModules(executor, { cwd, homeDir })).rejects.toThrow("Failed to load Python module");
+	});
+});

package/src/core/python-modules.ts

@@ -0,0 +1,110 @@
+import { readdir } from "node:fs/promises";
+import { homedir } from "node:os";
+import { join, resolve } from "node:path";
+
+export type PythonModuleSource = "user" | "project";
+
+export interface PythonModuleEntry {
+	path: string;
+	content: string;
+	source: PythonModuleSource;
+}
+
+export interface PythonModuleExecuteResult {
+	status: "ok" | "error";
+	cancelled: boolean;
+	error?: { name: string; value: string; traceback: string[] };
+}
+
+export interface PythonModuleExecutor {
+	execute: (
+		code: string,
+		options?: { silent?: boolean; storeHistory?: boolean },
+	) => Promise<PythonModuleExecuteResult>;
+}
+
+export interface DiscoverPythonModulesOptions {
+	/** Working directory for project-level modules. Default: process.cwd() */
+	cwd?: string;
+	/** Home directory for user-level modules. Default: os.homedir() */
+	homeDir?: string;
+}
+
+interface ModuleCandidate {
+	name: string;
+	path: string;
+	source: PythonModuleSource;
+}
+
+async function listModuleCandidates(dir: string, source: PythonModuleSource): Promise<ModuleCandidate[]> {
+	try {
+		const entries = await readdir(dir, { withFileTypes: true });
+		return entries
+			.filter((entry) => entry.isFile() && entry.name.endsWith(".py"))
+			.map((entry) => ({
+				name: entry.name,
+				path: resolve(dir, entry.name),
+				source,
+			}));
+	} catch {
+		return [];
+	}
+}
+
+async function readModuleContent(candidate: ModuleCandidate): Promise<PythonModuleEntry> {
+	try {
+		const content = await Bun.file(candidate.path).text();
+		return { path: candidate.path, content, source: candidate.source };
+	} catch (err) {
+		const message = err instanceof Error ? err.message : String(err);
+		throw new Error(`Failed to read Python module ${candidate.path}: ${message}`);
+	}
+}
+
+/**
+ * Discover Python prelude extension modules from user and project directories.
+ */
+export async function discoverPythonModules(options: DiscoverPythonModulesOptions = {}): Promise<PythonModuleEntry[]> {
+	const cwd = options.cwd ?? process.cwd();
+	const homeDir = options.homeDir ?? homedir();
+
+	const userDirs = [join(homeDir, ".omp", "agent", "modules"), join(homeDir, ".pi", "agent", "modules")];
+	const projectDirs = [resolve(cwd, ".omp", "modules"), resolve(cwd, ".pi", "modules")];
+
+	const userCandidates = (await Promise.all(userDirs.map((dir) => listModuleCandidates(dir, "user")))).flat();
+	const projectCandidates = (await Promise.all(projectDirs.map((dir) => listModuleCandidates(dir, "project")))).flat();
+
+	const byName = new Map<string, ModuleCandidate>();
+	for (const candidate of userCandidates) {
+		if (!byName.has(candidate.name)) {
+			byName.set(candidate.name, candidate);
+		}
+	}
+	for (const candidate of projectCandidates) {
+		const existing = byName.get(candidate.name);
+		if (!existing || existing.source === "user") {
+			byName.set(candidate.name, candidate);
+		}
+	}
+
+	const sorted = Array.from(byName.values()).sort((a, b) => a.name.localeCompare(b.name));
+	return Promise.all(sorted.map((candidate) => readModuleContent(candidate)));
+}
+
+/**
+ * Load Python prelude extension modules into an active kernel.
+ */
+export async function loadPythonModules(
+	executor: PythonModuleExecutor,
+	options: DiscoverPythonModulesOptions = {},
+): Promise<PythonModuleEntry[]> {
+	const modules = await discoverPythonModules(options);
+	for (const module of modules) {
+		const result = await executor.execute(module.content, { silent: true, storeHistory: false });
+		if (result.cancelled || result.status === "error") {
+			const details = result.error ? `${result.error.name}: ${result.error.value}` : "unknown error";
+			throw new Error(`Failed to load Python module ${module.path}: ${details}`);
+		}
+	}
+	return modules;
+}