@oh-my-pi/pi-coding-agent 4.3.0 → 4.3.2

package/src/migrations.ts

@@ -8,6 +8,7 @@ import chalk from "chalk";
 import { getAgentDbPath, getAgentDir, getBinDir } from "./config";
 import { AgentStorage } from "./core/agent-storage";
 import type { AuthCredential } from "./core/auth-storage";
+import { logger } from "./core/logger";
 
 /**
  * Migrate PI_* environment variables to OMP_* equivalents.
@@ -55,8 +56,8 @@ export function migrateAuthToAgentDb(): string[] {
 				providers.push(provider);
 			}
 			renameSync(oauthPath, `${oauthPath}.migrated`);
-		} catch {
-			// Skip on error
+		} catch (error) {
+			logger.warn("Failed to migrate oauth.json", { path: oauthPath, error: String(error) });
 		}
 	}
 
@@ -75,8 +76,8 @@ export function migrateAuthToAgentDb(): string[] {
 				delete settings.apiKeys;
 				writeFileSync(settingsPath, JSON.stringify(settings, null, 2));
 			}
-		} catch {
-			// Skip on error
+		} catch (error) {
+			logger.warn("Failed to migrate settings.json apiKeys", { path: settingsPath, error: String(error) });
 		}
 	}
 
@@ -105,7 +106,8 @@ export function migrateSessionsFromAgentRoot(): void {
 		files = readdirSync(agentDir)
 			.filter((f) => f.endsWith(".jsonl"))
 			.map((f) => join(agentDir, f));
-	} catch {
+	} catch (error) {
+		logger.warn("Failed to read agent directory for session migration", { path: agentDir, error: String(error) });
 		return;
 	}
 
@@ -137,8 +139,8 @@ export function migrateSessionsFromAgentRoot(): void {
 			if (existsSync(newPath)) continue; // Skip if target exists
 
 			renameSync(file, newPath);
-		} catch {
-			// Skip files that can't be migrated
+		} catch (error) {
+			logger.warn("Failed to migrate session file", { path: file, error: String(error) });
 		}
 	}
 }
@@ -168,8 +170,8 @@ function migrateToolsToBin(): void {
 				try {
 					renameSync(oldPath, newPath);
 					movedAny = true;
-				} catch {
-					// Ignore errors
+				} catch (error) {
+					logger.warn("Failed to migrate binary", { from: oldPath, to: newPath, error: String(error) });
 				}
 			} else {
 				// Target exists, just delete the old one

package/src/modes/interactive/components/extensions/state-manager.ts

@@ -13,6 +13,7 @@ import type { Skill } from "../../../../capability/skill";
 import type { SlashCommand } from "../../../../capability/slash-command";
 import type { CustomTool } from "../../../../capability/tool";
 import type { SourceMeta } from "../../../../capability/types";
+import { logger } from "../../../../core/logger";
 import {
 	disableProvider,
 	enableProvider,
@@ -105,8 +106,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: (s) => s.frontmatter?.description,
 			getTrigger: (s) => s.frontmatter?.globs?.join(", "),
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load skills capability", { error: String(error) });
 	}
 
 	// Load rules
@@ -116,8 +117,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: (r) => r.description,
 			getTrigger: (r) => r.globs?.join(", ") || (r.alwaysApply ? "always" : undefined),
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load rules capability", { error: String(error) });
 	}
 
 	// Load custom tools
@@ -126,8 +127,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 		addItems(tools.all, "tool", {
 			getDescription: (t) => t.description,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load tools capability", { error: String(error) });
 	}
 
 	// Load extension modules
@@ -135,8 +136,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 		const modules = await loadCapability<ExtensionModule>("extension-modules", loadOpts);
 		const nativeModules = modules.all.filter((module) => module._source.provider === "native");
 		addItems(nativeModules, "extension-module");
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load extension-modules capability", { error: String(error) });
 	}
 
 	// Load MCP servers
@@ -178,8 +179,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: server,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load mcps capability", { error: String(error) });
 	}
 
 	// Load prompts
@@ -189,8 +190,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: () => undefined,
 			getTrigger: (p) => `/prompts:${p.name}`,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load prompts capability", { error: String(error) });
 	}
 
 	// Load slash commands
@@ -200,8 +201,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 			getDescription: () => undefined,
 			getTrigger: (c) => `/${c.name}`,
 		});
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load slash-commands capability", { error: String(error) });
 	}
 
 	// Load hooks
@@ -243,8 +244,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: hook,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load hooks capability", { error: String(error) });
 	}
 
 	// Load context files
@@ -288,8 +289,8 @@ export async function loadAllExtensions(cwd?: string, disabledIds?: string[]): P
 				raw: file,
 			});
 		}
-	} catch {
-		// Capability may not be registered
+	} catch (error) {
+		logger.warn("Failed to load context-files capability", { error: String(error) });
 	}
 
 	return extensions;

package/src/modes/interactive/components/tool-execution.ts

@@ -11,6 +11,7 @@ import {
 	type TUI,
 } from "@oh-my-pi/pi-tui";
 import stripAnsi from "strip-ansi";
+import { BASH_DEFAULT_PREVIEW_LINES } from "../../../core/tools/bash";
 import { computeEditDiff, type EditDiffError, type EditDiffResult } from "../../../core/tools/edit-diff";
 import { toolRenderers } from "../../../core/tools/renderers";
 import { convertToPng } from "../../../utils/image-convert";
@@ -19,7 +20,6 @@ import { theme } from "../theme/theme";
 import { renderDiff } from "./diff";
 
 // Preview line limit for bash when not expanded
-const BASH_PREVIEW_LINES = 5;
 const GENERIC_PREVIEW_LINES = 6;
 const GENERIC_ARG_PREVIEW = 6;
 const GENERIC_VALUE_MAX = 80;
@@ -485,7 +485,7 @@ export class ToolExecutionComponent extends Container {
 			const output = this.getTextOutput().trim();
 			context.output = output;
 			context.expanded = this.expanded;
-			context.previewLines = BASH_PREVIEW_LINES;
+			context.previewLines = BASH_DEFAULT_PREVIEW_LINES;
 		} else if (this.toolName === "edit") {
 			// Edit needs diff preview and renderDiff function
 			context.editDiffPreview = this.editDiffPreview;

package/src/prompts/agents/frontmatter.md

@@ -3,5 +3,6 @@ name: {{name}}
 description: {{description}}
 {{#if spawns}}spawns: {{spawns}}
 {{/if}}{{#if model}}model: {{model}}
+{{/if}}{{#if thinkingLevel}}thinkingLevel: {{thinkingLevel}}
 {{/if}}---
 {{body}}

package/src/prompts/agents/reviewer.md

@@ -4,6 +4,33 @@ description: Code review specialist for quality and security analysis
 tools: read, grep, find, ls, bash, report_finding
 spawns: explore, task
 model: pi/slow, gpt-5.2-codex, gpt-5.2, codex, gpt
+output:
+  properties:
+    overall_correctness:
+      enum: [correct, incorrect]
+    explanation:
+      type: string
+    confidence:
+      type: number
+  optionalProperties:
+    findings:
+      elements:
+        properties:
+          title:
+            type: string
+          body:
+            type: string
+          priority:
+            type: number
+          confidence:
+            type: number
+          file_path:
+            type: string
+          line_start:
+            type: number
+          line_end:
+            type: number
+  required: [overall_correctness, explanation, confidence]
 ---
 
 You are a senior engineer reviewing a proposed code change. Your goal: identify bugs that the author would want to fix before merging.
@@ -64,11 +91,12 @@ Each `report_finding` requires:
 - `file_path`: Absolute path
 - `line_start`, `line_end`: Range ≤10 lines, must overlap the diff
 
-Final `complete` call:
+Final `complete` call (payload goes under `data`):
 
-- `overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
-- `explanation`: 1-3 sentences
-- `confidence`: 0.0-1.0
+- `data.overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
+- `data.explanation`: Plain text, 1-3 sentences summarizing your verdict. Do NOT include JSON, do NOT repeat findings here (they're already captured via `report_finding`).
+- `data.confidence`: 0.0-1.0
+- `data.findings`: Optional; MUST omit (it is populated from `report_finding` calls)
 
 Correctness judgment ignores non-blocking issues (style, docs, nits).
 

package/src/prompts/tools/task.md

@@ -12,12 +12,14 @@ If you discussed requirements, plans, schemas, or decisions with the user, you M
 ## Available Agents
 
 {{#list agents prefix="- " join="\n"}}
-{{name}}: {{description}} (Tools: {{default (join tools ", ") "All tools"}})
+{{name}}: {{description}} (Tools: {{default (join tools ", ") "All tools"}}{{#if output}}, Output: structured{{/if}})
 {{/list}}
 {{#if moreAgents}}
   ...and {{moreAgents}} more agents
 {{/if}}
 
+Agents with "Output: structured" have a fixed schema enforced via frontmatter; your `output` parameter will be ignored for these agents.
+
 ## When NOT to Use
 
 - Reading a specific file path → Use Read tool instead