@oh-my-pi/pi-coding-agent 4.3.0 → 4.3.1

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## [Unreleased]
 
+## [4.3.1] - 2026-01-11
+
+### Changed
+
+- Expanded system prompt with defensive reasoning guidance and assumption checks
+- Allowed agent frontmatter to override subagent thinking level, clamped to model capabilities
+
+### Fixed
+
+- Ensured reviewer agents use structured output schemas and include reported findings in task outputs
+
 ## [4.3.0] - 2026-01-11
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@oh-my-pi/pi-coding-agent",
-	"version": "4.3.0",
+	"version": "4.3.1",
 	"description": "Coding agent CLI with read, bash, edit, write tools and session management",
 	"type": "module",
 	"ompConfig": {
@@ -39,10 +39,10 @@
 		"prepublishOnly": "bun run generate-template && bun run clean && bun run build"
 	},
 	"dependencies": {
-		"@oh-my-pi/pi-ai": "4.3.0",
-		"@oh-my-pi/pi-agent-core": "4.3.0",
-		"@oh-my-pi/pi-git-tool": "4.3.0",
-		"@oh-my-pi/pi-tui": "4.3.0",
+		"@oh-my-pi/pi-ai": "4.3.1",
+		"@oh-my-pi/pi-agent-core": "4.3.1",
+		"@oh-my-pi/pi-git-tool": "4.3.1",
+		"@oh-my-pi/pi-tui": "4.3.1",
 		"@openai/agents": "^0.3.7",
 		"@sinclair/typebox": "^0.34.46",
 		"ajv": "^8.17.1",

package/src/cli/update-cli.ts

@@ -144,8 +144,8 @@ async function updateViaBun(): Promise<void> {
 	try {
 		execSync(`bun update -g ${PACKAGE}`, { stdio: "inherit" });
 		console.log(chalk.green(`\n${theme.status.success} Update complete`));
-	} catch {
-		throw new Error("bun update failed");
+	} catch (error) {
+		throw new Error("bun update failed", { cause: error });
 	}
 }
 

package/src/config.ts

@@ -1,9 +1,9 @@
 import { existsSync, readFileSync, statSync } from "node:fs";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
-
 // Embed package.json at build time for config
 import packageJson from "../package.json" with { type: "json" };
+import { logger } from "./core/logger";
 
 // =============================================================================
 // App Config (from embedded package.json)
@@ -244,8 +244,8 @@ export function readConfigFile<T = unknown>(
 					content: JSON.parse(content) as T,
 				};
 			}
-		} catch {
-			// Continue to next file on parse error
+		} catch (error) {
+			logger.warn("Failed to parse config file", { path: filePath, error: String(error) });
 		}
 	}
 
@@ -275,8 +275,8 @@ export function readAllConfigFiles<T = unknown>(
 					content: JSON.parse(content) as T,
 				});
 			}
-		} catch {
-			// Skip files that fail to parse
+		} catch (error) {
+			logger.warn("Failed to parse config file", { path: filePath, error: String(error) });
 		}
 	}
 

package/src/core/auth-storage.ts

@@ -939,7 +939,12 @@ export class AuthStorage {
 
 			this.recordSessionCredential(provider, sessionId, "oauth", selection.index);
 			return result.apiKey;
-		} catch {
+		} catch (error) {
+			logger.warn("OAuth token refresh failed, removing credential", {
+				provider,
+				index: selection.index,
+				error: String(error),
+			});
 			this.removeCredentialAt(provider, selection.index);
 			if (this.getCredentialsForProvider(provider).some((credential) => credential.type === "oauth")) {
 				return this.getApiKey(provider, sessionId, options);

package/src/core/custom-commands/loader.ts

@@ -11,6 +11,7 @@ import * as typebox from "@sinclair/typebox";
 import { getAgentDir, getConfigDirs } from "../../config";
 import * as piCodingAgent from "../../index";
 import { execCommand } from "../exec";
+import { logger } from "../logger";
 import { createReviewCommand } from "./bundled/review";
 import { createWorktreeCommand } from "./bundled/wt";
 import type {
@@ -110,7 +111,8 @@ export function discoverCustomCommands(options: DiscoverCustomCommandsOptions =
 		let entries: Dirent[];
 		try {
 			entries = readdirSync(commandsDir, { withFileTypes: true });
-		} catch {
+		} catch (error) {
+			logger.warn("Failed to read custom commands directory", { path: commandsDir, error: String(error) });
 			continue;
 		}
 		for (const entry of entries) {

package/src/core/custom-tools/loader.ts

@@ -5,11 +5,11 @@
  * to avoid import resolution issues with custom tools loaded from user directories.
  */
 
-import * as os from "node:os";
 import * as path from "node:path";
 import * as typebox from "@sinclair/typebox";
 import { toolCapability } from "../../capability/tool";
 import { type CustomTool, loadCapability } from "../../discovery";
+import { expandPath } from "../../discovery/helpers";
 import * as piCodingAgent from "../../index";
 import { theme } from "../../modes/interactive/theme/theme";
 import type { ExecOptions } from "../exec";
@@ -19,23 +19,6 @@ import { logger } from "../logger";
 import { getAllPluginToolPaths } from "../plugins/loader";
 import type { CustomToolAPI, CustomToolFactory, CustomToolsLoadResult, LoadedCustomTool } from "./types";
 
-const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
-
-function normalizeUnicodeSpaces(str: string): string {
-	return str.replace(UNICODE_SPACES, " ");
-}
-
-function expandPath(p: string): string {
-	const normalized = normalizeUnicodeSpaces(p);
-	if (normalized.startsWith("~/")) {
-		return path.join(os.homedir(), normalized.slice(2));
-	}
-	if (normalized.startsWith("~")) {
-		return path.join(os.homedir(), normalized.slice(1));
-	}
-	return normalized;
-}
-
 /**
  * Resolve tool path.
  * - Absolute paths used as-is

package/src/core/extensions/loader.ts

@@ -3,13 +3,12 @@
  */
 
 import { existsSync, readdirSync, readFileSync, statSync } from "node:fs";
-import { homedir } from "node:os";
 import * as path from "node:path";
 import type { KeyId } from "@oh-my-pi/pi-tui";
 import * as TypeBox from "@sinclair/typebox";
 import { type ExtensionModule, extensionModuleCapability } from "../../capability/extension-module";
 import { loadCapability } from "../../discovery";
-import { getExtensionNameFromPath } from "../../discovery/helpers";
+import { expandPath, getExtensionNameFromPath } from "../../discovery/helpers";
 import * as piCodingAgent from "../../index";
 import { createEventBus, type EventBus } from "../event-bus";
 import type { ExecOptions } from "../exec";
@@ -27,23 +26,6 @@ import type {
 	ToolDefinition,
 } from "./types";
 
-const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
-
-function normalizeUnicodeSpaces(str: string): string {
-	return str.replace(UNICODE_SPACES, " ");
-}
-
-function expandPath(p: string): string {
-	const normalized = normalizeUnicodeSpaces(p);
-	if (normalized.startsWith("~/")) {
-		return path.join(homedir(), normalized.slice(2));
-	}
-	if (normalized.startsWith("~")) {
-		return path.join(homedir(), normalized.slice(1));
-	}
-	return normalized;
-}
-
 function resolvePath(extPath: string, cwd: string): string {
 	const expanded = expandPath(extPath);
 	if (path.isAbsolute(expanded)) {
@@ -291,7 +273,8 @@ function readExtensionManifest(packageJsonPath: string): ExtensionManifest | nul
 			return manifest;
 		}
 		return null;
-	} catch {
+	} catch (error) {
+		logger.warn("Failed to read extension manifest", { path: packageJsonPath, error: String(error) });
 		return null;
 	}
 }
@@ -370,7 +353,8 @@ function discoverExtensionsInDir(dir: string): string[] {
 				}
 			}
 		}
-	} catch {
+	} catch (error) {
+		logger.warn("Failed to discover extensions in directory", { path: dir, error: String(error) });
 		return [];
 	}
 

package/src/core/hooks/loader.ts

@@ -2,12 +2,12 @@
  * Hook loader - loads TypeScript hook modules using native Bun import.
  */
 
-import * as os from "node:os";
 import * as path from "node:path";
 import * as typebox from "@sinclair/typebox";
 import { hookCapability } from "../../capability/hook";
 import type { Hook } from "../../discovery";
 import { loadCapability } from "../../discovery";
+import { expandPath } from "../../discovery/helpers";
 import * as piCodingAgent from "../../index";
 import { logger } from "../logger";
 import type { HookMessage } from "../messages";
@@ -84,23 +84,6 @@ export interface LoadHooksResult {
 	errors: Array<{ path: string; error: string }>;
 }
 
-const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
-
-function normalizeUnicodeSpaces(str: string): string {
-	return str.replace(UNICODE_SPACES, " ");
-}
-
-function expandPath(p: string): string {
-	const normalized = normalizeUnicodeSpaces(p);
-	if (normalized.startsWith("~/")) {
-		return path.join(os.homedir(), normalized.slice(2));
-	}
-	if (normalized.startsWith("~")) {
-		return path.join(os.homedir(), normalized.slice(1));
-	}
-	return normalized;
-}
-
 /**
  * Resolve hook path.
  * - Absolute paths used as-is

package/src/core/keybindings.ts

@@ -10,6 +10,7 @@ import {
 	setEditorKeybindings,
 } from "@oh-my-pi/pi-tui";
 import { getAgentDir } from "../config";
+import { logger } from "./logger";
 
 /**
  * Application-level actions (coding agent specific).
@@ -136,7 +137,8 @@ export class KeybindingsManager {
 		if (!existsSync(path)) return {};
 		try {
 			return JSON.parse(readFileSync(path, "utf-8"));
-		} catch {
+		} catch (error) {
+			logger.warn("Failed to parse keybindings config", { path, error: String(error) });
 			return {};
 		}
 	}

package/src/core/logger.ts

@@ -10,11 +10,10 @@ import { homedir } from "node:os";
 import { join } from "node:path";
 import winston from "winston";
 import DailyRotateFile from "winston-daily-rotate-file";
-import { CONFIG_DIR_NAME } from "../config";
 
 /** Get the logs directory (~/.omp/logs/) */
 function getLogsDir(): string {
-	return join(homedir(), CONFIG_DIR_NAME, "logs");
+	return join(homedir(), ".omp", "logs");
 }
 
 /** Ensure logs directory exists */

package/src/core/prompt-templates.ts

@@ -1,6 +1,7 @@
 import { join, resolve } from "node:path";
 import Handlebars from "handlebars";
 import { CONFIG_DIR_NAME, getPromptsDir } from "../config";
+import { logger } from "./logger";
 
 /**
  * Represents a prompt template loaded from a markdown file
@@ -448,12 +449,12 @@ async function loadTemplatesFromDir(
 						source: sourceStr,
 					});
 				}
-			} catch (_error) {
-				// Silently skip files that can't be read
+			} catch (error) {
+				logger.warn("Failed to load prompt template", { path: fullPath, error: String(error) });
 			}
 		}
-	} catch (_error) {
-		// Silently skip directories that can't be read
+	} catch (error) {
+		logger.warn("Failed to scan prompt templates directory", { dir, error: String(error) });
 	}
 
 	return templates;

package/src/core/sdk.ts

@@ -28,7 +28,7 @@
 
 import { join } from "node:path";
 import { Agent, type AgentEvent, type AgentMessage, type AgentTool, type ThinkingLevel } from "@oh-my-pi/pi-agent-core";
-import type { Message, Model } from "@oh-my-pi/pi-ai";
+import { type Message, type Model, supportsXhigh } from "@oh-my-pi/pi-ai";
 import type { Component } from "@oh-my-pi/pi-tui";
 import chalk from "chalk";
 // Import discovery to register all providers on startup
@@ -631,6 +631,8 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 	// Clamp to model capabilities
 	if (!model || !model.reasoning) {
 		thinkingLevel = "off";
+	} else if (thinkingLevel === "xhigh" && !supportsXhigh(model)) {
+		thinkingLevel = "high";
 	}
 
 	let skills: Skill[];
@@ -1021,8 +1023,8 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			});
 			lspServers = result.servers;
 			time("warmupLspServers");
-		} catch {
-			// Ignore warmup errors
+		} catch (error) {
+			logger.warn("LSP server warmup failed", { cwd, error: String(error) });
 		}
 	}
 

package/src/core/skills.ts

@@ -7,6 +7,7 @@ import type { SourceMeta } from "../capability/types";
 import type { Skill as CapabilitySkill, SkillFrontmatter as ImportedSkillFrontmatter } from "../discovery";
 import { loadCapability } from "../discovery";
 import { parseFrontmatter } from "../discovery/helpers";
+import { logger } from "./logger";
 import type { SkillsSettings } from "./settings-manager";
 
 // Re-export SkillFrontmatter for backward compatibility
@@ -67,8 +68,8 @@ export function loadSkillsFromDir(options: LoadSkillsFromDirOptions): LoadSkills
 					source: options.source,
 				});
 			}
-		} catch {
-			// Skip invalid skills
+		} catch (error) {
+			logger.warn("Failed to load skill", { path: skillFile, error: String(error) });
 		}
 	}
 
@@ -131,8 +132,8 @@ function scanDirectoryForSkills(dir: string): LoadSkillsResult {
 					source: "custom",
 				});
 			}
-		} catch {
-			// Skip invalid skills
+		} catch (error) {
+			logger.warn("Failed to load skill", { path: skillFile, error: String(error) });
 		}
 	}
 

package/src/core/tools/exa/mcp-client.ts

@@ -292,8 +292,8 @@ export async function fetchMCPToolSchema(
 			mcpSchemaCache.set(cacheKey, tool);
 			return tool;
 		}
-	} catch {
-		// Fall through to return null
+	} catch (error) {
+		logger.warn("Failed to fetch MCP tool schema", { mcpToolName, isWebsetsTool, error: String(error) });
 	}
 	return null;
 }

package/src/core/tools/task/agents.ts

@@ -4,6 +4,7 @@
  * Agents are embedded at build time via Bun's import with { type: "text" }.
  */
 
+import { parseAgentFields, parseFrontmatter } from "../../../discovery/helpers";
 import exploreMd from "../../../prompts/agents/explore.md" with { type: "text" };
 // Embed agent markdown files at build time
 import agentFrontmatterTemplate from "../../../prompts/agents/frontmatter.md" with { type: "text" };
@@ -18,6 +19,7 @@ interface AgentFrontmatter {
 	description: string;
 	spawns?: string;
 	model?: string;
+	thinkingLevel?: string;
 }
 
 interface EmbeddedAgentDef {
@@ -71,80 +73,19 @@ const EMBEDDED_AGENTS: { name: string; content: string }[] = EMBEDDED_AGENT_DEFS
 	content: buildAgentContent(def),
 }));
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
-}
-
 /**
  * Parse an agent from embedded content.
  */
 function parseAgent(fileName: string, content: string, source: AgentSource): AgentDefinition | null {
 	const { frontmatter, body } = parseFrontmatter(content);
+	const fields = parseAgentFields(frontmatter);
 
-	if (!frontmatter.name || !frontmatter.description) {
+	if (!fields) {
 		return null;
 	}
 
-	const tools = frontmatter.tools
-		?.split(",")
-		.map((t) => t.trim())
-		.filter(Boolean);
-
-	// Parse spawns field
-	let spawns: string[] | "*" | undefined;
-	if (frontmatter.spawns !== undefined) {
-		const spawnsRaw = frontmatter.spawns.trim();
-		if (spawnsRaw === "*") {
-			spawns = "*";
-		} else if (spawnsRaw) {
-			spawns = spawnsRaw
-				.split(",")
-				.map((s) => s.trim())
-				.filter(Boolean);
-			if (spawns.length === 0) spawns = undefined;
-		}
-	}
-
-	// Backward compat: infer spawns: "*" when tools includes "task"
-	if (spawns === undefined && tools?.includes("task")) {
-		spawns = "*";
-	}
-
 	return {
-		name: frontmatter.name,
-		description: frontmatter.description,
-		tools: tools && tools.length > 0 ? tools : undefined,
-		spawns,
-		model: frontmatter.model,
+		...fields,
 		systemPrompt: body,
 		source,
 		filePath: `embedded:${fileName}`,

package/src/core/tools/task/commands.ts

@@ -7,6 +7,7 @@
 import * as path from "node:path";
 import { type SlashCommand, slashCommandCapability } from "../../../capability/slash-command";
 import { loadCapability } from "../../../discovery";
+import { parseFrontmatter } from "../../../discovery/helpers";
 
 // Embed command markdown files at build time
 import initMd from "../../../prompts/agents/init.md" with { type: "text" };
@@ -27,37 +28,10 @@ export interface WorkflowCommand {
 	filePath: string;
 }
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
+/** Extract string value from frontmatter field */
+function getString(frontmatter: Record<string, unknown>, key: string): string {
+	const value = frontmatter[key];
+	return typeof value === "string" ? value : "";
 }
 
 /** Cache for bundled commands */
@@ -79,7 +53,7 @@ export function loadBundledCommands(): WorkflowCommand[] {
 
 		commands.push({
 			name: cmdName,
-			description: frontmatter.description || "",
+			description: getString(frontmatter, "description"),
 			instructions: body,
 			source: "bundled",
 			filePath: `embedded:${name}`,
@@ -115,7 +89,7 @@ export async function discoverCommands(cwd: string): Promise<WorkflowCommand[]>
 
 		commands.push({
 			name: cmd.name,
-			description: frontmatter.description || "",
+			description: getString(frontmatter, "description"),
 			instructions: body,
 			source,
 			filePath: cmd.path,

package/src/core/tools/task/discovery.ts

@@ -15,6 +15,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { findAllNearestProjectConfigDirs, getConfigDirs } from "../../../config";
+import { parseAgentFields, parseFrontmatter } from "../../../discovery/helpers";
 import { loadBundledAgents } from "./agents";
 import type { AgentDefinition, AgentSource } from "./types";
 
@@ -24,40 +25,6 @@ export interface DiscoveryResult {
 	projectAgentsDir: string | null;
 }
 
-/**
- * Parse YAML frontmatter from markdown content.
- */
-function parseFrontmatter(content: string): { frontmatter: Record<string, string>; body: string } {
-	const frontmatter: Record<string, string> = {};
-	const normalized = content.replace(/\r\n/g, "\n");
-
-	if (!normalized.startsWith("---")) {
-		return { frontmatter, body: normalized };
-	}
-
-	const endIndex = normalized.indexOf("\n---", 3);
-	if (endIndex === -1) {
-		return { frontmatter, body: normalized };
-	}
-
-	const frontmatterBlock = normalized.slice(4, endIndex);
-	const body = normalized.slice(endIndex + 4).trim();
-
-	for (const line of frontmatterBlock.split("\n")) {
-		const match = line.match(/^([\w-]+):\s*(.*)$/);
-		if (match) {
-			let value = match[2].trim();
-			// Strip quotes
-			if ((value.startsWith('"') && value.endsWith('"')) || (value.startsWith("'") && value.endsWith("'"))) {
-				value = value.slice(1, -1);
-			}
-			frontmatter[match[1]] = value;
-		}
-	}
-
-	return { frontmatter, body };
-}
-
 /**
  * Load agents from a directory.
  */
@@ -95,43 +62,14 @@ function loadAgentsFromDir(dir: string, source: AgentSource): AgentDefinition[]
 		}
 
 		const { frontmatter, body } = parseFrontmatter(content);
+		const fields = parseAgentFields(frontmatter);
 
-		// Require name and description
-		if (!frontmatter.name || !frontmatter.description) {
+		if (!fields) {
 			continue;
 		}
 
-		const tools = frontmatter.tools
-			?.split(",")
-			.map((t) => t.trim())
-			.filter(Boolean);
-
-		// Parse spawns field
-		let spawns: string[] | "*" | undefined;
-		if (frontmatter.spawns !== undefined) {
-			const spawnsRaw = frontmatter.spawns.trim();
-			if (spawnsRaw === "*") {
-				spawns = "*";
-			} else if (spawnsRaw) {
-				spawns = spawnsRaw
-					.split(",")
-					.map((s) => s.trim())
-					.filter(Boolean);
-				if (spawns.length === 0) spawns = undefined;
-			}
-		}
-
-		// Backward compat: infer spawns: "*" when tools includes "task"
-		if (spawns === undefined && tools?.includes("task")) {
-			spawns = "*";
-		}
-
 		agents.push({
-			name: frontmatter.name,
-			description: frontmatter.description,
-			tools: tools && tools.length > 0 ? tools : undefined,
-			spawns,
-			model: frontmatter.model,
+			...fields,
 			systemPrompt: body,
 			source,
 			filePath,