@oh-my-pi/pi-coding-agent 3.6.1337 → 3.8.1337

package/src/modes/interactive/components/tool-execution.ts

@@ -503,19 +503,19 @@ export class ToolExecutionComponent extends Container {
 			}
 
 			// Show LSP diagnostics if available
-			if (this.result?.details?.diagnostics?.available) {
+			if (this.result?.details?.diagnostics) {
 				const diag = this.result.details.diagnostics;
-				if (diag.diagnostics.length > 0) {
-					const icon = diag.hasErrors ? theme.fg("error", "●") : theme.fg("warning", "●");
+				if (diag.messages.length > 0) {
+					const icon = diag.errored ? theme.fg("error", "●") : theme.fg("warning", "●");
 					text += `\n\n${icon} ${theme.fg("toolTitle", "LSP Diagnostics")} ${theme.fg("dim", `(${diag.summary})`)}`;
-					const maxDiags = this.expanded ? diag.diagnostics.length : 5;
-					const displayDiags = diag.diagnostics.slice(0, maxDiags);
+					const maxDiags = this.expanded ? diag.messages.length : 5;
+					const displayDiags = diag.messages.slice(0, maxDiags);
 					for (const d of displayDiags) {
 						const color = d.includes("[error]") ? "error" : d.includes("[warning]") ? "warning" : "dim";
 						text += `\n  ${theme.fg(color, d)}`;
 					}
-					if (diag.diagnostics.length > maxDiags) {
-						text += theme.fg("dim", `\n  ... (${diag.diagnostics.length - maxDiags} more)`);
+					if (diag.messages.length > maxDiags) {
+						text += theme.fg("dim", `\n  ... (${diag.messages.length - maxDiags} more)`);
 					}
 				}
 			}
@@ -552,19 +552,19 @@ export class ToolExecutionComponent extends Container {
 			}
 
 			// Show LSP diagnostics if available
-			if (this.result?.details?.diagnostics?.available) {
+			if (this.result?.details?.diagnostics) {
 				const diag = this.result.details.diagnostics;
-				if (diag.diagnostics.length > 0) {
-					const icon = diag.hasErrors ? theme.fg("error", "●") : theme.fg("warning", "●");
+				if (diag.messages.length > 0) {
+					const icon = diag.errored ? theme.fg("error", "●") : theme.fg("warning", "●");
 					text += `\n\n${icon} ${theme.fg("toolTitle", "LSP Diagnostics")} ${theme.fg("dim", `(${diag.summary})`)}`;
-					const maxDiags = this.expanded ? diag.diagnostics.length : 5;
-					const displayDiags = diag.diagnostics.slice(0, maxDiags);
+					const maxDiags = this.expanded ? diag.messages.length : 5;
+					const displayDiags = diag.messages.slice(0, maxDiags);
 					for (const d of displayDiags) {
 						const color = d.includes("[error]") ? "error" : d.includes("[warning]") ? "warning" : "dim";
 						text += `\n  ${theme.fg(color, d)}`;
 					}
-					if (diag.diagnostics.length > maxDiags) {
-						text += theme.fg("dim", `\n  ... (${diag.diagnostics.length - maxDiags} more)`);
+					if (diag.messages.length > maxDiags) {
+						text += theme.fg("dim", `\n  ... (${diag.messages.length - maxDiags} more)`);
 					}
 				}
 			}

package/src/modes/interactive/interactive-mode.ts

@@ -143,9 +143,6 @@ export class InteractiveMode {
 	// Custom tools for custom rendering
 	private customTools: Map<string, LoadedCustomTool>;
 
-	// Title generation state
-	private titleGenerationAttempted = false;
-
 	// Convenience accessors
 	private get agent() {
 		return this.session.agent;
@@ -261,7 +258,6 @@ export class InteractiveMode {
 		const existingTitle = this.sessionManager.getSessionTitle();
 		if (existingTitle) {
 			setTerminalTitle(`pi: ${existingTitle}`);
-			this.titleGenerationAttempted = true; // Don't try to generate again
 		}
 
 		// Setup UI layout
@@ -401,7 +397,6 @@ export class InteractiveMode {
 				this.streamingComponent = undefined;
 				this.streamingMessage = undefined;
 				this.pendingTools.clear();
-				this.titleGenerationAttempted = false;
 
 				this.chatContainer.addChild(new Spacer(1));
 				this.chatContainer.addChild(new Text(`${theme.fg("accent", "✓ New session started")}`, 1, 1));
@@ -903,6 +898,21 @@ export class InteractiveMode {
 			// First, move any pending bash components to chat
 			this.flushPendingBashComponents();
 
+			// Generate session title on first message
+			const hasUserMessages = this.agent.state.messages.some((m) => m.role === "user");
+			if (!hasUserMessages && !this.sessionManager.getSessionTitle()) {
+				const registry = this.session.modelRegistry;
+				const smolModel = this.settingsManager.getModelRole("smol");
+				generateSessionTitle(text, registry, smolModel)
+					.then((title) => {
+						if (title) {
+							this.sessionManager.setSessionTitle(title);
+							setTerminalTitle(`omp: ${title}`);
+						}
+					})
+					.catch(() => {});
+			}
+
 			if (this.onInputCallback) {
 				// Include any pending images from clipboard paste
 				const images = this.pendingImages.length > 0 ? [...this.pendingImages] : undefined;
@@ -1085,12 +1095,6 @@ export class InteractiveMode {
 				}
 				this.pendingTools.clear();
 				this.ui.requestRender();
-
-				// Generate session title after first turn (if not already titled)
-				if (!this.titleGenerationAttempted && !this.sessionManager.getSessionTitle()) {
-					this.titleGenerationAttempted = true;
-					this.maybeGenerateTitle();
-				}
 				break;
 
 			case "auto_compaction_start": {
@@ -1635,42 +1639,6 @@ export class InteractiveMode {
 		this.ui.requestRender();
 	}
 
-	/**
-	 * Generate a title for the session based on the first user message.
-	 * Runs in background, doesn't block UI.
-	 */
-	private maybeGenerateTitle(): void {
-		// Find the first user message
-		const messages = this.agent.state.messages;
-		const firstUserMessage = messages.find((m) => m.role === "user");
-		if (!firstUserMessage) return;
-
-		// Extract text content
-		let messageText = "";
-		for (const content of firstUserMessage.content) {
-			if (typeof content === "string") {
-				messageText += content;
-			} else if (content.type === "text") {
-				messageText += content.text;
-			}
-		}
-		if (!messageText.trim()) return;
-
-		// Generate title in background
-		const registry = this.session.modelRegistry;
-		const smolModel = this.settingsManager.getModelRole("smol");
-		generateSessionTitle(messageText, registry, smolModel)
-			.then((title) => {
-				if (title) {
-					this.sessionManager.setSessionTitle(title);
-					setTerminalTitle(`omp: ${title}`);
-				}
-			})
-			.catch(() => {
-				// Errors logged via logger in title-generator
-			});
-	}
-
 	private updatePendingMessagesDisplay(): void {
 		this.pendingMessagesContainer.clear();
 		const queuedMessages = this.session.getQueuedMessages();
@@ -2076,13 +2044,7 @@ export class InteractiveMode {
 									}
 									this.ui.requestRender();
 
-									const openCmd =
-										process.platform === "darwin"
-											? "open"
-											: process.platform === "win32"
-												? "start"
-												: "xdg-open";
-									Bun.spawn([openCmd, info.url], { stdin: "ignore", stdout: "ignore", stderr: "ignore" });
+									this.openInBrowser(info.url);
 								},
 								onPrompt: async (prompt: { message: string; placeholder?: string }) => {
 									this.chatContainer.addChild(new Spacer(1));
@@ -2156,6 +2118,11 @@ export class InteractiveMode {
 	// Command handlers
 	// =========================================================================
 
+	private openInBrowser(urlOrPath: string): void {
+		const openCmd = process.platform === "darwin" ? "open" : process.platform === "win32" ? "start" : "xdg-open";
+		Bun.spawn([openCmd, urlOrPath], { stdin: "ignore", stdout: "ignore", stderr: "ignore" });
+	}
+
 	private async handleExportCommand(text: string): Promise<void> {
 		const parts = text.split(/\s+/);
 		const arg = parts.length > 1 ? parts[1] : undefined;
@@ -2180,6 +2147,7 @@ export class InteractiveMode {
 		try {
 			const filePath = await this.session.exportToHtml(arg);
 			this.showStatus(`Session exported to: ${filePath}`);
+			this.openInBrowser(filePath);
 		} catch (error: unknown) {
 			this.showError(`Failed to export session: ${error instanceof Error ? error.message : "Unknown error"}`);
 		}
@@ -2293,6 +2261,7 @@ export class InteractiveMode {
 			// Create the preview URL
 			const previewUrl = `https://gistpreview.github.io/?${gistId}`;
 			this.showStatus(`Share URL: ${previewUrl}\nGist: ${gistUrl}`);
+			this.openInBrowser(previewUrl);
 		} catch (error: unknown) {
 			if (!loader.signal.aborted) {
 				restoreEditor();