@oh-my-pi/pi-coding-agent 3.35.0 → 3.36.0

package/src/modes/interactive/interactive-mode.ts

@@ -1157,7 +1157,7 @@ export class InteractiveMode {
 			if (!hasUserMessages && !this.sessionManager.getSessionTitle()) {
 				const registry = this.session.modelRegistry;
 				const smolModel = this.settingsManager.getModelRole("smol");
-				generateSessionTitle(text, registry, smolModel)
+				generateSessionTitle(text, registry, smolModel, this.session.sessionId)
 					.then(async (title) => {
 						if (title) {
 							await this.sessionManager.setSessionTitle(title);
@@ -1484,11 +1484,14 @@ export class InteractiveMode {
 	}
 
 	private sendCompletionNotification(): void {
+		if (this.isBackgrounded === false) return;
 		if (isNotificationSuppressed()) return;
 		const method = this.settingsManager.getNotificationOnComplete();
 		if (method === "off") return;
 		const protocol = method === "auto" ? detectNotificationProtocol() : method;
-		sendNotification(protocol, "Agent complete");
+		const title = this.sessionManager.getSessionTitle();
+		const message = title ? `${title}: Complete` : "Complete";
+		sendNotification(protocol, message);
 	}
 
 	/** Extract text content from a user message */
@@ -2610,9 +2613,7 @@ export class InteractiveMode {
 	private async showOAuthSelector(mode: "login" | "logout"): Promise<void> {
 		if (mode === "logout") {
 			const providers = this.session.modelRegistry.authStorage.list();
-			const loggedInProviders = providers.filter(
-				(p) => this.session.modelRegistry.authStorage.get(p)?.type === "oauth",
-			);
+			const loggedInProviders = providers.filter((p) => this.session.modelRegistry.authStorage.hasOAuth(p));
 			if (loggedInProviders.length === 0) {
 				this.showStatus("No OAuth providers logged in. Use /login first.");
 				return;
@@ -2633,6 +2634,7 @@ export class InteractiveMode {
 							await this.session.modelRegistry.authStorage.login(providerId as OAuthProvider, {
 								onAuth: (info: { url: string; instructions?: string }) => {
 									this.chatContainer.addChild(new Spacer(1));
+									this.chatContainer.addChild(new Text(theme.fg("dim", info.url), 1, 0));
 									// Use OSC 8 hyperlink escape sequence for clickable link
 									const hyperlink = `\x1b]8;;${info.url}\x07Click here to login\x1b]8;;\x07`;
 									this.chatContainer.addChild(new Text(theme.fg("accent", hyperlink), 1, 0));

package/src/prompts/tools/ask.md

@@ -8,11 +8,6 @@ Use this tool to:
 - Request user preferences (styling, naming conventions, architecture patterns)
 - Offer meaningful choices about task direction
 
-Do NOT use for:
-- Questions resolvable by reading files or docs
-- Permission for normal dev tasks (just proceed)
-- Decisions you should make from codebase context
-
 Tips:
 - Place recommended option first with " (Recommended)" suffix
 - 2-5 concise, distinct options
@@ -22,3 +17,14 @@ Tips:
 question: "Which authentication method should this API use?"
 options: [{"label": "JWT (Recommended)"}, {"label": "OAuth2"}, {"label": "Session cookies"}]
 </example>
+
+## Critical: Resolve before asking
+
+**Exhaust all other options before asking.** Questions interrupt user flow.
+
+1. **Unknown file location?** → Search with grep/find first. Only ask if search fails.
+2. **Ambiguous syntax/format?** → Infer from context and codebase conventions. Make a reasonable choice.
+3. **Missing details?** → Check docs, related files, commit history. Fill gaps yourself.
+4. **Implementation approach?** → Choose based on codebase patterns. Ask only for genuinely novel architectural decisions.
+
+If you can make a reasonable inference from the user's request, **do it**. Users communicate intent, not specifications—your job is to translate intent into correct implementation.

package/src/prompts/tools/bash.md

@@ -13,6 +13,7 @@ Do NOT use Bash for:
 
 ## Command structure
 
+- Use `workdir` parameter to run commands in a specific directory instead of `cd dir && ...`
 - Paths with spaces must use double quotes: `cd "/path/with spaces"`
 - For sequential dependent operations, chain with `&&`: `mkdir foo && cd foo && touch bar`
 - For parallel independent operations, make multiple tool calls in one message

package/src/prompts/tools/calculator.md

@@ -0,0 +1,8 @@
+Basic calculations.
+
+Input:
+  - calculations: array of { expression: string, prefix: string, suffix: string }
+
+Notes:
+  - Supports +, -, *, /, %, ** and parentheses.
+  - Supports decimal, hex (0x), binary (0b), and octal (0o) literals.