@oh-my-pi/pi-coding-agent 3.3.1337 → 3.5.1337

package/src/modes/interactive/components/extensions/types.ts

@@ -0,0 +1,191 @@
+/**
+ * Types for the Extension Control Center dashboard.
+ */
+
+import type { SourceMeta } from "../../../../capability/types";
+
+/**
+ * Extension kinds matching capability types.
+ */
+export type ExtensionKind =
+	| "skill"
+	| "rule"
+	| "tool"
+	| "mcp"
+	| "prompt"
+	| "instruction"
+	| "context-file"
+	| "hook"
+	| "slash-command";
+
+/**
+ * Extension state (active, disabled, or shadowed).
+ */
+export type ExtensionState = "active" | "disabled" | "shadowed";
+
+/**
+ * Reason why an extension is disabled.
+ */
+export type DisabledReason = "provider-disabled" | "item-disabled" | "shadowed";
+
+/**
+ * Unified extension representation for the dashboard.
+ * Normalizes all capability types into a common shape.
+ */
+export interface Extension {
+	/** Unique ID: `${kind}:${name}` */
+	id: string;
+	/** Extension kind */
+	kind: ExtensionKind;
+	/** Extension name */
+	name: string;
+	/** Display name (may differ from name) */
+	displayName: string;
+	/** Description if available */
+	description?: string;
+	/** Trigger pattern (slash command, glob, regex) */
+	trigger?: string;
+	/** Absolute path to source file */
+	path: string;
+	/** Source metadata */
+	source: {
+		provider: string;
+		providerName: string;
+		level: "user" | "project" | "native";
+	};
+	/** Current state */
+	state: ExtensionState;
+	/** Reason for disabled state */
+	disabledReason?: DisabledReason;
+	/** If shadowed, what shadows it */
+	shadowedBy?: string;
+	/** Raw item data for inspector */
+	raw: unknown;
+}
+
+/**
+ * Tree node types for sidebar hierarchy.
+ */
+export type TreeNodeType = "provider" | "kind" | "item";
+
+/**
+ * Sidebar tree node.
+ */
+export interface TreeNode {
+	/** Unique ID */
+	id: string;
+	/** Display label */
+	label: string;
+	/** Node type (provider can be toggled, kind groups items) */
+	type: TreeNodeType;
+	/** Whether this node/provider is enabled */
+	enabled: boolean;
+	/** Whether collapsed */
+	collapsed: boolean;
+	/** Child nodes */
+	children: TreeNode[];
+	/** Extension count (for display) */
+	count?: number;
+}
+
+/**
+ * Flattened tree item for navigation.
+ */
+export interface FlatTreeItem {
+	node: TreeNode;
+	depth: number;
+	index: number;
+}
+
+/**
+ * Focus region in the tabbed dashboard.
+ */
+export type FocusRegion = "tabs" | "list";
+
+/**
+ * Provider tab representation.
+ */
+export interface ProviderTab {
+	/** Provider ID (or "all" for the ALL tab) */
+	id: string;
+	/** Display label */
+	label: string;
+	/** Whether provider is enabled (always true for "all") */
+	enabled: boolean;
+	/** Extension count for this provider */
+	count: number;
+}
+
+/**
+ * Tabbed dashboard state.
+ */
+export interface DashboardState {
+	/** Provider tabs */
+	tabs: ProviderTab[];
+	/** Active tab index */
+	activeTabIndex: number;
+
+	/** All extensions (unfiltered) */
+	extensions: Extension[];
+	/** Extensions filtered by active tab */
+	tabFiltered: Extension[];
+	/** Extensions filtered by search (applied after tab filter) */
+	searchFiltered: Extension[];
+	/** Current search query */
+	searchQuery: string;
+
+	/** Selected index in main list */
+	listIndex: number;
+	/** Scroll offset for main list */
+	scrollOffset: number;
+
+	/** Currently selected extension for inspector */
+	selected: Extension | null;
+}
+
+/**
+ * @deprecated Use FocusRegion instead
+ */
+export type FocusPane = "sidebar" | "main" | "inspector";
+
+/**
+ * Callbacks from dashboard to parent.
+ */
+export interface DashboardCallbacks {
+	/** Called when provider is toggled */
+	onProviderToggle: (providerId: string, enabled: boolean) => void;
+	/** Called when extension item is toggled */
+	onExtensionToggle: (extensionId: string, enabled: boolean) => void;
+	/** Called when dashboard is closed */
+	onClose: () => void;
+}
+
+/**
+ * Create extension ID from kind and name.
+ */
+export function makeExtensionId(kind: ExtensionKind, name: string): string {
+	return `${kind}:${name}`;
+}
+
+/**
+ * Parse extension ID into kind and name.
+ */
+export function parseExtensionId(id: string): { kind: ExtensionKind; name: string } | null {
+	const colonIdx = id.indexOf(":");
+	if (colonIdx === -1) return null;
+	return {
+		kind: id.slice(0, colonIdx) as ExtensionKind,
+		name: id.slice(colonIdx + 1),
+	};
+}
+
+/**
+ * Map SourceMeta to extension source shape.
+ */
+export function sourceFromMeta(meta: SourceMeta): Extension["source"] {
+	return {
+		provider: meta.provider,
+		providerName: meta.providerName,
+		level: meta.level,
+	};
+}

package/src/modes/interactive/components/footer.ts

@@ -58,6 +58,10 @@ export class FooterComponent implements Component {
 	private autoCompactEnabled: boolean = true;
 	private hookStatuses: Map<string, string> = new Map();
 
+	// Git status caching (1s TTL to avoid excessive subprocess spawns)
+	private cachedGitStatus: { staged: number; unstaged: number; untracked: number } | null = null;
+	private gitStatusLastFetch = 0;
+
 	constructor(session: AgentSession) {
 		this.session = session;
 	}
@@ -165,8 +169,14 @@ export class FooterComponent implements Component {
 	/**
 	 * Get git status indicators (staged, unstaged, untracked counts).
 	 * Returns null if not in a git repo.
+	 * Cached for 1s to avoid excessive subprocess spawns.
 	 */
 	private getGitStatus(): { staged: number; unstaged: number; untracked: number } | null {
+		const now = Date.now();
+		if (now - this.gitStatusLastFetch < 1000) {
+			return this.cachedGitStatus;
+		}
+
 		try {
 			const output = execSync("git status --porcelain 2>/dev/null", {
 				encoding: "utf8",
@@ -200,8 +210,12 @@ export class FooterComponent implements Component {
 				}
 			}
 
-			return { staged, unstaged, untracked };
+			this.cachedGitStatus = { staged, unstaged, untracked };
+			this.gitStatusLastFetch = now;
+			return this.cachedGitStatus;
 		} catch {
+			this.cachedGitStatus = null;
+			this.gitStatusLastFetch = now;
 			return null;
 		}
 	}

package/src/modes/interactive/components/settings-defs.ts

@@ -11,7 +11,6 @@
 import type { ThinkingLevel } from "@oh-my-pi/pi-agent-core";
 import { getCapabilities } from "@oh-my-pi/pi-tui";
 import type { SettingsManager } from "../../../core/settings-manager";
-import { getAllProvidersInfo, isProviderEnabled } from "../../../discovery";
 
 // Setting value types
 export type SettingValue = boolean | string;
@@ -155,6 +154,35 @@ export const SETTINGS_DEFS: SettingDef[] = [
 		get: (sm) => sm.getEditFuzzyMatch(),
 		set: (sm, v) => sm.setEditFuzzyMatch(v),
 	},
+	{
+		id: "ttsrEnabled",
+		tab: "config",
+		type: "boolean",
+		label: "TTSR enabled",
+		description: "Time Traveling Stream Rules: interrupt agent when output matches rule patterns",
+		get: (sm) => sm.getTtsrEnabled(),
+		set: (sm, v) => sm.setTtsrEnabled(v),
+	},
+	{
+		id: "ttsrContextMode",
+		tab: "config",
+		type: "enum",
+		label: "TTSR context mode",
+		description: "What to do with partial output when TTSR triggers",
+		values: ["discard", "keep"],
+		get: (sm) => sm.getTtsrContextMode(),
+		set: (sm, v) => sm.setTtsrContextMode(v as "keep" | "discard"),
+	},
+	{
+		id: "ttsrRepeatMode",
+		tab: "config",
+		type: "enum",
+		label: "TTSR repeat mode",
+		description: "How rules can repeat: once per session or after a message gap",
+		values: ["once", "after-gap"],
+		get: (sm) => sm.getTtsrRepeatMode(),
+		set: (sm, v) => sm.setTtsrRepeatMode(v as "once" | "after-gap"),
+	},
 	{
 		id: "thinkingLevel",
 		tab: "config",
@@ -268,38 +296,10 @@ export const SETTINGS_DEFS: SettingDef[] = [
 ];
 
 /**
- * Get discovery provider settings dynamically.
- * These are generated at runtime from getAllProvidersInfo().
- */
-function getDiscoverySettings(): SettingDef[] {
-	const providers = getAllProvidersInfo();
-	const settings: SettingDef[] = [];
-
-	for (const provider of providers) {
-		// Skip native provider - it can't be disabled
-		if (provider.id === "native") {
-			continue;
-		}
-
-		settings.push({
-			id: `discovery.${provider.id}`,
-			tab: "discovery",
-			type: "boolean",
-			label: provider.displayName,
-			description: provider.description,
-			get: () => isProviderEnabled(provider.id),
-			set: () => {}, // Handled in interactive-mode.ts
-		});
-	}
-
-	return settings;
-}
-
-/**
- * All settings with dynamic discovery settings merged in.
+ * All settings. Discovery settings have been moved to /extensions dashboard.
  */
 function getAllSettings(): SettingDef[] {
-	return [...SETTINGS_DEFS, ...getDiscoverySettings()];
+	return SETTINGS_DEFS;
 }
 
 /** Get settings for a specific tab */

package/src/modes/interactive/components/settings-selector.ts

@@ -99,7 +99,6 @@ const SETTINGS_TABS: Tab[] = [
 	{ id: "config", label: "Config" },
 	{ id: "lsp", label: "LSP" },
 	{ id: "exa", label: "Exa" },
-	{ id: "discovery", label: "Discovery" },
 	{ id: "plugins", label: "Plugins" },
 ];
 

package/src/modes/interactive/components/ttsr-notification.ts

@@ -0,0 +1,82 @@
+import { Box, Container, Spacer, Text } from "@oh-my-pi/pi-tui";
+import type { Rule } from "../../../capability/rule";
+import { theme } from "../theme/theme";
+
+/**
+ * Component that renders a TTSR (Time Traveling Stream Rules) notification.
+ * Shows when a rule violation is detected and the stream is being rewound.
+ */
+export class TtsrNotificationComponent extends Container {
+	private rules: Rule[];
+	private box: Box;
+	private _expanded = false;
+
+	constructor(rules: Rule[]) {
+		super();
+		this.rules = rules;
+
+		this.addChild(new Spacer(1));
+
+		// Use inverse warning color for yellow background effect
+		this.box = new Box(1, 1, (t) => theme.inverse(theme.fg("warning", t)));
+		this.addChild(this.box);
+
+		this.rebuild();
+	}
+
+	setExpanded(expanded: boolean): void {
+		if (this._expanded !== expanded) {
+			this._expanded = expanded;
+			this.rebuild();
+		}
+	}
+
+	isExpanded(): boolean {
+		return this._expanded;
+	}
+
+	private rebuild(): void {
+		this.box.clear();
+
+		// Build header: ⚠ Injecting <bold>rule-name</bold>    ↩
+		const ruleNames = this.rules.map((r) => theme.bold(r.name)).join(", ");
+		const label = this.rules.length === 1 ? "rule" : "rules";
+		const header = `\u26A0 Injecting ${label}: ${ruleNames}`;
+
+		// Create header with rewind icon on the right
+		const rewindIcon = "\u21A9"; // ↩
+
+		this.box.addChild(new Text(`${header}  ${rewindIcon}`, 0, 0));
+
+		// Show description(s) - italic and truncated
+		for (const rule of this.rules) {
+			const desc = rule.description || rule.content;
+			if (desc) {
+				this.box.addChild(new Spacer(1));
+
+				let displayText = desc.trim();
+				if (!this._expanded) {
+					// Truncate to first 2 lines
+					const lines = displayText.split("\n");
+					if (lines.length > 2) {
+						displayText = `${lines.slice(0, 2).join("\n")}...`;
+					}
+				}
+
+				// Use italic for subtle distinction (fg colors conflict with inverse)
+				this.box.addChild(new Text(theme.italic(displayText), 0, 0));
+			}
+		}
+
+		// Show expand hint if collapsed and there's more content
+		if (!this._expanded) {
+			const hasMoreContent = this.rules.some((r) => {
+				const desc = r.description || r.content;
+				return desc && desc.split("\n").length > 2;
+			});
+			if (hasMoreContent) {
+				this.box.addChild(new Text(theme.italic(" (ctrl+o to expand)"), 0, 0));
+			}
+		}
+	}
+}