@oh-my-pi/pi-coding-agent 3.21.0 → 3.25.0

package/src/core/tools/read.ts

@@ -12,6 +12,7 @@ import { formatDimensionNote, resizeImage } from "../../utils/image-resize";
 import { detectSupportedImageMimeTypeFromFile } from "../../utils/mime";
 import { ensureTool } from "../../utils/tools-manager";
 import type { RenderResultOptions } from "../custom-tools/types";
+import type { ToolSession } from "../sdk";
 import { untilAborted } from "../utils";
 import { createLsTool } from "./ls";
 import { resolveReadPath, resolveToCwd } from "./path-utils";
@@ -340,14 +341,9 @@ export interface ReadToolDetails {
 	redirectedTo?: "ls";
 }
 
-export interface ReadToolOptions {
-	/** Whether to auto-resize images to 2000x2000 max. Default: true */
-	autoResizeImages?: boolean;
-}
-
-export function createReadTool(cwd: string, options?: ReadToolOptions): AgentTool<typeof readSchema> {
-	const autoResizeImages = options?.autoResizeImages ?? true;
-	const lsTool = createLsTool(cwd);
+export function createReadTool(session: ToolSession): AgentTool<typeof readSchema> {
+	const autoResizeImages = session.settings?.getImageAutoResize() ?? true;
+	const lsTool = createLsTool(session);
 	return {
 		name: "read",
 		label: "Read",
@@ -358,7 +354,7 @@ export function createReadTool(cwd: string, options?: ReadToolOptions): AgentToo
 			{ path: readPath, offset, limit }: { path: string; offset?: number; limit?: number },
 			signal?: AbortSignal,
 		) => {
-			const absolutePath = resolveReadPath(readPath, cwd);
+			const absolutePath = resolveReadPath(readPath, session.cwd);
 
 			return untilAborted(signal, async () => {
 				let isDirectory = false;
@@ -378,14 +374,12 @@ export function createReadTool(cwd: string, options?: ReadToolOptions): AgentToo
 					}
 				} catch (error) {
 					if (isNotFoundError(error)) {
-						const suggestions = await findReadPathSuggestions(readPath, cwd);
+						const suggestions = await findReadPathSuggestions(readPath, session.cwd);
 						let message = `File not found: ${readPath}`;
 
 						if (suggestions?.suggestions.length) {
 							const scopeLabel = suggestions.scopeLabel ? ` in ${suggestions.scopeLabel}` : "";
-							message += `\n\nClosest matches${scopeLabel}:\n${suggestions.suggestions
-								.map((match) => `- ${match}`)
-								.join("\n")}`;
+							message += `\n\nClosest matches${scopeLabel}:\n${suggestions.suggestions.map((match) => `- ${match}`).join("\n")}`;
 							if (suggestions.truncated) {
 								message += `\n[Search truncated to first ${MAX_FUZZY_CANDIDATES} paths. Refine the path if the match isn't listed.]`;
 							}
@@ -462,9 +456,7 @@ export function createReadTool(cwd: string, options?: ReadToolOptions): AgentToo
 						let outputText = truncation.content;
 
 						if (truncation.truncated) {
-							outputText += `\n\n[Document converted via markitdown. Output truncated to ${formatSize(
-								DEFAULT_MAX_BYTES,
-							)}]`;
+							outputText += `\n\n[Document converted via markitdown. Output truncated to ${formatSize(DEFAULT_MAX_BYTES)}]`;
 							details = { truncation };
 						}
 
@@ -562,9 +554,6 @@ export function createReadTool(cwd: string, options?: ReadToolOptions): AgentToo
 	};
 }
 
-/** Default read tool using process.cwd() - for backwards compatibility */
-export const readTool = createReadTool(process.cwd());
-
 // =============================================================================
 // TUI Renderer
 // =============================================================================

package/src/core/tools/review.ts

@@ -19,13 +19,6 @@ const PRIORITY_LABELS: Record<number, string> = {
 	3: "P3",
 };
 
-const _PRIORITY_DESCRIPTIONS: Record<number, string> = {
-	0: "Drop everything to fix. Blocking release, operations, or major usage.",
-	1: "Urgent. Should be addressed in the next cycle.",
-	2: "Normal. To be fixed eventually.",
-	3: "Low. Nice to have.",
-};
-
 // report_finding schema
 const ReportFindingParams = Type.Object({
 	title: Type.String({
@@ -62,8 +55,6 @@ export const reportFindingTool: AgentTool<typeof ReportFindingParams, ReportFind
 	label: "Report Finding",
 	description: "Report a code review finding. Use this for each issue found. Call submit_review when done.",
 	parameters: ReportFindingParams,
-	hidden: true,
-
 	async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
 		const { title, body, priority, confidence, file_path, line_start, line_end } = params;
 		const location = `${file_path}:${line_start}${line_end !== line_start ? `-${line_end}` : ""}`;
@@ -142,7 +133,6 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 	label: "Submit Review",
 	description: "Submit the final review verdict. Call this after all findings have been reported.",
 	parameters: SubmitReviewParams,
-	hidden: true,
 
 	async execute(_toolCallId, params, _signal, _onUpdate, _ctx) {
 		const { overall_correctness, explanation, confidence } = params;
@@ -206,14 +196,6 @@ export const submitReviewTool: AgentTool<typeof SubmitReviewParams, SubmitReview
 	},
 };
 
-export function createReportFindingTool(): AgentTool<typeof ReportFindingParams, ReportFindingDetails, Theme> {
-	return reportFindingTool;
-}
-
-export function createSubmitReviewTool(): AgentTool<typeof SubmitReviewParams, SubmitReviewDetails, Theme> {
-	return submitReviewTool;
-}
-
 // Re-export types for external use
 export type { ReportFindingDetails, SubmitReviewDetails };
 

package/src/core/tools/rulebook.ts

@@ -9,6 +9,7 @@
 import type { AgentTool } from "@oh-my-pi/pi-agent-core";
 import { Type } from "@sinclair/typebox";
 import type { Rule } from "../../capability/rule";
+import type { ToolSession } from "./index";
 
 export interface RulebookToolDetails {
 	type: "rulebook";
@@ -23,9 +24,14 @@ const rulebookSchema = Type.Object({
 
 /**
  * Create a rulebook tool with access to discovered rules.
- * @param rules - Array of discovered rules (non-TTSR rules with descriptions)
+ * Returns null if no rules available.
  */
-export function createRulebookTool(rules: Rule[]): AgentTool<typeof rulebookSchema> {
+export function createRulebookTool(session: ToolSession): AgentTool<typeof rulebookSchema> | null {
+	const rules = session.rulebookRules;
+	if (!rules || rules.length === 0) {
+		return null;
+	}
+
 	// Build lookup map for O(1) access
 	const ruleMap = new Map<string, Rule>();
 	for (const rule of rules) {

package/src/core/tools/task/agents.ts

@@ -5,7 +5,6 @@
  */
 
 // Embed agent markdown files at build time
-import browserMd from "../../../prompts/browser.md" with { type: "text" };
 import exploreMd from "../../../prompts/explore.md" with { type: "text" };
 import planMd from "../../../prompts/plan.md" with { type: "text" };
 import reviewerMd from "../../../prompts/reviewer.md" with { type: "text" };
@@ -13,11 +12,37 @@ import taskMd from "../../../prompts/task.md" with { type: "text" };
 import type { AgentDefinition, AgentSource } from "./types";
 
 const EMBEDDED_AGENTS: { name: string; content: string }[] = [
-	{ name: "browser.md", content: browserMd },
 	{ name: "explore.md", content: exploreMd },
 	{ name: "plan.md", content: planMd },
 	{ name: "reviewer.md", content: reviewerMd },
-	{ name: "task.md", content: taskMd },
+	{
+		name: "task.md",
+		content: `---
+name: task
+description: General-purpose subagent with full capabilities for delegated multi-step tasks
+spawns: explore
+model: default
+---
+${taskMd}`,
+	},
+	{
+		name: "quick_task.md",
+		content: `---
+name: quick_task
+description: Quick task for fast execution
+model: pi/smol
+---
+${taskMd}`,
+	},
+	{
+		name: "deep_task.md",
+		content: `---
+name: deep_task
+description: Deep task for comprehensive reasoning
+model: pi/slow
+---
+${taskMd}`,
+	},
 ];
 
 /**
@@ -88,16 +113,12 @@ function parseAgent(fileName: string, content: string, source: AgentSource): Age
 		spawns = "*";
 	}
 
-	const recursive =
-		frontmatter.recursive === undefined ? false : frontmatter.recursive === "true" || frontmatter.recursive === "1";
-
 	return {
 		name: frontmatter.name,
 		description: frontmatter.description,
 		tools: tools && tools.length > 0 ? tools : undefined,
 		spawns,
 		model: frontmatter.model,
-		recursive,
 		systemPrompt: body,
 		source,
 		filePath: `embedded:${fileName}`,

package/src/core/tools/task/artifacts.ts

@@ -38,14 +38,12 @@ export function ensureArtifactsDir(dir: string): void {
  */
 export function getArtifactPaths(
 	dir: string,
-	agentName: string,
-	index: number,
+	taskId: string,
 ): { inputPath: string; outputPath: string; jsonlPath: string } {
-	const base = `${agentName}_${index}`;
 	return {
-		inputPath: path.join(dir, `${base}.in.md`),
-		outputPath: path.join(dir, `${base}.out.md`),
-		jsonlPath: path.join(dir, `${base}.jsonl`),
+		inputPath: path.join(dir, `${taskId}.in.md`),
+		outputPath: path.join(dir, `${taskId}.out.md`),
+		jsonlPath: path.join(dir, `${taskId}.jsonl`),
 	};
 }
 
@@ -54,15 +52,14 @@ export function getArtifactPaths(
  */
 export async function writeArtifacts(
 	dir: string,
-	agentName: string,
-	index: number,
+	taskId: string,
 	input: string,
 	output: string,
 	jsonlEvents?: string[],
 ): Promise<{ inputPath: string; outputPath: string; jsonlPath?: string }> {
 	ensureArtifactsDir(dir);
 
-	const paths = getArtifactPaths(dir, agentName, index);
+	const paths = getArtifactPaths(dir, taskId);
 
 	// Write input
 	await fs.promises.writeFile(paths.inputPath, input, "utf-8");

package/src/core/tools/task/discovery.ts

@@ -126,18 +126,12 @@ function loadAgentsFromDir(dir: string, source: AgentSource): AgentDefinition[]
 			spawns = "*";
 		}
 
-		const recursive =
-			frontmatter.recursive === undefined
-				? undefined
-				: frontmatter.recursive === "true" || frontmatter.recursive === "1";
-
 		agents.push({
 			name: frontmatter.name,
 			description: frontmatter.description,
 			tools: tools && tools.length > 0 ? tools : undefined,
 			spawns,
 			model: frontmatter.model,
-			recursive,
 			systemPrompt: body,
 			source,
 			filePath,